[intel/tpm2-tools] be3cca: tools: remove sentinel entry in struct options arr...
by GitHub
Branch: refs/heads/master
Home: https://github.com/intel/tpm2-tools
Commit: be3ccacfde1cb89a9cdafc278dcc21f7e436d1eb
https://github.com/intel/tpm2-tools/commit/be3ccacfde1cb89a9cdafc278dcc21...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M tools/tpm2_certify.c
M tools/tpm2_create.c
M tools/tpm2_createprimary.c
M tools/tpm2_encryptdecrypt.c
M tools/tpm2_evictcontrol.c
M tools/tpm2_hmac.c
M tools/tpm2_load.c
M tools/tpm2_makecredential.c
M tools/tpm2_unseal.c
Log Message:
-----------
tools: remove sentinel entry in struct options array
There's no need for a sentinel entry in the options array, remove them.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: c92d1664aa217af9fabcc98e14e33e0b4e489be7
https://github.com/intel/tpm2-tools/commit/c92d1664aa217af9fabcc98e14e33e...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M tools/tpm2_activatecredential.c
M tools/tpm2_flushcontext.c
M tools/tpm2_hmac.c
M tools/tpm2_loadexternal.c
M tools/tpm2_makecredential.c
Log Message:
-----------
tools: fix error codes returned in the tpm2_tool_onrun() functions
Some tools are still returning false instead of a non-zero value as an
error when they fail. This will wrongly report an exit status that is
for success.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: c7b9fb58a0a5d172c19efb13af60947d2b70474d
https://github.com/intel/tpm2-tools/commit/c7b9fb58a0a5d172c19efb13af6094...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M lib/tpm2_options.c
M lib/tpm2_options.h
Log Message:
-----------
lib: move struct tpm2_options definition to header file
The structure fields will need to be accessed from the tool to parse the
options so move its definition to the header file.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: 0b74c8c99de6fe1cdaf53317d1fc772fdaeef91f
https://github.com/intel/tpm2-tools/commit/0b74c8c99de6fe1cdaf53317d1fc77...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M lib/tpm2_options.c
M lib/tpm2_options.h
M tools/tpm2_activatecredential.c
M tools/tpm2_certify.c
M tools/tpm2_changeauth.c
M tools/tpm2_clear.c
M tools/tpm2_create.c
M tools/tpm2_createpolicy.c
M tools/tpm2_createprimary.c
M tools/tpm2_dictionarylockout.c
M tools/tpm2_encryptdecrypt.c
M tools/tpm2_evictcontrol.c
M tools/tpm2_flushcontext.c
M tools/tpm2_getcap.c
M tools/tpm2_getmanufec.c
M tools/tpm2_getpubak.c
M tools/tpm2_getpubek.c
M tools/tpm2_getrandom.c
M tools/tpm2_hash.c
M tools/tpm2_hmac.c
M tools/tpm2_import.c
M tools/tpm2_listpersistent.c
M tools/tpm2_load.c
M tools/tpm2_loadexternal.c
M tools/tpm2_makecredential.c
M tools/tpm2_nvdefine.c
M tools/tpm2_nvread.c
M tools/tpm2_nvreadlock.c
M tools/tpm2_nvrelease.c
M tools/tpm2_nvwrite.c
M tools/tpm2_pcrevent.c
M tools/tpm2_pcrextend.c
M tools/tpm2_pcrlist.c
M tools/tpm2_quote.c
M tools/tpm2_rc_decode.c
M tools/tpm2_readpublic.c
M tools/tpm2_rsadecrypt.c
M tools/tpm2_rsaencrypt.c
M tools/tpm2_send.c
M tools/tpm2_sign.c
M tools/tpm2_startup.c
M tools/tpm2_unseal.c
M tools/tpm2_verifysignature.c
Log Message:
-----------
tools: add a boolean to display or not usage text
Not all tools require an option in order to be executed correctly, some
tools can be executed without providing any option to them.
Add a boolean so tools can choose whether they want their usage text to
be displayed or not if a user executes them without providing an option.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: 5190f1c892bb1b39f969522b8a04f935342699a2
https://github.com/intel/tpm2-tools/commit/5190f1c892bb1b39f969522b8a04f9...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M tools/tpm2_tool.c
Log Message:
-----------
tools: add support to print usage summary when executed with no options
When the tools are executed with no options, print a usage text so users
know what are the available options. This may be useful in systems where
the man pages are not installed.
After this patch the tools will print a usage text like the following:
$ tpm2_activatecredential
usage: tpm2_activatecredential [OPTIONS]
[ -H | --handle=VALUE] [ -c | --context=VALUE] [ -k | --key-handle=VALUE] [ -C | --key-context=VALUE]
[ -P | --Password=VALUE] [ -e | --endorse-passwd=VALUE] [ -f | --in-file=VALUE] [ -o | --out-file=VALUE]
[ -X | --passwdInHex]
Fixes: #730
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Compare: https://github.com/intel/tpm2-tools/compare/881048996a51...5190f1c892bb
3 years, 2 months
[intel/tpm2-tools] 2f4b0c: man: make tpm2_clear.1.md similar to other .md fil...
by GitHub
Branch: refs/heads/master
Home: https://github.com/intel/tpm2-tools
Commit: 2f4b0cb4286e7effe626156f341529e15790b1b7
https://github.com/intel/tpm2-tools/commit/2f4b0cb4286e7effe626156f341529...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M man/tpm2_clear.1.md
Log Message:
-----------
man: make tpm2_clear.1.md similar to other .md files
For unknown reasons, the previous commiter of this file decided
to use an out of date presentation for this markdown file and
not to follow the exemples given by the other .1.md files.
Change this to use the presentation used in the other similar files.
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: 475fe5a678eae0b73d161b057f4dd5e9af3859f4
https://github.com/intel/tpm2-tools/commit/475fe5a678eae0b73d161b057f4dd5...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M man/tpm2_hmac.1.md
M man/tpm2_verifysignature.1.md
Log Message:
-----------
man: fix a few formating issues
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: 881048996a51d23151c310172d4421b914b4898b
https://github.com/intel/tpm2-tools/commit/881048996a51d23151c310172d4421...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-21 (Thu, 21 Dec 2017)
Changed paths:
M Makefile.am
A man/common/footer.md
M man/tpm2_activatecredential.1.md
M man/tpm2_certify.1.md
M man/tpm2_changeauth.1.md
M man/tpm2_clear.1.md
M man/tpm2_create.1.md
M man/tpm2_createpolicy.1.md
M man/tpm2_createprimary.1.md
M man/tpm2_dictionarylockout.1.md
M man/tpm2_encryptdecrypt.1.md
M man/tpm2_evictcontrol.1.md
M man/tpm2_flushcontext.1.md
M man/tpm2_getcap.1.md
M man/tpm2_getmanufec.1.md
M man/tpm2_getpubak.1.md
M man/tpm2_getpubek.1.md
M man/tpm2_getrandom.1.md
M man/tpm2_hash.1.md
M man/tpm2_hmac.1.md
M man/tpm2_import.1.md
M man/tpm2_listpersistent.1.md
M man/tpm2_load.1.md
M man/tpm2_loadexternal.1.md
M man/tpm2_makecredential.1.md
M man/tpm2_nvdefine.1.md
M man/tpm2_nvlist.1.md
M man/tpm2_nvread.1.md
M man/tpm2_nvreadlock.1.md
M man/tpm2_nvrelease.1.md
M man/tpm2_nvwrite.1.md
M man/tpm2_pcrevent.1.md
M man/tpm2_pcrextend.1.md
M man/tpm2_pcrlist.1.md
M man/tpm2_quote.1.md
M man/tpm2_rc_decode.1.md
M man/tpm2_readpublic.1.md
M man/tpm2_rsadecrypt.1.md
M man/tpm2_rsaencrypt.1.md
M man/tpm2_send.1.md
M man/tpm2_sign.1.md
M man/tpm2_startup.1.md
M man/tpm2_unseal.1.md
M man/tpm2_verifysignature.1.md
Log Message:
-----------
man: move the footer definition in its own included file
This change simplify further modification of the BUGS or HELP sections
of the man pages.
It also update the BUGS address to match the current, correct one
(https://github.com/intel/tpm2-tools/issues instead of
https://github.com/01org/tpm2-tools/issues).
Fixes: #745
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Compare: https://github.com/intel/tpm2-tools/compare/da1045acace8...881048996a51
3 years, 2 months
[intel/tpm2-tools] 438059: travis.yml: build and install autoconf-archive fro...
by GitHub
Branch: refs/heads/master
Home: https://github.com/intel/tpm2-tools
Commit: 438059053b5545226f993986d36b6ed78b6a78da
https://github.com/intel/tpm2-tools/commit/438059053b5545226f993986d36b6e...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-14 (Thu, 14 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
travis.yml: build and install autoconf-archive from source
Commit 590ed9d2ed21 ("travis: fix autconf dependency on tss") fixed the
tpm2-tss dependency with the AX_CODE_COVERAGE macro, by fetching latest
autoconf-archive and copying the macro into the tpm2-tss source code m4
directory.
But now tpm2-abrmd also uses the macro for code coverage and so instead
of duplicating the same logic, install autoconf-archive in the machine.
While being there, clone the tpm2-{tss,abrmd} repos from the latest URL.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: b08643267775aa45d71dfe41b01da60879f160a3
https://github.com/intel/tpm2-tools/commit/b08643267775aa45d71dfe41b01da6...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-14 (Thu, 14 Dec 2017)
Changed paths:
M .travis.yml
Log Message:
-----------
travis.yml: fix travis error by fetching latest OpenSSL packages
The OpenSSL packages version changed so Travis CI was failing due trying
to download the ones that are no longer available.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: a3f568ce40ca1de5f0f5caaee491641ce9297bc9
https://github.com/intel/tpm2-tools/commit/a3f568ce40ca1de5f0f5caaee49164...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-14 (Thu, 14 Dec 2017)
Changed paths:
M Makefile.am
Log Message:
-----------
Makefile.am: include integration tests to generated tarball
The integration tests are not included in the tarball generated by the
make dist target.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: 368e5a13743bb131cc15300bc156a01f11763433
https://github.com/intel/tpm2-tools/commit/368e5a13743bb131cc15300bc156a0...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M .ci/travis-build-and-run-tests.sh
M .travis.yml
M Makefile.am
M configure.ac
Log Message:
-----------
configure: enable code coverage
This patch adds support for code coverage calculation
using gcov and lcov by configures --enable-code-coverage
and make check-code-coverage.
Use this option in the travis build.
Fixes: #711
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: 68aaeddeda98379b29837218f12ad7eb1e234687
https://github.com/intel/tpm2-tools/commit/68aaeddeda98379b29837218f12ad7...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M Makefile.am
M configure.ac
Log Message:
-----------
configure.ac: enable silent-rules configure option by default
This change is inspired by Andreas Fuchs enabling the silent-rules option
by default on tpm2-tss. The output is much nicer and one can have the old
output anyways by either disabling the silent-rules option or "make V=1".
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
Commit: 0c366e6addcfd5c0444a2039904d80226dfc05d8
https://github.com/intel/tpm2-tools/commit/0c366e6addcfd5c0444a2039904d80...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
CHANGELOG.md: update for code-coverage
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: b713ec83610480e05960165fc606795c57d00771
https://github.com/intel/tpm2-tools/commit/b713ec83610480e05960165fc60679...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
Update CHANGELOG.md
Commit: 5437abdd960acf87464f23f2435bb506b1f872ca
https://github.com/intel/tpm2-tools/commit/5437abdd960acf87464f23f2435bb5...
Author: Jerry Snitselaar <jsnitsel(a)redhat.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M test/system/test_tpm2_nv.sh
Log Message:
-----------
test: test_tpm2_nv.sh large_file_name and large_file_read_name should be different
Currently both are set as nv.test_large_w, so the cmp -s after the redirect tests
will be comparing nv.test_large_w to itself. Change large_file_read_name to
nv.test_large_r.
Signed-off-by: Jerry Snitselaar <jsnitsel(a)redhat.com>
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: fb0edff055301769d0bdc3616d5feba7e9c277d4
https://github.com/intel/tpm2-tools/commit/fb0edff055301769d0bdc3616d5feb...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M test/system/test_tpm2_nv.sh
Log Message:
-----------
test_tpm2_nv.sh: whitespace fix
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: ab1a2d468c4b2ac09a0ac651563653f36a73215f
https://github.com/intel/tpm2-tools/commit/ab1a2d468c4b2ac09a0ac651563653...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M tools/tpm2_nvwrite.c
Log Message:
-----------
tpm2_nvwrite: fix buffer overflow
As reported by clang asan:
=================================================================
==435==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7ffe036c0902 at pc 0x0000004a326d bp 0x7ffe036c02f0 sp 0x7ffe036bfaa0
WRITE of size 2048 at 0x7ffe036c0902 thread T0
#0 0x4a326c in __asan_memcpy (/home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite+0x4a326c)
#1 0x4e887b in nv_write /home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite.c:129:9
#2 0x4e82c4 in tpm2_tool_onrun /home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite.c:316:11
#3 0x4e90d9 in main /home/wcrobert/workspace/tpm2-tools/tools/tpm2_tool.c:150:11
#4 0x7fdfc968d82f in __libc_start_main /build/glibc-bfm8X4/glibc-2.23/csu/../csu/libc-start.c:291
#5 0x4195c8 in _start (/home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite+0x4195c8)
Address 0x7ffe036c0902 is located in stack of thread T0 at offset 1538 in frame
#0 0x4e846f in nv_write /home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite.c:76
This frame has 8 object(s):
[32, 172) 'session_data_out'
[240, 256) 'sessions_data'
[272, 288) 'sessions_data_out'
[304, 312) 'session_data_array'
[336, 344) 'session_data_out_array'
[368, 452) 'nv_public'
[496, 500) 'max_data_size'
[512, 1538) 'nv_write_data' <== Memory access at offset 1538 overflows this variable
HINT: this may be a false positive if your program uses some custom stack unwind mechanism or swapcontext
(longjmp and C++ exceptions *are* supported)
SUMMARY: AddressSanitizer: stack-buffer-overflow (/home/wcrobert/workspace/tpm2-tools/tools/tpm2_nvwrite+0x4a326c) in __asan_memcpy
Shadow bytes around the buggy address:
0x1000406d00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d00f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d0100: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d0110: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x1000406d0120:[02]f3 f3 f3 f3 f3 f3 f3 f3 f3 f3 f3 f3 f3 f3 f3
0x1000406d0130: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d0140: 00 00 00 00 00 00 00 00 00 00 00 00 f1 f1 f1 f1
0x1000406d0150: 00 00 00 00 00 00 00 00 02 f2 f2 f2 f2 f2 00 f3
0x1000406d0160: f3 f3 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
0x1000406d0170: 00 00 00 00 f1 f1 f1 f1 00 f2 f2 f2 01 f2 00 f3
Shadow byte legend (one shadow byte represents 8 application bytes):
Addressable: 00
Partially addressable: 01 02 03 04 05 06 07
Heap left redzone: fa
Heap right redzone: fb
Freed heap region: fd
Stack left redzone: f1
Stack mid redzone: f2
Stack right redzone: f3
Stack partial redzone: f4
Stack after return: f5
Stack use after scope: f8
Global redzone: f9
Global init order: f6
Poisoned by user: f7
Container overflow: fc
Array cookie: ac
Intra object redzone: bb
ASan internal: fe
Left alloca redzone: ca
Right alloca redzone: cb
==435==ABORTING
Fix by using the max buffer's size field, not the loaded from
file buffers size field.
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: 666a436384c69d18704c2a55a5368a5e184606f3
https://github.com/intel/tpm2-tools/commit/666a436384c69d18704c2a55a5368a...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-15 (Fri, 15 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
Update CHANGELOG.md
Commit: f0d1920910166c093d08172f31501767f8b04328
https://github.com/intel/tpm2-tools/commit/f0d1920910166c093d08172f315017...
Author: Jerry Snitselaar <jsnitsel(a)redhat.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M tools/tpm2_nvread.c
M tools/tpm2_nvwrite.c
Log Message:
-----------
nv: don't exceed max nv buffer size for TSS
Currently if a tpm device supports a max nv buffer size greater than
tss supports we can get buffer overflows. Check the size returned by
the tpm device, and use the min of that and the max supported by tss.
Signed-off-by: Jerry Snitselaar <jsnitsel(a)redhat.com>
Commit: e428daa8e778595924748a148653a4162da3cfe8
https://github.com/intel/tpm2-tools/commit/e428daa8e778595924748a148653a4...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
Update CHANGELOG.md
Commit: e09fbb3ca65f4ff1e8bf1fa619e21f14a2efe4dc
https://github.com/intel/tpm2-tools/commit/e09fbb3ca65f4ff1e8bf1fa619e21f...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
CHANGELOG: set release date
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: 974e32d2907de38d69c063e802211949c618ccd8
https://github.com/intel/tpm2-tools/commit/974e32d2907de38d69c063e8022119...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-18 (Mon, 18 Dec 2017)
Changed paths:
M README.md
Log Message:
-----------
Update README.md
Commit: a8bdbdcc5bbf13d50f6ab50ef9c3a6f5abc9e885
https://github.com/intel/tpm2-tools/commit/a8bdbdcc5bbf13d50f6ab50ef9c3a6...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M CHANGELOG.md
Log Message:
-----------
CHANGELOG: set release date
Signed-off-by: William Roberts <william.c.roberts(a)intel.com>
Commit: a1145cd5f6eaa0d61de7ca249d10842b9b2da2a2
https://github.com/intel/tpm2-tools/commit/a1145cd5f6eaa0d61de7ca249d1084...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M .ci/travis-build-and-run-tests.sh
M CHANGELOG.md
Log Message:
-----------
Merge 3.X' into master
Commit: f392466e389f9556dd2e7683f148b6cc4f3639d6
https://github.com/intel/tpm2-tools/commit/f392466e389f9556dd2e7683f148b6...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Log Message:
-----------
Merge tag '3.0.2' into into-master
3.0.2 - 2017-12-18
* configure: enable code coverage option.
* build: enable silent rules options.
* Add system tests to dist tarball.
* tpm2_nv(read|write): fix buffer overflows.
Commit: da1045acace8142f44820ba1a819d14b6c8cc605
https://github.com/intel/tpm2-tools/commit/da1045acace8142f44820ba1a819d1...
Author: William Roberts <william.c.roberts(a)intel.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M .ci/travis-build-and-run-tests.sh
M CHANGELOG.md
Log Message:
-----------
Merge pull request #739 from williamcroberts/merge-3.X-into-master
Merge 3.x into master
Compare: https://github.com/intel/tpm2-tools/compare/561a9778808a...da1045acace8
3 years, 2 months
[intel/tpm2-tools] 561a97: tpm2_getmanufec: don't attempt to free a pointer t...
by GitHub
Branch: refs/heads/master
Home: https://github.com/intel/tpm2-tools
Commit: 561a9778808a1fcbcd4aceb87791b5b51b03a7c9
https://github.com/intel/tpm2-tools/commit/561a9778808a1fcbcd4aceb87791b5...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M tools/tpm2_getmanufec.c
Log Message:
-----------
tpm2_getmanufec: don't attempt to free a pointer that is already NULL
Commit cc51f9fe188a ("tpm2_getmanufec: fix a memory leak") fixed a memory
leak in TPMinitialProvisioning(), but after this change a pointer that is
already NULL is attempted to be freed.
This doesn't matter since free(3) is a no-op if a pointer is already NULL
but still it's a good practice to free the resources in the inverse order
than were allocated and also makes no sense to attempt to free a NULL ptr.
Reported-by: Jerry Snitselaar <jsnitsel(a)redhat.com>
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
3 years, 2 months
[intel/tpm2-tools] 13f11a: travis.yml: build and install autoconf-archive fro...
by GitHub
Branch: refs/heads/2.X
Home: https://github.com/intel/tpm2-tools
Commit: 13f11a4e038ad0bce37aa73340572ab3e2020932
https://github.com/intel/tpm2-tools/commit/13f11a4e038ad0bce37aa73340572a...
Author: Javier Martinez Canillas <javierm(a)redhat.com>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M .ci/travis-tss-install.sh
M .travis.yml
Log Message:
-----------
travis.yml: build and install autoconf-archive from source
Commit 590ed9d2ed21 ("travis: fix autconf dependency on tss") fixed the
tpm2-tss dependency with the AX_CODE_COVERAGE macro, by fetching latest
autoconf-archive and copying the macro into the tpm2-tss source code m4
directory.
But now tpm2-abrmd also uses the macro for code coverage and so instead
of duplicating the same logic, install autoconf-archive in the machine.
While being there, clone the tpm2-{tss,abrmd} repos from the latest URL.
Signed-off-by: Javier Martinez Canillas <javierm(a)redhat.com>
3 years, 2 months
[intel/tpm2-tools] 81a47c: command line: change option names from output to o...
by GitHub
Branch: refs/heads/master
Home: https://github.com/intel/tpm2-tools
Commit: 81a47c9762d8cec7f1cdd514b1d21fb8e75fde0e
https://github.com/intel/tpm2-tools/commit/81a47c9762d8cec7f1cdd514b1d21f...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M man/tpm2_getmanufec.1.md
M man/tpm2_getrandom.1.md
M man/tpm2_hash.1.md
M man/tpm2_hmac.1.md
M man/tpm2_nvread.1.md
M man/tpm2_pcrlist.1.md
M man/tpm2_readpublic.1.md
M man/tpm2_unseal.1.md
M test/system/tests/disabled/import.sh
M tools/tpm2_getmanufec.c
M tools/tpm2_getrandom.c
M tools/tpm2_hash.c
M tools/tpm2_hmac.c
M tools/tpm2_nvread.c
M tools/tpm2_pcrlist.c
M tools/tpm2_readpublic.c
M tools/tpm2_send.c
M tools/tpm2_unseal.c
Log Message:
-----------
command line: change option names from output to out-file
When comparing command line switches that are specified to select an
output file, most of the tools use option 'out-file' and only a few of
them use option 'output' or other rarer names such as 'outfile'. In
order to rationalize option naming a bit, we turn all these option
names into 'out-file'.
Fixes: #729
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: ba1a77fb333e0e38064b8ab73b856f7b5e842430
https://github.com/intel/tpm2-tools/commit/ba1a77fb333e0e38064b8ab73b856f...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M man/tpm2_getmanufec.1.md
M man/tpm2_getpubak.1.md
M man/tpm2_getpubek.1.md
M tools/tpm2_getmanufec.c
M tools/tpm2_getpubak.c
M tools/tpm2_getpubek.c
Log Message:
-----------
command line: change 'alg' to 'algorithm'
Most tools use the 'algorithm' command line switch, so rename the option
name for the few that are using it's shorthand 'alg'.
Fixes: #729
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: d6c0ba46926c440bca8a7e03600e40068ba828cd
https://github.com/intel/tpm2-tools/commit/d6c0ba46926c440bca8a7e03600e40...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M man/tpm2_changeauth.1.md
M man/tpm2_clear.1.md
M man/tpm2_pcrevent.1.md
M man/tpm2_quote.1.md
M tools/tpm2_changeauth.c
M tools/tpm2_clear.c
M tools/tpm2_pcrevent.c
M tools/tpm2_quote.c
Log Message:
-----------
command line: '*password' becomes '*passwd'
The passwd shorthand is used for a large part of all password-related
option names.
Fixes: #729
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: 5d4c08ff688de1d928bb37d4b536433aa0a79a76
https://github.com/intel/tpm2-tools/commit/5d4c08ff688de1d928bb37d4b53643...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M man/tpm2_sign.1.md
M man/tpm2_verifysignature.1.md
M tools/tpm2_sign.c
M tools/tpm2_verifysignature.c
Log Message:
-----------
command line: replace 'msg' by 'message'
Makes more clear what 'msg' is.
Fixes: #729
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: 0d1d02e843a01e37d555914da29aebfefb8a521d
https://github.com/intel/tpm2-tools/commit/0d1d02e843a01e37d555914da29aeb...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M tools/tpm2_hash.c
M tools/tpm2_send.c
Log Message:
-----------
command lines: various fixes
This fixes some typos and other small errors related to command line
options.
Fixes: #729
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: bad4999b948b9e4761bdcaf0b89c1e567571c692
https://github.com/intel/tpm2-tools/commit/bad4999b948b9e4761bdcaf0b89c1e...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M tools/tpm2_create.c
M tools/tpm2_createprimary.c
M tools/tpm2_encryptdecrypt.c
M tools/tpm2_evictcontrol.c
M tools/tpm2_getmanufec.c
M tools/tpm2_getpubek.c
M tools/tpm2_hmac.c
M tools/tpm2_load.c
M tools/tpm2_nvread.c
M tools/tpm2_nvreadlock.c
M tools/tpm2_nvrelease.c
M tools/tpm2_nvwrite.c
M tools/tpm2_rsadecrypt.c
M tools/tpm2_verifysignature.c
Log Message:
-----------
command line: replace 1 with required_argument in the option list
Make sure options are defined the same way in all tools in order to
simplify further development.
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Commit: d932ed67d3d8bb7d66ec4e1229b6469110976614
https://github.com/intel/tpm2-tools/commit/d932ed67d3d8bb7d66ec4e1229b646...
Author: Emmanuel Deloget <logout(a)free.fr>
Date: 2017-12-19 (Tue, 19 Dec 2017)
Changed paths:
M lib/tpm2_options.c
M tools/tpm2_certify.c
M tools/tpm2_changeauth.c
M tools/tpm2_clear.c
M tools/tpm2_dictionarylockout.c
M tools/tpm2_getpubak.c
M tools/tpm2_pcrevent.c
M tools/tpm2_pcrlist.c
M tools/tpm2_quote.c
M tools/tpm2_readpublic.c
M tools/tpm2_sign.c
M tools/tpm2_unseal.c
Log Message:
-----------
command line: correly present command line options in the code
The command line option code was a bit difficult to read because of
missing spaces, column offsets and so on. Strealine this to make it
easier to grasp (and to parse when using a tool).
Signed-off-by: Emmanuel Deloget <logout(a)free.fr>
Compare: https://github.com/intel/tpm2-tools/compare/d58e882554d2...d932ed67d3d8
3 years, 2 months