On Mon, 2009-12-14 at 15:12 +0000, Chen, Congwu wrote:
On Mon, 14 Dec 2009, Ohly, Patrick wrote:
> To handle this, I think we should declare that the "sync" property of
> sources which are merged into a super datastore are ignored. That
> setting must be taken from the super datastore config. Inconsistent
> settings are not an error, because the "syncevolution ... calendar+todo"
> command line invocation will lead to such an "inconsistent" config.
Ignoring duplicated properties is prefered. So 'sync' and 'uri'should be
set in the virtual datasource, the sub datasource should take these two
properties as ignored. No inconsistence check is needed for the two.
To implement this, when instatiating a virtual datasource, it will cause
all sub datasources be enabled the same time and the 'sync' and 'uri'
property
is set temporarily from the value in virtual datasource.
Sounds like the right approach to me.
There is still one property left need some consistence check:
'type'. It cannot
be simply merged, because a sub-datastore may still use it to identify it's
specific backend. However the 'format' part must be exactly the same for all
subdatastores and the virtual datastore.
Agreed.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.