Re: [SyncEvolution] sync timeouts for syncevo-http-server + nokia e51 phone

On Thu, 2013-02-07 at 21:47 +0100, Lukas Zeller wrote: I'm looking into enabling that for SyncEvolution. Some questions, if I may... With <subthreadmode>none</subthreadmode> for logging, is the shared logger instance really thread-safe, or should this mode rather be avoided? I don't see any mutex locking. My understanding is that logging will not look nice when different threads open and close blocks in the wrong order in the same .html file, which does indeed happen when 'ReadSyncSet' block continues while the main thread sends an intermediate reply. So that alone may be a reason to avoid the single-file approach, although multiple files will make debugging harder. Which defines do I need to change where to enable thread support? There is a comment in "define.h" which says that the __MAKE_THREADSAFE option was moved to "target_options.h", but I don't see that option there. __MAKE_THREADSAFE seems to be for the SyncML Toolkit. For the Synthesis engine, I am setting MULTI_THREAD_SUPPORT and MULTI_THREAD_DATASTORE in "target_options.h". Does that sound right? Patch attached. -- Best Regards, Patrick Ohly The content of this message is my personal opinion only and although I am an employee of Intel, the statements I make here in no way represent Intel's position on the issue, nor am I authorized to speak on behalf of Intel on this matter.