Re: [SyncEvolution] Syncevolution build system conversion
2011/8/31 Patrick Ohly <patrick.ohly(a)intel.com>:
On Di, 2011-08-30 at 15:05 +0200, Krzesimir Nowak wrote:
> I also added a warnings system like described in [1]. It may be useful.
> [1] http://www.murrayc.com/blog/permalink/2011/01/18/avoiding-use-of-deprecat...
Yes, sounds useful. In the nightly testing I add "-Werror -Wall" to the
CXXFLAGS/CFLAGS on the command line, but this --enable-warnings=fatal is
nicer.
Ah, minor caveat: libsynthesis doesn't support it yet. So at the moment,
the explicit flags are still needed when compiling both at the same
time.
> Again, I'm attaching a complete patch made against
> dbus-server-reorganization branch.
I've fast-forwarded "master" to your autotools-cleanup-2 branch this
morning and started testing it, after fixing the ActiveSync backend and
runtests.py (invoked make in the wrong directories/with wrong targets).
Works fine so far.
In the meantime you also made a similar change for ActiveSync. I think
I'll stay with my version because a) it doesn't add the
--export-dynamic, which no longer seems to be necessary (if it ever was)
and b) it doesn't include an unrelated change to addressbook.am.
and c) it does add README file into distribution.
And that change in addressbook.am was removing a leftover from old
build system (there are no separate Makefiles anymore), so maybe
you'll want to remove it sometime later.
But you are right about SYNCEVO_WFLAGS and wrapping AS_HELP_STRING(),
will fix that.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.