[PATCH net-next 0/9] mptcp: Another set of miscellaneous MPTCP fixes
by Mat Martineau
This is another collection of MPTCP fixes and enhancements that we have
tested in the MPTCP tree:
Patch 1 cleans up cgroup attachment for in-kernel subflow sockets.
Patches 2 and 3 make sure that deletion of advertised addresses by an
MPTCP path manager when flushing all addresses behaves similarly to the
remove-single-address operation, and adds related tests.
Patches 4 and 8 do some minor cleanup.
Patches 5-7 add MPTCP_FASTCLOSE functionality. Note that patch 6 adds MPTCP
option parsing to tcp_reset().
Patch 9 optimizes skb size for outgoing MPTCP packets.
Florian Westphal (3):
mptcp: hold mptcp socket before calling tcp_done
tcp: parse mptcp options contained in reset packets
mptcp: parse and act on incoming FASTCLOSE option
Geliang Tang (3):
mptcp: remove address when netlink flushes addrs
selftests: mptcp: add the flush addrs testcase
mptcp: use MPTCPOPT_HMAC_LEN macro
Nicolas Rybowski (1):
mptcp: attach subflow socket to parent cgroup
Paolo Abeni (2):
mptcp: pm: simplify select_local_address()
mptcp: let MPTCP create max size skbs
include/net/tcp.h | 2 +-
net/ipv4/tcp_input.c | 13 +++--
net/ipv4/tcp_minisocks.c | 2 +-
net/mptcp/options.c | 17 +++++++
net/mptcp/pm_netlink.c | 21 ++++----
net/mptcp/protocol.c | 47 +++++++++++++++--
net/mptcp/protocol.h | 6 ++-
net/mptcp/subflow.c | 34 ++++++++++++-
.../testing/selftests/net/mptcp/mptcp_join.sh | 50 +++++++++++++------
9 files changed, 155 insertions(+), 37 deletions(-)
base-commit: 51e13685bd93654e0e9b2559c8e103d6545ddf95
--
2.29.2
1 year, 8 months
[PATCH mptcp-net-next] mptcp: fix pending data accounting
by Paolo Abeni
When sendmsg() needs to wait for memory, the pending data
is not updated. That causes a drift in forward memory allocation,
leading to stall and/or warnings at socket close time.
This change addresses the above issue moving the pending data
counter update inside the sendmsg() main loop.
Fixes: 6e628cd3a8f7 ("mptcp: use mptcp release_cb for delayed tasks")
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
note:
- will target -net, should net-next close meanwhile
- this possibly fixes issues/115
---
net/mptcp/protocol.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 670d49825499..349134622077 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -1658,6 +1658,7 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
frag_truesize += psize;
pfrag->offset += frag_truesize;
WRITE_ONCE(msk->write_seq, msk->write_seq + psize);
+ msk->tx_pending_data += copied;
/* charge data on mptcp pending queue to the msk socket
* Note: we charge such data both to sk and ssk
@@ -1683,10 +1684,8 @@ static int mptcp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
goto out;
}
- if (copied) {
- msk->tx_pending_data += copied;
+ if (copied)
mptcp_push_pending(sk, msg->msg_flags);
- }
out:
release_sock(sk);
--
2.26.2
1 year, 8 months
[MPTCP][PATCH v7 mptcp-next 0/7] ADD_ADDR: ports support
by Geliang Tang
v7:
- use the MPTCP listening socket instead of TCP one
- release subflow_req->msk in subflow_init_req
- add mismatched port MIBs
- use sock_common in source_address
v6:
- create and bind the listening socket in mptcp_nl_cmd_add_addr.
- drop the patch "mptcp: add port number listened in kernel check" in
v5.
v5:
- use the per netns listening socket.
- First 8 patches in v4 had been merged to the export branch, drop them
from this patchset.
v4:
- hold msk->pm.lock in mptcp_pm_sport_in_anno_list.
- Merge the patchset 'Squash to "ADD_ADDR: ports support v3"' into v4.
v3:
- add two new patches, 8 and 11
- add more IS_ENABLED(CONFIG_MPTCP_IPV6) in patch 2
- define TCPOLEN_MPTCP_ADD_ADDR_HMAC in patch 4
- add flags check in patch 10
- update the testcases
v2:
- change mptcp_out_options's port field in CPU bype order.
- keep mptcp_options_received's port field in CPU bype order.
- add two new patches to simplify ADD_ADDR suboption writing.
- update mptcp_add_addr_len helper use adding up size.
- add more commit messages.
v1:
This series is the first version of ADD_ADDR ports support. I have solved
the listener problem which I mentioned at the meeting on 15th of October
by adding a new listening socket from the userspace (see patch 8). Up to
now this patchset works well.
Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/54
Geliang Tang (7):
mptcp: create the listening socket for new port
mptcp: add port number check for MP_JOIN
mptcp: add port number announced check
mptcp: deal with MPTCP_PM_ADDR_ATTR_PORT in PM netlink
selftests: mptcp: add port argument for pm_nl_ctl
mptcp: add the mibs for ADD_ADDR with port
selftests: mptcp: add testcases for ADD_ADDR with port
net/mptcp/mib.c | 6 +
net/mptcp/mib.h | 6 +
net/mptcp/options.c | 4 +
net/mptcp/pm_netlink.c | 97 ++++++++++++
net/mptcp/protocol.c | 2 +-
net/mptcp/protocol.h | 4 +
net/mptcp/subflow.c | 48 +++++-
.../testing/selftests/net/mptcp/mptcp_join.sh | 148 +++++++++++++++++-
tools/testing/selftests/net/mptcp/pm_nl_ctl.c | 24 ++-
9 files changed, 333 insertions(+), 6 deletions(-)
--
2.26.2
1 year, 8 months
[MPTCP][PATCH mptcp-next] Squash to "mptcp: add the address ID assignment bitmap"
by Geliang Tang
Initialize addr.id to zero in mptcp_pm_nl_get_local_id, otherwise it will
be a random number.
Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
---
net/mptcp/pm_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
index 4aa88a697b74..9b1f6298bbdb 100644
--- a/net/mptcp/pm_netlink.c
+++ b/net/mptcp/pm_netlink.c
@@ -656,6 +656,7 @@ int mptcp_pm_nl_get_local_id(struct mptcp_sock *msk, struct sock_common *skc)
entry->addr = skc_local;
entry->addr.ifindex = 0;
entry->addr.flags = 0;
+ entry->addr.id = 0;
ret = mptcp_pm_nl_append_new_local_addr(pernet, entry);
if (ret < 0)
kfree(entry);
--
2.29.2
1 year, 8 months
[PATCH mptcp-next] Squash-to: "mptcp: push pending frames when subflow has free space"
by Paolo Abeni
whoops, checking the free space on the wrong sock
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
net/mptcp/options.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index f4e6808691ed..973867f73952 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -881,7 +881,7 @@ static void ack_update_msk(struct mptcp_sock *msk,
/* this assumes mptcp_incoming_options() is invoked after tcp_ack() */
if (after64(msk->wnd_end, READ_ONCE(msk->snd_nxt)) &&
- sk_stream_memory_free(sk))
+ sk_stream_memory_free(ssk))
__mptcp_check_push(sk, ssk);
if (after64(new_snd_una, old_snd_una)) {
--
2.26.2
1 year, 8 months
[MPTCP][PATCH mptcp-next] Squash to "[PATCH v3 mptcp-next 1/6] mptcp: add the outgoing MP_PRIO support"
by Geliang Tang
Leave OPTION_MPTCP_FASTCLOSE as BIT(9) and set OPTION_MPTCP_PRIO as
BIT(10).
Signed-off-by: Geliang Tang <geliangtang(a)gmail.com>
---
net/mptcp/protocol.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index fda183553422..d6400ad2d615 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -23,8 +23,8 @@
#define OPTION_MPTCP_ADD_ADDR BIT(6)
#define OPTION_MPTCP_ADD_ADDR6 BIT(7)
#define OPTION_MPTCP_RM_ADDR BIT(8)
-#define OPTION_MPTCP_PRIO BIT(9)
-#define OPTION_MPTCP_FASTCLOSE BIT(10)
+#define OPTION_MPTCP_FASTCLOSE BIT(9)
+#define OPTION_MPTCP_PRIO BIT(10)
/* MPTCP option subtypes */
#define MPTCPOPT_MP_CAPABLE 0
--
2.26.2
1 year, 8 months
[Weekly meetings] MoM - 3rd of December 2020
by Matthieu Baerts
Hello everyone,
Last Thursday, we had our 127th meeting with Mat and Ossama (Intel),
Christoph (Apple), Geliang (Xiaomi) and myself (Tessares).
Davide, Paolo and Florian all got a red card but not hat.
Thanks again for this new good meeting!
Here are the minutes of the meeting:
Accepted patches:
- The list of accepted patches can be seen on PatchWork:
https://patchwork.ozlabs.org/project/mptcp/list/?state=3
netdev (if mptcp ML is in cc) (Paolo):
1407108 [net-next,6/6] mptcp: use mptcp release_cb for delayed tasks
1407107 [net-next,5/6] mptcp: avoid a few atomic ops in the rx path
1407105 [net-next,4/6] mptcp: allocate TX skbs in msk context
1407106 [net-next,3/6] mptcp: protect the rx path with the msk socket
spinlock
1407102 [net-next,2/6] mptcp: implement wmem reservation
1407104 [net-next,1/6] mptcp: open code mptcp variant for lock_sock
our repo (by: /):
/
Pending patches:
- The list of pending patches can be seen on PatchWork:
https://patchwork.ozlabs.org/project/mptcp/list/?state=*
netdev (if mptcp ML is in cc) (by: Florian):
1408363: New: [net-next,1/3] security: add const qualifier to struct
sock in various places
1408362: New: [net-next,2/3] tcp: merge 'init_req' and 'route_req' functions
1408365: New: [net-next,3/3] mptcp: emit tcp reset when a join request
fails:
- Waiting for feedback from the security team
our repo (by: Florian Westphal, Geliang Tang, Paolo Abeni):
1370702: RFC: [RFC,4/4] tcp: parse tcp options contained in reset packets
1375893: RFC: [RFC,mptpcp-next] mptcp: add ooo prune support
1395128: RFC: [1/5] tcp: make two mptcp helpers available to tcp stack
1395131: RFC: [3/5] mptcp: add mptcp reset option support
1395133: RFC: [5/5] mptcp: send fastclose if userspace closes socket
with unread data:
- WIP
1403495: Changes Requested: [mptcp-next,1/5] mptcp: add the outgoing
MP_PRIO support
1403497: Changes Requested: [mptcp-next,2/5] mptcp: add the incoming
MP_PRIO support
1403498: Changes Requested: [mptcp-next,3/5] mptcp: deal with
MPTCP_PM_ADDR_FLAG_BACKUP in PM netlink
1403499: Changes Requested: [mptcp-next,4/5] mptcp: add the mibs for MP_PRIO
1403500: Changes Requested: [mptcp-next,5/5] selftests: mptcp: add the
MP_PRIO testcases:
- some questions are still opened
- Behaviour with the Netlink interface are still pending
- @Paolo: might you have a look at these questions (how to use the
flags in the Netlink PM) please? → Done
- once replied, should be easy to implement
1406751: Needs Review / ACK: [v3] mptcp: let MPTCP create max size skbs:
- To be applied → Done
1408030: New: [v7,mptcp-next,1/7] mptcp: create the listening socket for
new port
1408031: New: [v7,mptcp-next,2/7] mptcp: add port number check for MP_JOIN
1408032: New: [v7,mptcp-next,3/7] mptcp: add port number announced check
1408033: New: [v7,mptcp-next,4/7] mptcp: deal with
MPTCP_PM_ADDR_ATTR_PORT in PM netlink
1408034: New: [v7,mptcp-next,5/7] selftests: mptcp: add port argument
for pm_nl_ctl
1408035: New: [v7,mptcp-next,6/7] mptcp: add the mibs for ADD_ADDR with port
1408036: New: [v7,mptcp-next,7/7] selftests: mptcp: add testcases for
ADD_ADDR with port:
- Mat would like to have a look and test it
- v7 should address Paolo's comment from v6
- Review needed on these ones → Done
1408091: New: [mptcp-next] Squash to "[MPTCP][PATCH v7 mptcp-next 3/7]
mptcp: add port number announced check"
1408144: New: [mptcp-next] mptcp: enable use_port when invoke
addresses_equal:
- Part of ADD_ADDR port support patch set
- will insert into ADD_ADDR port support v8
- need review → Done
1408800: New: [mptcp-next] mptcp: add the address ID assignment bitmap:
- for issue 117
- need review → Done
1408047: New: [v2,mptcp-next,1/2] mptcp: remove address when netlink
flush addrs
1408049: New: [v2,mptcp-next,2/2] selftests: mptcp: add the flush addrs
testcase
- these are ready
- to be applied → Done
1409483: New: [mptcp-next] Squash to "mptcp: use adding up size to get
ADD_ADDR length":
- to be squashed in a commit already in the export branch
- needs review → Done
1409493: New: [mptcp-next] mptcp: use MPTCPOPT_HMAC_LEN macro:
- is independent to the rest
- needs review → Done
1409622: Changes Requested: [RFC] selinux: handle MPTCP consistently
with TCP:
- sent upstream
- waiting for feedback from upstream → Done
- should be re-sent as non RFC?
- patches sent by Florian are still waiting for feedback, maybe
normal and we have to wait more?
1409810: Rejected: [mptcp-next] mptcp: address potential infinite loop
on receive:
- replaced by a patch from Eric (not sent to mptcp ml, directly netdev)
1410365: New: [mptcp-next] mptcp: link MPC subflow into msk only after
accept
- this will likely hide issues/104, but will not fix it (it fixes
issues/103)
- needs review → Done
1410476: New: [net-next] mptcp: pm: simplify select_local_address():
- need reviews → Done
Issues on Github:
https://github.com/multipath-tcp/mptcp_net-next/issues/
Recently opened (latest from last week: 116)
119 [syzkaller] memory leak in __get_filter:
- new, to be analysed
117 Allow user-space to set endpoint ID [enhancement] [help wanted]
@geliangtang:
- Geliang already sent a patch: mptcp: add the address ID
assignment bitmap
- v2 might be needed
Bugs (opened, flagged as "bug" and assigned)
104 [syzkaller] general protection fault in skb_release_data [bug]
[syzkaller] @geliangtang:
- Geliang is able to reproduce the issue
- Paolo has a patch -- mptcp: link MPC subflow into msk only
after accept -- that hides this issue
- but still a fix for 104 will be needed
94 Packetdrill: after a received DATA_FIN, no new packets can be
treated [bug] [packetdrill] @dcaratti:
- Davide sent a workaround
- Some fix in packetdrill are still needed
85 Packetdrill: multiple timeout reported by the CI [bug]
[packetdrill] @matttbe:
- The situation is better thanks to a modification in run_all.py
done by Florian
Bugs (opened and flagged as "bug" and not assigned)
115 [syzkaller] WARNING in sk_stream_kill_queues [bug] [syzkaller]
- any repro for this one?
- No repro but still happening with the export branch from 3 days
ago but no repro
- possibly related to:
https://syzkaller.appspot.com/x/repro.syz?x=103bf743500000 ???
114 packetdrill: dss tolerance issue to emit the FIN+ACK [bug]
[packetdrill]
112 sporadic failure of mptcp_join.sh selftest 13 [bug]
110 [syzkaller] memory leak in __ip_mc_join_group [bug] [syzkaller]
109 [syzkaller] memory leak in skb_ext_add [bug] [syzkaller]
108 [syzkaller] memory leak in sk_clone_lock [bug] [syzkaller]
107 Review use of WARN_ON() / WARN_ON_ONCE() [bug]
106 [syzkaller] BUG: Bad page state [bug] [syzkaller]
103 [syzkaller] WARNING in inet_csk_listen_stop [bug] [syzkaller]
[pabeni takes this one]:
- TODO: change assigned → Done
65 clearing properly the status in listen() [bug]
56 msk connection state set without msk lock [bug]
In Progress (opened and assigned)
117 Allow user-space to set endpoint ID [enhancement] [help wanted]
@geliangtang:
- see above
96 Python: add support for IPPROTO_MPTCP [enhancement] @matttbe
76 [gs]etsockopt per subflow: BPF [enhancement] @matttbe
54 ADD_ADDR: ports support [enhancement] @geliangtang:
- see "Patches" section ↑
51 MP_PRIO support [enhancement] @geliangtang:
- see "Patches" section ↑
43 [syzkaller] Change syzkaller to exercise MPTCP inet_diag
interface [enhancement] [syzkaller] @cpaasch:
- syzkaller is able to find its way
- it seems we could improve it to make sure more is covered
- not MPTCP specific issue
- TODO: unassign Christoph → Done
Recently closed (since last week)
118 ignore me: sorry for the noise, testing IRC notifications
111 [syzkaller] divide error in __tcp_select_window [bug] [syzkaller]
105 warning in `mptcp_reset_timer()` with `mptcp_connect.sh -m mmap`
[bug]
99 simult_flows selftest is unstable: remaining sockets in
TIME-WAIT state [bug]
FYI: Current Roadmap:
- Bugs: https://github.com/multipath-tcp/mptcp_net-next/projects/2
- Current merge window (5.11):
https://github.com/multipath-tcp/mptcp_net-next/projects/6
- For later: https://github.com/multipath-tcp/mptcp_net-next/projects/4
Patches to send to netdev:
- net:
- /
- net-next:
- next patches are from Geliang
- We need to squash one patch in "mptcp: use adding up size to
get ADD_ADDR length" → Done
- Then we could send the outgoing ADD_ADDR port support series
that is already in the export branch → Done
- @Florian: Or send fast-close support first if they are ready?
Extra tests:
- news about Syzkaller? (Christoph):
- See above
- news about interop with mptcp.org? (Christoph):
- IPerf test is really slow with last export
- Trying to find what caused the regression
- It looks like the receiver is dropping data at the MPTCP level
- sender is mptcp.org
- upstream is receiver
- Christoph will open a new bug report → Done
- news about Intel's kbuild? (Mat):
- Builds still running but still an intermittent MP_JOIN failure
- This test is time sensitive
- seems to happen less often
- packetdrill (Davide):
- Florian fixed an issue in run_all.py
- FC tests are back
- New tests from Paolo (regression)
- Tests for ADD_ADDR with v6 are not passing, to be investigate
- CI (Matth):
- Some improvements in IRC notifications
- stream performances:
- looks like east - west traffic is way slower than loopback,
root cause still to be investigated
- between 2 VMs? yep
- what about including use_mptcp in mptcpd? and what about some
additional script/glue to automatically generate
MPTCP-enabled systemd units?:
- looks fine to add this. Not directly related to mptcpd but linked
to mptcp
- Ossama will reply to this email → Done
- [pabeni] should I resend the selinux patch (possibly without the typo)
removing the RFC tag?:
- linked to "selinux: handle MPTCP consistently with TCP" patch
- Maybe yes, a non RFC version would be good to "force" feedback
- (upstream comments received)
- next upstream batch ? ebpf? or port-based endpoint support?:
- see the discussion above
Next meeting:
- We propose to have the next meeting on Thursday, the 10th of
December.
- Usual UTC time: 16:00 UTC (8am PST, 5pm CET, Midnight CST)
- Still open to everyone!
- https://annuel2.framapad.org/p/mptcp_upstreaming_20201210
Feel free to comment on these points and propose new ones for the next
meeting!
Talk to you 3 hours ago,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
1 year, 8 months
[PATCH mptcp-next] mptcp: push pending frames when subflow has free space
by Paolo Abeni
When multiple subflows are active, we can receive a
window update on subflow with no write space available.
MPTCP will try to push frames on such subflow and will
fail. Pending frames will be pushed only after receiving
a window update on a subflow with some wspace available.
Overall the above could lead to suboptimal aggregate
bandwidth usage.
Instead, we should try to push pending frames as soon as
the subflow reaches both conditions mentioned above.
We can finally enable self-tests with asymmetric links,
as the above makes them finally pass.
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
net/mptcp/options.c | 13 ++++++++-----
net/mptcp/protocol.c | 2 +-
net/mptcp/protocol.h | 2 +-
tools/testing/selftests/net/mptcp/simult_flows.sh | 6 +++---
4 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/net/mptcp/options.c b/net/mptcp/options.c
index f5f4bd04196d..f4e6808691ed 100644
--- a/net/mptcp/options.c
+++ b/net/mptcp/options.c
@@ -876,10 +876,13 @@ static void ack_update_msk(struct mptcp_sock *msk,
new_wnd_end = new_snd_una + tcp_sk(ssk)->snd_wnd;
- if (after64(new_wnd_end, msk->wnd_end)) {
+ if (after64(new_wnd_end, msk->wnd_end))
msk->wnd_end = new_wnd_end;
- __mptcp_wnd_updated(sk, ssk);
- }
+
+ /* this assumes mptcp_incoming_options() is invoked after tcp_ack() */
+ if (after64(msk->wnd_end, READ_ONCE(msk->snd_nxt)) &&
+ sk_stream_memory_free(sk))
+ __mptcp_check_push(sk, ssk);
if (after64(new_snd_una, old_snd_una)) {
msk->snd_una = new_snd_una;
@@ -945,8 +948,8 @@ void mptcp_incoming_options(struct sock *sk, struct sk_buff *skb)
* helpers are cheap.
*/
mptcp_data_lock(subflow->conn);
- if (mptcp_send_head(subflow->conn))
- __mptcp_wnd_updated(subflow->conn, sk);
+ if (sk_stream_memory_free(sk))
+ __mptcp_check_push(subflow->conn, sk);
__mptcp_data_acked(subflow->conn);
mptcp_data_unlock(subflow->conn);
return;
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 97210eaaa89e..670d49825499 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -2919,7 +2919,7 @@ void __mptcp_data_acked(struct sock *sk)
mptcp_schedule_work(sk);
}
-void __mptcp_wnd_updated(struct sock *sk, struct sock *ssk)
+void __mptcp_check_push(struct sock *sk, struct sock *ssk)
{
if (!mptcp_send_head(sk))
return;
diff --git a/net/mptcp/protocol.h b/net/mptcp/protocol.h
index b6feb5340dd0..21474a80efd6 100644
--- a/net/mptcp/protocol.h
+++ b/net/mptcp/protocol.h
@@ -506,7 +506,7 @@ void mptcp_rcv_space_init(struct mptcp_sock *msk, const struct sock *ssk);
void mptcp_data_ready(struct sock *sk, struct sock *ssk);
bool mptcp_finish_join(struct sock *sk);
bool mptcp_schedule_work(struct sock *sk);
-void __mptcp_wnd_updated(struct sock *sk, struct sock *ssk);
+void __mptcp_check_push(struct sock *sk, struct sock *ssk);
void __mptcp_data_acked(struct sock *sk);
void mptcp_subflow_eof(struct sock *sk);
bool mptcp_update_rcv_data_fin(struct mptcp_sock *msk, u64 data_fin_seq, bool use_64bit);
diff --git a/tools/testing/selftests/net/mptcp/simult_flows.sh b/tools/testing/selftests/net/mptcp/simult_flows.sh
index 2f649b431456..f039ee57eb3c 100755
--- a/tools/testing/selftests/net/mptcp/simult_flows.sh
+++ b/tools/testing/selftests/net/mptcp/simult_flows.sh
@@ -287,7 +287,7 @@ run_test 10 10 0 0 "balanced bwidth"
run_test 10 10 1 50 "balanced bwidth with unbalanced delay"
# we still need some additional infrastructure to pass the following test-cases
-# run_test 30 10 0 0 "unbalanced bwidth"
-# run_test 30 10 1 50 "unbalanced bwidth with unbalanced delay"
-# run_test 30 10 50 1 "unbalanced bwidth with opposed, unbalanced delay"
+run_test 30 10 0 0 "unbalanced bwidth"
+run_test 30 10 1 50 "unbalanced bwidth with unbalanced delay"
+run_test 30 10 50 1 "unbalanced bwidth with opposed, unbalanced delay"
exit $ret
--
2.26.2
1 year, 8 months
[PATCH net-next 0/3] mptcp: a bunch of fixes
by Paolo Abeni
This series includes a few fixes following-up the
recent code refactor for the MPTCP RX and TX paths.
Boundling them together, since the fixes are somewhat
related.
Paolo Abeni (3):
mptcp: link MPC subflow into msk only after accept
mptcp: plug subflow context memory leak
mptcp: be careful on subflows shutdown
net/mptcp/options.c | 7 ++++++-
net/mptcp/pm.c | 8 +++++++-
net/mptcp/protocol.c | 23 +++++++++++++++++++++--
net/mptcp/protocol.h | 1 +
net/mptcp/subflow.c | 19 +++++++++++++------
5 files changed, 48 insertions(+), 10 deletions(-)
--
2.26.2
1 year, 8 months