Hi Dan,
On Thu, 31 Dec 2015 19:24:21 -0800 Dan Williams <dan.j.williams(a)intel.com> wrote:
In file included from
/home/sfr/next/next/tools/include/linux/list.h:5:0,
from arch/../util/map.h:6,
from arch/../util/event.h:8,
from arch/../util/debug.h:7,
from arch/common.c:4:
include/linux/list.h: In function 'list_force_poison':
include/linux/list.h:123:56: error: unused parameter 'entry'
[-Werror=unused-parameter]
static inline void list_force_poison(struct list_head *entry)
perf does not like the empty definition of list_force_poison. For
simplicity just switch to list_del in the non-debug case.
Fixes "mm, dax, pmem: introduce {get|put}_dev_pagemap() for dax-gup" in
-next.
Reported-by: Stephen Rothwell <sfr(a)canb.auug.org.au>
Signed-off-by: Dan Williams <dan.j.williams(a)intel.com>
---
include/linux/list.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/linux/list.h b/include/linux/list.h
index d870ba3315f8..ebf5f358e8c3 100644
--- a/include/linux/list.h
+++ b/include/linux/list.h
@@ -120,9 +120,8 @@ extern void list_del(struct list_head *entry);
*/
extern void list_force_poison(struct list_head *entry);
#else
-static inline void list_force_poison(struct list_head *entry)
-{
-}
+/* fallback to the less strict LIST_POISON* definitions */
+#define list_force_poison list_del
#endif
/**
I applied this to linux-next today.
--
Cheers,
Stephen Rothwell sfr(a)canb.auug.org.au