On Thu, May 16, 2019 at 9:05 AM Qian Cai <cai(a)lca.pw> wrote:
Several places (dimm_devs.c, core.c etc) include label.h but only
label.c uses NSINDEX_SIGNATURE, so move its definition to label.c
In file included from drivers/nvdimm/dimm_devs.c:23:
drivers/nvdimm/label.h:41:19: warning: 'NSINDEX_SIGNATURE' defined but
not used [-Wunused-const-variable=]
Also, some places abuse "/**" which is only reserved for the kernel-doc.
drivers/nvdimm/bus.c:648: warning: cannot understand function prototype:
'struct attribute_group nd_device_attribute_group = '
drivers/nvdimm/bus.c:677: warning: cannot understand function prototype:
'struct attribute_group nd_numa_attribute_group = '
Those are just some member assignments for the "struct attribute_group"
instances and it can't be expressed in the kernel-doc.
Ah, good point, I missed that.
Reviewed-by: Vishal Verma <vishal.l.verma(a)intel.com>
Signed-off-by: Qian Cai <cai(a)lca.pw>
Looks good, I'll pull this in for a post -rc1 update.