if region_action failed, return the rc valude instead of 0 Signed-off-by: Yi Zhang <yi.zhang(a)redhat.com&gt; --- ndctl/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ndctl/region.c b/ndctl/region.c index 993b3f8..7945007 100644 --- a/ndctl/region.c +++ b/ndctl/region.c @@ -89,7 +89,7 @@ static int region_action(struct ndctl_region *region, enum device_action mode) break; } - return 0; + return rc; }

> -----Original Message----- > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Dan Williams > Sent: Monday, April 15, 2019 11:29 AM > Subject: Re: [PATCH ndctl] ndctl, region: return the rc value in region_action > > On Mon, Apr 15, 2019 at 1:24 AM Yi Zhang <yi.zhang(a)redhat.com&gt; wrote: >> if region_action failed, return the rc valude instead of 0 valude s/b value

>> Signed-off-by: Yi Zhang <yi.zhang(a)redhat.com&gt; >> --- >> ndctl/region.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/ndctl/region.c b/ndctl/region.c >> index 993b3f8..7945007 100644 >> --- a/ndctl/region.c >> +++ b/ndctl/region.c >> @@ -89,7 +89,7 @@ static int region_action(struct ndctl_region *region, enum device_action mode) >> break; >> } >> >> - return 0; >> + return rc; >> } > Looks good to me: > > Reviewed-by: Dan Williams <dan.j.williams(a)intel.com&gt; Perhaps a similar change should be made to ndctl_namespace_disable_safe(), one of the functions called by region_action() whose rc is propagated, to propagate the rc from ndctl_namespace_disable_invalidate().

_______________________________________________ Linux-nvdimm mailing list Linux-nvdimm(a)lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm