patchwork-bot+linux-nvdimm(a)kernel.org writes: > Hello: > > This patch was applied to nvdimm/nvdimm.git (refs/heads/libnvdimm-for-next). > > On Wed, 7 Aug 2019 09:30:29 +0530 you wrote: >> ndctl utility requires the ndbus to have unique names. If not while >> enumerating the bus in userspace it drops bus with similar names. >> This results in us not listing devices beneath the bus. >> >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com&gt; >> --- >> drivers/nvdimm/of_pmem.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > Here is a summary with links: > - nvdimm/of_pmem: Provide a unique name for bus provider > https://git.kernel.org/nvdimm/nvdimm/c/49bddc73d15c25a68e4294d76fc74519fd... > > You are awesome, thank you! We decided to fix this in ndctl tool? If we go with ndctl fix, we can drop the kernel change.

Parallely I am planning to do a fix for papr_scm driver that will update the provider name as "papr_scm". That way we can find out the backend driver using :~> ndctl list -B [ { "provider":"papr_scm", "dev":"ndbus1" }, { "provider":"of_pmem", "dev":"ndbus0" } ] -aneesh

On 8/30/19 10:10 AM, Dan Williams wrote: > On Thu, Aug 29, 2019 at 9:31 PM Aneesh Kumar K.V > <aneesh.kumar(a)linux.ibm.com&gt; wrote: >> >> patchwork-bot+linux-nvdimm(a)kernel.org writes: >> >>> Hello: >>> >>> This patch was applied to nvdimm/nvdimm.git (refs/heads/libnvdimm-for-next). >>> >>> On Wed, 7 Aug 2019 09:30:29 +0530 you wrote: >>>> ndctl utility requires the ndbus to have unique names. If not while >>>> enumerating the bus in userspace it drops bus with similar names. >>>> This results in us not listing devices beneath the bus. >>>> >>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar(a)linux.ibm.com&gt; >>>> --- >>>> drivers/nvdimm/of_pmem.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> >>> Here is a summary with links: >>> - nvdimm/of_pmem: Provide a unique name for bus provider >>> https://git.kernel.org/nvdimm/nvdimm/c/49bddc73d15c25a68e4294d76fc74519fd... >>> >>> You are awesome, thank you! >> >> We decided to fix this in ndctl tool? If we go with ndctl fix, we >> can drop the kernel change. > > Oh, I was planning to do both any concerns if I keep the kernel > change, otherwise I'll need to rebase the branch. > I guess rebasing is not going to be nice. So we can keep the patch and if we are really need to move the provider name to indicate backend driver, I will fixup both of_pmem and papr_scm together.