On Tue, Sep 03, 2019 at 08:26:18AM +1000, Dave Chinner wrote:
On Wed, Aug 28, 2019 at 07:02:31PM -0700, Ira Weiny wrote:
> On Mon, Aug 26, 2019 at 03:55:10PM +1000, Dave Chinner wrote:
> > On Fri, Aug 23, 2019 at 10:08:36PM -0700, Ira Weiny wrote:
> > > On Sat, Aug 24, 2019 at 10:11:24AM +1000, Dave Chinner wrote:
> > > > On Fri, Aug 23, 2019 at 09:04:29AM -0300, Jason Gunthorpe wrote:
> > > "Leases are associated with an open file description (see open(2)).
> > > that duplicate file descriptors (created by, for example, fork(2) or
> > > refer to the same lease, and this lease may be modified or released using
> > > of these descriptors. Furthermore, the lease is released by either an
> > > explicit F_UNLCK operation on any of these duplicate file descriptors, or
> > > all such file descriptors have been closed."
> > Right, the lease is attached to the struct file, so it follows
> > where-ever the struct file goes. That doesn't mean it's actually
> > useful when the struct file is duplicated and/or passed to another
> > process. :/
> > AFAICT, the problem is that when we take another reference to the
> > struct file, or when the struct file is passed to a different
> > process, nothing updates the lease or lease state attached to that
> > struct file.
> Ok, I probably should have made this more clear in the cover letter but _only_
> the process which took the lease can actually pin memory.
Sure, no question about that.
> That pinned memory _can_ be passed to another process but those sub-process'
> _not_ use the original lease to pin _more_ of the file. They would need to
> take their own lease to do that.
Yes, they would need a new lease to extend it. But that ignores the
fact they don't have a lease on the existing pins they are using and
have no control over the lease those pins originated under. e.g.
the originating process dies (for whatever reason) and now we have
pins without a valid lease holder.
Define "valid lease holder"?
If something else now takes an exclusive lease on the file (because
the original exclusive lease no longer exists), it's not going to
work correctly because of the zombied page pins caused by closing
the exclusive lease they were gained under. IOWs, pages pinned under
an exclusive lease are no longer "exclusive" the moment the original
exclusive lease is dropped, and pins passed to another process are
no longer covered by the original lease they were created under.
The page pins are not zombied the lease is. The lease still exists, it can't
be dropped while the pins are in place. I need to double check the
implementation but that was the intent.
Yep just did a quick check, I have a test for that. If the page pins exist
then the lease can _not_ be released. Closing the FD will "zombie" the lease
but it and the struct file will still exist until the pins go away.
Furthermore, a "zombie" lease is _not_ sufficient to pin more pages. (I have a
test for this too.) I apologize that I don't have something to submit to
xfstests. I'm new to that code base.
I'm happy to share the code I have which I've been using to test... But it is
pretty rough as it has undergone a number of changes. I think it would be
better to convert my test series to xfstests.
However, I don't know if it is ok to require RDMA within those tests. Right
now that is the only sub-system I have allowed to create these page pins. So
I'm not sure what to do at this time. I'm open to suggestions.
> Sorry for not being clear on that.
I know exactly what you are saying. What I'm failing to get across
is that file layout leases don't actually allow the behaviour you
want to have.
Not currently, no. But we are discussing the semantics to allow them _to_ have
the behavior needed.
> > As such, leases that require callbacks to userspace are currently
> > only valid within the process context the lease was taken in.
> But for long term pins we are not requiring callbacks.
Regardless, we still require an active lease for long term pins so
that other lease holders fail operations appropriately. And that
exclusive lease must follow the process that pins the pages so that
the life cycle is the same...
I disagree. See below.
> > Indeed, even closing the fd the lease was taken on without
> > F_UNLCKing it first doesn't mean the lease has been torn down if
> > there is some other reference to the struct file. That means the
> > original lease owner will still get SIGIO delivered to that fd on a
> > lease break regardless of whether it is open or not. ANd if we
> > implement "layout lease not released within SIGIO response timeout"
> > then that process will get killed, despite the fact it may not even
> > have a reference to that file anymore.
> I'm not seeing that as a problem. This is all a result of the application
> failing to do the right thing.
How is that not a problem?
The application has taken an exclusive lease and they don't have to let it go.
IOW, there is little difference between the application closing the FD and
creating a zombie lease vs keeping the FD open with a real lease. Because no
SIGIO is sent and there is no need to react to it anyway as the intention is to
keep the lease active and the layout pinned "indefinitely".
Furthermore, in both cases the admin must kill the application to change the
layout forcibly. Basically applications don't _have_ to do the right thing but
the kernel and the filesystem is still protected while the admin has a way to
correct the situation given a bad application.
Therefore, from the POV of the kernel and file system I don't see a problem.