Some quick feedback on your intro concerns...
On Thu, Nov 14, 2019 at 5:41 AM Frederic Barrat <fbarrat(a)linux.ibm.com> wrote:
The patch is huge and could/should probably be split in smaller pieces
Yeah, it's a must. Split the minimum viable infrastructure by topic
and then follow on with per-feature topic patches.
to ease the review. However, having sinned on that same topic in the
past, I made a first pass anyway. I haven't covered everything but tried
to focus on the general setup of the driver for now.
Since the patch is very long, I'm writing all the comments in one chunk
here instead of spreading them over a few thousand lines, where some
would be easy to miss.
Update MAINTAINERS for the new files
Have you discussed with the directory owner if it's ok to split the
driver over several files?
My thought is to establish drivers/opencapi/ and move this and the
existing drivers/misc/ocxl/ bits there.