Re: [PATCH] dax, pmem: add support for msync
On Mon, Aug 31, 2015 at 12:59:44PM -0600, Ross Zwisler wrote:
For DAX msync we just need to flush the given range using
wb_cache_pmem(), which is now a public part of the PMEM API.
The inclusion of <linux/dax.h> in fs/dax.c was done to make checkpatch
happy. Previously it was complaining about a bunch of undeclared
functions that could be made static.
Should this be abstracted by adding a ->msync method? Maybe not
worth to do for now, but it might be worth to keep that in mind.
Otherwise this looks fine to me.