Re: [PATCH v6 0/4] ndctl: convert actions to use util_filter_walk
On Fri, May 11, 2018 at 01:24:36PM -0700, Dave Jiang wrote:
util_filter_walk() does the looping through
bus/dimm/region/namespace
that a lot of the operations in ndctl uses. Converting them to common
code and reduce maintenance on individual versions of the same code.
In this series we are convering namespace, region, and dimm actions.
<>
ndctl/dimm.c | 78 +++++++++++++---------
ndctl/namespace.c | 189 +++++++++++++++++++++++++++++------------------------
ndctl/region.c | 54 +++++++++------
util/filter.c | 11 +++
util/filter.h | 25 +++++++
5 files changed, 212 insertions(+), 145 deletions(-)
Just from the cover letter I'm sort of confused - the paragraph above says we
are converging on common code and removing individual versions of the same
code...but the patch series grows this code by 70 lines? I would have
expected this to be a net code reduction?