On 21-02-04 07:16:46, Christoph Hellwig wrote:
On Wed, Feb 03, 2021 at 01:23:31PM -0800, Dan Williams wrote:
> > I'd prefer to keep the helpers for now as I do find them helpful, and so
> > nobody else who has touched the code has complained. If you feel strongly, I
> > will change it.
> After seeing the options, I think I'd prefer to not have to worry what
> extra magic is happening with cxl_read_mbox_reg32()
> cxl_read_mbox_reg32(cxlm, CXLDEV_MB_CAPS_OFFSET);
> readl(cxlm->mbox_regs + CXLDEV_MB_CAPS_OFFSET);
> The latter is both shorter and more idiomatic.
Same here. That being said I know some driver maintainers like
wrappers, my real main irk was the macro magic to generate them.
I think the wrapper is often used as a means of trying to have cross OS
compatibility to some degree. Just to be clear, that was *not* the purpose here.
Stating I disagree for posterity, I'll begin reworking this code and it will be
changed for v2.