CC: kbuild-all(a)lists.01.org
TO: Andrii Nakryiko <andriin(a)fb.com>
CC: Daniel Borkmann <daniel(a)iogearbox.net>
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: aab2003999e78bbf2058dae1e661c44ede1d9766
commit: 517bbe1994a3cee29a35c730662277bb5daff582 [4349/4685] bpf: Enforce BPF ringbuf size
to be the power of 2
:::::: branch date: 11 hours ago
:::::: commit date: 26 hours ago
config: i386-randconfig-m021-20200701 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
kernel/bpf/ringbuf.c:185 ringbuf_map_alloc() warn: passing a valid pointer to
'PTR_ERR'
#
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git remote update linux-next
git checkout 517bbe1994a3cee29a35c730662277bb5daff582
vim +/PTR_ERR +185 kernel/bpf/ringbuf.c
517bbe1994a3ce Andrii Nakryiko 2020-06-29 169
457f44363a8894 Andrii Nakryiko 2020-05-29 170 rb_map = kzalloc(sizeof(*rb_map),
GFP_USER);
457f44363a8894 Andrii Nakryiko 2020-05-29 171 if (!rb_map)
457f44363a8894 Andrii Nakryiko 2020-05-29 172 return ERR_PTR(-ENOMEM);
457f44363a8894 Andrii Nakryiko 2020-05-29 173
457f44363a8894 Andrii Nakryiko 2020-05-29 174
bpf_map_init_from_attr(&rb_map->map, attr);
457f44363a8894 Andrii Nakryiko 2020-05-29 175
457f44363a8894 Andrii Nakryiko 2020-05-29 176 cost = sizeof(struct bpf_ringbuf_map) +
457f44363a8894 Andrii Nakryiko 2020-05-29 177 sizeof(struct bpf_ringbuf) +
457f44363a8894 Andrii Nakryiko 2020-05-29 178 attr->max_entries;
457f44363a8894 Andrii Nakryiko 2020-05-29 179 err =
bpf_map_charge_init(&rb_map->map.memory, cost);
457f44363a8894 Andrii Nakryiko 2020-05-29 180 if (err)
457f44363a8894 Andrii Nakryiko 2020-05-29 181 goto err_free_map;
457f44363a8894 Andrii Nakryiko 2020-05-29 182
457f44363a8894 Andrii Nakryiko 2020-05-29 183 rb_map->rb =
bpf_ringbuf_alloc(attr->max_entries, rb_map->map.numa_node);
457f44363a8894 Andrii Nakryiko 2020-05-29 184 if (IS_ERR(rb_map->rb)) {
457f44363a8894 Andrii Nakryiko 2020-05-29 @185 err = PTR_ERR(rb_map->rb);
457f44363a8894 Andrii Nakryiko 2020-05-29 186 goto err_uncharge;
457f44363a8894 Andrii Nakryiko 2020-05-29 187 }
457f44363a8894 Andrii Nakryiko 2020-05-29 188
457f44363a8894 Andrii Nakryiko 2020-05-29 189 return &rb_map->map;
457f44363a8894 Andrii Nakryiko 2020-05-29 190
457f44363a8894 Andrii Nakryiko 2020-05-29 191 err_uncharge:
457f44363a8894 Andrii Nakryiko 2020-05-29 192
bpf_map_charge_finish(&rb_map->map.memory);
457f44363a8894 Andrii Nakryiko 2020-05-29 193 err_free_map:
457f44363a8894 Andrii Nakryiko 2020-05-29 194 kfree(rb_map);
457f44363a8894 Andrii Nakryiko 2020-05-29 195 return ERR_PTR(err);
457f44363a8894 Andrii Nakryiko 2020-05-29 196 }
457f44363a8894 Andrii Nakryiko 2020-05-29 197
:::::: The code at line 185 was first introduced by commit
:::::: 457f44363a8894135c85b7a9afd2bd8196db24ab bpf: Implement BPF ring buffer and
verifier support for it
:::::: TO: Andrii Nakryiko <andriin(a)fb.com>
:::::: CC: Alexei Starovoitov <ast(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org