CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Vladimir Oltean <vladimir.oltean(a)nxp.com&gt; CC: Florian Fainelli <f.fainelli(a)gmail.com&gt; tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4d41ead6ead97c3730bbd186a601a64828668f01 commit: ec5ae61076d07be986df19773662506220757c9f net: dsa: sja1105: save/restore VLANs using a delta commit method date: 4 months ago :::::: branch date: 10 hours ago :::::: commit date: 4 months ago config: arm-randconfig-m031-20200829 (attached as .config) compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <lkp(a)intel.com&gt; Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com&gt; New smatch warnings: drivers/net/dsa/sja1105/sja1105_main.c:1958 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1980 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? Old smatch warnings: drivers/net/dsa/sja1105/sja1105_main.c:46 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:47 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:48 sja1105_port_allow_traffic() warn: should '(((1))) << to' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:188 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1 drivers/net/dsa/sja1105/sja1105_main.c:191 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1 drivers/net/dsa/sja1105/sja1105_main.c:197 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1 drivers/net/dsa/sja1105/sja1105_main.c:202 sja1105_init_mii_settings() warn: is 'table->entries' large enough for 'struct sja1105_xmii_params_entry'? 1 drivers/net/dsa/sja1105/sja1105_main.c:527 sja1105_init_avb_params() warn: is 'table->entries' large enough for 'struct sja1105_avb_params_entry'? 1 drivers/net/dsa/sja1105/sja1105_main.c:1119 sja1105_find_static_fdb_entry() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1237 sja1105et_fdb_add() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1239 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1247 sja1105et_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1333 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1341 sja1105pqrs_fdb_add() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1346 sja1105pqrs_fdb_add() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1396 sja1105pqrs_fdb_del() warn: should '(((1))) << port' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1480 sja1105_fdb_dump() warn: should '((((1))) << port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1716 sja1105_static_config_reload() warn: bitwise AND condition is false here drivers/net/dsa/sja1105/sja1105_main.c:1959 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1961 sja1105_build_bridge_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1981 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:1983 sja1105_build_dsa_8021q_vlans() warn: should '(((1))) << (v->port)' be a 64 bit type? drivers/net/dsa/sja1105/sja1105_main.c:2431 sja1105_mgmt_xmit() warn: should '(((1))) << port' be a 64 bit type? # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit... git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git git fetch --no-tags linus master git checkout ec5ae61076d07be986df19773662506220757c9f vim +1958 drivers/net/dsa/sja1105/sja1105_main.c ec5ae61076d07b Vladimir Oltean 2020-05-12 1944 ec5ae61076d07b Vladimir Oltean 2020-05-12 1945 static int ec5ae61076d07b Vladimir Oltean 2020-05-12 1946 sja1105_build_bridge_vlans(struct sja1105_private *priv, ec5ae61076d07b Vladimir Oltean 2020-05-12 1947 struct sja1105_vlan_lookup_entry *new_vlan) ec5ae61076d07b Vladimir Oltean 2020-05-12 1948 { ec5ae61076d07b Vladimir Oltean 2020-05-12 1949 struct sja1105_bridge_vlan *v; ec5ae61076d07b Vladimir Oltean 2020-05-12 1950 ec5ae61076d07b Vladimir Oltean 2020-05-12 1951 if (priv->vlan_state == SJA1105_VLAN_UNAWARE) ec5ae61076d07b Vladimir Oltean 2020-05-12 1952 return 0; ec5ae61076d07b Vladimir Oltean 2020-05-12 1953 ec5ae61076d07b Vladimir Oltean 2020-05-12 1954 list_for_each_entry(v, &priv->bridge_vlans, list) { ec5ae61076d07b Vladimir Oltean 2020-05-12 1955 int match = v->vid; ec5ae61076d07b Vladimir Oltean 2020-05-12 1956 ec5ae61076d07b Vladimir Oltean 2020-05-12 1957 new_vlan[match].vlanid = v->vid; ec5ae61076d07b Vladimir Oltean 2020-05-12 @1958 new_vlan[match].vmemb_port |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1959 new_vlan[match].vlan_bc |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1960 if (!v->untagged) ec5ae61076d07b Vladimir Oltean 2020-05-12 1961 new_vlan[match].tag_port |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1962 } ec5ae61076d07b Vladimir Oltean 2020-05-12 1963 ec5ae61076d07b Vladimir Oltean 2020-05-12 1964 return 0; ec5ae61076d07b Vladimir Oltean 2020-05-12 1965 } ec5ae61076d07b Vladimir Oltean 2020-05-12 1966 ec5ae61076d07b Vladimir Oltean 2020-05-12 1967 static int ec5ae61076d07b Vladimir Oltean 2020-05-12 1968 sja1105_build_dsa_8021q_vlans(struct sja1105_private *priv, ec5ae61076d07b Vladimir Oltean 2020-05-12 1969 struct sja1105_vlan_lookup_entry *new_vlan) ec5ae61076d07b Vladimir Oltean 2020-05-12 1970 { ec5ae61076d07b Vladimir Oltean 2020-05-12 1971 struct sja1105_bridge_vlan *v; ec5ae61076d07b Vladimir Oltean 2020-05-12 1972 ec5ae61076d07b Vladimir Oltean 2020-05-12 1973 if (priv->vlan_state == SJA1105_VLAN_FILTERING_FULL) ec5ae61076d07b Vladimir Oltean 2020-05-12 1974 return 0; ec5ae61076d07b Vladimir Oltean 2020-05-12 1975 ec5ae61076d07b Vladimir Oltean 2020-05-12 1976 list_for_each_entry(v, &priv->dsa_8021q_vlans, list) { ec5ae61076d07b Vladimir Oltean 2020-05-12 1977 int match = v->vid; ec5ae61076d07b Vladimir Oltean 2020-05-12 1978 ec5ae61076d07b Vladimir Oltean 2020-05-12 1979 new_vlan[match].vlanid = v->vid; ec5ae61076d07b Vladimir Oltean 2020-05-12 @1980 new_vlan[match].vmemb_port |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1981 new_vlan[match].vlan_bc |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1982 if (!v->untagged) ec5ae61076d07b Vladimir Oltean 2020-05-12 1983 new_vlan[match].tag_port |= BIT(v->port); ec5ae61076d07b Vladimir Oltean 2020-05-12 1984 } ec5ae61076d07b Vladimir Oltean 2020-05-12 1985 ec5ae61076d07b Vladimir Oltean 2020-05-12 1986 return 0; ec5ae61076d07b Vladimir Oltean 2020-05-12 1987 } ec5ae61076d07b Vladimir Oltean 2020-05-12 1988 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org