sound/soc/stm/stm32_i2s.c:434:2: warning: Call to function 'strcat' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcat'. CWE-119 [clang...

Thursday, 30 September 2021


CC: llvm(a)lists.linux.dev
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Olivier Moysan <olivier.moysan(a)st.com&gt;
CC: Mark Brown <broonie(a)kernel.org&gt;

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   02d5e016800d082058b3d3b7c3ede136cdc6ddcb
commit: 8a262e614ef8675cfde924c6ddf873a95db0be6a ASoC: stm32: i2s: add master clock
provider
date:   8 months ago
:::::: branch date: 14 hours ago
:::::: commit date: 8 months ago
config: arm-randconfig-c002-20210929 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project
dc6e8dfdfe7efecfda318d43a06fae18b40eb498)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm cross compiling tool for clang build
        # apt-get install binutils-arm-linux-gnueabi
        #
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
        git remote add linus
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 8a262e614ef8675cfde924c6ddf873a95db0be6a
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm clang-analyzer


If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com&gt;


clang-analyzer warnings: (new ones prefixed by >>)
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:550:2: warning: Value stored to 'priv'
is never read [clang-analyzer-deadcode.DeadStores]
           priv = dev->dev_private;
           ^      ~~~~~~~~~~~~~~~~
   drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c:550:2: note: Value stored to 'priv' is
never read
           priv = dev->dev_private;
           ^      ~~~~~~~~~~~~~~~~
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   1 warning generated.
   Suppressed 1 warnings (1 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   1 warning generated.
   Suppressed 1 warnings (1 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   1 warning generated.
   Suppressed 1 warnings (1 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   drivers/mtd/nand/raw/r852.c:593:2: warning: Call to function 'strcpy' is
insecure as it does not provide bounding of the memory buffer. Replace unbounded copy
functions with analogous functions that support length arguments such as
'strlcpy'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]
           strcpy(buf, data);
           ^~~~~~
   drivers/mtd/nand/raw/r852.c:593:2: note: Call to function 'strcpy' is insecure
as it does not provide bounding of the memory buffer. Replace unbounded copy functions
with analogous functions that support length arguments such as 'strlcpy'. CWE-119
           strcpy(buf, data);
           ^~~~~~
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   sound/soc/kirkwood/kirkwood-i2s.c:322:2: warning: Value stored to 'value' is
never read [clang-analyzer-deadcode.DeadStores]
           value = readl(priv->io + KIRKWOOD_RECCTL);
           ^
   sound/soc/kirkwood/kirkwood-i2s.c:322:2: note: Value stored to 'value' is never
read
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   18 warnings generated.
...
> sound/soc/stm/stm32_i2s.c:434:2: warning: Call to function
'strcat' is insecure as it does not provide bounding of the memory buffer. Replace
unbounded copy functions with analogous functions that support length arguments such as
'strlcat'. CWE-119 [clang-analyzer-security.insecureAPI.strcpy]           
strcat(p, "_mclk");
           ^~~~~~
   sound/soc/stm/stm32_i2s.c:434:2: note: Call to function 'strcat' is insecure as
it does not provide bounding of the memory buffer. Replace unbounded copy functions with
analogous functions that support length arguments such as 'strlcat'. CWE-119
           strcat(p, "_mclk");
           ^~~~~~
   sound/soc/stm/stm32_i2s.c:455:26: warning: Value stored to 'pdev' during its
initialization is never read [clang-analyzer-deadcode.DeadStores]
           struct platform_device *pdev = i2s->pdev;
                                   ^~~~   ~~~~~~~~~
   sound/soc/stm/stm32_i2s.c:455:26: note: Value stored to 'pdev' during its
initialization is never read
           struct platform_device *pdev = i2s->pdev;
                                   ^~~~   ~~~~~~~~~
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   sound/soc/codecs/rt700.c:127:3: warning: Value stored to 'ret' is never read
[clang-analyzer-deadcode.DeadStores]
                   ret = regmap_read(rt700->regmap, reg, &jack_status);
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/rt700.c:127:3: note: Value stored to 'ret' is never read
                   ret = regmap_read(rt700->regmap, reg, &jack_status);
                   ^     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   sound/soc/codecs/rt711.c:95:2: warning: Value stored to 'dev' is never read
[clang-analyzer-deadcode.DeadStores]
           dev = regmap_get_device(regmap);
           ^     ~~~~~~~~~~~~~~~~~~~~~~~~~
   sound/soc/codecs/rt711.c:95:2: note: Value stored to 'dev' is never read
           dev = regmap_get_device(regmap);
           ^     ~~~~~~~~~~~~~~~~~~~~~~~~~
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (17 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   1 warning generated.
   Suppressed 1 warnings (1 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   drivers/media/platform/davinci/vpbe.c:631:4: warning: Value stored to 'err' is
never read [clang-analyzer-deadcode.DeadStores]
                           err = -ENOMEM;
                           ^     ~~~~~~~
   drivers/media/platform/davinci/vpbe.c:631:4: note: Value stored to 'err' is
never read
                           err = -ENOMEM;
                           ^     ~~~~~~~
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   17 warnings generated.
   Suppressed 17 warnings (16 in non-user code, 1 with check filters).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.
   16 warnings generated.
   Suppressed 16 warnings (16 in non-user code).
   Use -header-filter=.* to display errors from all non-system headers. Use
-system-headers to display errors from system headers as well.

vim +434 sound/soc/stm/stm32_i2s.c

8a262e614ef8675 Olivier Moysan 2021-02-05  406  
8a262e614ef8675 Olivier Moysan 2021-02-05  407  static int
stm32_i2s_add_mclk_provider(struct stm32_i2s_data *i2s)
8a262e614ef8675 Olivier Moysan 2021-02-05  408  {
8a262e614ef8675 Olivier Moysan 2021-02-05  409  	struct clk_hw *hw;
8a262e614ef8675 Olivier Moysan 2021-02-05  410  	struct stm32_i2smclk_data *mclk;
8a262e614ef8675 Olivier Moysan 2021-02-05  411  	struct device *dev =
&i2s->pdev->dev;
8a262e614ef8675 Olivier Moysan 2021-02-05  412  	const char *pname =
__clk_get_name(i2s->i2sclk);
8a262e614ef8675 Olivier Moysan 2021-02-05  413  	char *mclk_name, *p, *s = (char *)pname;
8a262e614ef8675 Olivier Moysan 2021-02-05  414  	int ret, i = 0;
8a262e614ef8675 Olivier Moysan 2021-02-05  415  
8a262e614ef8675 Olivier Moysan 2021-02-05  416  	mclk = devm_kzalloc(dev, sizeof(*mclk),
GFP_KERNEL);
8a262e614ef8675 Olivier Moysan 2021-02-05  417  	if (!mclk)
8a262e614ef8675 Olivier Moysan 2021-02-05  418  		return -ENOMEM;
8a262e614ef8675 Olivier Moysan 2021-02-05  419  
8a262e614ef8675 Olivier Moysan 2021-02-05  420  	mclk_name = devm_kcalloc(dev,
sizeof(char),
8a262e614ef8675 Olivier Moysan 2021-02-05  421  				 STM32_I2S_NAME_LEN, GFP_KERNEL);
8a262e614ef8675 Olivier Moysan 2021-02-05  422  	if (!mclk_name)
8a262e614ef8675 Olivier Moysan 2021-02-05  423  		return -ENOMEM;
8a262e614ef8675 Olivier Moysan 2021-02-05  424  
8a262e614ef8675 Olivier Moysan 2021-02-05  425  	/*
8a262e614ef8675 Olivier Moysan 2021-02-05  426  	 * Forge mclk clock name from parent
clock name and suffix.
8a262e614ef8675 Olivier Moysan 2021-02-05  427  	 * String after "_" char is
stripped in parent name.
8a262e614ef8675 Olivier Moysan 2021-02-05  428  	 */
8a262e614ef8675 Olivier Moysan 2021-02-05  429  	p = mclk_name;
8a262e614ef8675 Olivier Moysan 2021-02-05  430  	while (*s && *s != '_'
&& (i < (STM32_I2S_NAME_LEN - 7))) {
8a262e614ef8675 Olivier Moysan 2021-02-05  431  		*p++ = *s++;
8a262e614ef8675 Olivier Moysan 2021-02-05  432  		i++;
8a262e614ef8675 Olivier Moysan 2021-02-05  433  	}
8a262e614ef8675 Olivier Moysan 2021-02-05 @434  	strcat(p, "_mclk");
8a262e614ef8675 Olivier Moysan 2021-02-05  435  
8a262e614ef8675 Olivier Moysan 2021-02-05  436  	mclk->hw.init = CLK_HW_INIT(mclk_name,
pname, &mclk_ops, 0);
8a262e614ef8675 Olivier Moysan 2021-02-05  437  	mclk->i2s_data = i2s;
8a262e614ef8675 Olivier Moysan 2021-02-05  438  	hw = &mclk->hw;
8a262e614ef8675 Olivier Moysan 2021-02-05  439  
8a262e614ef8675 Olivier Moysan 2021-02-05  440  	dev_dbg(dev, "Register master clock
%s\n", mclk_name);
8a262e614ef8675 Olivier Moysan 2021-02-05  441  	ret =
devm_clk_hw_register(&i2s->pdev->dev, hw);
8a262e614ef8675 Olivier Moysan 2021-02-05  442  	if (ret) {
8a262e614ef8675 Olivier Moysan 2021-02-05  443  		dev_err(dev, "mclk register fails
with error %d\n", ret);
8a262e614ef8675 Olivier Moysan 2021-02-05  444  		return ret;
8a262e614ef8675 Olivier Moysan 2021-02-05  445  	}
8a262e614ef8675 Olivier Moysan 2021-02-05  446  	i2s->i2smclk = hw->clk;
8a262e614ef8675 Olivier Moysan 2021-02-05  447  
8a262e614ef8675 Olivier Moysan 2021-02-05  448  	/* register mclk provider */
8a262e614ef8675 Olivier Moysan 2021-02-05  449  	return devm_of_clk_add_hw_provider(dev,
of_clk_hw_simple_get, hw);
8a262e614ef8675 Olivier Moysan 2021-02-05  450  }
8a262e614ef8675 Olivier Moysan 2021-02-05  451  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

2022

2021

2020

2019