CC: kbuild-all(a)lists.01.org
TO: Robin Gong <yibin.gong(a)nxp.com>
CC: Mark Brown <broonie(a)kernel.org>
CC: Frieder Schrempf <frieder.schrempf(a)kontron.de>
CC: Liam Girdwood <lgirdwood(a)gmail.com>
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp(a)intel.com>
drivers/regulator/pca9450-regulator.c:779:7-32: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests")
threaded IRQs without a primary handler need to be requested with
IRQF_ONESHOT, otherwise the request will fail.
So pass the IRQF_ONESHOT flag in this case.
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Fixes: 0935ff5f1f0a ("regulator: pca9450: add pca9450 pmic driver")
CC: Robin Gong <yibin.gong(a)nxp.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 4f5baedd579d5499876eadb1de12ddfdadcaa3ab
commit: 0935ff5f1f0a44f66a13e075ed49f97ad99d2fdc [5037/10784] regulator: pca9450: add
pca9450 pmic driver
:::::: branch date: 20 hours ago
:::::: commit date: 3 weeks ago
Please take the patch only if it's a positive warning. Thanks!
pca9450-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/regulator/pca9450-regulator.c
+++ b/drivers/regulator/pca9450-regulator.c
@@ -778,7 +778,7 @@ static int pca9450_i2c_probe(struct i2c_
ret = devm_request_threaded_irq(pca9450->dev, pca9450->irq, NULL,
pca9450_irq_handler,
- (IRQF_TRIGGER_FALLING | IRQF_ONESHOT),
+ (IRQF_TRIGGER_FALLING | IRQF_ONESHOT) | IRQF_ONESHOT,
"pca9450-irq", pca9450);
if (ret != 0) {
dev_err(pca9450->dev, "Failed to request IRQ: %d\n",