[linux-next:master 8121/11990] drivers/dma/xilinx/xilinx_dpdma.c:1412:2-9: line 1412 is redundant because platform_get_irq() already prints an error
4:57 p.m.
CC: kbuild-all(a)lists.01.org
TO: Hyun Kwon <hyun.kwon(a)xilinx.com>
CC: Vinod Koul <vkoul(a)kernel.org>
CC: Tejas Upadhyay <tejasu(a)xilinx.com>
CC: Michal Simek <monstr(a)monstr.eu>
CC: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e9a523ff8f76de0768857f02ea76437d3b39d151
commit: 7cbb0c63de3fc218fd06ecfedb477772a4d12f76 [8121/11990] dmaengine: xilinx: dpdma:
Add the Xilinx DisplayPort DMA engine driver
:::::: branch date: 2 hours ago
:::::: commit date: 10 days ago
config: arc-randconfig-c003-20200727 (attached as .config)
compiler: arc-elf-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
> drivers/dma/xilinx/xilinx_dpdma.c:1412:2-9: line 1412 is
redundant because platform_get_irq() already prints an error
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4:57 p.m.
New subject: [PATCH] dmaengine: xilinx: dpdma: fix platform_get_irq.cocci warnings
CC: kbuild-all(a)lists.01.org
TO: Hyun Kwon <hyun.kwon(a)xilinx.com>
CC: Vinod Koul <vkoul(a)kernel.org>
CC: Tejas Upadhyay <tejasu(a)xilinx.com>
CC: Michal Simek <monstr(a)monstr.eu>
CC: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com>
CC: Dan Williams <dan.j.williams(a)intel.com>
CC: dmaengine(a)vger.kernel.org
CC: linux-arm-kernel(a)lists.infradead.org
CC: linux-kernel(a)vger.kernel.org
From: kernel test robot <lkp(a)intel.com>
drivers/dma/xilinx/xilinx_dpdma.c:1412:2-9: line 1412 is redundant because
platform_get_irq() already prints an error
Remove dev_err() messages after platform_get_irq*() failures
Generated by: scripts/coccinelle/api/platform_get_irq.cocci
Fixes: 7cbb0c63de3f ("dmaengine: xilinx: dpdma: Add the Xilinx DisplayPort DMA engine
driver")
CC: Hyun Kwon <hyun.kwon(a)xilinx.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
---
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: e9a523ff8f76de0768857f02ea76437d3b39d151
commit: 7cbb0c63de3fc218fd06ecfedb477772a4d12f76 [8121/11990] dmaengine: xilinx: dpdma:
Add the Xilinx DisplayPort DMA engine driver
:::::: branch date: 2 hours ago
:::::: commit date: 10 days ago
Please take the patch only if it's a positive warning. Thanks!
xilinx_dpdma.c | 1 -
1 file changed, 1 deletion(-)
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1409,7 +1409,6 @@ static int xilinx_dpdma_probe(struct pla
xdev->irq = platform_get_irq(pdev, 0);
if (xdev->irq < 0) {
- dev_err(xdev->dev, "failed to get platform irq\n");
return xdev->irq;
}
663
days inactive
663
days old
1 comments
1 participants
participants (1)
-
kernel test robot