Re: [PATCH 4/4] drm/crtc: add drmm_crtc_alloc_with_planes()
by Dan Carpenter
Hi Philipp,
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/drm-add-drmm_encod...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-m001-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/gpu/drm/drm_crtc.c:343 drm_crtc_init_with_planes() error: uninitialized symbol 'ap'.
drivers/gpu/drm/drm_crtc.c:383 __drmm_crtc_alloc_with_planes() error: uninitialized symbol 'ap'.
# https://github.com/0day-ci/linux/commit/236b7bc44ae0fdecc8e80c5aba0655ca1...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Philipp-Zabel/drm-add-drmm_encoder_alloc/20200826-203629
git checkout 236b7bc44ae0fdecc8e80c5aba0655ca14fdfb23
vim +/ap +343 drivers/gpu/drm/drm_crtc.c
236b7bc44ae0fd Philipp Zabel 2020-08-26 331 int drm_crtc_init_with_planes(struct drm_device *dev, struct drm_crtc *crtc,
236b7bc44ae0fd Philipp Zabel 2020-08-26 332 struct drm_plane *primary,
236b7bc44ae0fd Philipp Zabel 2020-08-26 333 struct drm_plane *cursor,
236b7bc44ae0fd Philipp Zabel 2020-08-26 334 const struct drm_crtc_funcs *funcs,
236b7bc44ae0fd Philipp Zabel 2020-08-26 335 const char *name, ...)
236b7bc44ae0fd Philipp Zabel 2020-08-26 336 {
236b7bc44ae0fd Philipp Zabel 2020-08-26 337 va_list ap;
236b7bc44ae0fd Philipp Zabel 2020-08-26 338 int ret;
236b7bc44ae0fd Philipp Zabel 2020-08-26 339
236b7bc44ae0fd Philipp Zabel 2020-08-26 340 if (name)
236b7bc44ae0fd Philipp Zabel 2020-08-26 341 va_start(ap, name);
236b7bc44ae0fd Philipp Zabel 2020-08-26 342 ret = drm_crtc_init_with_planes(dev, crtc, primary, cursor, funcs,
236b7bc44ae0fd Philipp Zabel 2020-08-26 @343 name, ap);
^^
236b7bc44ae0fd Philipp Zabel 2020-08-26 344 if (name)
236b7bc44ae0fd Philipp Zabel 2020-08-26 345 va_end(ap);
236b7bc44ae0fd Philipp Zabel 2020-08-26 346
236b7bc44ae0fd Philipp Zabel 2020-08-26 347 return ret;
236b7bc44ae0fd Philipp Zabel 2020-08-26 348 }
e13161af80c185 Matt Roper 2014-04-01 349 EXPORT_SYMBOL(drm_crtc_init_with_planes);
f453ba0460742a Dave Airlie 2008-11-07 350
236b7bc44ae0fd Philipp Zabel 2020-08-26 351 static void drmm_crtc_alloc_with_planes_cleanup(struct drm_device *dev,
236b7bc44ae0fd Philipp Zabel 2020-08-26 352 void *ptr)
236b7bc44ae0fd Philipp Zabel 2020-08-26 353 {
236b7bc44ae0fd Philipp Zabel 2020-08-26 354 struct drm_crtc *crtc = ptr;
236b7bc44ae0fd Philipp Zabel 2020-08-26 355
236b7bc44ae0fd Philipp Zabel 2020-08-26 356 drm_crtc_cleanup(crtc);
236b7bc44ae0fd Philipp Zabel 2020-08-26 357 }
236b7bc44ae0fd Philipp Zabel 2020-08-26 358
236b7bc44ae0fd Philipp Zabel 2020-08-26 359 void *__drmm_crtc_alloc_with_planes(struct drm_device *dev,
236b7bc44ae0fd Philipp Zabel 2020-08-26 360 size_t size, size_t offset,
236b7bc44ae0fd Philipp Zabel 2020-08-26 361 struct drm_plane *primary,
236b7bc44ae0fd Philipp Zabel 2020-08-26 362 struct drm_plane *cursor,
236b7bc44ae0fd Philipp Zabel 2020-08-26 363 const struct drm_crtc_funcs *funcs,
236b7bc44ae0fd Philipp Zabel 2020-08-26 364 const char *name, ...)
236b7bc44ae0fd Philipp Zabel 2020-08-26 365 {
236b7bc44ae0fd Philipp Zabel 2020-08-26 366 void *container;
236b7bc44ae0fd Philipp Zabel 2020-08-26 367 struct drm_crtc *crtc;
236b7bc44ae0fd Philipp Zabel 2020-08-26 368 va_list ap;
236b7bc44ae0fd Philipp Zabel 2020-08-26 369 int ret;
236b7bc44ae0fd Philipp Zabel 2020-08-26 370
236b7bc44ae0fd Philipp Zabel 2020-08-26 371 if (!funcs || funcs->destroy)
236b7bc44ae0fd Philipp Zabel 2020-08-26 372 return ERR_PTR(-EINVAL);
236b7bc44ae0fd Philipp Zabel 2020-08-26 373
236b7bc44ae0fd Philipp Zabel 2020-08-26 374 container = drmm_kzalloc(dev, size, GFP_KERNEL);
236b7bc44ae0fd Philipp Zabel 2020-08-26 375 if (!container)
236b7bc44ae0fd Philipp Zabel 2020-08-26 376 return ERR_PTR(-ENOMEM);
236b7bc44ae0fd Philipp Zabel 2020-08-26 377
236b7bc44ae0fd Philipp Zabel 2020-08-26 378 crtc = container + offset;
236b7bc44ae0fd Philipp Zabel 2020-08-26 379
236b7bc44ae0fd Philipp Zabel 2020-08-26 380 if (name)
236b7bc44ae0fd Philipp Zabel 2020-08-26 381 va_start(ap, name);
236b7bc44ae0fd Philipp Zabel 2020-08-26 382 ret = __drm_crtc_init_with_planes(dev, crtc, primary, cursor, funcs,
236b7bc44ae0fd Philipp Zabel 2020-08-26 @383 name, ap);
236b7bc44ae0fd Philipp Zabel 2020-08-26 384 if (name)
236b7bc44ae0fd Philipp Zabel 2020-08-26 385 va_end(ap);
236b7bc44ae0fd Philipp Zabel 2020-08-26 386 if (ret)
236b7bc44ae0fd Philipp Zabel 2020-08-26 387 return ERR_PTR(ret);
236b7bc44ae0fd Philipp Zabel 2020-08-26 388
236b7bc44ae0fd Philipp Zabel 2020-08-26 389 ret = drmm_add_action_or_reset(dev, drmm_crtc_alloc_with_planes_cleanup,
236b7bc44ae0fd Philipp Zabel 2020-08-26 390 crtc);
236b7bc44ae0fd Philipp Zabel 2020-08-26 391 if (ret)
236b7bc44ae0fd Philipp Zabel 2020-08-26 392 return ERR_PTR(ret);
236b7bc44ae0fd Philipp Zabel 2020-08-26 393
236b7bc44ae0fd Philipp Zabel 2020-08-26 394 return container;
236b7bc44ae0fd Philipp Zabel 2020-08-26 395 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH 3/4] drm/plane: add drmm_universal_plane_alloc()
by Dan Carpenter
Hi Philipp,
url: https://github.com/0day-ci/linux/commits/Philipp-Zabel/drm-add-drmm_encod...
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-m001-20200826 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/gpu/drm/drm_plane.c:302 drm_universal_plane_init() error: uninitialized symbol 'ap'.
drivers/gpu/drm/drm_plane.c:345 __drmm_universal_plane_alloc() error: uninitialized symbol 'ap'.
Old smatch warnings:
drivers/gpu/drm/drm_plane.c:117 create_in_format_blob() error: potential null dereference 'blob'. (drm_property_create_blob returns null)
# https://github.com/0day-ci/linux/commit/d809a51da3d2939a84ecf6b4ada8f5be6...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Philipp-Zabel/drm-add-drmm_encoder_alloc/20200826-203629
git checkout d809a51da3d2939a84ecf6b4ada8f5be6c3ecb35
vim +/ap +302 drivers/gpu/drm/drm_plane.c
d809a51da3d293 Philipp Zabel 2020-08-26 287 int drm_universal_plane_init(struct drm_device *dev, struct drm_plane *plane,
d809a51da3d293 Philipp Zabel 2020-08-26 288 uint32_t possible_crtcs,
d809a51da3d293 Philipp Zabel 2020-08-26 289 const struct drm_plane_funcs *funcs,
d809a51da3d293 Philipp Zabel 2020-08-26 290 const uint32_t *formats, unsigned int format_count,
d809a51da3d293 Philipp Zabel 2020-08-26 291 const uint64_t *format_modifiers,
d809a51da3d293 Philipp Zabel 2020-08-26 292 enum drm_plane_type type,
d809a51da3d293 Philipp Zabel 2020-08-26 293 const char *name, ...)
d809a51da3d293 Philipp Zabel 2020-08-26 294 {
d809a51da3d293 Philipp Zabel 2020-08-26 295 va_list ap;
^^^^^^^^^^
d809a51da3d293 Philipp Zabel 2020-08-26 296 int ret;
d809a51da3d293 Philipp Zabel 2020-08-26 297
d809a51da3d293 Philipp Zabel 2020-08-26 298 if (name)
d809a51da3d293 Philipp Zabel 2020-08-26 299 va_start(ap, name);
^^
d809a51da3d293 Philipp Zabel 2020-08-26 300 ret = __drm_universal_plane_init(dev, plane, possible_crtcs, funcs,
d809a51da3d293 Philipp Zabel 2020-08-26 301 formats, format_count, format_modifiers,
d809a51da3d293 Philipp Zabel 2020-08-26 @302 type, name, ap);
^^
This isn't always initialized. Presumably it's not a problem but
runtime tools like KASan (syzbot) will detect the load and complain as
well so it's probably better to silence it.
d809a51da3d293 Philipp Zabel 2020-08-26 303 if (name)
d809a51da3d293 Philipp Zabel 2020-08-26 304 va_end(ap);
d809a51da3d293 Philipp Zabel 2020-08-26 305 return ret;
d809a51da3d293 Philipp Zabel 2020-08-26 306 }
43968d7b806d7a Daniel Vetter 2016-09-21 307 EXPORT_SYMBOL(drm_universal_plane_init);
43968d7b806d7a Daniel Vetter 2016-09-21 308
d809a51da3d293 Philipp Zabel 2020-08-26 309 static void drmm_universal_plane_alloc_release(struct drm_device *dev, void *ptr)
d809a51da3d293 Philipp Zabel 2020-08-26 310 {
d809a51da3d293 Philipp Zabel 2020-08-26 311 struct drm_plane *plane = ptr;
d809a51da3d293 Philipp Zabel 2020-08-26 312
d809a51da3d293 Philipp Zabel 2020-08-26 313 if (WARN_ON(!plane->dev))
d809a51da3d293 Philipp Zabel 2020-08-26 314 return;
d809a51da3d293 Philipp Zabel 2020-08-26 315
d809a51da3d293 Philipp Zabel 2020-08-26 316 drm_plane_cleanup(plane);
d809a51da3d293 Philipp Zabel 2020-08-26 317 }
d809a51da3d293 Philipp Zabel 2020-08-26 318
d809a51da3d293 Philipp Zabel 2020-08-26 319 void *__drmm_universal_plane_alloc(struct drm_device *dev, size_t size,
d809a51da3d293 Philipp Zabel 2020-08-26 320 size_t offset, uint32_t possible_crtcs,
d809a51da3d293 Philipp Zabel 2020-08-26 321 const struct drm_plane_funcs *funcs,
d809a51da3d293 Philipp Zabel 2020-08-26 322 const uint32_t *formats, unsigned int format_count,
d809a51da3d293 Philipp Zabel 2020-08-26 323 const uint64_t *format_modifiers,
d809a51da3d293 Philipp Zabel 2020-08-26 324 enum drm_plane_type type,
d809a51da3d293 Philipp Zabel 2020-08-26 325 const char *name, ...)
d809a51da3d293 Philipp Zabel 2020-08-26 326 {
d809a51da3d293 Philipp Zabel 2020-08-26 327 void *container;
d809a51da3d293 Philipp Zabel 2020-08-26 328 struct drm_plane *plane;
d809a51da3d293 Philipp Zabel 2020-08-26 329 va_list ap;
d809a51da3d293 Philipp Zabel 2020-08-26 330 int ret;
d809a51da3d293 Philipp Zabel 2020-08-26 331
d809a51da3d293 Philipp Zabel 2020-08-26 332 if (!funcs || funcs->destroy)
d809a51da3d293 Philipp Zabel 2020-08-26 333 return ERR_PTR(-EINVAL);
d809a51da3d293 Philipp Zabel 2020-08-26 334
d809a51da3d293 Philipp Zabel 2020-08-26 335 container = drmm_kzalloc(dev, size, GFP_KERNEL);
d809a51da3d293 Philipp Zabel 2020-08-26 336 if (!container)
d809a51da3d293 Philipp Zabel 2020-08-26 337 return ERR_PTR(-ENOMEM);
d809a51da3d293 Philipp Zabel 2020-08-26 338
d809a51da3d293 Philipp Zabel 2020-08-26 339 plane = container + offset;
d809a51da3d293 Philipp Zabel 2020-08-26 340
d809a51da3d293 Philipp Zabel 2020-08-26 341 if (name)
d809a51da3d293 Philipp Zabel 2020-08-26 342 va_start(ap, name);
d809a51da3d293 Philipp Zabel 2020-08-26 343 ret = __drm_universal_plane_init(dev, plane, possible_crtcs, funcs,
d809a51da3d293 Philipp Zabel 2020-08-26 344 formats, format_count, format_modifiers,
d809a51da3d293 Philipp Zabel 2020-08-26 @345 type, name, ap);
d809a51da3d293 Philipp Zabel 2020-08-26 346 if (name)
d809a51da3d293 Philipp Zabel 2020-08-26 347 va_end(ap);
d809a51da3d293 Philipp Zabel 2020-08-26 348 if (ret)
d809a51da3d293 Philipp Zabel 2020-08-26 349 return ERR_PTR(ret);
d809a51da3d293 Philipp Zabel 2020-08-26 350
d809a51da3d293 Philipp Zabel 2020-08-26 351 ret = drmm_add_action_or_reset(dev, drmm_universal_plane_alloc_release,
d809a51da3d293 Philipp Zabel 2020-08-26 352 plane);
d809a51da3d293 Philipp Zabel 2020-08-26 353 if (ret)
d809a51da3d293 Philipp Zabel 2020-08-26 354 return ERR_PTR(ret);
d809a51da3d293 Philipp Zabel 2020-08-26 355
d809a51da3d293 Philipp Zabel 2020-08-26 356 return container;
d809a51da3d293 Philipp Zabel 2020-08-26 357 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
arch/arm64/kvm/arm.c:1288:37: sparse: expected void
by kernel test robot
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: David Brazdil <dbrazdil(a)google.com>
CC: Marc Zyngier <maz(a)kernel.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: dcc5c6f013d841e9ae74d527d312d512dfc2e2f0
commit: 71b3ec5f221b8b3ff545639be83ddfcd5d7c9800 KVM: arm64: Clean up cpu_init_hyp_mode()
date: 3 months ago
:::::: branch date: 3 hours ago
:::::: commit date: 3 months ago
config: arm64-randconfig-s031-20200831 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
git checkout 71b3ec5f221b8b3ff545639be83ddfcd5d7c9800
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
arch/arm64/kvm/arm.c:1288:37: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void *val @@ got struct kvm_host_data [noderef] <asn:3> * @@
>> arch/arm64/kvm/arm.c:1288:37: sparse: expected void *val
arch/arm64/kvm/arm.c:1288:37: sparse: got struct kvm_host_data [noderef] <asn:3> *
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 71b3ec5f221b8b3ff545639be83ddfcd5d7c9800
vim +1288 arch/arm64/kvm/arm.c
749cf76c5a363e arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1271
7e0befd521b6d4 virt/kvm/arm/arm.c Miaohe Lin 2019-11-21 1272 static void cpu_init_hyp_mode(void)
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1273 {
dac288f7b38a74 arch/arm/kvm/arm.c Marc Zyngier 2013-05-14 1274 phys_addr_t pgd_ptr;
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1275 unsigned long hyp_stack_ptr;
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1276 unsigned long vector_ptr;
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1277 unsigned long tpidr_el2;
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1278
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1279 /* Switch from the HYP stub to our own HYP init vector */
5a677ce044f18a arch/arm/kvm/arm.c Marc Zyngier 2013-04-12 1280 __hyp_set_vectors(kvm_get_idmap_vector());
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1281
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1282 /*
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1283 * Calculate the raw per-cpu offset without a translation from the
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1284 * kernel's mapping to the linear mapping, and store it in tpidr_el2
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1285 * so that we can use adr_l to access per-cpu variables in EL2.
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1286 */
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1287 tpidr_el2 = ((unsigned long)this_cpu_ptr(&kvm_host_data) -
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 @1288 (unsigned long)kvm_ksym_ref(kvm_host_data));
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1289
dac288f7b38a74 arch/arm/kvm/arm.c Marc Zyngier 2013-05-14 1290 pgd_ptr = kvm_mmu_get_httbr();
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1291 hyp_stack_ptr = __this_cpu_read(kvm_arm_hyp_stack_page) + PAGE_SIZE;
6840bdd73d0721 virt/kvm/arm/arm.c Marc Zyngier 2018-01-03 1292 vector_ptr = (unsigned long)kvm_get_hyp_vector();
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1293
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1294 /*
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1295 * Call initialization code, and switch to the full blown HYP code.
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1296 * If the cpucaps haven't been finalized yet, something has gone very
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1297 * wrong, and hyp will crash and burn when it uses any
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1298 * cpus_have_const_cap() wrapper.
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1299 */
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1300 BUG_ON(!system_capabilities_finalized());
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1301 __kvm_call_hyp((void *)pgd_ptr, hyp_stack_ptr, vector_ptr, tpidr_el2);
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1302
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1303 /*
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1304 * Disabling SSBD on a non-VHE system requires us to enable SSBS
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1305 * at EL2.
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1306 */
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1307 if (this_cpu_has_cap(ARM64_SSBS) &&
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1308 arm64_get_ssbd_state() == ARM64_SSBD_FORCE_DISABLE) {
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1309 kvm_call_hyp(__kvm_enable_ssbs);
71b3ec5f221b8b arch/arm64/kvm/arm.c David Brazdil 2020-05-15 1310 }
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1311 }
342cd0ab0e6ca3 arch/arm/kvm/arm.c Christoffer Dall 2013-01-20 1312
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH net-next RFC v3 03/14] devlink: Add reload actions counters to dev get
by kernel test robot
CC: kbuild-all(a)lists.01.org
In-Reply-To: <1598801254-27764-4-git-send-email-moshe(a)mellanox.com>
References: <1598801254-27764-4-git-send-email-moshe(a)mellanox.com>
TO: Moshe Shemesh <moshe(a)mellanox.com>
Hi Moshe,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]
url: https://github.com/0day-ci/linux/commits/Moshe-Shemesh/Add-devlink-reload...
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 0f091e43310f5c292b7094f9f115e651358e8053
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-m021-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
net/core/devlink.c:507 devlink_nl_fill() error: buffer overflow 'devlink->reload_actions_cnts' 3 <= 3
Old smatch warnings:
net/core/devlink.c:5356 devlink_fmsg_prepare_skb() error: uninitialized symbol 'err'.
include/linux/u64_stats_sync.h:128 u64_stats_update_begin() warn: statement has no effect 31
# https://github.com/0day-ci/linux/commit/009b615f56e566df8c2712eb3b126c619...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Moshe-Shemesh/Add-devlink-reload-action-option/20200830-233543
git checkout 009b615f56e566df8c2712eb3b126c61959549d4
vim +507 net/core/devlink.c
7fe82281ae7acd4 Moshe Shemesh 2020-08-30 475
bfcd3a466172094 Jiri Pirko 2016-02-26 476 static int devlink_nl_fill(struct sk_buff *msg, struct devlink *devlink,
bfcd3a466172094 Jiri Pirko 2016-02-26 477 enum devlink_command cmd, u32 portid,
bfcd3a466172094 Jiri Pirko 2016-02-26 478 u32 seq, int flags)
bfcd3a466172094 Jiri Pirko 2016-02-26 479 {
009b615f56e566d Moshe Shemesh 2020-08-30 480 struct nlattr *reload_actions_cnts, *reload_action_cnt;
bfcd3a466172094 Jiri Pirko 2016-02-26 481 void *hdr;
009b615f56e566d Moshe Shemesh 2020-08-30 482 int i;
bfcd3a466172094 Jiri Pirko 2016-02-26 483
bfcd3a466172094 Jiri Pirko 2016-02-26 484 hdr = genlmsg_put(msg, portid, seq, &devlink_nl_family, flags, cmd);
bfcd3a466172094 Jiri Pirko 2016-02-26 485 if (!hdr)
bfcd3a466172094 Jiri Pirko 2016-02-26 486 return -EMSGSIZE;
bfcd3a466172094 Jiri Pirko 2016-02-26 487
bfcd3a466172094 Jiri Pirko 2016-02-26 488 if (devlink_nl_put_handle(msg, devlink))
bfcd3a466172094 Jiri Pirko 2016-02-26 489 goto nla_put_failure;
2670ac2625f9855 Jiri Pirko 2019-09-12 490 if (nla_put_u8(msg, DEVLINK_ATTR_RELOAD_FAILED, devlink->reload_failed))
2670ac2625f9855 Jiri Pirko 2019-09-12 491 goto nla_put_failure;
bfcd3a466172094 Jiri Pirko 2016-02-26 492
009b615f56e566d Moshe Shemesh 2020-08-30 493 if (devlink_reload_supported(devlink)) {
009b615f56e566d Moshe Shemesh 2020-08-30 494 reload_actions_cnts = nla_nest_start(msg, DEVLINK_ATTR_RELOAD_ACTIONS_CNTS);
009b615f56e566d Moshe Shemesh 2020-08-30 495 if (!reload_actions_cnts)
009b615f56e566d Moshe Shemesh 2020-08-30 496 goto nla_put_failure;
009b615f56e566d Moshe Shemesh 2020-08-30 497
009b615f56e566d Moshe Shemesh 2020-08-30 498 for (i = 0; i <= DEVLINK_RELOAD_ACTION_MAX; i++) {
009b615f56e566d Moshe Shemesh 2020-08-30 499 if (!devlink_reload_action_is_supported(devlink, i))
009b615f56e566d Moshe Shemesh 2020-08-30 500 continue;
009b615f56e566d Moshe Shemesh 2020-08-30 501 reload_action_cnt = nla_nest_start(msg, DEVLINK_ATTR_RELOAD_ACTION_CNT);
009b615f56e566d Moshe Shemesh 2020-08-30 502 if (!reload_action_cnt)
009b615f56e566d Moshe Shemesh 2020-08-30 503 goto reload_actions_cnts_nest_cancel;
009b615f56e566d Moshe Shemesh 2020-08-30 504 if (nla_put_u8(msg, DEVLINK_ATTR_RELOAD_ACTION, i))
009b615f56e566d Moshe Shemesh 2020-08-30 505 goto reload_action_cnt_nest_cancel;
009b615f56e566d Moshe Shemesh 2020-08-30 506 if (nla_put_u8(msg, DEVLINK_ATTR_RELOAD_ACTION_CNT_VALUE,
009b615f56e566d Moshe Shemesh 2020-08-30 @507 devlink->reload_actions_cnts[i]))
009b615f56e566d Moshe Shemesh 2020-08-30 508 goto reload_action_cnt_nest_cancel;
009b615f56e566d Moshe Shemesh 2020-08-30 509 nla_nest_end(msg, reload_action_cnt);
009b615f56e566d Moshe Shemesh 2020-08-30 510 }
009b615f56e566d Moshe Shemesh 2020-08-30 511 nla_nest_end(msg, reload_actions_cnts);
009b615f56e566d Moshe Shemesh 2020-08-30 512 }
009b615f56e566d Moshe Shemesh 2020-08-30 513
bfcd3a466172094 Jiri Pirko 2016-02-26 514 genlmsg_end(msg, hdr);
bfcd3a466172094 Jiri Pirko 2016-02-26 515 return 0;
bfcd3a466172094 Jiri Pirko 2016-02-26 516
009b615f56e566d Moshe Shemesh 2020-08-30 517 reload_action_cnt_nest_cancel:
009b615f56e566d Moshe Shemesh 2020-08-30 518 nla_nest_cancel(msg, reload_action_cnt);
009b615f56e566d Moshe Shemesh 2020-08-30 519 reload_actions_cnts_nest_cancel:
009b615f56e566d Moshe Shemesh 2020-08-30 520 nla_nest_cancel(msg, reload_actions_cnts);
bfcd3a466172094 Jiri Pirko 2016-02-26 521 nla_put_failure:
bfcd3a466172094 Jiri Pirko 2016-02-26 522 genlmsg_cancel(msg, hdr);
bfcd3a466172094 Jiri Pirko 2016-02-26 523 return -EMSGSIZE;
bfcd3a466172094 Jiri Pirko 2016-02-26 524 }
bfcd3a466172094 Jiri Pirko 2016-02-26 525
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
Re: [PATCH 14/19] floppy: use a separate gendisk for each media format
by kernel test robot
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200830062445.1199128-15-hch(a)lst.de>
References: <20200830062445.1199128-15-hch(a)lst.de>
TO: Christoph Hellwig <hch(a)lst.de>
Hi Christoph,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc2 next-20200828]
[cannot apply to block/for-next ide/master driver-core/driver-core-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Christoph-Hellwig/char_dev-repla...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 1127b219ce9481c84edad9711626d856127d5e51
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
config: x86_64-randconfig-m001-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/block/floppy.c:4592 floppy_alloc_disk() warn: passing a valid pointer to 'PTR_ERR'
Old smatch warnings:
drivers/block/floppy.c:2880 redo_fd_request() error: we previously assumed 'current_req' could be null (see line 2868)
drivers/block/floppy.c:3633 fd_locked_ioctl() error: uninitialized symbol 'outparam'.
# https://github.com/0day-ci/linux/commit/f08c4ae246f71af7908c08acf544e35dc...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Christoph-Hellwig/char_dev-replace-cdev_map-with-an-xarray/20200830-152505
git checkout f08c4ae246f71af7908c08acf544e35dcc4b672b
vim +/PTR_ERR +4592 drivers/block/floppy.c
8d3ab4ebfd7435b Herton Ronaldo Krzesinski 2012-08-27 4580
f08c4ae246f71af Christoph Hellwig 2020-08-30 4581 static int floppy_alloc_disk(unsigned int drive, unsigned int type)
^1da177e4c3f415 Linus Torvalds 2005-04-16 4582 {
f08c4ae246f71af Christoph Hellwig 2020-08-30 4583 struct gendisk *disk;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4584 int err;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4585
f08c4ae246f71af Christoph Hellwig 2020-08-30 4586 disk = alloc_disk(1);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4587 if (!disk)
f08c4ae246f71af Christoph Hellwig 2020-08-30 4588 return -ENOMEM;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4589
f08c4ae246f71af Christoph Hellwig 2020-08-30 4590 disk->queue = blk_mq_init_queue(&tag_sets[drive]);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4591 if (IS_ERR(disk->queue)) {
f08c4ae246f71af Christoph Hellwig 2020-08-30 @4592 err = PTR_ERR(disk);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4593 disk->queue = NULL;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4594 put_disk(disk);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4595 return err;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4596 }
f08c4ae246f71af Christoph Hellwig 2020-08-30 4597
f08c4ae246f71af Christoph Hellwig 2020-08-30 4598 blk_queue_bounce_limit(disk->queue, BLK_BOUNCE_HIGH);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4599 blk_queue_max_hw_sectors(disk->queue, 64);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4600 disk->major = FLOPPY_MAJOR;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4601 disk->first_minor = TOMINOR(drive) | (type << 2);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4602 disk->fops = &floppy_fops;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4603 disk->events = DISK_EVENT_MEDIA_CHANGE;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4604 if (type)
f08c4ae246f71af Christoph Hellwig 2020-08-30 4605 sprintf(disk->disk_name, "fd%d_type%d", drive, type);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4606 else
f08c4ae246f71af Christoph Hellwig 2020-08-30 4607 sprintf(disk->disk_name, "fd%d", drive);
f08c4ae246f71af Christoph Hellwig 2020-08-30 4608 /* to be cleaned up... */
f08c4ae246f71af Christoph Hellwig 2020-08-30 4609 disk->private_data = (void *)(long)drive;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4610 disk->flags |= GENHD_FL_REMOVABLE;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4611
f08c4ae246f71af Christoph Hellwig 2020-08-30 4612 disks[drive][type] = disk;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4613 return 0;
f08c4ae246f71af Christoph Hellwig 2020-08-30 4614 }
f08c4ae246f71af Christoph Hellwig 2020-08-30 4615
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[zen-kernel-zen-kernel:5.8/clearlinux 26/31] arch/x86/kernel/cpu/microcode/intel.c:693:17: sparse: sparse: invalid access below 'force_ucode_load' (-1073741824 1)
by kernel test robot
CC: kbuild-all(a)lists.01.org
TO: Ashok Raj <ashok.raj(a)intel.com>
CC: Steven Barrett <steven(a)liquorix.net>
tree: https://github.com/zen-kernel/zen-kernel 5.8/clearlinux
head: 5ac67ba4e481294a88d40f836664099f0e2bf0c9
commit: de76ebc4f3c0d6ea2e476d4b84654f1bb06e63eb [26/31] x86/microcode: Force update a uCode even if the rev is the same
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: i386-randconfig-s001-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.2-191-g10164920-dirty
git checkout de76ebc4f3c0d6ea2e476d4b84654f1bb06e63eb
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
>> arch/x86/kernel/cpu/microcode/intel.c:693:17: sparse: sparse: invalid access below 'force_ucode_load' (-1073741824 1)
arch/x86/kernel/cpu/microcode/intel.c:753:15: sparse: sparse: invalid access below 'intel_ucode_patch' (-1073741824 4)
# https://github.com/zen-kernel/zen-kernel/commit/de76ebc4f3c0d6ea2e476d4b8...
git remote add zen-kernel-zen-kernel https://github.com/zen-kernel/zen-kernel
git fetch --no-tags zen-kernel-zen-kernel 5.8/clearlinux
git checkout de76ebc4f3c0d6ea2e476d4b84654f1bb06e63eb
vim +/force_ucode_load +693 arch/x86/kernel/cpu/microcode/intel.c
de76ebc4f3c0d6 Ashok Raj 2019-07-20 687
de76ebc4f3c0d6 Ashok Raj 2019-07-20 688 if (cmdline_find_option_bool(cmdline, option)) {
de76ebc4f3c0d6 Ashok Raj 2019-07-20 689 printk("cmdline forcing ucode update for same rev\n");
de76ebc4f3c0d6 Ashok Raj 2019-07-20 690 *res = true;
de76ebc4f3c0d6 Ashok Raj 2019-07-20 691 }
de76ebc4f3c0d6 Ashok Raj 2019-07-20 692
de76ebc4f3c0d6 Ashok Raj 2019-07-20 @693 return *res;
de76ebc4f3c0d6 Ashok Raj 2019-07-20 694 }
de76ebc4f3c0d6 Ashok Raj 2019-07-20 695
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[iio:fixes-togreg 19/19] drivers/iio/adc/mcp3422.c:147:3-9: preceding lock on line 137
by kernel test robot
CC: kbuild-all(a)lists.01.org
TO: Angelo Compagnucci <angelo.compagnucci(a)gmail.com>
CC: Jonathan Cameron <Jonathan.Cameron(a)huawei.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git fixes-togreg
head: ba255800f7fbb8da411c92c33b25d52970558509
commit: ba255800f7fbb8da411c92c33b25d52970558509 [19/19] iio: adc: mcp3422: fix locking scope
:::::: branch date: 3 hours ago
:::::: commit date: 3 hours ago
config: i386-randconfig-c001-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/iio/adc/mcp3422.c:147:3-9: preceding lock on line 137
# https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=...
git remote add iio https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
git fetch --no-tags iio fixes-togreg
git checkout ba255800f7fbb8da411c92c33b25d52970558509
vim +147 drivers/iio/adc/mcp3422.c
07914c84ba30e31 Angelo Compagnucci 2013-09-02 129
07914c84ba30e31 Angelo Compagnucci 2013-09-02 130 static int mcp3422_read_channel(struct mcp3422 *adc,
07914c84ba30e31 Angelo Compagnucci 2013-09-02 131 struct iio_chan_spec const *channel, int *value)
07914c84ba30e31 Angelo Compagnucci 2013-09-02 132 {
07914c84ba30e31 Angelo Compagnucci 2013-09-02 133 int ret;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 134 u8 config;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 135 u8 req_channel = channel->channel;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 136
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 @137 mutex_lock(&adc->lock);
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 138
07914c84ba30e31 Angelo Compagnucci 2013-09-02 139 if (req_channel != MCP3422_CHANNEL(adc->config)) {
07914c84ba30e31 Angelo Compagnucci 2013-09-02 140 config = adc->config;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 141 config &= ~MCP3422_CHANNEL_MASK;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 142 config |= MCP3422_CHANNEL_VALUE(req_channel);
07914c84ba30e31 Angelo Compagnucci 2013-09-02 143 config &= ~MCP3422_PGA_MASK;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 144 config |= MCP3422_PGA_VALUE(adc->pga[req_channel]);
07914c84ba30e31 Angelo Compagnucci 2013-09-02 145 ret = mcp3422_update_config(adc, config);
07914c84ba30e31 Angelo Compagnucci 2013-09-02 146 if (ret < 0)
07914c84ba30e31 Angelo Compagnucci 2013-09-02 @147 return ret;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 148 msleep(mcp3422_read_times[MCP3422_SAMPLE_RATE(adc->config)]);
07914c84ba30e31 Angelo Compagnucci 2013-09-02 149 }
07914c84ba30e31 Angelo Compagnucci 2013-09-02 150
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 151 ret = mcp3422_read(adc, value, &config);
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 152
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 153 mutex_unlock(&adc->lock);
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 154
ba255800f7fbb8d Angelo Compagnucci 2020-08-19 155 return ret;
07914c84ba30e31 Angelo Compagnucci 2013-09-02 156 }
07914c84ba30e31 Angelo Compagnucci 2013-09-02 157
:::::: The code at line 147 was first introduced by commit
:::::: 07914c84ba30e311f6bfb65b811b33a1dc094311 iio: adc: Add driver for Microchip MCP3422/3/4 high resolution ADC
:::::: TO: Angelo Compagnucci <angelo.compagnucci(a)gmail.com>
:::::: CC: Jonathan Cameron <jic23(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[iio:testing 75/76] drivers/iio/accel/adxl372.c:350 adxl372_write_threshold_value() warn: inconsistent returns 'st->threshold_m'.
by kernel test robot
CC: kbuild-all(a)lists.01.org
TO: Stefan Popa <stefan.popa(a)analog.com>
CC: Jonathan Cameron <Jonathan.Cameron(a)huawei.com>
CC: Alexandru Tachici <alexandru.tachici(a)analog.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git testing
head: b7959420e446032114da12b9af2a36ab62396dce
commit: 84847a0a0c6314106e93d75ee9f50401fd0806ec [75/76] iio: accel: adxl372: Add support for FIFO peak mode
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago
config: microblaze-randconfig-m031-20200830 (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/iio/accel/adxl372.c:350 adxl372_write_threshold_value() warn: inconsistent returns 'st->threshold_m'.
# https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=...
git remote add iio https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
git fetch --no-tags iio testing
git checkout 84847a0a0c6314106e93d75ee9f50401fd0806ec
vim +350 drivers/iio/accel/adxl372.c
84847a0a0c6314 Stefan Popa 2020-08-10 333
84847a0a0c6314 Stefan Popa 2020-08-10 334 static ssize_t adxl372_write_threshold_value(struct iio_dev *indio_dev, unsigned int addr,
84847a0a0c6314 Stefan Popa 2020-08-10 335 u16 threshold)
84847a0a0c6314 Stefan Popa 2020-08-10 336 {
84847a0a0c6314 Stefan Popa 2020-08-10 337 struct adxl372_state *st = iio_priv(indio_dev);
84847a0a0c6314 Stefan Popa 2020-08-10 338 int ret;
84847a0a0c6314 Stefan Popa 2020-08-10 339
84847a0a0c6314 Stefan Popa 2020-08-10 340 mutex_lock(&st->threshold_m);
84847a0a0c6314 Stefan Popa 2020-08-10 341 ret = regmap_write(st->regmap, addr, ADXL372_THRESH_VAL_H_SEL(threshold));
84847a0a0c6314 Stefan Popa 2020-08-10 342 if (ret < 0)
84847a0a0c6314 Stefan Popa 2020-08-10 343 return ret;
84847a0a0c6314 Stefan Popa 2020-08-10 344
84847a0a0c6314 Stefan Popa 2020-08-10 345 ret = regmap_update_bits(st->regmap, addr + 1, GENMASK(7, 5),
84847a0a0c6314 Stefan Popa 2020-08-10 346 ADXL372_THRESH_VAL_L_SEL(threshold) << 5);
84847a0a0c6314 Stefan Popa 2020-08-10 347
84847a0a0c6314 Stefan Popa 2020-08-10 348 mutex_unlock(&st->threshold_m);
84847a0a0c6314 Stefan Popa 2020-08-10 349
84847a0a0c6314 Stefan Popa 2020-08-10 @350 return ret;
84847a0a0c6314 Stefan Popa 2020-08-10 351 }
84847a0a0c6314 Stefan Popa 2020-08-10 352
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
[iio:fixes-togreg 19/19] drivers/iio/adc/mcp3422.c:155 mcp3422_read_channel() warn: inconsistent returns 'adc->lock'.
by kernel test robot
CC: kbuild-all(a)lists.01.org
TO: Angelo Compagnucci <angelo.compagnucci(a)gmail.com>
CC: Jonathan Cameron <Jonathan.Cameron(a)huawei.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git fixes-togreg
head: ba255800f7fbb8da411c92c33b25d52970558509
commit: ba255800f7fbb8da411c92c33b25d52970558509 [19/19] iio: adc: mcp3422: fix locking scope
:::::: branch date: 54 minutes ago
:::::: commit date: 54 minutes ago
config: x86_64-randconfig-m001-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
drivers/iio/adc/mcp3422.c:155 mcp3422_read_channel() warn: inconsistent returns 'adc->lock'.
# https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?id=...
git remote add iio https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git
git fetch --no-tags iio fixes-togreg
git checkout ba255800f7fbb8da411c92c33b25d52970558509
vim +155 drivers/iio/adc/mcp3422.c
07914c84ba30e3 Angelo Compagnucci 2013-09-02 129
07914c84ba30e3 Angelo Compagnucci 2013-09-02 130 static int mcp3422_read_channel(struct mcp3422 *adc,
07914c84ba30e3 Angelo Compagnucci 2013-09-02 131 struct iio_chan_spec const *channel, int *value)
07914c84ba30e3 Angelo Compagnucci 2013-09-02 132 {
07914c84ba30e3 Angelo Compagnucci 2013-09-02 133 int ret;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 134 u8 config;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 135 u8 req_channel = channel->channel;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 136
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 137 mutex_lock(&adc->lock);
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 138
07914c84ba30e3 Angelo Compagnucci 2013-09-02 139 if (req_channel != MCP3422_CHANNEL(adc->config)) {
07914c84ba30e3 Angelo Compagnucci 2013-09-02 140 config = adc->config;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 141 config &= ~MCP3422_CHANNEL_MASK;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 142 config |= MCP3422_CHANNEL_VALUE(req_channel);
07914c84ba30e3 Angelo Compagnucci 2013-09-02 143 config &= ~MCP3422_PGA_MASK;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 144 config |= MCP3422_PGA_VALUE(adc->pga[req_channel]);
07914c84ba30e3 Angelo Compagnucci 2013-09-02 145 ret = mcp3422_update_config(adc, config);
07914c84ba30e3 Angelo Compagnucci 2013-09-02 146 if (ret < 0)
07914c84ba30e3 Angelo Compagnucci 2013-09-02 147 return ret;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 148 msleep(mcp3422_read_times[MCP3422_SAMPLE_RATE(adc->config)]);
07914c84ba30e3 Angelo Compagnucci 2013-09-02 149 }
07914c84ba30e3 Angelo Compagnucci 2013-09-02 150
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 151 ret = mcp3422_read(adc, value, &config);
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 152
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 153 mutex_unlock(&adc->lock);
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 154
ba255800f7fbb8 Angelo Compagnucci 2020-08-19 @155 return ret;
07914c84ba30e3 Angelo Compagnucci 2013-09-02 156 }
07914c84ba30e3 Angelo Compagnucci 2013-09-02 157
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months
drivers/scsi/qedi/qedi_main.c:924 qedi_get_boot_tgt_info() error: snprintf() chops off the last chars of 256 vs 255
by kernel test robot
CC: kbuild-all(a)lists.01.org
CC: linux-kernel(a)vger.kernel.org
TO: Manish Rangankar <mrangankar(a)marvell.com>
CC: "Martin K. Petersen" <martin.petersen(a)oracle.com>
CC: Lee Duncan <lduncan(a)suse.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 4d41ead6ead97c3730bbd186a601a64828668f01
commit: 2f1ea39870c95aa9fff6a0b48757625a0b22f551 scsi: qedi: Remove additional char from boot target iqnname
date: 5 months ago
:::::: branch date: 18 hours ago
:::::: commit date: 5 months ago
config: i386-randconfig-m021-20200830 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/scsi/qedi/qedi_main.c:924 qedi_get_boot_tgt_info() error: snprintf() chops off the last chars of 'block->target[index]->target_name.byte': 256 vs 255
Old smatch warnings:
drivers/scsi/qedi/qedi_main.c:956 qedi_find_boot_info() warn: returning -1 instead of -ENOMEM is sloppy
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2f1ea39870c95aa9fff6a0b48757625a0b22f551
vim +924 drivers/scsi/qedi/qedi_main.c
ace7f46ba5fde7 Manish Rangankar 2016-12-01 915
534bbdf8832ae4 Manish Rangankar 2018-05-22 916 static void qedi_get_boot_tgt_info(struct nvm_iscsi_block *block,
534bbdf8832ae4 Manish Rangankar 2018-05-22 917 struct qedi_boot_target *tgt, u8 index)
534bbdf8832ae4 Manish Rangankar 2018-05-22 918 {
534bbdf8832ae4 Manish Rangankar 2018-05-22 919 u32 ipv6_en;
534bbdf8832ae4 Manish Rangankar 2018-05-22 920
534bbdf8832ae4 Manish Rangankar 2018-05-22 921 ipv6_en = !!(block->generic.ctrl_flags &
534bbdf8832ae4 Manish Rangankar 2018-05-22 922 NVM_ISCSI_CFG_GEN_IPV6_ENABLED);
534bbdf8832ae4 Manish Rangankar 2018-05-22 923
2f1ea39870c95a Manish Rangankar 2020-04-07 @924 snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s",
534bbdf8832ae4 Manish Rangankar 2018-05-22 925 block->target[index].target_name.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 926
534bbdf8832ae4 Manish Rangankar 2018-05-22 927 tgt->ipv6_en = ipv6_en;
534bbdf8832ae4 Manish Rangankar 2018-05-22 928
534bbdf8832ae4 Manish Rangankar 2018-05-22 929 if (ipv6_en)
534bbdf8832ae4 Manish Rangankar 2018-05-22 930 snprintf(tgt->ip_addr, IPV6_LEN, "%pI6\n",
534bbdf8832ae4 Manish Rangankar 2018-05-22 931 block->target[index].ipv6_addr.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 932 else
534bbdf8832ae4 Manish Rangankar 2018-05-22 933 snprintf(tgt->ip_addr, IPV4_LEN, "%pI4\n",
534bbdf8832ae4 Manish Rangankar 2018-05-22 934 block->target[index].ipv4_addr.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 935 }
534bbdf8832ae4 Manish Rangankar 2018-05-22 936
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 4 months