drivers/acpi/processor_thermal.c:66:1: warning: the frame size of 2160 bytes is larger than 2048 bytes
12:20 a.m.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 96b95eff4a591dbac582c2590d067e356a18aacb
commit: 3000ce3c52f8b8db093e4dc649cd172390f71137 cpufreq: Use per-policy frequency QoS
date: 4 weeks ago
config: ia64-randconfig-a001-20191115 (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3000ce3c52f8b8db093e4dc649cd172390f71137
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/acpi/processor_thermal.c: In function 'cpu_has_cpufreq.part.0':
> drivers/acpi/processor_thermal.c:66:1: warning: the frame size of
2160 bytes is larger than 2048 bytes [-Wframe-larger-than=]
}
^
--
drivers/cpufreq/cpufreq.c: In function 'refresh_frequency_limits.part.33':
> drivers/cpufreq/cpufreq.c:1116:1: warning: the frame size of 2160
bytes is larger than 2048 bytes [-Wframe-larger-than=]
}
^
drivers/cpufreq/cpufreq.c: In function 'store_scaling_governor':
drivers/cpufreq/cpufreq.c:789:1: warning: the frame size of 2176 bytes is larger than
2048 bytes [-Wframe-larger-than=]
}
^
drivers/cpufreq/cpufreq.c: In function 'cpufreq_init_policy':
drivers/cpufreq/cpufreq.c:1081:1: warning: the frame size of 2160 bytes is larger than
2048 bytes [-Wframe-larger-than=]
}
^
vim +66 drivers/acpi/processor_thermal.c
2815ab92ba3ab2 Andi Kleen 2012-02-06 59
^1da177e4c3f41 Linus Torvalds 2005-04-16 60 static int cpu_has_cpufreq(unsigned int
cpu)
^1da177e4c3f41 Linus Torvalds 2005-04-16 61 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 62 struct cpufreq_policy policy;
d15ce412737acc Viresh Kumar 2019-08-28 63 if (!acpi_processor_cpufreq_init ||
cpufreq_get_policy(&policy, cpu))
^1da177e4c3f41 Linus Torvalds 2005-04-16 64 return 0;
75b245b3259133 Thomas Renninger 2005-12-21 65 return 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16 @66 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 67
:::::: The code at line 66 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2
:::::: TO: Linus Torvalds <torvalds(a)ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds(a)ppc970.osdl.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
10:51 a.m.
Hi Rafael, Viresh,
On Fri, Nov 15, 2019 at 6:23 AM kbuild test robot <lkp(a)intel.com> wrote:
tree:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 96b95eff4a591dbac582c2590d067e356a18aacb
commit: 3000ce3c52f8b8db093e4dc649cd172390f71137 cpufreq: Use per-policy frequency QoS
date: 4 weeks ago
config: ia64-randconfig-a001-20191115 (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 3000ce3c52f8b8db093e4dc649cd172390f71137
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Seeing similar warnings on arm64, so this triggered my attention.
--
drivers/cpufreq/cpufreq.c: In function 'refresh_frequency_limits.part.33':
>> drivers/cpufreq/cpufreq.c:1116:1: warning: the frame size of 2160 bytes is
larger than 2048 bytes [-Wframe-larger-than=]
| struct cpufreq_policy new_policy;
That's a large struct on the stack...
| if (!policy_is_inactive(policy)) {
| new_policy = *policy;
Let's make a copy?
How well does this work, given struct cpufreq_policy contains a
work_struct, list_head, kobject, completion, semaphore, spinlock_t,
wait_queue_head_t, and two notifier_blocks, which are all objects you
cannot just copy and reuse?
| pr_debug("updating policy for CPU %u\n", policy->cpu);
|
| cpufreq_set_policy(policy, &new_policy);
If cpufreq_set_policy() uses only a few fields from new_policy, it might
be a good idea to extract those into its own structure.
}
^
drivers/cpufreq/cpufreq.c: In function 'store_scaling_governor':
drivers/cpufreq/cpufreq.c:789:1: warning: the frame size of 2176 bytes is larger than
2048 bytes [-Wframe-larger-than=]
| struct cpufreq_policy new_policy;
|
| memcpy(&new_policy, policy, sizeof(*policy));
Likewise.
}
^
drivers/cpufreq/cpufreq.c: In function 'cpufreq_init_policy':
drivers/cpufreq/cpufreq.c:1081:1: warning: the frame size of 2160 bytes is larger than
2048 bytes [-Wframe-larger-than=]
| struct cpufreq_policy new_policy;
|
| memcpy(&new_policy, policy, sizeof(*policy));
One more.
}
^
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert(a)linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like
that.
-- Linus Torvalds
5:16 a.m.
On Fri, Jan 17, 2020 at 4:51 PM Geert Uytterhoeven <geert(a)linux-m68k.org> wrote:
Hi Rafael, Viresh,
On Fri, Nov 15, 2019 at 6:23 AM kbuild test robot <lkp(a)intel.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head: 96b95eff4a591dbac582c2590d067e356a18aacb
> commit: 3000ce3c52f8b8db093e4dc649cd172390f71137 cpufreq: Use per-policy frequency
QoS
> date: 4 weeks ago
> config: ia64-randconfig-a001-20191115 (attached as .config)
> compiler: ia64-linux-gcc (GCC) 7.4.0
> reproduce:
> wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
> chmod +x ~/bin/make.cross
> git checkout 3000ce3c52f8b8db093e4dc649cd172390f71137
> # save the attached .config to linux build tree
> GCC_VERSION=7.4.0 make.cross ARCH=ia64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp(a)intel.com>
Seeing similar warnings on arm64, so this triggered my attention.
> --
> drivers/cpufreq/cpufreq.c: In function
'refresh_frequency_limits.part.33':
> >> drivers/cpufreq/cpufreq.c:1116:1: warning: the frame size of 2160 bytes is
larger than 2048 bytes [-Wframe-larger-than=]
| struct cpufreq_policy new_policy;
That's a large struct on the stack...
| if (!policy_is_inactive(policy)) {
| new_policy = *policy;
Let's make a copy?
How well does this work, given struct cpufreq_policy contains a
work_struct, list_head, kobject, completion, semaphore, spinlock_t,
wait_queue_head_t, and two notifier_blocks, which are all objects you
cannot just copy and reuse?
| pr_debug("updating policy for CPU %u\n", policy->cpu);
|
| cpufreq_set_policy(policy, &new_policy);
If cpufreq_set_policy() uses only a few fields from new_policy,
That's really the case.
it might be a good idea to extract those into its own structure.
Or organize the code differently.
This is old code that hasn't been change, but I'll look at it since it
is problematic.
Thanks!
403
days inactive
469
days old
2 comments
3 participants
participants (3)
-
Geert Uytterhoeven -
kbuild test robot -
Rafael J. Wysocki