Hi Tobias,
url:
https://github.com/0day-ci/linux/commits/Tobias-Waldekranz/net-dsa-link-a...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
4525c8781ec0701ce824e8bd379ae1b129e26568
config: parisc-randconfig-m031-20201028 (attached as .config)
compiler: hppa64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:5488 mv88e6xxx_port_lag_join() warn: inconsistent returns
'chip->reg_lock'.
Old smatch warnings:
drivers/net/dsa/mv88e6xxx/chip.c:2475 mv88e6xxx_serdes_irq_request() warn: 'irq'
not released on lines: 2475.
vim +5488 drivers/net/dsa/mv88e6xxx/chip.c
79cd23f00678afd Tobias Waldekranz 2020-10-27 5470 static int
mv88e6xxx_port_lag_join(struct dsa_switch *ds, int port,
79cd23f00678afd Tobias Waldekranz 2020-10-27 5471 struct net_device *lag_dev)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5472 {
79cd23f00678afd Tobias Waldekranz 2020-10-27 5473 struct dsa_lag *lag = dsa_to_port(ds,
port)->lag;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5474 struct mv88e6xxx_chip *chip =
ds->priv;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5475 int err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5476
79cd23f00678afd Tobias Waldekranz 2020-10-27 5477 mv88e6xxx_reg_lock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5478
79cd23f00678afd Tobias Waldekranz 2020-10-27 5479 err = mv88e6xxx_port_set_trunk(chip,
port, true, lag->id);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5480 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5481 return err;
^^^^^^^^^^^
Call mv88e6xxx_reg_unlock() unlock before returning.
79cd23f00678afd Tobias Waldekranz 2020-10-27 5482
79cd23f00678afd Tobias Waldekranz 2020-10-27 5483 err = mv88e6xxx_lag_sync_map(ds,
lag);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5484 if (err)
79cd23f00678afd Tobias Waldekranz 2020-10-27 5485 mv88e6xxx_port_set_trunk(chip, port,
false, 0);
79cd23f00678afd Tobias Waldekranz 2020-10-27 5486
79cd23f00678afd Tobias Waldekranz 2020-10-27 5487 mv88e6xxx_reg_unlock(chip);
79cd23f00678afd Tobias Waldekranz 2020-10-27 @5488 return err;
79cd23f00678afd Tobias Waldekranz 2020-10-27 5489 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org