Hi "Marek,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on cd29296fdfca919590e4004a7e4905544f4c4a32]
url:
https://github.com/0day-ci/linux/commits/Marek-Beh-n/netdev-trigger-offlo...
base: cd29296fdfca919590e4004a7e4905544f4c4a32
config: nios2-defconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O
~/bin/make.cross
chmod +x ~/bin/make.cross
#
https://github.com/0day-ci/linux/commit/0cfca88266cb524576ecb45f52c9f40c1...
git remote add linux-review
https://github.com/0day-ci/linux
git fetch --no-tags linux-review
Marek-Beh-n/netdev-trigger-offloading-and-LEDs-on-Marvell-PHYs/20201030-194640
git checkout 0cfca88266cb524576ecb45f52c9f40c177f1560
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
> drivers/net/phy/marvell.c:885:13: warning: 'struct
led_netdev_data' declared inside parameter list will not be visible outside of this
definition or declaration
885 | struct led_netdev_data *trig)
| ^~~~~~~~~~~~~~~
drivers/net/phy/marvell.c: In function 'marvell_find_led_mode':
drivers/net/phy/marvell.c:892:21: error: dereferencing pointer to incomplete type
'struct led_netdev_data'
892 | key = LED_MODE(trig->link, trig->tx, trig->rx);
| ^~
drivers/net/phy/marvell.c:832:28: note: in definition of macro 'BITIF'
832 | #define BITIF(i, cond) ((cond) ? BIT(i) : 0)
| ^~~~
drivers/net/phy/marvell.c:892:8: note: in expansion of macro 'LED_MODE'
892 | key = LED_MODE(trig->link, trig->tx, trig->rx);
| ^~~~~~~~
drivers/net/phy/marvell.c: In function 'marvell_led_trigger_offload':
drivers/net/phy/marvell.c:941:28: error: 'netdev_led_trigger' undeclared (first
use in this function); did you mean 'module_led_trigger'?
941 | if (led->cdev.trigger != &netdev_led_trigger ||
!phydev->attached_dev ||
| ^~~~~~~~~~~~~~~~~~
| module_led_trigger
drivers/net/phy/marvell.c:941:28: note: each undeclared identifier is reported only
once for each function it appears in
drivers/net/phy/marvell.c:942:34: error: dereferencing pointer to incomplete type
'struct led_netdev_data'
942 | phydev->attached_dev != trig->net_dev)
| ^~
drivers/net/phy/marvell.c:945:44: error: passing argument 3 of
'marvell_find_led_mode' from incompatible pointer type
[-Werror=incompatible-pointer-types]
945 | mode = marvell_find_led_mode(phydev, led, trig);
| ^~~~
| |
| struct led_netdev_data *
drivers/net/phy/marvell.c:885:30: note: expected 'struct led_netdev_data *' but
argument is of type 'struct led_netdev_data *'
885 | struct led_netdev_data *trig)
| ~~~~~~~~~~~~~~~~~~~~~~~~^~~~
cc1: some warnings being treated as errors
vim +885 drivers/net/phy/marvell.c
883
884 static int marvell_find_led_mode(struct phy_device *phydev, struct phy_led *led,
885 struct led_netdev_data *trig)
886 {
887 const struct marvell_leds_info *info = led->priv;
888 const struct marvell_led_mode_info *mode;
889 u32 key;
890 int i;
891
892 key = LED_MODE(trig->link, trig->tx, trig->rx);
893
894 for (i = 0; i < ARRAY_SIZE(marvell_led_mode_info); ++i) {
895 mode = &marvell_led_mode_info[i];
896
897 if (key != mode->key || mode->regval[led->addr] == -1 ||
898 !(info->flags & mode->flags))
899 continue;
900
901 return mode->regval[led->addr];
902 }
903
904 dev_dbg(led->cdev.dev,
905 "cannot offload trigger configuration (%s, link=%i, tx=%i, rx=%i)\n",
906 netdev_name(trig->net_dev), trig->link, trig->tx, trig->rx);
907
908 return -1;
909 }
910
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org