Re: [atishp04:efi_stub 1/1] drivers/firmware/efi/libstub/arm-stub.c:203:7: warning: variable 'secure_boot' is uninitialized when used here
7:10 p.m.
On Wed, Nov 20, 2019 at 2:46 PM Atish Patra <Atish.Patra(a)wdc.com> wrote:
On Mon, 2019-11-18 at 22:39 -0800, Nick Desaulniers wrote:
> Atish, below is a report from 0day bot from a build with Clang. The
> warning looks legit, can you please take a look?
>
Hi Nick,
Thanks for the email. This is a work in progress branch. Is there way
not to trigger kbuild tests on this branch ?
That's a common question that Rong or Philip can answer (I forgot what
the answer has been in the past). Rong/Philip, it may be good to have
a URL/link that I can point people to in the future, since it's a FAQ.
--
Regards,
Atish
> On Mon, Nov 18, 2019 at 10:17 PM kbuild test robot <lkp(a)intel.com>
> wrote:
> > CC: kbuild-all(a)lists.01.org
> > TO: Atish Patra <atish.patra(a)wdc.com>
> >
> > tree: https://github.com/atishp04/linux efi_stub
> > head: 7dbf2060ab3115d2edcfba8f0f677a321a1611f1
> > commit: 7dbf2060ab3115d2edcfba8f0f677a321a1611f1 [1/1] Add efi stub
> > config: arm64-defconfig (attached as .config)
> > compiler: clang version 10.0.0 (git://gitmirror/llvm_project
> > 0213adde218530bc31e5c4e50b49704c6bb2f2e9)
> > reproduce:
> > wget
> > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > git checkout 7dbf2060ab3115d2edcfba8f0f677a321a1611f1
> > # save the attached .config to linux build tree
> > make.cross ARCH=arm64
> >
> > If you fix the issue, kindly add following tag
> > Reported-by: kbuild test robot <lkp(a)intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > drivers/firmware/efi/libstub/arm-stub.c:132:22: warning: unused
> > variable 'si' [-Wunused-variable]
> > struct screen_info *si;
> > ^
> > > > drivers/firmware/efi/libstub/arm-stub.c:203:7: warning:
> > > > variable 'secure_boot' is uninitialized when used here [-
> > > > Wuninitialized]
> > secure_boot != efi_secureboot_mode_disabled) {
> > ^~~~~~~~~~~
> > drivers/firmware/efi/libstub/arm-stub.c:131:2: note: variable
> > 'secure_boot' is declared here
> > enum efi_secureboot_mode secure_boot;
> > ^
> > 2 warnings generated.
> >
> > vim +/secure_boot +203 drivers/firmware/efi/libstub/arm-stub.c
> >
> > b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-09-21 92
> > b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-09-21 93
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 94 /*
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 95 * This function handles the
> > architcture specific differences between arm and
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 96 * arm64 regarding where the kernel
> > image must be loaded and any memory that
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 97 * must be reserved. On failure it is
> > required to free all
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 98 * all allocations it has made.
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 99 */
> > bd669475d14e32 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-07-02 100 efi_status_t
> > handle_kernel_image(efi_system_table_t *sys_table,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 101 unsigned long
> > *image_addr,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 102 unsigned long
> > *image_size,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 103 unsigned long
> > *reserve_addr,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 104 unsigned long
> > *reserve_size,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 105 unsigned long dram_base,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 106 efi_loaded_image_t
> > *image);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 107 /*
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 108 * EFI entry point for the arm/arm64
> > EFI stubs. This is the entrypoint
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 109 * that is described in the PE/COFF
> > header. Most of the code is the same
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 110 * for both archictectures, with the
> > arch-specific code provided in the
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 111 * handle_kernel_image() function.
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 112 */
> > ddeeefe2dfbe1f drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2015-01-12 113 unsigned long efi_entry(void *handle,
> > efi_system_table_t *sys_table,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 114 unsigned
> > long *image_addr)
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 115 {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 116 efi_loaded_image_t *image;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 117 efi_status_t status;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 118 unsigned long image_size = 0;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 119 unsigned long dram_base;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 120 /* addr/point and size pairs
> > for memory management*/
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 121 unsigned long initrd_addr;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 122 u64 initrd_size = 0;
> > 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-04-03 123 unsigned long fdt_addr =
> > 0; /* Original DTB */
> > a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2015-03-04 124 unsigned long fdt_size = 0;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 125 char *cmdline_ptr = NULL;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 126 int cmdline_size = 0;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 127 unsigned long new_fdt_addr;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 128 efi_guid_t loaded_image_proto =
> > LOADED_IMAGE_PROTOCOL_GUID;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 129 unsigned long reserve_addr = 0;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 130 unsigned long reserve_size = 0;
> > de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
> > Howells 2017-02-06 131 enum efi_secureboot_mode
> > secure_boot;
> > f0827e18a7a1da drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-04-25 @132 struct screen_info *si;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 133
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 134 /* Check if we were booted by
> > the EFI firmware */
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 135 if (sys_table->hdr.signature !=
> > EFI_SYSTEM_TABLE_SIGNATURE)
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 136 goto fail;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 137
> > b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-02-17 138 status =
> > check_platform_features(sys_table);
> > b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-02-17 139 if (status != EFI_SUCCESS)
> > b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-02-17 140 goto fail;
> > b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-02-17 141
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 142 /*
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 143 * Get a handle to the loaded
> > image protocol. This is used to get
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 144 * information about the
> > running image, such as size and the command
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 145 * line.
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 146 */
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 147 status = sys_table->boottime-
> > >handle_protocol(handle,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 148 &loaded_image_prot
> > o, (void *)&image);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 149 if (status != EFI_SUCCESS) {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 150 pr_efi_err(sys_table,
> > "Failed to get loaded image protocol\n");
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 151 goto fail;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 152 }
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 153
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 154 dram_base =
> > get_dram_base(sys_table);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 155 if (dram_base == EFI_ERROR) {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 156 pr_efi_err(sys_table,
> > "Failed to find DRAM base\n");
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 157 goto fail;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 158 }
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 159
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 160 /*
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 161 * Get the command line from
> > EFI, using the LOADED_IMAGE
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 162 * protocol. We are going to
> > copy the command line into the
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 163 * device tree, so this can be
> > allocated anywhere.
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 164 */
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 165 cmdline_ptr =
> > efi_convert_cmdline(sys_table, image, &cmdline_size);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 166 if (!cmdline_ptr) {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 167 pr_efi_err(sys_table,
> > "getting command line via LOADED_IMAGE_PROTOCOL\n");
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 168 goto fail;
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 169 }
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 170
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 171 if
> > (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 172 IS_ENABLED(CONFIG_CMDLINE_FORCE) ||
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 173 cmdline_size == 0)
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 174 efi_parse_options(CONFIG_CMDLINE);
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 175
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 176 if
> > (!IS_ENABLED(CONFIG_CMDLINE_FORCE) && cmdline_size > 0)
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 177 efi_parse_options(cmdline_ptr);
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 178
> > eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 179 pr_efi(sys_table, "Booting
> > Linux Kernel...\n");
> > 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
> > Patra 2019-11-18 180 #if 0
> > f0827e18a7a1da drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-04-25 181 si =
> > setup_graphics(sys_table);
> > 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
> > Patra 2019-11-18 182 #endif
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 183 status =
> > handle_kernel_image(sys_table, image_addr, &image_size,
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-
> > 26 184 &reserve_addr,
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-
> > 26 185 &reserve_size,
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-
> > 26 186 dram_base, image);
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 187 if (status != EFI_SUCCESS) {
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 188 pr_efi_err(sys_table,
> > "Failed to relocate kernel\n");
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 189 goto
> > fail_free_cmdline;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 190 }
> > 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
> > Patra 2019-11-18 191 #if 0
> > ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
> > Garrett 2017-08-25 192 /* Ask the firmware to clear
> > memory on unclean shutdown */
> > ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
> > Garrett 2017-08-
> > 25 193 efi_enable_reset_attack_mitigation(sys_table);
> > ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
> > Garrett 2017-08-25 194
> > 73a6492589c87c drivers/firmware/efi/libstub/arm-stub.c Linn
> > Crosetto 2016-04-25 195 secure_boot =
> > efi_get_secureboot(sys_table);
> > 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
> > Patra 2019-11-18 196 #endif
> > 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-04-03 197 /*
> > de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
> > Howells 2017-02-06 198 * Unauthenticated device tree
> > data is a security hazard, so ignore
> > de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
> > Howells 2017-02-06 199 * 'dtb=' unless UEFI Secure
> > Boot is disabled. We assume that secure
> > de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
> > Howells 2017-02-06 200 * boot is enabled if we can't
> > determine its state.
> > 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-04-03 201 */
> > 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-07-11 202 if
> > (!IS_ENABLED(CONFIG_EFI_ARMSTUB_DTB_LOADER) ||
> > 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-07-11 @203 secure_boot !=
> > efi_secureboot_mode_disabled) {
> > 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-07-11 204 if
> > (strstr(cmdline_ptr, "dtb="))
> > 73a6492589c87c drivers/firmware/efi/libstub/arm-stub.c Linn
> > Crosetto 2016-04-
> > 25 205 pr_efi(sys_table, "Ignoring DTB
> > from command line.\n");
> > 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-04-03 206 } else {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 207 status =
> > handle_cmdline_files(sys_table, image, cmdline_ptr,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 208 "dtb=",
> > a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2015-03-
> > 04 209 ~0UL,
> > &fdt_addr, &fdt_size);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 210
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 211 if (status !=
> > EFI_SUCCESS) {
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 212 pr_efi_err(sys_table, "Failed to
> > load device tree!\n");
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 213 goto
> > fail_free_image;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 214 }
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 215 }
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 216
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 217 if (fdt_addr) {
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 218 pr_efi(sys_table,
> > "Using DTB from command line\n");
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 219 } else {
> > 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
> > Biesheuvel 2014-04-03 220 /* Look for a device
> > tree configuration table entry. */
> > a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2015-03-04 221 fdt_addr =
> > (uintptr_t)get_fdt(sys_table, &fdt_size);
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 222 if (fdt_addr)
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-
> > 23 223 pr_efi(sys_table, "Using DTB from
> > configuration table\n");
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 224 }
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 225
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 226 if (!fdt_addr)
> > 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
> > Rutland 2014-10-23 227 pr_efi(sys_table,
> > "Generating empty DTB\n");
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 228
> > 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 229 status =
> > handle_cmdline_files(sys_table, image, cmdline_ptr, "initrd=",
> > 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 230 efi_get_max_initrd_a
> > ddr(dram_base,
> > 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 231
> > *image_addr),
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 232 (unsigned long
> > *)&initrd_addr,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 233 (unsigned long
> > *)&initrd_size);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 234 if (status != EFI_SUCCESS)
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 235 pr_efi_err(sys_table,
> > "Failed initrd from command line!\n");
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 236
> > 568bc4e87033d2 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-11-
> > 12 237 efi_random_get_seed(sys_table);
> > 568bc4e87033d2 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-11-12 238
> > 38fb6652229c21 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-10-25 239 /* hibernation expects the
> > runtime regions to stay in the same place */
> > 38fb6652229c21 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-10-25 240 if
> > (!IS_ENABLED(CONFIG_HIBERNATION) && !nokaslr()) {
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 241 /*
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 242 * Randomize the base
> > of the UEFI runtime services region.
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 243 * Preserve the 2 MB
> > alignment of the region by taking a
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 244 * shift of 21 bit
> > positions into account when scaling
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 245 * the headroom value
> > using a 32-bit random value.
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 246 */
> > 197decefdb79d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-17 247 static const u64
> > headroom = EFI_RT_VIRTUAL_LIMIT -
> > 197decefdb79d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 17 248 EFI_RT_VIRTUAL
> > _BASE -
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 249 EFI_RT_VIRTUAL
> > _SIZE;
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 250 u32 rnd;
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 251
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 252 status =
> > efi_get_random_bytes(sys_table, sizeof(rnd),
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 253 (u8 *)&rnd);
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 254 if (status ==
> > EFI_SUCCESS) {
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 255 virtmap_base =
> > EFI_RT_VIRTUAL_BASE +
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 256 (((headroom >> 21)
> > * rnd) >> (32 - 21));
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 257 }
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 258 }
> > e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-04 259
> > b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-09-
> > 21 260 install_memreserve_table(sys_table);
> > b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2018-09-21 261
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 262 new_fdt_addr = fdt_addr;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 263 status =
> > allocate_new_fdt_and_exit_boot(sys_table, handle,
> > 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2017-04-
> > 04 264 &new_fdt_addr,
> > efi_get_max_fdt_addr(dram_base),
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 265 initrd_addr, initrd_size,
> > cmdline_ptr,
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-
> > 15 266 fdt_addr, fdt_size);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 267
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 268 /*
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 269 * If all went well, we need to
> > return the FDT address to the
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 270 * calling function so it can
> > be passed to kernel as part of
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 271 * the kernel boot protocol.
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 272 */
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 273 if (status == EFI_SUCCESS)
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 274 return new_fdt_addr;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 275
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 276 pr_efi_err(sys_table, "Failed
> > to update FDT and exit boot services\n");
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 277
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 278 efi_free(sys_table,
> > initrd_size, initrd_addr);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 279 efi_free(sys_table, fdt_size,
> > fdt_addr);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 280
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 281 fail_free_image:
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 282 efi_free(sys_table, image_size,
> > *image_addr);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 283 efi_free(sys_table,
> > reserve_size, reserve_addr);
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 284 fail_free_cmdline:
> > 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
> > Patra 2019-11-18 285 //free_screen_info(sys_table,
> > si);
> > 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2016-01-26 286 efi_free(sys_table,
> > cmdline_size, (unsigned long)cmdline_ptr);
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 287 fail:
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 288 return EFI_ERROR;
> > 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
> > Salter 2014-04-15 289 }
> > f3cdfd239da56a drivers/firmware/efi/libstub/arm-stub.c Ard
> > Biesheuvel 2014-10-20 290
> >
> > :::::: The code at line 203 was first introduced by commit
> > :::::: 3d7ee348aa4127a7893c11261da9b76371a970e6 efi/libstub/arm:
> > Add opt-in Kconfig option for the DTB loader
> >
> > :::::: TO: Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
> > :::::: CC: Ingo Molnar <mingo(a)kernel.org>
> >
> > ---
> > 0-DAY kernel test infrastructure Open Source
> > Technology Center
> > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel
> > Corporation
>
>
--
Thanks,
~Nick Desaulniers
8:10 a.m.
New subject: [atishp04:efi_stub 1/1] drivers/firmware/efi/libstub/arm-stub.c:203:7: warning: variable 'secure_boot' is uninitialized when used here
Hi Nick,
On 11/22/19 3:10 AM, Nick Desaulniers wrote:
On Wed, Nov 20, 2019 at 2:46 PM Atish Patra
<Atish.Patra(a)wdc.com> wrote:
> On Mon, 2019-11-18 at 22:39 -0800, Nick Desaulniers wrote:
>> Atish, below is a report from 0day bot from a build with Clang. The
>> warning looks legit, can you please take a look?
>>
> Hi Nick,
> Thanks for the email. This is a work in progress branch. Is there way
> not to trigger kbuild tests on this branch ?
That's a common question that Rong or Philip can answer (I forgot what
the answer has been in the past). Rong/Philip, it may be good to have
a URL/link that I can point people to in the future, since it's a FAQ.
We have blacklisted "efi_stub" and "wip_.*" branches for Atish. In
general, branches named as ".*experimental.*" or ".*dont-build"
won't be tested by default. and we have a doc to introduce basic
configurations: https://github.com/intel/lkp-tests/wiki/Repo-Spec
Best Regards,
Rong Chen
> --
> Regards,
> Atish
>
>
>> On Mon, Nov 18, 2019 at 10:17 PM kbuild test robot <lkp(a)intel.com>
>> wrote:
>>> CC: kbuild-all(a)lists.01.org
>>> TO: Atish Patra <atish.patra(a)wdc.com>
>>>
>>> tree: https://github.com/atishp04/linux efi_stub
>>> head: 7dbf2060ab3115d2edcfba8f0f677a321a1611f1
>>> commit: 7dbf2060ab3115d2edcfba8f0f677a321a1611f1 [1/1] Add efi stub
>>> config: arm64-defconfig (attached as .config)
>>> compiler: clang version 10.0.0 (git://gitmirror/llvm_project
>>> 0213adde218530bc31e5c4e50b49704c6bb2f2e9)
>>> reproduce:
>>> wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> git checkout 7dbf2060ab3115d2edcfba8f0f677a321a1611f1
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=arm64
>>>
>>> If you fix the issue, kindly add following tag
>>> Reported-by: kbuild test robot <lkp(a)intel.com>
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>> drivers/firmware/efi/libstub/arm-stub.c:132:22: warning: unused
>>> variable 'si' [-Wunused-variable]
>>> struct screen_info *si;
>>> ^
>>>>> drivers/firmware/efi/libstub/arm-stub.c:203:7: warning:
>>>>> variable 'secure_boot' is uninitialized when used here [-
>>>>> Wuninitialized]
>>> secure_boot != efi_secureboot_mode_disabled) {
>>> ^~~~~~~~~~~
>>> drivers/firmware/efi/libstub/arm-stub.c:131:2: note: variable
>>> 'secure_boot' is declared here
>>> enum efi_secureboot_mode secure_boot;
>>> ^
>>> 2 warnings generated.
>>>
>>> vim +/secure_boot +203 drivers/firmware/efi/libstub/arm-stub.c
>>>
>>> b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-09-21 92
>>> b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-09-21 93
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 94 /*
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 95 * This function handles the
>>> architcture specific differences between arm and
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 96 * arm64 regarding where the kernel
>>> image must be loaded and any memory that
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 97 * must be reserved. On failure it is
>>> required to free all
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 98 * all allocations it has made.
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 99 */
>>> bd669475d14e32 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-07-02 100 efi_status_t
>>> handle_kernel_image(efi_system_table_t *sys_table,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 101 unsigned long
>>> *image_addr,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 102 unsigned long
>>> *image_size,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 103 unsigned long
>>> *reserve_addr,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 104 unsigned long
>>> *reserve_size,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 105 unsigned long dram_base,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 106 efi_loaded_image_t
>>> *image);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 107 /*
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 108 * EFI entry point for the arm/arm64
>>> EFI stubs. This is the entrypoint
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 109 * that is described in the PE/COFF
>>> header. Most of the code is the same
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 110 * for both archictectures, with the
>>> arch-specific code provided in the
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 111 * handle_kernel_image() function.
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 112 */
>>> ddeeefe2dfbe1f drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2015-01-12 113 unsigned long efi_entry(void *handle,
>>> efi_system_table_t *sys_table,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 114 unsigned
>>> long *image_addr)
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 115 {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 116 efi_loaded_image_t *image;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 117 efi_status_t status;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 118 unsigned long image_size = 0;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 119 unsigned long dram_base;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 120 /* addr/point and size pairs
>>> for memory management*/
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 121 unsigned long initrd_addr;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 122 u64 initrd_size = 0;
>>> 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-04-03 123 unsigned long fdt_addr =
>>> 0; /* Original DTB */
>>> a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2015-03-04 124 unsigned long fdt_size = 0;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 125 char *cmdline_ptr = NULL;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 126 int cmdline_size = 0;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 127 unsigned long new_fdt_addr;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 128 efi_guid_t loaded_image_proto =
>>> LOADED_IMAGE_PROTOCOL_GUID;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 129 unsigned long reserve_addr = 0;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 130 unsigned long reserve_size = 0;
>>> de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
>>> Howells 2017-02-06 131 enum efi_secureboot_mode
>>> secure_boot;
>>> f0827e18a7a1da drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-04-25 @132 struct screen_info *si;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 133
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 134 /* Check if we were booted by
>>> the EFI firmware */
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 135 if (sys_table->hdr.signature !=
>>> EFI_SYSTEM_TABLE_SIGNATURE)
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 136 goto fail;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 137
>>> b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-02-17 138 status =
>>> check_platform_features(sys_table);
>>> b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-02-17 139 if (status != EFI_SUCCESS)
>>> b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-02-17 140 goto fail;
>>> b9d6769b5678db drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-02-17 141
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 142 /*
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 143 * Get a handle to the loaded
>>> image protocol. This is used to get
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 144 * information about the
>>> running image, such as size and the command
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 145 * line.
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 146 */
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 147 status = sys_table->boottime-
>>>> handle_protocol(handle,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 148 &loaded_image_prot
>>> o, (void *)&image);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 149 if (status != EFI_SUCCESS) {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 150 pr_efi_err(sys_table,
>>> "Failed to get loaded image protocol\n");
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 151 goto fail;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 152 }
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 153
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 154 dram_base =
>>> get_dram_base(sys_table);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 155 if (dram_base == EFI_ERROR) {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 156 pr_efi_err(sys_table,
>>> "Failed to find DRAM base\n");
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 157 goto fail;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 158 }
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 159
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 160 /*
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 161 * Get the command line from
>>> EFI, using the LOADED_IMAGE
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 162 * protocol. We are going to
>>> copy the command line into the
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 163 * device tree, so this can be
>>> allocated anywhere.
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 164 */
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 165 cmdline_ptr =
>>> efi_convert_cmdline(sys_table, image, &cmdline_size);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 166 if (!cmdline_ptr) {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 167 pr_efi_err(sys_table,
>>> "getting command line via LOADED_IMAGE_PROTOCOL\n");
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 168 goto fail;
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 169 }
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 170
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 171 if
>>> (IS_ENABLED(CONFIG_CMDLINE_EXTEND) ||
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 172 IS_ENABLED(CONFIG_CMDLINE_FORCE) ||
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 173 cmdline_size == 0)
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 174 efi_parse_options(CONFIG_CMDLINE);
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 175
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 176 if
>>> (!IS_ENABLED(CONFIG_CMDLINE_FORCE) && cmdline_size > 0)
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 177 efi_parse_options(cmdline_ptr);
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 178
>>> eeff7d634f4750 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 179 pr_efi(sys_table, "Booting
>>> Linux Kernel...\n");
>>> 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
>>> Patra 2019-11-18 180 #if 0
>>> f0827e18a7a1da drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-04-25 181 si =
>>> setup_graphics(sys_table);
>>> 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
>>> Patra 2019-11-18 182 #endif
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 183 status =
>>> handle_kernel_image(sys_table, image_addr, &image_size,
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-
>>> 26 184 &reserve_addr,
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-
>>> 26 185 &reserve_size,
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-
>>> 26 186 dram_base, image);
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 187 if (status != EFI_SUCCESS) {
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 188 pr_efi_err(sys_table,
>>> "Failed to relocate kernel\n");
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 189 goto
>>> fail_free_cmdline;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 190 }
>>> 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
>>> Patra 2019-11-18 191 #if 0
>>> ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
>>> Garrett 2017-08-25 192 /* Ask the firmware to clear
>>> memory on unclean shutdown */
>>> ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
>>> Garrett 2017-08-
>>> 25 193 efi_enable_reset_attack_mitigation(sys_table);
>>> ccc829ba3624be drivers/firmware/efi/libstub/arm-stub.c Matthew
>>> Garrett 2017-08-25 194
>>> 73a6492589c87c drivers/firmware/efi/libstub/arm-stub.c Linn
>>> Crosetto 2016-04-25 195 secure_boot =
>>> efi_get_secureboot(sys_table);
>>> 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
>>> Patra 2019-11-18 196 #endif
>>> 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-04-03 197 /*
>>> de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
>>> Howells 2017-02-06 198 * Unauthenticated device tree
>>> data is a security hazard, so ignore
>>> de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
>>> Howells 2017-02-06 199 * 'dtb=' unless UEFI Secure
>>> Boot is disabled. We assume that secure
>>> de8cb458625c16 drivers/firmware/efi/libstub/arm-stub.c David
>>> Howells 2017-02-06 200 * boot is enabled if we can't
>>> determine its state.
>>> 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-04-03 201 */
>>> 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-07-11 202 if
>>> (!IS_ENABLED(CONFIG_EFI_ARMSTUB_DTB_LOADER) ||
>>> 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-07-11 @203 secure_boot !=
>>> efi_secureboot_mode_disabled) {
>>> 3d7ee348aa4127 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-07-11 204 if
>>> (strstr(cmdline_ptr, "dtb="))
>>> 73a6492589c87c drivers/firmware/efi/libstub/arm-stub.c Linn
>>> Crosetto 2016-04-
>>> 25 205 pr_efi(sys_table, "Ignoring DTB
>>> from command line.\n");
>>> 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-04-03 206 } else {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 207 status =
>>> handle_cmdline_files(sys_table, image, cmdline_ptr,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 208 "dtb=",
>>> a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2015-03-
>>> 04 209 ~0UL,
>>> &fdt_addr, &fdt_size);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 210
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 211 if (status !=
>>> EFI_SUCCESS) {
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 212 pr_efi_err(sys_table, "Failed to
>>> load device tree!\n");
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 213 goto
>>> fail_free_image;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 214 }
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 215 }
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 216
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 217 if (fdt_addr) {
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 218 pr_efi(sys_table,
>>> "Using DTB from command line\n");
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 219 } else {
>>> 345c736edd07b6 drivers/firmware/efi/arm-stub.c Ard
>>> Biesheuvel 2014-04-03 220 /* Look for a device
>>> tree configuration table entry. */
>>> a643375f4b1755 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2015-03-04 221 fdt_addr =
>>> (uintptr_t)get_fdt(sys_table, &fdt_size);
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 222 if (fdt_addr)
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-
>>> 23 223 pr_efi(sys_table, "Using DTB from
>>> configuration table\n");
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 224 }
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 225
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 226 if (!fdt_addr)
>>> 0bcaa9040d0586 drivers/firmware/efi/libstub/arm-stub.c Mark
>>> Rutland 2014-10-23 227 pr_efi(sys_table,
>>> "Generating empty DTB\n");
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 228
>>> 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 229 status =
>>> handle_cmdline_files(sys_table, image, cmdline_ptr, "initrd=",
>>> 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 230 efi_get_max_initrd_a
>>> ddr(dram_base,
>>> 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 231
>>> *image_addr),
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 232 (unsigned long
>>> *)&initrd_addr,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 233 (unsigned long
>>> *)&initrd_size);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 234 if (status != EFI_SUCCESS)
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 235 pr_efi_err(sys_table,
>>> "Failed initrd from command line!\n");
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 236
>>> 568bc4e87033d2 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-11-
>>> 12 237 efi_random_get_seed(sys_table);
>>> 568bc4e87033d2 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-11-12 238
>>> 38fb6652229c21 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-10-25 239 /* hibernation expects the
>>> runtime regions to stay in the same place */
>>> 38fb6652229c21 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-10-25 240 if
>>> (!IS_ENABLED(CONFIG_HIBERNATION) && !nokaslr()) {
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 241 /*
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 242 * Randomize the base
>>> of the UEFI runtime services region.
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 243 * Preserve the 2 MB
>>> alignment of the region by taking a
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 244 * shift of 21 bit
>>> positions into account when scaling
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 245 * the headroom value
>>> using a 32-bit random value.
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 246 */
>>> 197decefdb79d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-17 247 static const u64
>>> headroom = EFI_RT_VIRTUAL_LIMIT -
>>> 197decefdb79d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 17 248 EFI_RT_VIRTUAL
>>> _BASE -
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 249 EFI_RT_VIRTUAL
>>> _SIZE;
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 250 u32 rnd;
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 251
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 252 status =
>>> efi_get_random_bytes(sys_table, sizeof(rnd),
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 253 (u8 *)&rnd);
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 254 if (status ==
>>> EFI_SUCCESS) {
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 255 virtmap_base =
>>> EFI_RT_VIRTUAL_BASE +
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 256 (((headroom >> 21)
>>> * rnd) >> (32 - 21));
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 257 }
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 258 }
>>> e69176d68d26d6 drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-04 259
>>> b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-09-
>>> 21 260 install_memreserve_table(sys_table);
>>> b844470f22061e drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2018-09-21 261
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 262 new_fdt_addr = fdt_addr;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 263 status =
>>> allocate_new_fdt_and_exit_boot(sys_table, handle,
>>> 138728dd4ee30d drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2017-04-
>>> 04 264 &new_fdt_addr,
>>> efi_get_max_fdt_addr(dram_base),
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 265 initrd_addr, initrd_size,
>>> cmdline_ptr,
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-
>>> 15 266 fdt_addr, fdt_size);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 267
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 268 /*
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 269 * If all went well, we need to
>>> return the FDT address to the
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 270 * calling function so it can
>>> be passed to kernel as part of
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 271 * the kernel boot protocol.
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 272 */
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 273 if (status == EFI_SUCCESS)
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 274 return new_fdt_addr;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 275
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 276 pr_efi_err(sys_table, "Failed
>>> to update FDT and exit boot services\n");
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 277
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 278 efi_free(sys_table,
>>> initrd_size, initrd_addr);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 279 efi_free(sys_table, fdt_size,
>>> fdt_addr);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 280
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 281 fail_free_image:
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 282 efi_free(sys_table, image_size,
>>> *image_addr);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 283 efi_free(sys_table,
>>> reserve_size, reserve_addr);
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 284 fail_free_cmdline:
>>> 7dbf2060ab3115 drivers/firmware/efi/libstub/arm-stub.c Atish
>>> Patra 2019-11-18 285 //free_screen_info(sys_table,
>>> si);
>>> 2b5fe07a78a09a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2016-01-26 286 efi_free(sys_table,
>>> cmdline_size, (unsigned long)cmdline_ptr);
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 287 fail:
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 288 return EFI_ERROR;
>>> 3c7f255039a2ad drivers/firmware/efi/arm-stub.c Mark
>>> Salter 2014-04-15 289 }
>>> f3cdfd239da56a drivers/firmware/efi/libstub/arm-stub.c Ard
>>> Biesheuvel 2014-10-20 290
>>>
>>> :::::: The code at line 203 was first introduced by commit
>>> :::::: 3d7ee348aa4127a7893c11261da9b76371a970e6 efi/libstub/arm:
>>> Add opt-in Kconfig option for the DTB loader
>>>
>>> :::::: TO: Ard Biesheuvel <ard.biesheuvel(a)linaro.org>
>>> :::::: CC: Ingo Molnar <mingo(a)kernel.org>
>>>
>>> ---
>>> 0-DAY kernel test infrastructure Open Source
>>> Technology Center
>>> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel
>>> Corporation
>>
6:11 p.m.
New subject: [atishp04:efi_stub 1/1] drivers/firmware/efi/libstub/arm-stub.c:203:7: warning: variable 'secure_boot' is uninitialized when used here
On Mon, Nov 25, 2019 at 12:11 AM Rong Chen <rong.a.chen(a)intel.com> wrote:
Hi Nick,
On 11/22/19 3:10 AM, Nick Desaulniers wrote:
> On Wed, Nov 20, 2019 at 2:46 PM Atish Patra <Atish.Patra(a)wdc.com> wrote:
>> On Mon, 2019-11-18 at 22:39 -0800, Nick Desaulniers wrote:
>>> Atish, below is a report from 0day bot from a build with Clang. The
>>> warning looks legit, can you please take a look?
>>>
>> Hi Nick,
>> Thanks for the email. This is a work in progress branch. Is there way
>> not to trigger kbuild tests on this branch ?
> That's a common question that Rong or Philip can answer (I forgot what
> the answer has been in the past). Rong/Philip, it may be good to have
> a URL/link that I can point people to in the future, since it's a FAQ.
We have blacklisted "efi_stub" and "wip_.*" branches for Atish. In
general, branches named as ".*experimental.*" or ".*dont-build"
won't be tested by default. and we have a doc to introduce basic
configurations: https://github.com/intel/lkp-tests/wiki/Repo-Spec
Thanks for the link. Looks like it doesn't mention the `wip_`
convention, and it says `*experiment*` (more specifically). Would you
mind either adding the note about `wip_` or a new wiki page saying "If
you don't want 0day bot to find/test your branches, please use the
following naming conventions when pushing branches: XXX." That way in
the future when I nag someone, and it was just an experimental branch,
I can just send them the link to the wiki about the convention, and
don't have to nag you?
--
Thanks,
~Nick Desaulniers
8:52 a.m.
New subject: [atishp04:efi_stub 1/1] drivers/firmware/efi/libstub/arm-stub.c:203:7: warning: variable 'secure_boot' is uninitialized when used here
On 11/26/19 2:11 AM, Nick Desaulniers wrote:
On Mon, Nov 25, 2019 at 12:11 AM Rong Chen
<rong.a.chen(a)intel.com> wrote:
> Hi Nick,
>
> On 11/22/19 3:10 AM, Nick Desaulniers wrote:
>> On Wed, Nov 20, 2019 at 2:46 PM Atish Patra <Atish.Patra(a)wdc.com> wrote:
>>> On Mon, 2019-11-18 at 22:39 -0800, Nick Desaulniers wrote:
>>>> Atish, below is a report from 0day bot from a build with Clang. The
>>>> warning looks legit, can you please take a look?
>>>>
>>> Hi Nick,
>>> Thanks for the email. This is a work in progress branch. Is there way
>>> not to trigger kbuild tests on this branch ?
>> That's a common question that Rong or Philip can answer (I forgot what
>> the answer has been in the past). Rong/Philip, it may be good to have
>> a URL/link that I can point people to in the future, since it's a FAQ.
> We have blacklisted "efi_stub" and "wip_.*" branches for Atish.
In
> general, branches named as ".*experimental.*" or ".*dont-build"
> won't be tested by default. and we have a doc to introduce basic
> configurations: https://github.com/intel/lkp-tests/wiki/Repo-Spec
Thanks for the link. Looks like it doesn't mention the `wip_`
convention, and it says `*experiment*` (more specifically). Would you
mind either adding the note about `wip_` or a new wiki page saying "If
you don't want 0day bot to find/test your branches, please use the
following naming conventions when pushing branches: XXX." That way in
the future when I nag someone, and it was just an experimental branch,
I can just send them the link to the wiki about the convention, and
don't have to nag you?
Hi Nick,
Sorry for the delay, I just got the permission to write a doc in
github, please see
https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-tri...
Best Regards,
Rong Chen
5:21 p.m.
New subject: [atishp04:efi_stub 1/1] drivers/firmware/efi/libstub/arm-stub.c:203:7: warning: variable 'secure_boot' is uninitialized when used here
On Tue, Dec 3, 2019 at 12:52 AM Rong Chen <rong.a.chen(a)intel.com> wrote:
On 11/26/19 2:11 AM, Nick Desaulniers wrote:
> On Mon, Nov 25, 2019 at 12:11 AM Rong Chen <rong.a.chen(a)intel.com> wrote:
>> Hi Nick,
>>
>> On 11/22/19 3:10 AM, Nick Desaulniers wrote:
>>> On Wed, Nov 20, 2019 at 2:46 PM Atish Patra <Atish.Patra(a)wdc.com>
wrote:
>>>> On Mon, 2019-11-18 at 22:39 -0800, Nick Desaulniers wrote:
>>>>> Atish, below is a report from 0day bot from a build with Clang. The
>>>>> warning looks legit, can you please take a look?
>>>>>
>>>> Hi Nick,
>>>> Thanks for the email. This is a work in progress branch. Is there way
>>>> not to trigger kbuild tests on this branch ?
>>> That's a common question that Rong or Philip can answer (I forgot what
>>> the answer has been in the past). Rong/Philip, it may be good to have
>>> a URL/link that I can point people to in the future, since it's a FAQ.
>> We have blacklisted "efi_stub" and "wip_.*" branches for
Atish. In
>> general, branches named as ".*experimental.*" or
".*dont-build"
>> won't be tested by default. and we have a doc to introduce basic
>> configurations: https://github.com/intel/lkp-tests/wiki/Repo-Spec
> Thanks for the link. Looks like it doesn't mention the `wip_`
> convention, and it says `*experiment*` (more specifically). Would you
> mind either adding the note about `wip_` or a new wiki page saying "If
> you don't want 0day bot to find/test your branches, please use the
> following naming conventions when pushing branches: XXX." That way in
> the future when I nag someone, and it was just an experimental branch,
> I can just send them the link to the wiki about the convention, and
> don't have to nag you?
>
>
Hi Nick,
Sorry for the delay, I just got the permission to write a doc in
github, please see
https://github.com/intel/lkp-tests/wiki/LKP-FAQ#is-there-a-way-not-to-tri...
Thanks Rong, this is perfect. I've bookmarked it and will forward that
link when someone asks me about blacklisting branches from 0day bot in
the future.
--
Thanks,
~Nick Desaulniers
936
days inactive
948
days old
4 comments
2 participants
participants (2)
-
Nick Desaulniers -
Rong Chen