[linuxppc:next-test 48/49] arch/x86/kernel/signal.c:312:7: error: implicit declaration of function 'user_access_begin'; did you mean 'user_access_end'?
3:13 p.m.
tree: https://github.com/linuxppc/linux next-test
head: 7d204d846b04d0a1b4d3712736029fbf2e7a7359
commit: 5bb3b9d986426296507d3ef58d1e5fe4625de01f [48/49] uaccess: Rename
user_access_begin/end() to user_full_access_begin/end()
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 5bb3b9d986426296507d3ef58d1e5fe4625de01f
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/x86/kernel/signal.c: In function '__setup_frame':
> arch/x86/kernel/signal.c:312:7: error: implicit declaration of
function 'user_access_begin'; did you mean 'user_access_end'?
[-Werror=implicit-function-declaration]
if (!user_access_begin(frame,
sizeof(*frame)))
^~~~~~~~~~~~~~~~~
user_access_end
cc1: some warnings being treated as errors
vim +312 arch/x86/kernel/signal.c
75779f05264b99 arch/x86/kernel/signal.c Hiroshi Shimamoto 2009-02-27 301
7e907f48980d66 arch/x86/kernel/signal_32.c Ingo Molnar 2008-03-06 302 static int
235b80226b986d arch/x86/kernel/signal.c Al Viro 2012-11-09 303
__setup_frame(int sig, struct ksignal *ksig, sigset_t *set,
7e907f48980d66 arch/x86/kernel/signal_32.c Ingo Molnar 2008-03-06 304
struct pt_regs *regs)
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 305 {
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 306 struct
sigframe __user *frame;
7e907f48980d66 arch/x86/kernel/signal_32.c Ingo Molnar 2008-03-06 307 void __user
*restorer;
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 308 void __user
*fp = NULL;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 309
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 310 frame =
get_sigframe(&ksig->ka, regs, sizeof(*frame), &fp);
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 311
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 @312 if
(!user_access_begin(frame, sizeof(*frame)))
3d0aedd9538e6b arch/x86/kernel/signal_32.c Hiroshi Shimamoto 2008-09-12 313 return
-EFAULT;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 314
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 315
unsafe_put_user(sig, &frame->sig, Efault);
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 316
unsafe_put_sigcontext(&frame->sc, fp, regs, set, Efault);
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 317
unsafe_put_user(set->sig[1], &frame->extramask[0], Efault);
1a3e4ca41c5a38 arch/x86/kernel/signal_32.c Roland McGrath 2008-04-09 318 if
(current->mm->context.vdso)
6f121e548f8367 arch/x86/kernel/signal.c Andy Lutomirski 2014-05-05 319 restorer =
current->mm->context.vdso +
0a6d1fa0d2b48f arch/x86/kernel/signal.c Andy Lutomirski 2015-10-05 320
vdso_image_32.sym___kernel_sigreturn;
9fbbd4dd17d071 arch/i386/kernel/signal.c Andi Kleen 2007-02-13 321 else
ade1af77129dea arch/x86/kernel/signal_32.c Jan Engelhardt 2008-01-30 322 restorer =
&frame->retcode;
235b80226b986d arch/x86/kernel/signal.c Al Viro 2012-11-09 323 if
(ksig->ka.sa.sa_flags & SA_RESTORER)
235b80226b986d arch/x86/kernel/signal.c Al Viro 2012-11-09 324 restorer =
ksig->ka.sa.sa_restorer;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 325
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 326 /* Set up
to return from userspace. */
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 327
unsafe_put_user(restorer, &frame->pretcode, Efault);
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 328
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 329 /*
7e907f48980d66 arch/x86/kernel/signal_32.c Ingo Molnar 2008-03-06 330 * This is
popl %eax ; movl $__NR_sigreturn, %eax ; int $0x80
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 331 *
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 332 * WE DO
NOT USE IT ANY MORE! It's only left here for historical
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 333 * reasons
and because gdb uses it as a signature to notice
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 334 * signal
handler stack frames.
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 335 */
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 336
unsafe_put_user(*((u64 *)&retcode), (u64 *)frame->retcode, Efault);
5c1f178094631e arch/x86/kernel/signal.c Al Viro 2020-02-15 337
user_access_end();
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 338
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 339 /* Set up
registers for signal handler */
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 340 regs->sp
= (unsigned long)frame;
235b80226b986d arch/x86/kernel/signal.c Al Viro 2012-11-09 341 regs->ip
= (unsigned long)ksig->ka.sa.sa_handler;
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 342 regs->ax
= (unsigned long)sig;
92bc2056855b32 arch/x86/kernel/signal_32.c Harvey Harrison 2008-02-08 343 regs->dx
= 0;
92bc2056855b32 arch/x86/kernel/signal_32.c Harvey Harrison 2008-02-08 344 regs->cx
= 0;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 345
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 346 regs->ds
= __USER_DS;
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 347 regs->es
= __USER_DS;
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 348 regs->ss
= __USER_DS;
65ea5b03499035 arch/x86/kernel/signal_32.c H. Peter Anvin 2008-01-30 349 regs->cs
= __USER_CS;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 350
283828f3c19ceb arch/i386/kernel/signal.c David Howells 2006-01-18 351 return 0;
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 352
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 353 Efault:
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 354
user_access_end();
b00d8f8f0b2b39 arch/x86/kernel/signal.c Al Viro 2020-02-15 355 return
-EFAULT;
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 356 }
^1da177e4c3f41 arch/i386/kernel/signal.c Linus Torvalds 2005-04-16 357
:::::: The code at line 312 was first introduced by commit
:::::: 5c1f178094631e8b9acc67e4a9b6e03abfbc2529 x86: __setup_frame(): consolidate uaccess
areas
:::::: TO: Al Viro <viro(a)zeniv.linux.org.uk>
:::::: CC: Al Viro <viro(a)zeniv.linux.org.uk>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
3:47 p.m.
Hi Michael,
Le 30/04/2020 à 16:13, kbuild test robot a écrit :
tree: https://github.com/linuxppc/linux next-test
head: 7d204d846b04d0a1b4d3712736029fbf2e7a7359
commit: 5bb3b9d986426296507d3ef58d1e5fe4625de01f [48/49] uaccess: Rename
user_access_begin/end() to user_full_access_begin/end()
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
git checkout 5bb3b9d986426296507d3ef58d1e5fe4625de01f
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/x86/kernel/signal.c: In function '__setup_frame':
>> arch/x86/kernel/signal.c:312:7: error: implicit declaration of function
'user_access_begin'; did you mean 'user_access_end'?
[-Werror=implicit-function-declaration]
if (!user_access_begin(frame, sizeof(*frame)))
^~~~~~~~~~~~~~~~~
user_access_end
cc1: some warnings being treated as errors
I see you took the entire series.
The problem is that people added additional uses of user_access_begin()
after I submitted the series.
In the meantime, Linus has suggested to keep the original name of the
function and drop patch 5 (see discussion at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/42da416106d5c1cf9...)
Christophe
5:39 a.m.
Christophe Leroy <christophe.leroy(a)c-s.fr> writes:
Hi Michael,
Le 30/04/2020 à 16:13, kbuild test robot a écrit :
> tree: https://github.com/linuxppc/linux next-test
> head: 7d204d846b04d0a1b4d3712736029fbf2e7a7359
> commit: 5bb3b9d986426296507d3ef58d1e5fe4625de01f [48/49] uaccess: Rename
user_access_begin/end() to user_full_access_begin/end()
> config: i386-tinyconfig (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
> git checkout 5bb3b9d986426296507d3ef58d1e5fe4625de01f
> # save the attached .config to linux build tree
> make ARCH=i386
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp(a)intel.com>
>
> All errors (new ones prefixed by >>):
>
> arch/x86/kernel/signal.c: In function '__setup_frame':
>>> arch/x86/kernel/signal.c:312:7: error: implicit declaration of function
'user_access_begin'; did you mean 'user_access_end'?
[-Werror=implicit-function-declaration]
> if (!user_access_begin(frame, sizeof(*frame)))
> ^~~~~~~~~~~~~~~~~
> user_access_end
> cc1: some warnings being treated as errors
I see you took the entire series.
The problem is that people added additional uses of user_access_begin()
after I submitted the series.
In the meantime, Linus has suggested to keep the original name of the
function and drop patch 5 (see discussion at
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/42da416106d5c1cf9...)
Yep sorry for the spam.
I forgot to drop the last patch before I pushed, and then the build bot
picked it up.
I've dropped the rename patch now.
cheers
786
days inactive
787
days old
2 comments
3 participants
participants (3)
-
Christophe Leroy -
kbuild test robot -
Michael Ellerman