tree: https://github.com/alibaba/cloud-kernel.git intel/ck-4.19.67 head: 5d5ebaddcbf30a52bfdee633c6076b6e0c24ddf5 commit: a7362a4df1f090ed0aec1d22971187e63a61c936 [100/119] resource: Clean it up a bit reproduce: make htmldocs If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp(a)intel.com&gt; All warnings (new ones prefixed by >>): Warning: The Sphinx 'sphinx_rtd_theme' HTML theme was not found. Make sure you have the theme installed to produce pretty HTML output. Falling back to the default theme. WARNING: dot(1) not found, for better output quality install graphviz from http://www.graphviz.org WARNING: convert(1) not found, for SVG to PDF conversion install ImageMagick (https://www.imagemagick.org) kernel/resource.c:337: warning: Function parameter or member 'start' not described in 'find_next_iomem_res' kernel/resource.c:337: warning: Function parameter or member 'end' not described in 'find_next_iomem_res' kernel/resource.c:337: warning: Function parameter or member 'flags' not described in 'find_next_iomem_res' kernel/resource.c:337: warning: Function parameter or member 'desc' not described in 'find_next_iomem_res' kernel/resource.c:337: warning: Function parameter or member 'res' not described in 'find_next_iomem_res' block/genhd.c:526: warning: Function parameter or member 'devt' not described in 'blk_invalidate_devt' include/linux/srcu.h:175: warning: Function parameter or member 'p' not described in 'srcu_dereference_notrace' include/linux/srcu.h:175: warning: Function parameter or member 'sp' not described in 'srcu_dereference_notrace' include/linux/gfp.h:1: warning: no structured comments found include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.ibss' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.connect' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.keys' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.ie' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.ie_len' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.bssid' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.ssid' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.default_key' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.default_mgmt_key' not described in 'wireless_dev' include/net/cfg80211.h:4382: warning: Function parameter or member 'wext.prev_bssid_valid' not described in 'wireless_dev' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.units_pos' not described in 'ieee80211_hw' include/net/mac80211.h:2328: warning: Function parameter or member 'radiotap_timestamp.accuracy' not described in 'ieee80211_hw' include/net/mac80211.h:977: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.rts_cts_rate_idx' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_rts' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.use_cts_prot' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.short_preamble' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.skip_table' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.jiffies' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.vif' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.hw_key' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.flags' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'control.enqueue_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'ack.cookie' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_ack_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.ampdu_len' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.antenna' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.tx_time' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.is_valid_ack_signal' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'status.status_driver_data' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'driver_rates' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'pad' not described in 'ieee80211_tx_info' include/net/mac80211.h:977: warning: Function parameter or member 'rate_driver_data' not described in 'ieee80211_tx_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'rx_stats_avg.chain_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.filtered' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.retry_count' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.lost_packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_tdls_pkt_time' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_retries' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.msdu_failed' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.last_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.ack_signal_filled' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'status_stats.avg_ack_signal' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.packets' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.bytes' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.last_rate' not described in 'sta_info' net/mac80211/sta_info.h:588: warning: Function parameter or member 'tx_stats.msdu' not described in 'sta_info' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_excl.active' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.cb' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.poll' not described in 'dma_buf' include/linux/dma-buf.h:304: warning: Function parameter or member 'cb_shared.active' not described in 'dma_buf' include/linux/dma-fence-array.h:54: warning: Function parameter or member 'work' not described in 'dma_fence_array' include/linux/gpio/driver.h:149: warning: Function parameter or member 'request_key' not described in 'gpio_irq_chip' include/linux/i2c.h:343: warning: Function parameter or member 'init_irq' not described in 'i2c_client' include/linux/iio/hw-consumer.h:1: warning: no structured comments found drivers/base/node.c:78: warning: Function parameter or member 'hmem_attrs' not described in 'node_access_nodes' drivers/base/node.c:690: warning: Function parameter or member 'mem_nid' not described in 'register_memory_node_under_compute_node' drivers/base/node.c:690: warning: Function parameter or member 'cpu_nid' not described in 'register_memory_node_under_compute_node' drivers/base/node.c:690: warning: Excess function parameter 'mem_node' description in 'register_memory_node_under_compute_node' drivers/base/node.c:690: warning: Excess function parameter 'cpu_node' description in 'register_memory_node_under_compute_node' include/linux/input/sparse-keymap.h:46: warning: Function parameter or member 'sw' not described in 'key_entry' drivers/pci/pci.c:218: warning: Excess function parameter 'p' description in 'pci_dev_str_match_path' include/linux/regulator/driver.h:227: warning: Function parameter or member 'resume' not described in 'regulator_ops' drivers/regulator/core.c:4479: warning: Excess function parameter 'state' description in 'regulator_suspend' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw0' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw1' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw2' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.esw3' not described in 'irb' arch/s390/include/asm/cio.h:245: warning: Function parameter or member 'esw.eadm' not described in 'irb' drivers/slimbus/stream.c:1: warning: no structured comments found drivers/target/target_core_device.c:1: warning: no structured comments found drivers/usb/typec/bus.c:1: warning: no structured comments found drivers/usb/typec/class.c:1: warning: no structured comments found include/linux/w1.h:281: warning: Function parameter or member 'of_match_table' not described in 'w1_family' fs/direct-io.c:257: warning: Excess function parameter 'offset' description in 'dio_complete' fs/file_table.c:1: warning: no structured comments found fs/libfs.c:477: warning: Excess function parameter 'available' description in 'simple_write_end' fs/posix_acl.c:646: warning: Function parameter or member 'inode' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'mode_p' not described in 'posix_acl_update_mode' fs/posix_acl.c:646: warning: Function parameter or member 'acl' not described in 'posix_acl_update_mode' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:183: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_read_lock' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:254: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_gfx' drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:302: warning: Function parameter or member 'blockable' not described in 'amdgpu_mn_invalidate_range_start_hsa' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3012: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3013: warning: Function parameter or member 'adev' not described in 'amdgpu_vm_get_task_info' drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:3013: warning: Excess function parameter 'dev' description in 'amdgpu_vm_get_task_info' include/drm/drm_drv.h:610: warning: Function parameter or member 'gem_prime_pin' not described in 'drm_driver' vim +337 kernel/resource.c ^1da177e4c3f41 Linus Torvalds 2005-04-16 320 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 321 /** 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 322 * Finds the lowest iomem resource that covers part of [start..end]. The 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 323 * caller must specify start, end, flags, and desc (which may be 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 324 * IORES_DESC_NONE). 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 325 * 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 326 * If a resource is found, returns 0 and *res is overwritten with the part 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 327 * of the resource that's within [start..end]; if none is found, returns 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 328 * -1. 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 329 * 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 330 * This function walks the whole tree and not just first level children a7362a4df1f090 Borislav Petkov 2018-10-09 331 * unless @first_lvl is true. 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 332 */ 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 333 static int find_next_iomem_res(resource_size_t start, resource_size_t end, 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 334 unsigned long flags, unsigned long desc, a7362a4df1f090 Borislav Petkov 2018-10-09 335 bool first_lvl, struct resource *res) 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 336 { 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 @337 struct resource *p; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 338 a7362a4df1f090 Borislav Petkov 2018-10-09 339 if (!res) a7362a4df1f090 Borislav Petkov 2018-10-09 340 return -EINVAL; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 341 a7362a4df1f090 Borislav Petkov 2018-10-09 342 if (start >= end) a7362a4df1f090 Borislav Petkov 2018-10-09 343 return -EINVAL; 8c86e70acead62 Vivek Goyal 2014-08-08 344 800df627e2eaba Vivek Goyal 2014-08-29 345 read_lock(&resource_lock); 800df627e2eaba Vivek Goyal 2014-08-29 346 a7362a4df1f090 Borislav Petkov 2018-10-09 347 for (p = iomem_resource.child; p; p = next_resource(p, first_lvl)) { 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 348 if ((p->flags & flags) != flags) 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 349 continue; 3f33647c419624 Toshi Kani 2016-01-26 350 if ((desc != IORES_DESC_NONE) && (desc != p->desc)) 3f33647c419624 Toshi Kani 2016-01-26 351 continue; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 352 if (p->start > end) { 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 353 p = NULL; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 354 break; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 355 } 07c10a447c23cf Bjorn Helgaas 2018-09-27 356 if ((p->end >= start) && (p->start <= end)) 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 357 break; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 358 } 8c86e70acead62 Vivek Goyal 2014-08-08 359 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 360 read_unlock(&resource_lock); 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 361 if (!p) 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 362 return -1; 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 363 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 364 /* copy data */ 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 365 res->start = max(start, p->start); 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 366 res->end = min(end, p->end); 0e4c12b45aa88e Tom Lendacky 2017-10-20 367 res->flags = p->flags; 0e4c12b45aa88e Tom Lendacky 2017-10-20 368 res->desc = p->desc; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 369 return 0; 2842f11419704f KAMEZAWA Hiroyuki 2006-06-27 370 } 908eedc6168bd9 KAMEZAWA Hiroyuki 2009-09-22 371 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 372 static int __walk_iomem_res_desc(resource_size_t start, resource_size_t end, 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 373 unsigned long flags, unsigned long desc, a7362a4df1f090 Borislav Petkov 2018-10-09 374 bool first_lvl, void *arg, 1d2e733b13b450 Tom Lendacky 2017-10-20 375 int (*func)(struct resource *, void *)) 4ac2aed837cbdb Tom Lendacky 2017-10-20 376 { 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 377 struct resource res; 4ac2aed837cbdb Tom Lendacky 2017-10-20 378 int ret = -1; 4ac2aed837cbdb Tom Lendacky 2017-10-20 379 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 380 while (start < end && a7362a4df1f090 Borislav Petkov 2018-10-09 381 !find_next_iomem_res(start, end, flags, desc, first_lvl, &res)) { 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 382 ret = (*func)(&res, arg); 4ac2aed837cbdb Tom Lendacky 2017-10-20 383 if (ret) 4ac2aed837cbdb Tom Lendacky 2017-10-20 384 break; 4ac2aed837cbdb Tom Lendacky 2017-10-20 385 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 386 start = res.end + 1; 4ac2aed837cbdb Tom Lendacky 2017-10-20 387 } 4ac2aed837cbdb Tom Lendacky 2017-10-20 388 4ac2aed837cbdb Tom Lendacky 2017-10-20 389 return ret; 4ac2aed837cbdb Tom Lendacky 2017-10-20 390 } 4ac2aed837cbdb Tom Lendacky 2017-10-20 391 a7362a4df1f090 Borislav Petkov 2018-10-09 392 /** 8c86e70acead62 Vivek Goyal 2014-08-08 393 * Walks through iomem resources and calls func() with matching resource 8c86e70acead62 Vivek Goyal 2014-08-08 394 * ranges. This walks through whole tree and not just first level children. 8c86e70acead62 Vivek Goyal 2014-08-08 395 * All the memory ranges which overlap start,end and also match flags and 3f33647c419624 Toshi Kani 2016-01-26 396 * desc are valid candidates. 3f33647c419624 Toshi Kani 2016-01-26 397 * 3f33647c419624 Toshi Kani 2016-01-26 398 * @desc: I/O resource descriptor. Use IORES_DESC_NONE to skip @desc check. 3f33647c419624 Toshi Kani 2016-01-26 399 * @flags: I/O resource flags 3f33647c419624 Toshi Kani 2016-01-26 400 * @start: start addr 3f33647c419624 Toshi Kani 2016-01-26 401 * @end: end addr 3f33647c419624 Toshi Kani 2016-01-26 402 * 3f33647c419624 Toshi Kani 2016-01-26 403 * NOTE: For a new descriptor search, define a new IORES_DESC in 3f33647c419624 Toshi Kani 2016-01-26 404 * <linux/ioport.h> and set it in 'desc' of a target resource entry. 3f33647c419624 Toshi Kani 2016-01-26 405 */ 3f33647c419624 Toshi Kani 2016-01-26 406 int walk_iomem_res_desc(unsigned long desc, unsigned long flags, u64 start, 1d2e733b13b450 Tom Lendacky 2017-10-20 407 u64 end, void *arg, int (*func)(struct resource *, void *)) 3f33647c419624 Toshi Kani 2016-01-26 408 { 1f908f1c7fa49c Bjorn Helgaas 2018-09-27 @409 return __walk_iomem_res_desc(start, end, flags, desc, false, arg, func); 3f33647c419624 Toshi Kani 2016-01-26 410 } d76401ade0bb6a Dan Williams 2018-06-02 411 EXPORT_SYMBOL_GPL(walk_iomem_res_desc); 3f33647c419624 Toshi Kani 2016-01-26 412 :::::: The code at line 337 was first introduced by commit :::::: 2842f11419704f8707fffc82e10d2263427fc130 [PATCH] catch valid mem range at onlining memory :::::: TO: KAMEZAWA Hiroyuki <kamezawa.hiroyu(a)jp.fujitsu.com&gt; :::::: CC: Linus Torvalds <torvalds(a)g5.osdl.org&gt; --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation