Hi Bartlomiej,
I love your patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on mkp-scsi/for-next scsi/for-next v5.6-rc3 next-20200228]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see
https://stackoverflow.com/a/37406982]
url:
https://github.com/0day-ci/linux/commits/Bartlomiej-Zolnierkiewicz/ata-op...
base:
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
reproduce:
# apt-get install sparse
# sparse version: v0.6.1-173-ge0787745-dirty
make ARCH=x86_64 allmodconfig
make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
sparse warnings: (new ones prefixed by >>)
drivers/ata/sata_dwc_460ex.c:1152:9: sparse: sparse: Initializer entry defined twice
> drivers/ata/sata_dwc_460ex.c:1152:9: sparse: also defined here
vim +1152 drivers/ata/sata_dwc_460ex.c
a7e6de544c5c23 Christian Lamparter 2016-04-26 1147
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1148 /*
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1149 * scsi mid-layer and libata
interface structures
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1150 */
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1151 static struct scsi_host_template
sata_dwc_sht = {
62936009f35a66 Rupjyoti Sarmah 2010-07-06 @1152 ATA_NCQ_SHT(DRV_NAME),
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1153 /*
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1154 * test-only: Currently this driver
doesn't handle NCQ
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1155 * correctly. We enable NCQ but set
the queue depth to a
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1156 * max of 1. This will get fixed in
in a future release.
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1157 */
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1158 .sg_tablesize = LIBATA_MAX_PRD,
d7c256e857c125 Andy Shevchenko 2015-01-07 1159 /* .can_queue = ATA_MAX_QUEUE, */
6689dfac00ef31 Andy Shevchenko 2016-04-26 1160 /*
6689dfac00ef31 Andy Shevchenko 2016-04-26 1161 * Make sure a LLI block is not
created that will span 8K max FIS
6689dfac00ef31 Andy Shevchenko 2016-04-26 1162 * boundary. If the block spans such
a FIS boundary, there is a chance
6689dfac00ef31 Andy Shevchenko 2016-04-26 1163 * that a DMA burst will cross that
boundary -- this results in an
6689dfac00ef31 Andy Shevchenko 2016-04-26 1164 * error in the host controller.
6689dfac00ef31 Andy Shevchenko 2016-04-26 1165 */
6689dfac00ef31 Andy Shevchenko 2016-04-26 1166 .dma_boundary = 0x1fff /*
ATA_DMA_BOUNDARY */,
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1167 };
62936009f35a66 Rupjyoti Sarmah 2010-07-06 1168
:::::: The code at line 1152 was first introduced by commit
:::::: 62936009f35a6659cc3ebe0d90c754182d60da73 [libata] Add 460EX on-chip SATA driver,
sata_dwc_460ex
:::::: TO: Rupjyoti Sarmah <rsarmah(a)amcc.com>
:::::: CC: Jeff Garzik <jgarzik(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org