Re: [PATCH v3] include: linux: Reorganize timekeeping and ktime headers
by kernel test robot
Hi Carlos,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/timers/core]
[also build test WARNING on kvmarm/next abelloni/rtc-next sound/for-next soc/for-next linus/master tip/x86/core v5.14-rc2 next-20210722]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Carlos-Bilbao/include-linux-Reor...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 2d0a9eb23ccfdf11308bec6db0bc007585d919d2
config: ia64-buildonly-randconfig-r004-20210722 (attached as .config)
compiler: ia64-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/e35011219261f218feeaea55c97d4d583...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Carlos-Bilbao/include-linux-Reorganize-timekeeping-and-ktime-headers/20210722-233301
git checkout e35011219261f218feeaea55c97d4d583d9747a9
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
arch/ia64/kernel/time.c: In function 'timer_interrupt':
arch/ia64/kernel/time.c:190:3: error: implicit declaration of function 'legacy_timer_tick' [-Werror=implicit-function-declaration]
190 | legacy_timer_tick(smp_processor_id() == time_keeper_id);
| ^~~~~~~~~~~~~~~~~
arch/ia64/kernel/time.c: At top level:
arch/ia64/kernel/time.c:259:6: warning: no previous prototype for 'ia64_init_itm' [-Wmissing-prototypes]
259 | void ia64_init_itm(void)
| ^~~~~~~~~~~~~
>> arch/ia64/kernel/time.c:390:6: warning: no previous prototype for 'read_persistent_clock64' [-Wmissing-prototypes]
390 | void read_persistent_clock64(struct timespec64 *ts)
| ^~~~~~~~~~~~~~~~~~~~~~~
arch/ia64/kernel/time.c:396:1: warning: no previous prototype for 'time_init' [-Wmissing-prototypes]
396 | time_init (void)
| ^~~~~~~~~
cc1: some warnings being treated as errors
--
>> kernel/time/tick-legacy.c:25:6: warning: no previous prototype for 'legacy_timer_tick' [-Wmissing-prototypes]
25 | void legacy_timer_tick(unsigned long ticks)
| ^~~~~~~~~~~~~~~~~
vim +/legacy_timer_tick +25 kernel/time/tick-legacy.c
b3550164a19d62 Arnd Bergmann 2020-09-24 12
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 13 /**
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 14 * legacy_timer_tick() - advances the timekeeping infrastructure
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 15 * @ticks: number of ticks, that have elapsed since the last call.
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 16 *
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 17 * This is used by platforms that have not been converted to
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 18 * generic clockevents.
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 19 *
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 20 * If 'ticks' is zero, the CPU is not handling timekeeping, so
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 21 * only perform process accounting and profiling.
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 22 *
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 23 * Must be called with interrupts disabled.
56cc7b8acfb7c7 Arnd Bergmann 2020-09-24 24 */
b3550164a19d62 Arnd Bergmann 2020-09-24 @25 void legacy_timer_tick(unsigned long ticks)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
Re: [PATCH 3/3] mm: don't remap clean subpages when splitting isolated thp
by kernel test robot
Hi Yu,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.14-rc3]
[cannot apply to hnaz-linux-mm/master linux/master next-20210730]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Yu-Zhao/mm-optimize-thp-for-recl...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git c7d102232649226a69dddd58a4942cf13cff4f7c
config: i386-randconfig-a003-20210730 (attached as .config)
compiler: gcc-10 (Ubuntu 10.3.0-1ubuntu1~20.04) 10.3.0
reproduce (this is a W=1 build):
# https://github.com/0day-ci/linux/commit/e4e76c4915b364558aacae2cf320a4330...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yu-Zhao/mm-optimize-thp-for-reclaim-and-migration/20210731-144129
git checkout e4e76c4915b364558aacae2cf320a43306a20fa1
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
mm/migrate.c: In function 'try_to_unmap_clean':
>> mm/migrate.c:199:17: error: 'THP_SPLIT_UNMAP' undeclared (first use in this function)
199 | count_vm_event(THP_SPLIT_UNMAP);
| ^~~~~~~~~~~~~~~
mm/migrate.c:199:17: note: each undeclared identifier is reported only once for each function it appears in
vim +/THP_SPLIT_UNMAP +199 mm/migrate.c
170
171 static bool try_to_unmap_clean(struct page_vma_mapped_walk *pvmw, struct page *page)
172 {
173 void *addr;
174 bool dirty;
175
176 VM_BUG_ON_PAGE(PageLRU(page), page);
177 VM_BUG_ON_PAGE(PageCompound(page), page);
178 VM_BUG_ON_PAGE(!PageAnon(page), page);
179 VM_BUG_ON_PAGE(!PageLocked(page), page);
180 VM_BUG_ON_PAGE(pte_present(*pvmw->pte), page);
181
182 if (PageMlocked(page) || (pvmw->vma->vm_flags & VM_LOCKED))
183 return false;
184
185 /*
186 * The pmd entry mapping the old thp was flushed and the pte mapping
187 * this subpage has been non present. Therefore, this subpage is
188 * inaccessible. We don't need to remap it if it contains only zeros.
189 */
190 addr = kmap_atomic(page);
191 dirty = !!memchr_inv(addr, 0, PAGE_SIZE);
192 kunmap_atomic(addr);
193
194 if (dirty)
195 return false;
196
197 pte_clear_not_present_full(pvmw->vma->vm_mm, pvmw->address, pvmw->pte, false);
198 dec_mm_counter(pvmw->vma->vm_mm, mm_counter(page));
> 199 count_vm_event(THP_SPLIT_UNMAP);
200
201 return true;
202 }
203
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
xillybus_of.c:undefined reference to `devm_platform_ioremap_resource'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: c7d102232649226a69dddd58a4942cf13cff4f7c
commit: a1315dcb7b6a7d3a78df848eed5b331a4b3ec28a hwrng: ks-sa - Add dependency on IOMEM and OF
date: 8 months ago
config: s390-buildonly-randconfig-r001-20210730 (attached as .config)
compiler: s390-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a1315dcb7b6a7d3a78df848eed5b331a4b3ec28a
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=s390 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390-linux-ld: kernel/dma/coherent.o: in function `dma_init_coherent_memory':
coherent.c:(.text+0x50c): undefined reference to `memremap'
s390-linux-ld: coherent.c:(.text+0x5f8): undefined reference to `memunmap'
s390-linux-ld: kernel/dma/coherent.o: in function `dma_declare_coherent_memory':
coherent.c:(.text+0x7c8): undefined reference to `memunmap'
s390-linux-ld: drivers/irqchip/irq-al-fic.o: in function `al_fic_init_dt':
irq-al-fic.c:(.init.text+0x60): undefined reference to `of_iomap'
s390-linux-ld: irq-al-fic.c:(.init.text+0x1f6): undefined reference to `iounmap'
s390-linux-ld: drivers/irqchip/irq-imx-intmux.o: in function `imx_intmux_probe':
irq-imx-intmux.c:(.text+0x78c): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/phy/marvell/phy-mvebu-a3700-utmi.o: in function `mvebu_a3700_utmi_phy_probe':
phy-mvebu-a3700-utmi.c:(.text+0x4c6): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/soc/fsl/dpaa2-console.o: in function `dpaa2_console_close':
dpaa2-console.c:(.text+0x84): undefined reference to `iounmap'
s390-linux-ld: drivers/soc/fsl/dpaa2-console.o: in function `dpaa2_console_probe':
dpaa2-console.c:(.text+0xe0): undefined reference to `of_address_to_resource'
s390-linux-ld: drivers/soc/fsl/dpaa2-console.o: in function `dpaa2_generic_console_open.constprop.0':
dpaa2-console.c:(.text+0x234): undefined reference to `ioremap'
s390-linux-ld: dpaa2-console.c:(.text+0x26a): undefined reference to `iounmap'
s390-linux-ld: dpaa2-console.c:(.text+0x284): undefined reference to `ioremap'
s390-linux-ld: dpaa2-console.c:(.text+0x3ec): undefined reference to `iounmap'
s390-linux-ld: drivers/char/hw_random/exynos-trng.o: in function `exynos_trng_probe':
exynos-trng.c:(.text+0x298): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/char/hw_random/meson-rng.o: in function `meson_rng_probe':
meson-rng.c:(.text+0xbc): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/char/hw_random/mtk-rng.o: in function `mtk_rng_probe':
mtk-rng.c:(.text+0x2e0): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/char/hw_random/npcm-rng.o: in function `npcm_rng_probe':
npcm-rng.c:(.text+0x2ae): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/char/xillybus/xillybus_of.o: in function `xilly_drv_probe':
>> xillybus_of.c:(.text+0x1dc): undefined reference to `devm_platform_ioremap_resource'
s390-linux-ld: drivers/ptp/ptp_qoriq.o: in function `ptp_qoriq_probe':
ptp_qoriq.c:(.text+0x130e): undefined reference to `ioremap'
s390-linux-ld: ptp_qoriq.c:(.text+0x1374): undefined reference to `iounmap'
s390-linux-ld: drivers/ptp/ptp_qoriq.o: in function `ptp_qoriq_free':
ptp_qoriq.c:(.text+0x14cc): undefined reference to `iounmap'
s390-linux-ld: drivers/watchdog/sirfsoc_wdt.o: in function `sirfsoc_wdt_probe':
sirfsoc_wdt.c:(.text+0x180): undefined reference to `devm_platform_ioremap_resource'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
[pinchartl-media:drm/du/compile-test 7/12] dcss-scaler.c:undefined reference to `__aeabi_ldivmod'
by kernel test robot
tree: git://linuxtv.org/pinchartl/media.git drm/du/compile-test
head: e5afcf496f9bd487419c7ee0c258da75d0d1dae6
commit: 63a1b5069c9f428592e841ad8c8f7bc5c9974819 [7/12] drm/imx/dcss: Enable COMPILE_TEST on all architectures
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add pinchartl-media git://linuxtv.org/pinchartl/media.git
git fetch --no-tags pinchartl-media drm/du/compile-test
git checkout 63a1b5069c9f428592e841ad8c8f7bc5c9974819
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross O=build_dir ARCH=arm SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: drivers/gpu/drm/imx/dcss/dcss-scaler.o: in function `dcss_scaler_gaussian_filter':
>> dcss-scaler.c:(.text+0xdc): undefined reference to `__aeabi_ldivmod'
>> arm-linux-gnueabi-ld: dcss-scaler.c:(.text+0x150): undefined reference to `__aeabi_ldivmod'
arm-linux-gnueabi-ld: dcss-scaler.c:(.text+0x1f4): undefined reference to `__aeabi_ldivmod'
arm-linux-gnueabi-ld: dcss-scaler.c:(.text+0x2d0): undefined reference to `__aeabi_ldivmod'
arm-linux-gnueabi-ld: dcss-scaler.c:(.text+0x51c): undefined reference to `__aeabi_ldivmod'
arm-linux-gnueabi-ld: drivers/gpu/drm/imx/dcss/dcss-scaler.o:dcss-scaler.c:(.text+0x69c): more undefined references to `__aeabi_ldivmod' follow
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
[pinchartl-media:drm/du/compile-test 8/12] drivers/gpu/drm/omapdrm/omap_gem.c:986:21: error: implicit declaration of function 'vmap'; did you mean 'kmap'?
by kernel test robot
tree: git://linuxtv.org/pinchartl/media.git drm/du/compile-test
head: e5afcf496f9bd487419c7ee0c258da75d0d1dae6
commit: 64940a5f2f2156bc2718679b6248c0b32566983b [8/12] drm/omap: Enable COMPILE_TEST on all architectures
config: parisc-allyesconfig (attached as .config)
compiler: hppa-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git remote add pinchartl-media git://linuxtv.org/pinchartl/media.git
git fetch --no-tags pinchartl-media drm/du/compile-test
git checkout 64940a5f2f2156bc2718679b6248c0b32566983b
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=parisc
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_vaddr':
>> drivers/gpu/drm/omapdrm/omap_gem.c:986:21: error: implicit declaration of function 'vmap'; did you mean 'kmap'? [-Werror=implicit-function-declaration]
986 | omap_obj->vaddr = vmap(omap_obj->pages, obj->size >> PAGE_SHIFT,
| ^~~~
| kmap
>> drivers/gpu/drm/omapdrm/omap_gem.c:987:5: error: 'VM_MAP' undeclared (first use in this function); did you mean 'VM_MTE'?
987 | VM_MAP, pgprot_writecombine(PAGE_KERNEL));
| ^~~~~~
| VM_MTE
drivers/gpu/drm/omapdrm/omap_gem.c:987:5: note: each undeclared identifier is reported only once for each function it appears in
drivers/gpu/drm/omapdrm/omap_gem.c: In function 'omap_gem_free_object':
>> drivers/gpu/drm/omapdrm/omap_gem.c:1126:3: error: implicit declaration of function 'vunmap'; did you mean 'kunmap'? [-Werror=implicit-function-declaration]
1126 | vunmap(omap_obj->vaddr);
| ^~~~~~
| kunmap
cc1: some warnings being treated as errors
vim +986 drivers/gpu/drm/omapdrm/omap_gem.c
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 965
e1c1174f8d5602 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 966 #ifdef CONFIG_DRM_FBDEV_EMULATION
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 967 /*
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 968 * Get kernel virtual address for CPU access.. this more or less only
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 969 * exists for omap_fbdev.
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 970 */
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 971 void *omap_gem_vaddr(struct drm_gem_object *obj)
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 972 {
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 973 struct omap_gem_object *omap_obj = to_omap_bo(obj);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 974 void *vaddr;
620063e10ed48c drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-25 975 int ret;
620063e10ed48c drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-25 976
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 977 mutex_lock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 978
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 979 if (!omap_obj->vaddr) {
2491244d7709d4 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-25 980 ret = omap_gem_attach_pages(obj);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 981 if (ret) {
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 982 vaddr = ERR_PTR(ret);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 983 goto unlock;
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 984 }
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 985
2491244d7709d4 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-25 @986 omap_obj->vaddr = vmap(omap_obj->pages, obj->size >> PAGE_SHIFT,
f7f9f4536a09f9 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-12-05 @987 VM_MAP, pgprot_writecombine(PAGE_KERNEL));
f7f9f4536a09f9 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-12-05 988 }
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 989
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 990 vaddr = omap_obj->vaddr;
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 991
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 992 unlock:
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 993 mutex_unlock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 994 return vaddr;
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 995 }
e1c1174f8d5602 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 996 #endif
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 997
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 998 /* -----------------------------------------------------------------------------
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 999 * Power Management
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1000 */
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1001
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1002 #ifdef CONFIG_PM
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1003 /* re-pin objects in DMM in resume path: */
7fb15c480eea29 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2017-10-13 1004 int omap_gem_resume(struct drm_device *dev)
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1005 {
7fb15c480eea29 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2017-10-13 1006 struct omap_drm_private *priv = dev->dev_private;
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1007 struct omap_gem_object *omap_obj;
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1008 int ret = 0;
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1009
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1010 mutex_lock(&priv->list_lock);
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1011 list_for_each_entry(omap_obj, &priv->obj_list, mm_list) {
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1012 if (omap_obj->block) {
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1013 struct drm_gem_object *obj = &omap_obj->base;
dfe9cfccb26488 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-02-11 1014 u32 npages = obj->size >> PAGE_SHIFT;
dfe9cfccb26488 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-02-11 1015
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1016 WARN_ON(!omap_obj->pages); /* this can't happen */
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1017 ret = tiler_pin(omap_obj->block,
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1018 omap_obj->pages, npages,
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1019 omap_obj->roll, true);
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1020 if (ret) {
7fb15c480eea29 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2017-10-13 1021 dev_err(dev->dev, "could not repin: %d\n", ret);
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1022 goto done;
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1023 }
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1024 }
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1025 }
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1026
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1027 done:
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1028 mutex_unlock(&priv->list_lock);
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1029 return ret;
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1030 }
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1031 #endif
e78edba113086d drivers/staging/omapdrm/omap_gem.c Andy Gross 2012-12-19 1032
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1033 /* -----------------------------------------------------------------------------
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1034 * DebugFS
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1035 */
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1036
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1037 #ifdef CONFIG_DEBUG_FS
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1038 void omap_gem_describe(struct drm_gem_object *obj, struct seq_file *m)
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1039 {
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1040 struct omap_gem_object *omap_obj = to_omap_bo(obj);
dfe9cfccb26488 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-02-11 1041 u64 off;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1042
0de23977cfeb5b drivers/gpu/drm/omapdrm/omap_gem.c David Herrmann 2013-07-24 1043 off = drm_vma_node_start(&obj->vma_node);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1044
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1045 mutex_lock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1046
2d31ca3ad7d5d4 drivers/gpu/drm/omapdrm/omap_gem.c Russell King 2014-07-12 1047 seq_printf(m, "%08x: %2d (%2d) %08llx %pad (%2d) %p %4d",
2c935bc57221cc drivers/gpu/drm/omapdrm/omap_gem.c Peter Zijlstra 2016-11-14 1048 omap_obj->flags, obj->name, kref_read(&obj->refcount),
cec4fa7511ef7a drivers/gpu/drm/omapdrm/omap_gem.c Jean-Jacques Hiblot 2019-10-10 1049 off, &omap_obj->dma_addr,
cec4fa7511ef7a drivers/gpu/drm/omapdrm/omap_gem.c Jean-Jacques Hiblot 2019-10-10 1050 refcount_read(&omap_obj->dma_addr_cnt),
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1051 omap_obj->vaddr, omap_obj->roll);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1052
48b34ac041756c drivers/gpu/drm/omapdrm/omap_gem.c Tomi Valkeinen 2019-10-10 1053 if (omap_obj->flags & OMAP_BO_TILED_MASK) {
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1054 seq_printf(m, " %dx%d", omap_obj->width, omap_obj->height);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1055 if (omap_obj->block) {
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1056 struct tcm_area *area = &omap_obj->block->area;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1057 seq_printf(m, " (%dx%d, %dx%d)",
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1058 area->p0.x, area->p0.y,
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1059 area->p1.x, area->p1.y);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1060 }
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1061 } else {
2150c19b15b014 drivers/gpu/drm/omapdrm/omap_gem.c Tomi Valkeinen 2017-02-21 1062 seq_printf(m, " %zu", obj->size);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1063 }
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1064
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1065 mutex_unlock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1066
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1067 seq_printf(m, "\n");
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1068 }
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1069
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1070 void omap_gem_describe_objects(struct list_head *list, struct seq_file *m)
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1071 {
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1072 struct omap_gem_object *omap_obj;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1073 int count = 0;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1074 size_t size = 0;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1075
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1076 list_for_each_entry(omap_obj, list, mm_list) {
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1077 struct drm_gem_object *obj = &omap_obj->base;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1078 seq_printf(m, " ");
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1079 omap_gem_describe(obj, m);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1080 count++;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1081 size += obj->size;
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1082 }
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1083
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1084 seq_printf(m, "Total %d objects, %zu bytes\n", count, size);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1085 }
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1086 #endif
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1087
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1088 /* -----------------------------------------------------------------------------
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1089 * Constructor & Destructor
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1090 */
7ef93b0aa85dd1 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1091
c5ca5e029fa64b drivers/gpu/drm/omapdrm/omap_gem.c Thomas Zimmermann 2020-09-23 1092 static void omap_gem_free_object(struct drm_gem_object *obj)
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1093 {
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1094 struct drm_device *dev = obj->dev;
76c4055f2c9a7a drivers/gpu/drm/omapdrm/omap_gem.c Tomi Valkeinen 2014-12-17 1095 struct omap_drm_private *priv = dev->dev_private;
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1096 struct omap_gem_object *omap_obj = to_omap_bo(obj);
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1097
620063e10ed48c drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-25 1098 omap_gem_evict(obj);
f7f9f4536a09f9 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-12-05 1099
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1100 mutex_lock(&priv->list_lock);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1101 list_del(&omap_obj->mm_list);
5117bd898e8c0a drivers/gpu/drm/omapdrm/omap_gem.c Daniel Vetter 2018-05-25 1102 mutex_unlock(&priv->list_lock);
f6b6036e56ca17 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-03-05 1103
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1104 /*
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1105 * We own the sole reference to the object at this point, but to keep
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1106 * lockdep happy, we must still take the omap_obj_lock to call
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1107 * omap_gem_detach_pages(). This should hardly make any difference as
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1108 * there can't be any lock contention.
9a0774e0991c82 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-01-16 1109 */
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1110 mutex_lock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1111
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1112 /* The object should not be pinned. */
cec4fa7511ef7a drivers/gpu/drm/omapdrm/omap_gem.c Jean-Jacques Hiblot 2019-10-10 1113 WARN_ON(refcount_read(&omap_obj->dma_addr_cnt) > 0);
9a0774e0991c82 drivers/staging/omapdrm/omap_gem.c Rob Clark 2012-01-16 1114
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1115 if (omap_obj->pages) {
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1116 if (omap_obj->flags & OMAP_BO_MEM_DMABUF)
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1117 kfree(omap_obj->pages);
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1118 else
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1119 omap_gem_detach_pages(obj);
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1120 }
ae053039553349 drivers/staging/omapdrm/omap_gem.c YAMANE Toshiaki 2012-11-14 1121
cdb0381d2f1997 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1122 if (omap_obj->flags & OMAP_BO_MEM_DMA_API) {
f6e45661f9be54 drivers/gpu/drm/omapdrm/omap_gem.c Luis R. Rodriguez 2016-01-22 1123 dma_free_wc(dev->dev, obj->size, omap_obj->vaddr,
16869083b9bec8 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2017-04-21 1124 omap_obj->dma_addr);
f7f9f4536a09f9 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-12-05 1125 } else if (omap_obj->vaddr) {
f7f9f4536a09f9 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-12-05 @1126 vunmap(omap_obj->vaddr);
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1127 } else if (obj->import_attach) {
b22e6690a3f656 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1128 drm_prime_gem_destroy(obj, omap_obj->sgt);
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1129 }
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1130
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1131 mutex_unlock(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1132
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1133 drm_gem_object_release(obj);
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1134
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1135 mutex_destroy(&omap_obj->lock);
3cbd0c587b129b drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2018-05-26 1136
00e9c7c7002de3 drivers/gpu/drm/omapdrm/omap_gem.c Laurent Pinchart 2015-12-14 1137 kfree(omap_obj);
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1138 }
cd5351f4d2b1b8 drivers/staging/omapdrm/omap_gem.c Rob Clark 2011-11-12 1139
:::::: The code at line 986 was first introduced by commit
:::::: 2491244d7709d4e35f61d75ed3f6b4ea31b0a6f3 drm/omap: gem: Merge __omap_gem_get_pages() and omap_gem_attach_pages()
:::::: TO: Laurent Pinchart <laurent.pinchart(a)ideasonboard.com>
:::::: CC: Tomi Valkeinen <tomi.valkeinen(a)ti.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year
[linux-next:master 3254/4668] drivers/firmware/efi/sysfb_efi.c:190:35: warning: unused variable 'efifb_dmi_system_table'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 8d4b477da1a807199ca60e0829357ce7aa6758d5
commit: 15d27b15de965043d6f8e23bc7f34386fcd1a772 [3254/4668] efi: sysfb_efi: fix build when EFI is not set
config: x86_64-randconfig-r004-20210730 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project 4f71f59bf3d9914188a11d0c41bedbb339d36ff5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 15d27b15de965043d6f8e23bc7f34386fcd1a772
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/firmware/efi/sysfb_efi.c:72:6: warning: no previous prototype for function 'efifb_setup_from_dmi' [-Wmissing-prototypes]
void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
^
drivers/firmware/efi/sysfb_efi.c:72:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
^
static
>> drivers/firmware/efi/sysfb_efi.c:190:35: warning: unused variable 'efifb_dmi_system_table' [-Wunused-const-variable]
static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
^
>> drivers/firmware/efi/sysfb_efi.c:240:35: warning: unused variable 'efifb_dmi_swap_width_height' [-Wunused-const-variable]
static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
^
>> drivers/firmware/efi/sysfb_efi.c:331:39: warning: unused variable 'efifb_fwnode_ops' [-Wunused-const-variable]
static const struct fwnode_operations efifb_fwnode_ops = {
^
4 warnings generated.
vim +/efifb_dmi_system_table +190 drivers/firmware/efi/sysfb_efi.c
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 71
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 @72 void efifb_setup_from_dmi(struct screen_info *si, const char *opt)
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 73 {
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 74 int i;
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 75
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 76 for (i = 0; i < M_UNKNOWN; i++) {
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 77 if (efifb_dmi_list[i].base != 0 &&
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 78 !strcmp(opt, efifb_dmi_list[i].optname)) {
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 79 si->lfb_base = efifb_dmi_list[i].base;
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 80 si->lfb_linelength = efifb_dmi_list[i].stride;
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 81 si->lfb_width = efifb_dmi_list[i].width;
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 82 si->lfb_height = efifb_dmi_list[i].height;
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 83 }
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 84 }
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 85 }
21289ec02b41c4 arch/x86/kernel/sysfb_efi.c Ard Biesheuvel 2016-04-25 86
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 87 #define choose_value(dmivalue, fwvalue, field, flags) ({ \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 88 typeof(fwvalue) _ret_ = fwvalue; \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 89 if ((flags) & (field)) \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 90 _ret_ = dmivalue; \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 91 else if ((fwvalue) == 0) \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 92 _ret_ = dmivalue; \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 93 _ret_; \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 94 })
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 95
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 96 static int __init efifb_set_system(const struct dmi_system_id *id)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 97 {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 98 struct efifb_dmi_info *info = id->driver_data;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 99
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 100 if (info->base == 0 && info->height == 0 && info->width == 0 &&
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 101 info->stride == 0)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 102 return 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 103
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 104 /* Trust the bootloader over the DMI tables */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 105 if (screen_info.lfb_base == 0) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 106 #if defined(CONFIG_PCI)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 107 struct pci_dev *dev = NULL;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 108 int found_bar = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 109 #endif
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 110 if (info->base) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 111 screen_info.lfb_base = choose_value(info->base,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 112 screen_info.lfb_base, OVERRIDE_BASE,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 113 info->flags);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 114
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 115 #if defined(CONFIG_PCI)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 116 /* make sure that the address in the table is actually
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 117 * on a VGA device's PCI BAR */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 118
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 119 for_each_pci_dev(dev) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 120 int i;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 121 if ((dev->class >> 8) != PCI_CLASS_DISPLAY_VGA)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 122 continue;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 123 for (i = 0; i < DEVICE_COUNT_RESOURCE; i++) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 124 resource_size_t start, end;
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 125 unsigned long flags;
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 126
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 127 flags = pci_resource_flags(dev, i);
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 128 if (!(flags & IORESOURCE_MEM))
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 129 continue;
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 130
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 131 if (flags & IORESOURCE_UNSET)
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 132 continue;
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 133
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 134 if (pci_resource_len(dev, i) == 0)
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 135 continue;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 136
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 137 start = pci_resource_start(dev, i);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 138 end = pci_resource_end(dev, i);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 139 if (screen_info.lfb_base >= start &&
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 140 screen_info.lfb_base < end) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 141 found_bar = 1;
c10fcb14c7afd6 arch/x86/kernel/sysfb_efi.c Wang YanQing 2016-05-05 142 break;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 143 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 144 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 145 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 146 if (!found_bar)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 147 screen_info.lfb_base = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 148 #endif
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 149 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 150 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 151 if (screen_info.lfb_base) {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 152 screen_info.lfb_linelength = choose_value(info->stride,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 153 screen_info.lfb_linelength, OVERRIDE_STRIDE,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 154 info->flags);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 155 screen_info.lfb_width = choose_value(info->width,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 156 screen_info.lfb_width, OVERRIDE_WIDTH,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 157 info->flags);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 158 screen_info.lfb_height = choose_value(info->height,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 159 screen_info.lfb_height, OVERRIDE_HEIGHT,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 160 info->flags);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 161 if (screen_info.orig_video_isVGA == 0)
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 162 screen_info.orig_video_isVGA = VIDEO_TYPE_EFI;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 163 } else {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 164 screen_info.lfb_linelength = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 165 screen_info.lfb_width = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 166 screen_info.lfb_height = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 167 screen_info.orig_video_isVGA = 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 168 return 0;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 169 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 170
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 171 printk(KERN_INFO "efifb: dmi detected %s - framebuffer at 0x%08x "
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 172 "(%dx%d, stride %d)\n", id->ident,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 173 screen_info.lfb_base, screen_info.lfb_width,
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 174 screen_info.lfb_height, screen_info.lfb_linelength);
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 175
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 176 return 1;
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 177 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 178
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 179 #define EFIFB_DMI_SYSTEM_ID(vendor, name, enumid) \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 180 { \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 181 efifb_set_system, \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 182 name, \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 183 { \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 184 DMI_MATCH(DMI_BIOS_VENDOR, vendor), \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 185 DMI_MATCH(DMI_PRODUCT_NAME, name) \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 186 }, \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 187 &efifb_dmi_list[enumid] \
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 188 }
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 189
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 @190 static const struct dmi_system_id efifb_dmi_system_table[] __initconst = {
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 191 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "iMac4,1", M_I17),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 192 /* At least one of these two will be right; maybe both? */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 193 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "iMac5,1", M_I20),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 194 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac5,1", M_I20),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 195 /* At least one of these two will be right; maybe both? */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 196 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "iMac6,1", M_I24),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 197 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac6,1", M_I24),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 198 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac7,1", M_I20_SR),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 199 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac8,1", M_I24_8_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 200 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac10,1", M_I24_10_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 201 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "iMac11,1", M_I27_11_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 202 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "Macmini1,1", M_MINI),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 203 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "Macmini3,1", M_MINI_3_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 204 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "Macmini4,1", M_MINI_4_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 205 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBook1,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 206 /* At least one of these two will be right; maybe both? */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 207 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBook2,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 208 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook2,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 209 /* At least one of these two will be right; maybe both? */
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 210 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBook3,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 211 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook3,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 212 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook4,1", M_MB),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 213 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook5,1", M_MB_5_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 214 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook6,1", M_MB_6_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 215 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBook7,1", M_MB_7_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 216 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookAir1,1", M_MBA),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 217 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookAir3,1", M_MBA_3),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 218 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBookPro1,1", M_MBP),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 219 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBookPro2,1", M_MBP_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 220 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBookPro2,2", M_MBP_2_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 221 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro2,1", M_MBP_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 222 EFIFB_DMI_SYSTEM_ID("Apple Computer, Inc.", "MacBookPro3,1", M_MBP_SR),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 223 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro3,1", M_MBP_SR),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 224 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro4,1", M_MBP_4),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 225 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro5,1", M_MBP_5_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 226 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro5,2", M_MBP_5_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 227 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro5,3", M_MBP_5_3),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 228 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro6,1", M_MBP_6_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 229 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro6,2", M_MBP_6_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 230 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro7,1", M_MBP_7_1),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 231 EFIFB_DMI_SYSTEM_ID("Apple Inc.", "MacBookPro8,2", M_MBP_8_2),
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 232 {},
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 233 };
2995e506276bfd arch/x86/kernel/sysfb_efi.c David Herrmann 2013-08-02 234
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 235 /*
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 236 * Some devices have a portrait LCD but advertise a landscape resolution (and
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 237 * pitch). We simply swap width and height for these devices so that we can
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 238 * correctly deal with some of them coming with multiple resolutions.
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 239 */
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 @240 static const struct dmi_system_id efifb_dmi_swap_width_height[] __initconst = {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 241 {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 242 /*
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 243 * Lenovo MIIX310-10ICR, only some batches have the troublesome
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 244 * 800x1280 portrait screen. Luckily the portrait version has
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 245 * its own BIOS version, so we match on that.
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 246 */
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 247 .matches = {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 248 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 249 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION, "MIIX 310-10ICR"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 250 DMI_EXACT_MATCH(DMI_BIOS_VERSION, "1HCN44WW"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 251 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 252 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 253 {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 254 /* Lenovo MIIX 320-10ICR with 800x1280 portrait screen */
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 255 .matches = {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 256 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 257 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 258 "Lenovo MIIX 320-10ICR"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 259 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 260 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 261 {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 262 /* Lenovo D330 with 800x1280 or 1200x1920 portrait screen */
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 263 .matches = {
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 264 DMI_EXACT_MATCH(DMI_SYS_VENDOR, "LENOVO"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 265 DMI_EXACT_MATCH(DMI_PRODUCT_VERSION,
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 266 "Lenovo ideapad D330-10IGM"),
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 267 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 268 },
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 269 {},
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 270 };
d02f1aa39189e0 arch/x86/kernel/sysfb_efi.c Hans de Goede 2019-07-21 271
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 272 static bool efifb_overlaps_pci_range(const struct of_pci_range *range)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 273 {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 274 u64 fb_base = screen_info.lfb_base;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 275
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 276 if (screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 277 fb_base |= (u64)(unsigned long)screen_info.ext_lfb_base << 32;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 278
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 279 return fb_base >= range->cpu_addr &&
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 280 fb_base < (range->cpu_addr + range->size);
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 281 }
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 282
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 283 static struct device_node *find_pci_overlap_node(void)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 284 {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 285 struct device_node *np;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 286
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 287 for_each_node_by_type(np, "pci") {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 288 struct of_pci_range_parser parser;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 289 struct of_pci_range range;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 290 int err;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 291
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 292 err = of_pci_range_parser_init(&parser, np);
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 293 if (err) {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 294 pr_warn("of_pci_range_parser_init() failed: %d\n", err);
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 295 continue;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 296 }
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 297
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 298 for_each_of_pci_range(&parser, &range)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 299 if (efifb_overlaps_pci_range(&range))
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 300 return np;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 301 }
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 302 return NULL;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 303 }
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 304
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 305 /*
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 306 * If the efifb framebuffer is backed by a PCI graphics controller, we have
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 307 * to ensure that this relation is expressed using a device link when
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 308 * running in DT mode, or the probe order may be reversed, resulting in a
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 309 * resource reservation conflict on the memory window that the efifb
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 310 * framebuffer steals from the PCIe host bridge.
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 311 */
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 312 static int efifb_add_links(struct fwnode_handle *fwnode)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 313 {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 314 struct device_node *sup_np;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 315
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 316 sup_np = find_pci_overlap_node();
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 317
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 318 /*
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 319 * If there's no PCI graphics controller backing the efifb, we are
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 320 * done here.
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 321 */
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 322 if (!sup_np)
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 323 return 0;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 324
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 325 fwnode_link_add(fwnode, of_fwnode_handle(sup_np));
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 326 of_node_put(sup_np);
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 327
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 328 return 0;
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 329 }
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 330
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 @331 static const struct fwnode_operations efifb_fwnode_ops = {
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 332 .add_links = efifb_add_links,
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 333 };
8633ef82f101c0 drivers/firmware/efi/sysfb_efi.c Javier Martinez Canillas 2021-06-25 334
:::::: The code at line 190 was first introduced by commit
:::::: 2995e506276bfdc7311eb02db8b2aa1a61a4b849 x86: sysfb: move EFI quirks from efifb to sysfb
:::::: TO: David Herrmann <dh.herrmann(a)gmail.com>
:::::: CC: H. Peter Anvin <hpa(a)linux.intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year