[aa:mapcount_deshare 20/27] mm/gup.c:2756:3: error: implicit declaration of function 'mm_set_has_pinned_flag'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git mapcount_deshare
head: 3e2f198cce0c1792ad71d6d81974b091019b6483
commit: 8dec302e87453234fc7ac1cf4d09e4d577a06cf3 [20/27] mm: gup: pack has_pinned in MMF_HAS_PINNED
config: arm-randconfig-r014-20210511 (attached as .config)
compiler: clang version 13.0.0 (https://github.com/llvm/llvm-project a0fed635fe1701470062495a6ffee1c608f3f1bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git/commit/?id=...
git remote add aa https://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git
git fetch --no-tags aa mapcount_deshare
git checkout 8dec302e87453234fc7ac1cf4d09e4d577a06cf3
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
>> mm/gup.c:2756:3: error: implicit declaration of function 'mm_set_has_pinned_flag' [-Werror,-Wimplicit-function-declaration]
mm_set_has_pinned_flag(¤t->mm->flags);
^
1 error generated.
vim +/mm_set_has_pinned_flag +2756 mm/gup.c
2740
2741 static int internal_get_user_pages_fast(unsigned long start,
2742 unsigned long nr_pages,
2743 unsigned int gup_flags,
2744 struct page **pages)
2745 {
2746 unsigned long len, end;
2747 unsigned long nr_pinned;
2748 int ret;
2749
2750 if (WARN_ON_ONCE(gup_flags & ~(FOLL_WRITE | FOLL_LONGTERM |
2751 FOLL_FORCE | FOLL_PIN | FOLL_GET |
2752 FOLL_FAST_ONLY)))
2753 return -EINVAL;
2754
2755 if (gup_flags & FOLL_PIN)
> 2756 mm_set_has_pinned_flag(¤t->mm->flags);
2757
2758 if (!(gup_flags & FOLL_FAST_ONLY))
2759 might_lock_read(¤t->mm->mmap_lock);
2760
2761 start = untagged_addr(start) & PAGE_MASK;
2762 len = nr_pages << PAGE_SHIFT;
2763 if (check_add_overflow(start, len, &end))
2764 return 0;
2765 if (unlikely(!access_ok((void __user *)start, len)))
2766 return -EFAULT;
2767
2768 nr_pinned = lockless_pages_from_mm(start, end, gup_flags, pages);
2769 if (nr_pinned == nr_pages || gup_flags & FOLL_FAST_ONLY)
2770 return nr_pinned;
2771
2772 /* Slow path: try to get the remaining pages with get_user_pages */
2773 start += nr_pinned << PAGE_SHIFT;
2774 pages += nr_pinned;
2775 ret = __gup_longterm_unlocked(start, nr_pages - nr_pinned, gup_flags,
2776 pages);
2777 if (ret < 0) {
2778 /*
2779 * The caller has to unpin the pages we already pinned so
2780 * returning -errno is not an option
2781 */
2782 if (nr_pinned)
2783 return nr_pinned;
2784 return ret;
2785 }
2786 return ret + nr_pinned;
2787 }
2788
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months, 1 week
Re: [PATCH v6 2/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander
by kernel test robot
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on robh/for-next v5.13-rc7 next-20210624]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/David-Bauer/dt-bindings-pinctrl-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: s390-allmodconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/dd31385136eaa3a3feb0934f1e4ae4846...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review David-Bauer/dt-bindings-pinctrl-Add-bindings-for-Awinic-AW9523-AW9523B/20210625-055313
git checkout dd31385136eaa3a3feb0934f1e4ae4846a308c0c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/pinctrl/pinctrl-aw9523.c: In function 'aw9523_init_gpiochip':
>> drivers/pinctrl/pinctrl-aw9523.c:812:10: error: 'struct gpio_chip' has no member named 'of_node'
812 | gpiochip->of_node = dev->of_node;
| ^~
vim +812 drivers/pinctrl/pinctrl-aw9523.c
791
792 static int aw9523_init_gpiochip(struct aw9523 *awi, unsigned int npins)
793 {
794 struct device *dev = awi->dev;
795 struct gpio_chip *gpiochip = &awi->gpio;
796
797 gpiochip->label = devm_kstrdup(dev, dev_name(dev), GFP_KERNEL);
798 if (!gpiochip->label)
799 return -ENOMEM;
800
801 gpiochip->base = -1;
802 gpiochip->ngpio = npins;
803 gpiochip->get_direction = aw9523_gpio_get_direction;
804 gpiochip->direction_input = aw9523_direction_input;
805 gpiochip->direction_output = aw9523_direction_output;
806 gpiochip->get = aw9523_gpio_get;
807 gpiochip->get_multiple = aw9523_gpio_get_multiple;
808 gpiochip->set = aw9523_gpio_set;
809 gpiochip->set_multiple = aw9523_gpio_set_multiple;
810 gpiochip->set_config = gpiochip_generic_config;
811 gpiochip->parent = dev;
> 812 gpiochip->of_node = dev->of_node;
813 gpiochip->owner = THIS_MODULE;
814 gpiochip->can_sleep = false;
815
816 return 0;
817 }
818
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
Re: [PATCH 08/15] iio: dac: ad5624r: Fix incorrect handling of an optional regulator.
by kernel test robot
Hi Jonathan,
I love your patch! Yet something to improve:
[auto build test ERROR on iio/togreg]
[also build test ERROR on robh/for-next v5.13-rc7 next-20210625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jonathan-Cameron/dt-bindings-iio...
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: nios2-randconfig-r001-20210627 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/4f70da9b9819945461961ccdfbd87438a...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jonathan-Cameron/dt-bindings-iio-dac-Add-most-missing-binding-documents/20210628-003216
git checkout 4f70da9b9819945461961ccdfbd87438ac8a9f89
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash drivers/iio/dac/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
drivers/iio/dac/ad5624r_spi.c: In function 'ad5624r_probe':
>> drivers/iio/dac/ad5624r_spi.c:296:12: error: invalid storage class for function 'ad5624r_remove'
296 | static int ad5624r_remove(struct spi_device *spi)
| ^~~~~~~~~~~~~~
>> drivers/iio/dac/ad5624r_spi.c:296:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
296 | static int ad5624r_remove(struct spi_device *spi)
| ^~~~~~
>> drivers/iio/dac/ad5624r_spi.c:324:12: error: initializer element is not constant
324 | .remove = ad5624r_remove,
| ^~~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:324:12: note: (near initialization for 'ad5624r_driver.remove')
drivers/iio/dac/ad5624r_spi.c:319:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
319 | static struct spi_driver ad5624r_driver = {
| ^~~~~~
In file included from include/linux/device.h:32,
from drivers/iio/dac/ad5624r_spi.c:10:
>> drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_init'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/device/driver.h:259:19: note: in definition of macro 'module_driver'
259 | static int __init __driver##_init(void) \
| ^~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/printk.h:6,
from include/linux/kernel.h:17,
from include/linux/interrupt.h:6,
from drivers/iio/dac/ad5624r_spi.c:8:
drivers/iio/dac/ad5624r_spi.c:327:19: error: initializer element is not constant
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/init.h:250:41: note: in definition of macro '____define_initcall'
250 | __attribute__((__section__(__sec))) = fn;
| ^~
include/linux/init.h:260:2: note: in expansion of macro '__unique_initcall'
260 | __unique_initcall(fn, id, __sec, __initcall_id(fn))
| ^~~~~~~~~~~~~~~~~
include/linux/init.h:262:35: note: in expansion of macro '___define_initcall'
262 | #define __define_initcall(fn, id) ___define_initcall(fn, id, .initcall##id)
| ^~~~~~~~~~~~~~~~~~
include/linux/init.h:291:30: note: in expansion of macro '__define_initcall'
291 | #define device_initcall(fn) __define_initcall(fn, 6)
| ^~~~~~~~~~~~~~~~~
include/linux/init.h:296:24: note: in expansion of macro 'device_initcall'
296 | #define __initcall(fn) device_initcall(fn)
| ^~~~~~~~~~~~~~~
include/linux/module.h:87:24: note: in expansion of macro '__initcall'
87 | #define module_init(x) __initcall(x);
| ^~~~~~~~~~
include/linux/device/driver.h:263:1: note: in expansion of macro 'module_init'
263 | module_init(__driver##_init); \
| ^~~~~~~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/device.h:32,
from drivers/iio/dac/ad5624r_spi.c:10:
>> drivers/iio/dac/ad5624r_spi.c:327:19: error: invalid storage class for function 'ad5624r_driver_exit'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/device/driver.h:264:20: note: in definition of macro 'module_driver'
264 | static void __exit __driver##_exit(void) \
| ^~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
>> include/linux/device/driver.h:264:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
264 | static void __exit __driver##_exit(void) \
| ^~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/printk.h:6,
from include/linux/kernel.h:17,
from include/linux/interrupt.h:6,
from drivers/iio/dac/ad5624r_spi.c:8:
drivers/iio/dac/ad5624r_spi.c:327:19: error: initializer element is not constant
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~
include/linux/init.h:299:50: note: in definition of macro '__exitcall'
299 | static exitcall_t __exitcall_##fn __exit_call = fn
| ^~
include/linux/device/driver.h:268:1: note: in expansion of macro 'module_exit'
268 | module_exit(__driver##_exit);
| ^~~~~~~~~~~
include/linux/spi/spi.h:315:2: note: in expansion of macro 'module_driver'
315 | module_driver(__spi_driver, spi_register_driver, \
| ^~~~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:327:1: note: in expansion of macro 'module_spi_driver'
327 | module_spi_driver(ad5624r_driver);
| ^~~~~~~~~~~~~~~~~
In file included from include/linux/module.h:21,
from include/linux/bpf.h:19,
from include/linux/bpf-cgroup.h:5,
from include/linux/cgroup-defs.h:22,
from include/linux/cgroup.h:28,
from include/linux/memcontrol.h:13,
from include/linux/swap.h:9,
from include/linux/suspend.h:5,
from include/linux/regulator/consumer.h:35,
from drivers/iio/dac/ad5624r_spi.c:15:
include/linux/moduleparam.h:24:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
24 | static const char __UNIQUE_ID(name)[] \
| ^~~~~~
include/linux/module.h:165:32: note: in expansion of macro '__MODULE_INFO'
165 | #define MODULE_INFO(tag, info) __MODULE_INFO(tag, tag, info)
| ^~~~~~~~~~~~~
include/linux/module.h:235:32: note: in expansion of macro 'MODULE_INFO'
235 | #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author)
| ^~~~~~~~~~~
drivers/iio/dac/ad5624r_spi.c:329:1: note: in expansion of macro 'MODULE_AUTHOR'
329 | MODULE_AUTHOR("Barry Song <21cnbao(a)gmail.com>");
| ^~~~~~~~~~~~~
>> drivers/iio/dac/ad5624r_spi.c:331:1: error: expected declaration or statement at end of input
331 | MODULE_LICENSE("GPL v2");
| ^~~~~~~~~~~~~~
At top level:
drivers/iio/dac/ad5624r_spi.c:222:12: warning: 'ad5624r_probe' defined but not used [-Wunused-function]
222 | static int ad5624r_probe(struct spi_device *spi)
| ^~~~~~~~~~~~~
vim +/ad5624r_remove +296 drivers/iio/dac/ad5624r_spi.c
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 295
fc52692c49969e drivers/iio/dac/ad5624r_spi.c Greg Kroah-Hartman 2012-12-21 @296 static int ad5624r_remove(struct spi_device *spi)
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 297 {
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 298 struct iio_dev *indio_dev = spi_get_drvdata(spi);
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 299 struct ad5624r_state *st = iio_priv(indio_dev);
3ff242055b7b46 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-06-27 300
d2fffd6c2fd60f drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-10-14 301 iio_device_unregister(indio_dev);
75238230cce22b drivers/iio/dac/ad5624r_spi.c Sachin Kamat 2013-08-19 302 if (!IS_ERR(st->reg))
26a54797c1b094 drivers/staging/iio/dac/ad5624r_spi.c Jonathan Cameron 2011-08-30 303 regulator_disable(st->reg);
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 304
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 305 return 0;
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 306 }
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 307
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 308 static const struct spi_device_id ad5624r_id[] = {
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 309 {"ad5624r3", ID_AD5624R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 310 {"ad5644r3", ID_AD5644R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 311 {"ad5664r3", ID_AD5664R3},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 312 {"ad5624r5", ID_AD5624R5},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 313 {"ad5644r5", ID_AD5644R5},
14f88f1b07e03b drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2011-03-09 314 {"ad5664r5", ID_AD5664R5},
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 315 {}
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 316 };
55e4390cb04e8b drivers/staging/iio/dac/ad5624r_spi.c Lars-Peter Clausen 2011-11-16 317 MODULE_DEVICE_TABLE(spi, ad5624r_id);
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 318
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 319 static struct spi_driver ad5624r_driver = {
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 320 .driver = {
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 321 .name = "ad5624r",
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 322 },
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 323 .probe = ad5624r_probe,
fc52692c49969e drivers/iio/dac/ad5624r_spi.c Greg Kroah-Hartman 2012-12-21 @324 .remove = ad5624r_remove,
ece30c15921f94 drivers/staging/iio/dac/ad5624r_spi.c Michael Hennerich 2010-11-19 325 .id_table = ad5624r_id,
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 326 };
ae6ae6fec3f7d6 drivers/staging/iio/dac/ad5624r_spi.c Lars-Peter Clausen 2011-11-16 @327 module_spi_driver(ad5624r_driver);
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 328
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 329 MODULE_AUTHOR("Barry Song <21cnbao(a)gmail.com>");
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 330 MODULE_DESCRIPTION("Analog Devices AD5624/44/64R DAC spi driver");
6790e29fef61b2 drivers/staging/iio/dac/ad5624r_spi.c Barry Song 2010-10-27 @331 MODULE_LICENSE("GPL v2");
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months
[PATCH] crypto: fix flexible_array.cocci warnings
by Julia Lawall
From: kernel test robot <lkp(a)intel.com>
Zero-length and one-element arrays are deprecated, see
Documentation/process/deprecated.rst
Flexible-array members should be used instead.
Generated by: scripts/coccinelle/misc/flexible_array.cocci
Fixes: 7540b2861e52 ("crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ")
CC: Megha Dey <megha.dey(a)intel.com>
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Julia Lawall <julia.lawall(a)inria.fr>
---
tree: https://github.com/meghadey/crypto for_crypto_avx512
head: a89c5880f0d6260dd593bf579df26f2a2d56ac32
commit: 7540b2861e5292b5993f8e693fc69510b2a7277a [5/6] crypto: aesni - AVX512 version of AESNI-GCM using VPCLMULQDQ
:::::: branch date: 7 hours ago
:::::: commit date: 7 hours ago
aesni-intel_glue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/crypto/aesni-intel_glue.c
+++ b/arch/x86/crypto/aesni-intel_glue.c
@@ -87,7 +87,7 @@ struct gcm_context_data {
u64 partial_block_len;
u64 unused;
/* Allocate space for hash_keys later */
- u8 hash_keys[0];
+ u8 hash_keys[];
};
asmlinkage int aesni_set_key(struct crypto_aes_ctx *ctx, const u8 *in_key,
1 year, 2 months
[mkl-can-next:testing 5/28] net/can/j1939/transport.c:811:25: error: 'skcb' undeclared
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
head: ca9280f6324bf09ec5d3667579f7dd3f7567e809
commit: a2ea50608a02ac48371a9fab0167c1b44457913e [5/28] can: j1939: j1939_session_tx_dat(): use consistent name se_skcb for session skb control buffer
config: i386-randconfig-a011-20210628 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git/co...
git remote add mkl-can-next https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git
git fetch --no-tags mkl-can-next testing
git checkout a2ea50608a02ac48371a9fab0167c1b44457913e
# save the attached .config to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/net/sock.h:46,
from include/linux/can/skb.h:17,
from net/can/j1939/transport.c:11:
net/can/j1939/transport.c: In function 'j1939_session_tx_dat':
>> net/can/j1939/transport.c:811:25: error: 'skcb' undeclared (first use in this function)
811 | __func__, session, skcb->offset,
| ^~~~
include/linux/netdevice.h:5255:36: note: in definition of macro 'netdev_level_once'
5255 | netdev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
net/can/j1939/transport.c:809:4: note: in expansion of macro 'netdev_err_once'
809 | netdev_err_once(priv->ndev,
| ^~~~~~~~~~~~~~~
net/can/j1939/transport.c:811:25: note: each undeclared identifier is reported only once for each function it appears in
811 | __func__, session, skcb->offset,
| ^~~~
include/linux/netdevice.h:5255:36: note: in definition of macro 'netdev_level_once'
5255 | netdev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
net/can/j1939/transport.c:809:4: note: in expansion of macro 'netdev_err_once'
809 | netdev_err_once(priv->ndev,
| ^~~~~~~~~~~~~~~
vim +/skcb +811 net/can/j1939/transport.c
9d71dd0c700999 The j1939 authors 2018-10-08 775
9d71dd0c700999 The j1939 authors 2018-10-08 776 static int j1939_session_tx_dat(struct j1939_session *session)
9d71dd0c700999 The j1939 authors 2018-10-08 777 {
9d71dd0c700999 The j1939 authors 2018-10-08 778 struct j1939_priv *priv = session->priv;
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 779 struct j1939_sk_buff_cb *se_skcb;
9d71dd0c700999 The j1939 authors 2018-10-08 780 int offset, pkt_done, pkt_end;
9d71dd0c700999 The j1939 authors 2018-10-08 781 unsigned int len, pdelay;
9d71dd0c700999 The j1939 authors 2018-10-08 782 struct sk_buff *se_skb;
9d71dd0c700999 The j1939 authors 2018-10-08 783 const u8 *tpdat;
9d71dd0c700999 The j1939 authors 2018-10-08 784 int ret = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 785 u8 dat[8];
9d71dd0c700999 The j1939 authors 2018-10-08 786
2030043e616cab Oleksij Rempel 2021-05-21 787 se_skb = j1939_session_skb_get_by_offset(session, session->pkt.tx * 7);
9d71dd0c700999 The j1939 authors 2018-10-08 788 if (!se_skb)
9d71dd0c700999 The j1939 authors 2018-10-08 789 return -ENOBUFS;
9d71dd0c700999 The j1939 authors 2018-10-08 790
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 791 se_skcb = j1939_skb_to_cb(se_skb);
9d71dd0c700999 The j1939 authors 2018-10-08 792 tpdat = se_skb->data;
9d71dd0c700999 The j1939 authors 2018-10-08 793 ret = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 794 pkt_done = 0;
9d71dd0c700999 The j1939 authors 2018-10-08 795 if (session->skcb.addr.type != J1939_ETP &&
9d71dd0c700999 The j1939 authors 2018-10-08 796 j1939_cb_is_broadcast(&session->skcb))
9d71dd0c700999 The j1939 authors 2018-10-08 797 pkt_end = session->pkt.total;
9d71dd0c700999 The j1939 authors 2018-10-08 798 else
9d71dd0c700999 The j1939 authors 2018-10-08 799 pkt_end = session->pkt.last;
9d71dd0c700999 The j1939 authors 2018-10-08 800
9d71dd0c700999 The j1939 authors 2018-10-08 801 while (session->pkt.tx < pkt_end) {
9d71dd0c700999 The j1939 authors 2018-10-08 802 dat[0] = session->pkt.tx - session->pkt.dpo + 1;
a2ea50608a02ac Marc Kleine-Budde 2021-05-21 803 offset = (session->pkt.tx * 7) - se_skcb->offset;
9d71dd0c700999 The j1939 authors 2018-10-08 804 len = se_skb->len - offset;
9d71dd0c700999 The j1939 authors 2018-10-08 805 if (len > 7)
9d71dd0c700999 The j1939 authors 2018-10-08 806 len = 7;
9d71dd0c700999 The j1939 authors 2018-10-08 807
cd3b3636c99fca Oleksij Rempel 2020-08-07 808 if (offset + len > se_skb->len) {
cd3b3636c99fca Oleksij Rempel 2020-08-07 809 netdev_err_once(priv->ndev,
cd3b3636c99fca Oleksij Rempel 2020-08-07 810 "%s: 0x%p: requested data outside of queued buffer: offset %i, len %i, pkt.tx: %i\n",
563289f4161c81 Marc Kleine-Budde 2021-06-16 @811 __func__, session, skcb->offset,
563289f4161c81 Marc Kleine-Budde 2021-06-16 812 se_skb->len , session->pkt.tx);
2030043e616cab Oleksij Rempel 2021-05-21 813 ret = -EOVERFLOW;
2030043e616cab Oleksij Rempel 2021-05-21 814 goto out_free;
cd3b3636c99fca Oleksij Rempel 2020-08-07 815 }
cd3b3636c99fca Oleksij Rempel 2020-08-07 816
cd3b3636c99fca Oleksij Rempel 2020-08-07 817 if (!len) {
cd3b3636c99fca Oleksij Rempel 2020-08-07 818 ret = -ENOBUFS;
cd3b3636c99fca Oleksij Rempel 2020-08-07 819 break;
cd3b3636c99fca Oleksij Rempel 2020-08-07 820 }
cd3b3636c99fca Oleksij Rempel 2020-08-07 821
9d71dd0c700999 The j1939 authors 2018-10-08 822 memcpy(&dat[1], &tpdat[offset], len);
9d71dd0c700999 The j1939 authors 2018-10-08 823 ret = j1939_tp_tx_dat(session, dat, len + 1);
9d71dd0c700999 The j1939 authors 2018-10-08 824 if (ret < 0) {
9d71dd0c700999 The j1939 authors 2018-10-08 825 /* ENOBUS == CAN interface TX queue is full */
9d71dd0c700999 The j1939 authors 2018-10-08 826 if (ret != -ENOBUFS)
9d71dd0c700999 The j1939 authors 2018-10-08 827 netdev_alert(priv->ndev,
9d71dd0c700999 The j1939 authors 2018-10-08 828 "%s: 0x%p: queue data error: %i\n",
9d71dd0c700999 The j1939 authors 2018-10-08 829 __func__, session, ret);
9d71dd0c700999 The j1939 authors 2018-10-08 830 break;
9d71dd0c700999 The j1939 authors 2018-10-08 831 }
9d71dd0c700999 The j1939 authors 2018-10-08 832
9d71dd0c700999 The j1939 authors 2018-10-08 833 session->last_txcmd = 0xff;
9d71dd0c700999 The j1939 authors 2018-10-08 834 pkt_done++;
9d71dd0c700999 The j1939 authors 2018-10-08 835 session->pkt.tx++;
9d71dd0c700999 The j1939 authors 2018-10-08 836 pdelay = j1939_cb_is_broadcast(&session->skcb) ? 50 :
9d71dd0c700999 The j1939 authors 2018-10-08 837 j1939_tp_packet_delay;
9d71dd0c700999 The j1939 authors 2018-10-08 838
9d71dd0c700999 The j1939 authors 2018-10-08 839 if (session->pkt.tx < session->pkt.total && pdelay) {
9d71dd0c700999 The j1939 authors 2018-10-08 840 j1939_tp_schedule_txtimer(session, pdelay);
9d71dd0c700999 The j1939 authors 2018-10-08 841 break;
9d71dd0c700999 The j1939 authors 2018-10-08 842 }
9d71dd0c700999 The j1939 authors 2018-10-08 843 }
9d71dd0c700999 The j1939 authors 2018-10-08 844
9d71dd0c700999 The j1939 authors 2018-10-08 845 if (pkt_done)
9d71dd0c700999 The j1939 authors 2018-10-08 846 j1939_tp_set_rxtimeout(session, 250);
9d71dd0c700999 The j1939 authors 2018-10-08 847
2030043e616cab Oleksij Rempel 2021-05-21 848 out_free:
2030043e616cab Oleksij Rempel 2021-05-21 849 if (ret)
2030043e616cab Oleksij Rempel 2021-05-21 850 kfree_skb(se_skb);
2030043e616cab Oleksij Rempel 2021-05-21 851 else
2030043e616cab Oleksij Rempel 2021-05-21 852 consume_skb(se_skb);
2030043e616cab Oleksij Rempel 2021-05-21 853
9d71dd0c700999 The j1939 authors 2018-10-08 854 return ret;
9d71dd0c700999 The j1939 authors 2018-10-08 855 }
9d71dd0c700999 The j1939 authors 2018-10-08 856
:::::: The code at line 811 was first introduced by commit
:::::: 563289f4161c81b55ce19c05cd8ba2737fb26240 can: j1939: fix checkpatch warnings
:::::: TO: Marc Kleine-Budde <mkl(a)pengutronix.de>
:::::: CC: Marc Kleine-Budde <mkl(a)pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 2 months