[kbuild] [linux-next:master 7132/11526] drivers/bluetooth/btusb.c:3775 btusb_mtk_setup() error: uninitialized symbol 'fw_version'.
by Dan Carpenter
[ Why is linux-mm CC'd on these patches??? - dan ]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 6553715b6db5ff5d4898895dad1b2926cfe406cf
commit: fc342c4dc408754f50f19dc832152fbb4b73f1e6 [7132/11526] Bluetooth: btusb: Add protocol support for MediaTek MT7921U USB devices
config: parisc-randconfig-m031-20210216 (attached as .config)
compiler: hppa-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/bluetooth/btusb.c:3775 btusb_mtk_setup() error: uninitialized symbol 'fw_version'.
Old smatch warnings:
drivers/bluetooth/btusb.c:2201 btusb_setup_intel() warn: inconsistent indenting
vim +/fw_version +3775 drivers/bluetooth/btusb.c
a1c49c434e15050 Sean Wang 2019-06-02 3729 static int btusb_mtk_setup(struct hci_dev *hdev)
a1c49c434e15050 Sean Wang 2019-06-02 3730 {
a1c49c434e15050 Sean Wang 2019-06-02 3731 struct btusb_data *data = hci_get_drvdata(hdev);
a1c49c434e15050 Sean Wang 2019-06-02 3732 struct btmtk_hci_wmt_params wmt_params;
a1c49c434e15050 Sean Wang 2019-06-02 3733 ktime_t calltime, delta, rettime;
a1c49c434e15050 Sean Wang 2019-06-02 3734 struct btmtk_tci_sleep tci_sleep;
a1c49c434e15050 Sean Wang 2019-06-02 3735 unsigned long long duration;
a1c49c434e15050 Sean Wang 2019-06-02 3736 struct sk_buff *skb;
a1c49c434e15050 Sean Wang 2019-06-02 3737 const char *fwname;
a1c49c434e15050 Sean Wang 2019-06-02 3738 int err, status;
a1c49c434e15050 Sean Wang 2019-06-02 3739 u32 dev_id;
fc342c4dc408754 Mark Chen 2021-02-02 3740 char fw_bin_name[64];
fc342c4dc408754 Mark Chen 2021-02-02 3741 u32 fw_version;
a1c49c434e15050 Sean Wang 2019-06-02 3742 u8 param;
a1c49c434e15050 Sean Wang 2019-06-02 3743
a1c49c434e15050 Sean Wang 2019-06-02 3744 calltime = ktime_get();
a1c49c434e15050 Sean Wang 2019-06-02 3745
48c13301e6baba5 Mark Chen 2021-02-02 3746 err = btusb_mtk_id_get(data, 0x80000008, &dev_id);
a1c49c434e15050 Sean Wang 2019-06-02 3747 if (err < 0) {
a1c49c434e15050 Sean Wang 2019-06-02 3748 bt_dev_err(hdev, "Failed to get device id (%d)", err);
a1c49c434e15050 Sean Wang 2019-06-02 3749 return err;
a1c49c434e15050 Sean Wang 2019-06-02 3750 }
a1c49c434e15050 Sean Wang 2019-06-02 3751
fc342c4dc408754 Mark Chen 2021-02-02 3752 if (!dev_id) {
fc342c4dc408754 Mark Chen 2021-02-02 3753 err = btusb_mtk_id_get(data, 0x70010200, &dev_id);
fc342c4dc408754 Mark Chen 2021-02-02 3754 if (err < 0) {
fc342c4dc408754 Mark Chen 2021-02-02 3755 bt_dev_err(hdev, "Failed to get device id (%d)", err);
fc342c4dc408754 Mark Chen 2021-02-02 3756 return err;
fc342c4dc408754 Mark Chen 2021-02-02 3757 }
fc342c4dc408754 Mark Chen 2021-02-02 3758 err = btusb_mtk_id_get(data, 0x80021004, &fw_version);
fc342c4dc408754 Mark Chen 2021-02-02 3759 if (err < 0) {
fc342c4dc408754 Mark Chen 2021-02-02 3760 bt_dev_err(hdev, "Failed to get fw version (%d)", err);
fc342c4dc408754 Mark Chen 2021-02-02 3761 return err;
fc342c4dc408754 Mark Chen 2021-02-02 3762 }
fc342c4dc408754 Mark Chen 2021-02-02 3763 }
"fw_version" not initialized on else path.
fc342c4dc408754 Mark Chen 2021-02-02 3764
a1c49c434e15050 Sean Wang 2019-06-02 3765 switch (dev_id) {
9ce67c3235be71e Sean Wang 2019-06-02 3766 case 0x7663:
9ce67c3235be71e Sean Wang 2019-06-02 3767 fwname = FIRMWARE_MT7663;
9ce67c3235be71e Sean Wang 2019-06-02 3768 break;
a1c49c434e15050 Sean Wang 2019-06-02 3769 case 0x7668:
a1c49c434e15050 Sean Wang 2019-06-02 3770 fwname = FIRMWARE_MT7668;
a1c49c434e15050 Sean Wang 2019-06-02 3771 break;
fc342c4dc408754 Mark Chen 2021-02-02 3772 case 0x7961:
fc342c4dc408754 Mark Chen 2021-02-02 3773 snprintf(fw_bin_name, sizeof(fw_bin_name),
fc342c4dc408754 Mark Chen 2021-02-02 3774 "mediatek/BT_RAM_CODE_MT%04x_1_%x_hdr.bin",
fc342c4dc408754 Mark Chen 2021-02-02 @3775 dev_id & 0xffff, (fw_version & 0xff) + 1);
^^^^^^^^^^
fc342c4dc408754 Mark Chen 2021-02-02 3776 err = btusb_mtk_setup_firmware_79xx(hdev, fw_bin_name);
fc342c4dc408754 Mark Chen 2021-02-02 3777
fc342c4dc408754 Mark Chen 2021-02-02 3778 /* Enable Bluetooth protocol */
fc342c4dc408754 Mark Chen 2021-02-02 3779 param = 1;
fc342c4dc408754 Mark Chen 2021-02-02 3780 wmt_params.op = BTMTK_WMT_FUNC_CTRL;
fc342c4dc408754 Mark Chen 2021-02-02 3781 wmt_params.flag = 0;
fc342c4dc408754 Mark Chen 2021-02-02 3782 wmt_params.dlen = sizeof(param);
fc342c4dc408754 Mark Chen 2021-02-02 3783 wmt_params.data = ¶m;
fc342c4dc408754 Mark Chen 2021-02-02 3784 wmt_params.status = NULL;
fc342c4dc408754 Mark Chen 2021-02-02 3785
fc342c4dc408754 Mark Chen 2021-02-02 3786 err = btusb_mtk_hci_wmt_sync(hdev, &wmt_params);
fc342c4dc408754 Mark Chen 2021-02-02 3787 if (err < 0) {
fc342c4dc408754 Mark Chen 2021-02-02 3788 bt_dev_err(hdev, "Failed to send wmt func ctrl (%d)", err);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
3 months, 4 weeks
mmu.c:undefined reference to `patch__hash_page_A0'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 3fb6d0e00efc958d01c2f109c8453033a2d96796
commit: 259149cf7c3c6195e6199e045ca988c31d081cab powerpc/32s: Only build hash code when CONFIG_PPC_BOOK3S_604 is selected
date: 4 weeks ago
config: powerpc64-randconfig-r013-20210227 (attached as .config)
compiler: powerpc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 259149cf7c3c6195e6199e045ca988c31d081cab
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
powerpc-linux-ld: arch/powerpc/mm/book3s32/mmu.o: in function `MMU_init_hw_patch':
>> mmu.c:(.init.text+0x75e): undefined reference to `patch__hash_page_A0'
>> powerpc-linux-ld: mmu.c:(.init.text+0x76a): undefined reference to `patch__hash_page_A0'
>> powerpc-linux-ld: mmu.c:(.init.text+0x776): undefined reference to `patch__hash_page_A1'
powerpc-linux-ld: mmu.c:(.init.text+0x782): undefined reference to `patch__hash_page_A1'
>> powerpc-linux-ld: mmu.c:(.init.text+0x78e): undefined reference to `patch__hash_page_A2'
powerpc-linux-ld: mmu.c:(.init.text+0x79a): undefined reference to `patch__hash_page_A2'
>> powerpc-linux-ld: mmu.c:(.init.text+0x7aa): undefined reference to `patch__hash_page_B'
powerpc-linux-ld: mmu.c:(.init.text+0x7b6): undefined reference to `patch__hash_page_B'
>> powerpc-linux-ld: mmu.c:(.init.text+0x7c2): undefined reference to `patch__hash_page_C'
powerpc-linux-ld: mmu.c:(.init.text+0x7ce): undefined reference to `patch__hash_page_C'
>> powerpc-linux-ld: mmu.c:(.init.text+0x7da): undefined reference to `patch__flush_hash_A0'
powerpc-linux-ld: mmu.c:(.init.text+0x7e6): undefined reference to `patch__flush_hash_A0'
>> powerpc-linux-ld: mmu.c:(.init.text+0x7f2): undefined reference to `patch__flush_hash_A1'
powerpc-linux-ld: mmu.c:(.init.text+0x7fe): undefined reference to `patch__flush_hash_A1'
>> powerpc-linux-ld: mmu.c:(.init.text+0x80a): undefined reference to `patch__flush_hash_A2'
powerpc-linux-ld: mmu.c:(.init.text+0x816): undefined reference to `patch__flush_hash_A2'
>> powerpc-linux-ld: mmu.c:(.init.text+0x83e): undefined reference to `patch__flush_hash_B'
powerpc-linux-ld: mmu.c:(.init.text+0x84e): undefined reference to `patch__flush_hash_B'
powerpc-linux-ld: arch/powerpc/mm/book3s32/mmu.o: in function `update_mmu_cache':
>> mmu.c:(.text.update_mmu_cache+0xa0): undefined reference to `add_hash_page'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
4 months, 3 weeks
include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(struct canfd_frame, len) || offsetof(struct can_frame, data) != offsetof(struc...
by kernel test robot
Hi Oliver,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 812da4d39463a060738008a46cfc9f775e4bfcf6
commit: c7b74967799b1af52b3045d69d4c26836b2d41de can: replace can_dlc as variable/element for payload length
date: 4 months ago
config: arm-randconfig-r016-20210321 (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout c7b74967799b1af52b3045d69d4c26836b2d41de
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from <command-line>:
net/can/af_can.c: In function 'can_init':
>> include/linux/compiler_types.h:315:38: error: call to '__compiletime_assert_536' declared with attribute error: BUILD_BUG_ON failed: offsetof(struct can_frame, len) != offsetof(struct canfd_frame, len) || offsetof(struct can_frame, data) != offsetof(struct canfd_frame, data)
315 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^
include/linux/compiler_types.h:296:4: note: in definition of macro '__compiletime_assert'
296 | prefix ## suffix(); \
| ^~~~~~
include/linux/compiler_types.h:315:2: note: in expansion of macro '_compiletime_assert'
315 | _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
| ^~~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:39:37: note: in expansion of macro 'compiletime_assert'
39 | #define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
| ^~~~~~~~~~~~~~~~~~
include/linux/build_bug.h:50:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
50 | BUILD_BUG_ON_MSG(condition, "BUILD_BUG_ON failed: " #condition)
| ^~~~~~~~~~~~~~~~
net/can/af_can.c:891:2: note: in expansion of macro 'BUILD_BUG_ON'
891 | BUILD_BUG_ON(offsetof(struct can_frame, len) !=
| ^~~~~~~~~~~~
vim +/__compiletime_assert_536 +315 include/linux/compiler_types.h
eb5c2d4b45e3d2 Will Deacon 2020-07-21 301
eb5c2d4b45e3d2 Will Deacon 2020-07-21 302 #define _compiletime_assert(condition, msg, prefix, suffix) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 303 __compiletime_assert(condition, msg, prefix, suffix)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 304
eb5c2d4b45e3d2 Will Deacon 2020-07-21 305 /**
eb5c2d4b45e3d2 Will Deacon 2020-07-21 306 * compiletime_assert - break build and emit msg if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 307 * @condition: a compile-time constant condition to check
eb5c2d4b45e3d2 Will Deacon 2020-07-21 308 * @msg: a message to emit if condition is false
eb5c2d4b45e3d2 Will Deacon 2020-07-21 309 *
eb5c2d4b45e3d2 Will Deacon 2020-07-21 310 * In tradition of POSIX assert, this macro will break the build if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 311 * supplied condition is *false*, emitting the supplied error message if the
eb5c2d4b45e3d2 Will Deacon 2020-07-21 312 * compiler has support to do so.
eb5c2d4b45e3d2 Will Deacon 2020-07-21 313 */
eb5c2d4b45e3d2 Will Deacon 2020-07-21 314 #define compiletime_assert(condition, msg) \
eb5c2d4b45e3d2 Will Deacon 2020-07-21 @315 _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
eb5c2d4b45e3d2 Will Deacon 2020-07-21 316
:::::: The code at line 315 was first introduced by commit
:::::: eb5c2d4b45e3d2d5d052ea6b8f1463976b1020d5 compiler.h: Move compiletime_assert() macros into compiler_types.h
:::::: TO: Will Deacon <will(a)kernel.org>
:::::: CC: Will Deacon <will(a)kernel.org>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
5 months, 1 week
Re: [PATCH] mm: gup: remove FOLL_SPLIT
by kernel test robot
Hi Yang,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-linux-mm/master]
url: https://github.com/0day-ci/linux/commits/Yang-Shi/mm-gup-remove-FOLL_SPLI...
base: https://github.com/hnaz/linux-mm master
config: s390-randconfig-r032-20210330 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c8563a636718f98af86a3965d94e25b8f...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Yang-Shi/mm-gup-remove-FOLL_SPLIT/20210330-034042
git checkout c8563a636718f98af86a3965d94e25b8f2cf2354
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/s390/mm/gmap.c: In function 'thp_split_mm':
>> arch/s390/mm/gmap.c:2498:27: error: 'FOLL_SPLIT' undeclared (first use in this function); did you mean 'FOLL_PIN'?
2498 | follow_page(vma, addr, FOLL_SPLIT);
| ^~~~~~~~~~
| FOLL_PIN
arch/s390/mm/gmap.c:2498:27: note: each undeclared identifier is reported only once for each function it appears in
vim +2498 arch/s390/mm/gmap.c
0959e168678d2d Janosch Frank 2018-07-17 2487
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2488 static inline void thp_split_mm(struct mm_struct *mm)
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2489 {
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2490 #ifdef CONFIG_TRANSPARENT_HUGEPAGE
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2491 struct vm_area_struct *vma;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2492 unsigned long addr;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2493
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2494 for (vma = mm->mmap; vma != NULL; vma = vma->vm_next) {
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2495 for (addr = vma->vm_start;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2496 addr < vma->vm_end;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2497 addr += PAGE_SIZE)
1e133ab296f3ff Martin Schwidefsky 2016-03-08 @2498 follow_page(vma, addr, FOLL_SPLIT);
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2499 vma->vm_flags &= ~VM_HUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2500 vma->vm_flags |= VM_NOHUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2501 }
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2502 mm->def_flags |= VM_NOHUGEPAGE;
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2503 #endif
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2504 }
1e133ab296f3ff Martin Schwidefsky 2016-03-08 2505
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
5 months, 1 week
disk-io.c:undefined reference to `atomic64_set_386'
by kernel test robot
Hi Josef,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5e46d1b78a03d52306f21f77a4e4a144b6d31486
commit: 8260edba67a2e6bd5e709d32188e23aa22cb4a38 btrfs: make the init of static elements in fs_info separate
date: 1 year ago
config: um-randconfig-r023-20210330 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 8260edba67a2e6bd5e709d32188e23aa22cb4a38
# save the attached .config to linux build tree
make W=1 ARCH=um
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
/usr/bin/ld: kernel/fork.o: in function `mm_init':
fork.c:(.text+0x82): undefined reference to `atomic64_set_386'
/usr/bin/ld: kernel/sched/fair.o: in function `update_curr.constprop.0':
fair.c:(.text+0x529): undefined reference to `atomic64_add_386'
/usr/bin/ld: kernel/futex.o: in function `get_futex_key':
futex.c:(.text+0x1266): undefined reference to `atomic64_read_386'
/usr/bin/ld: futex.c:(.text+0x1354): undefined reference to `atomic64_add_return_386'
/usr/bin/ld: futex.c:(.text+0x1370): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_zpool_total_size':
z3fold.c:(.text+0x6f): undefined reference to `atomic64_read_386'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_zpool_create':
z3fold.c:(.text+0x5b0): undefined reference to `atomic64_set_386'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_page_putback':
z3fold.c:(.text+0xb95): undefined reference to `atomic64_dec_386'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_zpool_shrink':
z3fold.c:(.text+0x1029): undefined reference to `atomic64_dec_386'
/usr/bin/ld: z3fold.c:(.text+0x1534): undefined reference to `atomic64_dec_386'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_alloc':
z3fold.c:(.text+0x1990): undefined reference to `atomic64_inc_386'
/usr/bin/ld: z3fold.c:(.text+0x1ff8): undefined reference to `atomic64_dec_386'
/usr/bin/ld: mm/z3fold.o: in function `do_compact_page':
z3fold.c:(.text+0x23c5): undefined reference to `atomic64_dec_386'
/usr/bin/ld: z3fold.c:(.text+0x2c33): undefined reference to `atomic64_dec_386'
/usr/bin/ld: mm/z3fold.o: in function `z3fold_zpool_free':
z3fold.c:(.text+0x2d9f): undefined reference to `atomic64_dec_386'
/usr/bin/ld: z3fold.c:(.text+0x3036): undefined reference to `atomic64_dec_386'
/usr/bin/ld: fs/inode.o: in function `inode_init_always':
inode.c:(.text+0x438): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/inode.o: in function `generic_update_time':
inode.c:(.text+0x23e8): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x243a): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/inode.o: in function `file_update_time':
inode.c:(.text+0x3193): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/namespace.o: in function `alloc_mnt_ns':
namespace.c:(.text+0x453): undefined reference to `atomic64_add_return_386'
/usr/bin/ld: fs/ext4/mballoc.o: in function `ext4_mb_mark_diskspace_used':
mballoc.c:(.text+0x5c31): undefined reference to `atomic64_sub_386'
/usr/bin/ld: fs/ext4/mballoc.o: in function `ext4_free_blocks':
mballoc.c:(.text+0x80d3): undefined reference to `atomic64_add_386'
/usr/bin/ld: fs/ext4/mballoc.o: in function `ext4_group_add_blocks':
mballoc.c:(.text+0x8ca4): undefined reference to `atomic64_add_386'
/usr/bin/ld: fs/ext4/super.o: in function `ext4_statfs':
super.c:(.text+0x117): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/ext4/super.o: in function `ext4_alloc_inode':
super.c:(.text+0x12df): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/ext4/super.o: in function `ext4_fill_super':
super.c:(.text+0x903a): undefined reference to `atomic64_set_386'
/usr/bin/ld: super.c:(.text+0x9b61): undefined reference to `atomic64_add_386'
/usr/bin/ld: fs/ext4/sysfs.o: in function `ext4_attr_store':
sysfs.c:(.text+0x1a2): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/ext4/sysfs.o: in function `ext4_attr_show':
sysfs.c:(.text+0x6f9): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/ext2/super.o: in function `ext2_alloc_inode':
super.c:(.text+0x780): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/fat/inode.o: in function `fat_fill_inode':
inode.c:(.text+0x2240): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x2281): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/inode.o: in function `fat_build_inode':
inode.c:(.text+0x2894): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/fat/inode.o: in function `fat_fill_super':
inode.c:(.text+0x324e): undefined reference to `atomic64_set_386'
/usr/bin/ld: inode.c:(.text+0x327c): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x32cf): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_rmdir':
namei_vfat.c:(.text+0x581): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x5bd): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_unlink':
namei_vfat.c:(.text+0x6be): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x6fa): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_lookup':
namei_vfat.c:(.text+0x7fa): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x82a): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_revalidate_ci':
namei_vfat.c:(.text+0xa18): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_revalidate':
namei_vfat.c:(.text+0xaa5): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_rename':
namei_vfat.c:(.text+0x20ad): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x2106): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: namei_vfat.c:(.text+0x2250): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x22ab): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_mkdir':
namei_vfat.c:(.text+0x2792): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x27d5): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: namei_vfat.c:(.text+0x2847): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x287f): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fat/namei_vfat.o: in function `vfat_create':
namei_vfat.c:(.text+0x29d0): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x2a0d): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: namei_vfat.c:(.text+0x2a76): undefined reference to `atomic64_read_386'
/usr/bin/ld: namei_vfat.c:(.text+0x2aae): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/fuse/inode.o: in function `fuse_change_attributes_common':
inode.c:(.text+0x15c4): undefined reference to `atomic64_inc_return_386'
/usr/bin/ld: fs/fuse/inode.o: in function `fuse_conn_init':
inode.c:(.text+0x1ddf): undefined reference to `atomic64_set_386'
/usr/bin/ld: inode.c:(.text+0x1e17): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/btrfs/disk-io.o: in function `btrfs_init_fs_info':
>> disk-io.c:(.text+0x340b): undefined reference to `atomic64_set_386'
>> /usr/bin/ld: disk-io.c:(.text+0x343b): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/btrfs/inode.o: in function `fill_inode_item':
inode.c:(.text+0xbd1): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_read_locked_inode':
inode.c:(.text+0x58b3): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/btrfs/inode.o: in function `__btrfs_unlink_inode':
inode.c:(.text+0x8392): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x83cd): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x83f6): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x842f): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_update_time':
inode.c:(.text+0x887b): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x88e6): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `__btrfs_prealloc_file_range':
inode.c:(.text+0x8d40): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x8d7d): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_unlink_subvol':
inode.c:(.text+0xd9a6): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0xd9df): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_setsize':
inode.c:(.text+0x10b63): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x10b9b): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_setattr':
inode.c:(.text+0x11249): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x1128d): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_add_link':
inode.c:(.text+0x1337b): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x133bc): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_rename_exchange':
inode.c:(.text+0x13c34): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x13c77): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x13ca3): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x13ce6): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x13d0e): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x13d51): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x13d7c): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x13dbf): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_link':
inode.c:(.text+0x15400): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x15439): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/inode.o: in function `btrfs_rename':
inode.c:(.text+0x15c5d): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x15cb8): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x15ce7): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x15d42): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x15d71): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x15dcc): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: inode.c:(.text+0x16296): undefined reference to `atomic64_read_386'
/usr/bin/ld: inode.c:(.text+0x162ef): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/file.o: in function `btrfs_punch_hole':
file.c:(.text+0x7ac5): undefined reference to `atomic64_read_386'
/usr/bin/ld: file.c:(.text+0x7b0b): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: file.c:(.text+0x7c55): undefined reference to `atomic64_read_386'
/usr/bin/ld: file.c:(.text+0x7c9a): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/file.o: in function `btrfs_file_write_iter':
file.c:(.text+0x8d58): undefined reference to `atomic64_read_386'
/usr/bin/ld: file.c:(.text+0x8d9b): undefined reference to `cmpxchg8b_emu'
/usr/bin/ld: fs/btrfs/delayed-ref.o: in function `btrfs_add_delayed_tree_ref':
delayed-ref.c:(.text+0x1e61): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/btrfs/delayed-ref.o: in function `btrfs_add_delayed_data_ref':
delayed-ref.c:(.text+0x2331): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/btrfs/delayed-inode.o: in function `fill_stack_inode_item':
delayed-inode.c:(.text+0x18e): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/btrfs/delayed-inode.o: in function `btrfs_fill_inode':
delayed-inode.c:(.text+0x3393): undefined reference to `atomic64_set_386'
/usr/bin/ld: fs/f2fs/extent_cache.o: in function `f2fs_lookup_extent_cache':
extent_cache.c:(.text+0x1722): undefined reference to `atomic64_inc_386'
/usr/bin/ld: extent_cache.c:(.text+0x176f): undefined reference to `atomic64_inc_386'
/usr/bin/ld: extent_cache.c:(.text+0x17d6): undefined reference to `atomic64_inc_386'
/usr/bin/ld: extent_cache.c:(.text+0x180d): undefined reference to `atomic64_inc_386'
/usr/bin/ld: fs/f2fs/debug.o: in function `update_general_status':
debug.c:(.text+0x32): undefined reference to `atomic64_read_386'
/usr/bin/ld: debug.c:(.text+0x43): undefined reference to `atomic64_read_386'
/usr/bin/ld: debug.c:(.text+0x54): undefined reference to `atomic64_read_386'
/usr/bin/ld: debug.c:(.text+0x7b): undefined reference to `atomic64_read_386'
/usr/bin/ld: fs/f2fs/debug.o: in function `f2fs_build_stats':
debug.c:(.text+0x1773): undefined reference to `atomic64_set_386'
/usr/bin/ld: debug.c:(.text+0x177e): undefined reference to `atomic64_set_386'
/usr/bin/ld: debug.c:(.text+0x1789): undefined reference to `atomic64_set_386'
/usr/bin/ld: debug.c:(.text+0x1794): undefined reference to `atomic64_set_386'
/usr/bin/ld: lib/atomic64_test.o: in function `test_atomic64':
atomic64_test.c:(.init.text+0x23f9): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x243f): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x248c): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x249d): undefined reference to `atomic64_add_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x24a4): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x24bf): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x24fa): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x2506): undefined reference to `atomic64_add_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x250d): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x2528): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x2563): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x2574): undefined reference to `atomic64_sub_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x257b): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x2596): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x25d1): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x25dd): undefined reference to `atomic64_sub_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x25e4): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x25ff): undefined reference to `atomic64_read_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x263a): undefined reference to `atomic64_set_386'
/usr/bin/ld: atomic64_test.c:(.init.text+0x266d): undefined reference to `cmpxchg8b_emu'
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
5 months, 1 week
[kbuild] Re: [PATCH v13 1/9] drivers: thermal: tsens: Add VER_0 tsens version
by Dan Carpenter
Hi Ansuel,
url: https://github.com/0day-ci/linux/commits/Ansuel-Smith/drivers-thermal-tse...
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: riscv-randconfig-m031-20210330 (attached as .config)
compiler: riscv32-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
New smatch warnings:
drivers/thermal/qcom/tsens.c:792 init_common() warn: passing zero to 'PTR_ERR'
vim +/PTR_ERR +792 drivers/thermal/qcom/tsens.c
a7ff82976122eb Amit Kucheria 2020-04-29 741 int __init init_common(struct tsens_priv *priv)
a7ff82976122eb Amit Kucheria 2020-04-29 742 {
a7ff82976122eb Amit Kucheria 2020-04-29 743 void __iomem *tm_base, *srot_base;
a7ff82976122eb Amit Kucheria 2020-04-29 744 struct device *dev = priv->dev;
a7ff82976122eb Amit Kucheria 2020-04-29 745 u32 ver_minor;
a7ff82976122eb Amit Kucheria 2020-04-29 746 struct resource *res;
a7ff82976122eb Amit Kucheria 2020-04-29 747 u32 enabled;
a7ff82976122eb Amit Kucheria 2020-04-29 748 int ret, i, j;
a7ff82976122eb Amit Kucheria 2020-04-29 749 struct platform_device *op = of_find_device_by_node(priv->dev->of_node);
a7ff82976122eb Amit Kucheria 2020-04-29 750
a7ff82976122eb Amit Kucheria 2020-04-29 751 if (!op)
a7ff82976122eb Amit Kucheria 2020-04-29 752 return -EINVAL;
a7ff82976122eb Amit Kucheria 2020-04-29 753
a7ff82976122eb Amit Kucheria 2020-04-29 754 if (op->num_resources > 1) {
a7ff82976122eb Amit Kucheria 2020-04-29 755 /* DT with separate SROT and TM address space */
a7ff82976122eb Amit Kucheria 2020-04-29 756 priv->tm_offset = 0;
a7ff82976122eb Amit Kucheria 2020-04-29 757 res = platform_get_resource(op, IORESOURCE_MEM, 1);
a7ff82976122eb Amit Kucheria 2020-04-29 758 srot_base = devm_ioremap_resource(dev, res);
a7ff82976122eb Amit Kucheria 2020-04-29 759 if (IS_ERR(srot_base)) {
a7ff82976122eb Amit Kucheria 2020-04-29 760 ret = PTR_ERR(srot_base);
a7ff82976122eb Amit Kucheria 2020-04-29 761 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 762 }
a7ff82976122eb Amit Kucheria 2020-04-29 763
a7ff82976122eb Amit Kucheria 2020-04-29 764 priv->srot_map = devm_regmap_init_mmio(dev, srot_base,
a7ff82976122eb Amit Kucheria 2020-04-29 765 &tsens_srot_config);
a7ff82976122eb Amit Kucheria 2020-04-29 766 if (IS_ERR(priv->srot_map)) {
a7ff82976122eb Amit Kucheria 2020-04-29 767 ret = PTR_ERR(priv->srot_map);
a7ff82976122eb Amit Kucheria 2020-04-29 768 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 769 }
a7ff82976122eb Amit Kucheria 2020-04-29 770 } else {
a7ff82976122eb Amit Kucheria 2020-04-29 771 /* old DTs where SROT and TM were in a contiguous 2K block */
a7ff82976122eb Amit Kucheria 2020-04-29 772 priv->tm_offset = 0x1000;
a7ff82976122eb Amit Kucheria 2020-04-29 773 }
a7ff82976122eb Amit Kucheria 2020-04-29 774
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 775 if (tsens_version(priv) >= VER_0_1) {
a7ff82976122eb Amit Kucheria 2020-04-29 776 res = platform_get_resource(op, IORESOURCE_MEM, 0);
a7ff82976122eb Amit Kucheria 2020-04-29 777 tm_base = devm_ioremap_resource(dev, res);
a7ff82976122eb Amit Kucheria 2020-04-29 778 if (IS_ERR(tm_base)) {
a7ff82976122eb Amit Kucheria 2020-04-29 779 ret = PTR_ERR(tm_base);
a7ff82976122eb Amit Kucheria 2020-04-29 780 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 781 }
a7ff82976122eb Amit Kucheria 2020-04-29 782
a7ff82976122eb Amit Kucheria 2020-04-29 783 priv->tm_map = devm_regmap_init_mmio(dev, tm_base, &tsens_config);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 784 } else { /* VER_0 share the same gcc regs using a syscon */
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 785 struct device *parent = priv->dev->parent;
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 786
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 787 if (parent)
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 788 priv->tm_map = syscon_node_to_regmap(parent->of_node);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 789 }
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 790
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 791 if (IS_ERR_OR_NULL(priv->tm_map)) {
This used to be an IS_ERR() check, but now if "priv->tm_map" is NULL
we short cut the rest of the function and return success. It's hard to
tell without more context if that's intentional or if it should be
something like:
if (IS_ERR_OR_NULL(priv->tm_map)) {
if (!priv->tm_map)
ret = -ENODEV;
else
ret = PTR_ERR(priv->tm_map);
goto err_put_device;
}
a7ff82976122eb Amit Kucheria 2020-04-29 @792 ret = PTR_ERR(priv->tm_map);
a7ff82976122eb Amit Kucheria 2020-04-29 793 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 794 }
a7ff82976122eb Amit Kucheria 2020-04-29 795
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 796 /* VER_0 have only tm_map */
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 797 if (!priv->srot_map)
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 798 priv->srot_map = priv->tm_map;
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 799
a7ff82976122eb Amit Kucheria 2020-04-29 800 if (tsens_version(priv) > VER_0_1) {
a7ff82976122eb Amit Kucheria 2020-04-29 801 for (i = VER_MAJOR; i <= VER_STEP; i++) {
a7ff82976122eb Amit Kucheria 2020-04-29 802 priv->rf[i] = devm_regmap_field_alloc(dev, priv->srot_map,
a7ff82976122eb Amit Kucheria 2020-04-29 803 priv->fields[i]);
a7ff82976122eb Amit Kucheria 2020-04-29 804 if (IS_ERR(priv->rf[i]))
a7ff82976122eb Amit Kucheria 2020-04-29 805 return PTR_ERR(priv->rf[i]);
a7ff82976122eb Amit Kucheria 2020-04-29 806 }
a7ff82976122eb Amit Kucheria 2020-04-29 807 ret = regmap_field_read(priv->rf[VER_MINOR], &ver_minor);
a7ff82976122eb Amit Kucheria 2020-04-29 808 if (ret)
a7ff82976122eb Amit Kucheria 2020-04-29 809 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 810 }
a7ff82976122eb Amit Kucheria 2020-04-29 811
a7ff82976122eb Amit Kucheria 2020-04-29 812 priv->rf[TSENS_EN] = devm_regmap_field_alloc(dev, priv->srot_map,
a7ff82976122eb Amit Kucheria 2020-04-29 813 priv->fields[TSENS_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 814 if (IS_ERR(priv->rf[TSENS_EN])) {
a7ff82976122eb Amit Kucheria 2020-04-29 815 ret = PTR_ERR(priv->rf[TSENS_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 816 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 817 }
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 818 /* in VER_0 TSENS need to be explicitly enabled */
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 819 if (tsens_version(priv) == VER_0)
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 820 regmap_field_write(priv->rf[TSENS_EN], 1);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 821
a7ff82976122eb Amit Kucheria 2020-04-29 822 ret = regmap_field_read(priv->rf[TSENS_EN], &enabled);
a7ff82976122eb Amit Kucheria 2020-04-29 823 if (ret)
a7ff82976122eb Amit Kucheria 2020-04-29 824 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 825 if (!enabled) {
a7ff82976122eb Amit Kucheria 2020-04-29 826 dev_err(dev, "%s: device not enabled\n", __func__);
a7ff82976122eb Amit Kucheria 2020-04-29 827 ret = -ENODEV;
a7ff82976122eb Amit Kucheria 2020-04-29 828 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 829 }
a7ff82976122eb Amit Kucheria 2020-04-29 830
a7ff82976122eb Amit Kucheria 2020-04-29 831 priv->rf[SENSOR_EN] = devm_regmap_field_alloc(dev, priv->srot_map,
a7ff82976122eb Amit Kucheria 2020-04-29 832 priv->fields[SENSOR_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 833 if (IS_ERR(priv->rf[SENSOR_EN])) {
a7ff82976122eb Amit Kucheria 2020-04-29 834 ret = PTR_ERR(priv->rf[SENSOR_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 835 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 836 }
a7ff82976122eb Amit Kucheria 2020-04-29 837 priv->rf[INT_EN] = devm_regmap_field_alloc(dev, priv->tm_map,
a7ff82976122eb Amit Kucheria 2020-04-29 838 priv->fields[INT_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 839 if (IS_ERR(priv->rf[INT_EN])) {
a7ff82976122eb Amit Kucheria 2020-04-29 840 ret = PTR_ERR(priv->rf[INT_EN]);
a7ff82976122eb Amit Kucheria 2020-04-29 841 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 842 }
a7ff82976122eb Amit Kucheria 2020-04-29 843
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 844 priv->rf[TSENS_SW_RST] =
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 845 devm_regmap_field_alloc(dev, priv->srot_map, priv->fields[TSENS_SW_RST]);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 846 if (IS_ERR(priv->rf[TSENS_SW_RST])) {
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 847 ret = PTR_ERR(priv->rf[TSENS_SW_RST]);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 848 goto err_put_device;
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 849 }
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 850
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 851 priv->rf[TRDY] = devm_regmap_field_alloc(dev, priv->tm_map, priv->fields[TRDY]);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 852 if (IS_ERR(priv->rf[TRDY])) {
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 853 ret = PTR_ERR(priv->rf[TRDY]);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 854 goto err_put_device;
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 855 }
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 856
a7ff82976122eb Amit Kucheria 2020-04-29 857 /* This loop might need changes if enum regfield_ids is reordered */
a7ff82976122eb Amit Kucheria 2020-04-29 858 for (j = LAST_TEMP_0; j <= UP_THRESH_15; j += 16) {
a7ff82976122eb Amit Kucheria 2020-04-29 859 for (i = 0; i < priv->feat->max_sensors; i++) {
a7ff82976122eb Amit Kucheria 2020-04-29 860 int idx = j + i;
a7ff82976122eb Amit Kucheria 2020-04-29 861
a7ff82976122eb Amit Kucheria 2020-04-29 862 priv->rf[idx] = devm_regmap_field_alloc(dev,
a7ff82976122eb Amit Kucheria 2020-04-29 863 priv->tm_map,
a7ff82976122eb Amit Kucheria 2020-04-29 864 priv->fields[idx]);
a7ff82976122eb Amit Kucheria 2020-04-29 865 if (IS_ERR(priv->rf[idx])) {
a7ff82976122eb Amit Kucheria 2020-04-29 866 ret = PTR_ERR(priv->rf[idx]);
a7ff82976122eb Amit Kucheria 2020-04-29 867 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 868 }
a7ff82976122eb Amit Kucheria 2020-04-29 869 }
a7ff82976122eb Amit Kucheria 2020-04-29 870 }
a7ff82976122eb Amit Kucheria 2020-04-29 871
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 872 if (priv->feat->crit_int || tsens_version(priv) < VER_0_1) {
a7ff82976122eb Amit Kucheria 2020-04-29 873 /* Loop might need changes if enum regfield_ids is reordered */
a7ff82976122eb Amit Kucheria 2020-04-29 874 for (j = CRITICAL_STATUS_0; j <= CRIT_THRESH_15; j += 16) {
a7ff82976122eb Amit Kucheria 2020-04-29 875 for (i = 0; i < priv->feat->max_sensors; i++) {
a7ff82976122eb Amit Kucheria 2020-04-29 876 int idx = j + i;
a7ff82976122eb Amit Kucheria 2020-04-29 877
a7ff82976122eb Amit Kucheria 2020-04-29 878 priv->rf[idx] =
a7ff82976122eb Amit Kucheria 2020-04-29 879 devm_regmap_field_alloc(dev,
a7ff82976122eb Amit Kucheria 2020-04-29 880 priv->tm_map,
a7ff82976122eb Amit Kucheria 2020-04-29 881 priv->fields[idx]);
a7ff82976122eb Amit Kucheria 2020-04-29 882 if (IS_ERR(priv->rf[idx])) {
a7ff82976122eb Amit Kucheria 2020-04-29 883 ret = PTR_ERR(priv->rf[idx]);
a7ff82976122eb Amit Kucheria 2020-04-29 884 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 885 }
a7ff82976122eb Amit Kucheria 2020-04-29 886 }
a7ff82976122eb Amit Kucheria 2020-04-29 887 }
a7ff82976122eb Amit Kucheria 2020-04-29 888 }
a7ff82976122eb Amit Kucheria 2020-04-29 889
a7ff82976122eb Amit Kucheria 2020-04-29 890 if (tsens_version(priv) > VER_1_X && ver_minor > 2) {
a7ff82976122eb Amit Kucheria 2020-04-29 891 /* Watchdog is present only on v2.3+ */
a7ff82976122eb Amit Kucheria 2020-04-29 892 priv->feat->has_watchdog = 1;
a7ff82976122eb Amit Kucheria 2020-04-29 893 for (i = WDOG_BARK_STATUS; i <= CC_MON_MASK; i++) {
a7ff82976122eb Amit Kucheria 2020-04-29 894 priv->rf[i] = devm_regmap_field_alloc(dev, priv->tm_map,
a7ff82976122eb Amit Kucheria 2020-04-29 895 priv->fields[i]);
a7ff82976122eb Amit Kucheria 2020-04-29 896 if (IS_ERR(priv->rf[i])) {
a7ff82976122eb Amit Kucheria 2020-04-29 897 ret = PTR_ERR(priv->rf[i]);
a7ff82976122eb Amit Kucheria 2020-04-29 898 goto err_put_device;
a7ff82976122eb Amit Kucheria 2020-04-29 899 }
a7ff82976122eb Amit Kucheria 2020-04-29 900 }
a7ff82976122eb Amit Kucheria 2020-04-29 901 /*
a7ff82976122eb Amit Kucheria 2020-04-29 902 * Watchdog is already enabled, unmask the bark.
a7ff82976122eb Amit Kucheria 2020-04-29 903 * Disable cycle completion monitoring
a7ff82976122eb Amit Kucheria 2020-04-29 904 */
a7ff82976122eb Amit Kucheria 2020-04-29 905 regmap_field_write(priv->rf[WDOG_BARK_MASK], 0);
a7ff82976122eb Amit Kucheria 2020-04-29 906 regmap_field_write(priv->rf[CC_MON_MASK], 1);
a7ff82976122eb Amit Kucheria 2020-04-29 907 }
a7ff82976122eb Amit Kucheria 2020-04-29 908
a7ff82976122eb Amit Kucheria 2020-04-29 909 spin_lock_init(&priv->ul_lock);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 910
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 911 /* VER_0 interrupt doesn't need to be enabled */
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 912 if (tsens_version(priv) >= VER_0_1)
a7ff82976122eb Amit Kucheria 2020-04-29 913 tsens_enable_irq(priv);
fea5c5e6f2e2a0 Ansuel Smith 2021-03-24 914
a7ff82976122eb Amit Kucheria 2020-04-29 915 tsens_debug_init(op);
a7ff82976122eb Amit Kucheria 2020-04-29 916
a7ff82976122eb Amit Kucheria 2020-04-29 917 err_put_device:
a7ff82976122eb Amit Kucheria 2020-04-29 918 put_device(&op->dev);
a7ff82976122eb Amit Kucheria 2020-04-29 919 return ret;
a7ff82976122eb Amit Kucheria 2020-04-29 920 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
_______________________________________________
kbuild mailing list -- kbuild(a)lists.01.org
To unsubscribe send an email to kbuild-leave(a)lists.01.org
5 months, 2 weeks