[linux-next:master 11806/11956] kernel/trace/bpf_trace.c:1181:23: warning: Uninitialized variable: t
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 49e7e3e905e437a02782019570f70997e2da9101
commit: c4d0bfb45068d853a478b9067a95969b1886a30f [11806/11956] bpf: Add bpf_snprintf_btf helper
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
vim +1181 kernel/trace/bpf_trace.c
1153
1154 #define BTF_F_ALL (BTF_F_COMPACT | BTF_F_NONAME | \
1155 BTF_F_PTR_RAW | BTF_F_ZERO)
1156
1157 static int bpf_btf_printf_prepare(struct btf_ptr *ptr, u32 btf_ptr_size,
1158 u64 flags, const struct btf **btf,
1159 s32 *btf_id)
1160 {
1161 const struct btf_type *t;
1162
1163 if (unlikely(flags & ~(BTF_F_ALL)))
1164 return -EINVAL;
1165
1166 if (btf_ptr_size != sizeof(struct btf_ptr))
1167 return -EINVAL;
1168
1169 *btf = bpf_get_btf_vmlinux();
1170
1171 if (IS_ERR_OR_NULL(*btf))
1172 return PTR_ERR(*btf);
1173
1174 if (ptr->type_id > 0)
1175 *btf_id = ptr->type_id;
1176 else
1177 return -EINVAL;
1178
1179 if (*btf_id > 0)
1180 t = btf_type_by_id(*btf, *btf_id);
> 1181 if (*btf_id <= 0 || !t)
1182 return -ENOENT;
1183
1184 return 0;
1185 }
1186
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[dm:for-next 20/20] drivers/md/dm.c:2374:19: warning: variable 'map' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next
head: 3a6434fb7a713f9735912aef297078eeda3e47b4
commit: 3a6434fb7a713f9735912aef297078eeda3e47b4 [20/20] dm: fix missing imposition of queue_limits from dm_wq_work() thread
config: xtensa-allyesconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.gi...
git remote add dm https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git
git fetch --no-tags dm for-next
git checkout 3a6434fb7a713f9735912aef297078eeda3e47b4
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=xtensa
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers/md/dm.c: In function 'dm_wq_work':
>> drivers/md/dm.c:2374:19: warning: variable 'map' set but not used [-Wunused-but-set-variable]
2374 | struct dm_table *map;
| ^~~
vim +/map +2374 drivers/md/dm.c
85067747cf9888 Ming Lei 2020-06-24 2364
^1da177e4c3f41 Linus Torvalds 2005-04-16 2365 /*
^1da177e4c3f41 Linus Torvalds 2005-04-16 2366 * Process the deferred bios
^1da177e4c3f41 Linus Torvalds 2005-04-16 2367 */
ef2085870ea448 Mikulas Patocka 2009-04-02 2368 static void dm_wq_work(struct work_struct *work)
^1da177e4c3f41 Linus Torvalds 2005-04-16 2369 {
ef2085870ea448 Mikulas Patocka 2009-04-02 2370 struct mapped_device *md = container_of(work, struct mapped_device,
ef2085870ea448 Mikulas Patocka 2009-04-02 2371 work);
3a6434fb7a713f Mike Snitzer 2020-09-28 2372 struct bio *bio;
83d5e5b0af907d Mikulas Patocka 2013-07-10 2373 int srcu_idx;
83d5e5b0af907d Mikulas Patocka 2013-07-10 @2374 struct dm_table *map;
^1da177e4c3f41 Linus Torvalds 2005-04-16 2375
83d5e5b0af907d Mikulas Patocka 2013-07-10 2376 map = dm_get_live_table(md, &srcu_idx);
ef2085870ea448 Mikulas Patocka 2009-04-02 2377
3b00b2036fac7a Mikulas Patocka 2009-04-09 2378 while (!test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags)) {
022c261100e156 Mikulas Patocka 2009-04-02 2379 spin_lock_irq(&md->deferred_lock);
3a6434fb7a713f Mike Snitzer 2020-09-28 2380 bio = bio_list_pop(&md->deferred);
022c261100e156 Mikulas Patocka 2009-04-02 2381 spin_unlock_irq(&md->deferred_lock);
022c261100e156 Mikulas Patocka 2009-04-02 2382
3a6434fb7a713f Mike Snitzer 2020-09-28 2383 if (!bio)
df12ee996378a5 Alasdair G Kergon 2009-04-09 2384 break;
73d410c0137f63 Milan Broz 2008-02-08 2385
3a6434fb7a713f Mike Snitzer 2020-09-28 2386 submit_bio_noacct(bio);
df12ee996378a5 Alasdair G Kergon 2009-04-09 2387 }
ef2085870ea448 Mikulas Patocka 2009-04-02 2388
83d5e5b0af907d Mikulas Patocka 2013-07-10 2389 dm_put_live_table(md, srcu_idx);
^1da177e4c3f41 Linus Torvalds 2005-04-16 2390 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 2391
:::::: The code at line 2374 was first introduced by commit
:::::: 83d5e5b0af907d46d241a86d9e44003b3f0accbd dm: optimize use SRCU and RCU
:::::: TO: Mikulas Patocka <mpatocka(a)redhat.com>
:::::: CC: Alasdair G Kergon <agk(a)redhat.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 10741/11956] ERROR: modpost: "scp_get_venc_hw_capa" undefined!
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 49e7e3e905e437a02782019570f70997e2da9101
commit: c7244811b1c951dca812079d16b17cb241882a80 [10741/11956] media: mtk-vcodec: add SCP firmware ops
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout c7244811b1c951dca812079d16b17cb241882a80
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
>> ERROR: modpost: "scp_get_venc_hw_capa" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_ipi_send" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_put" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_get" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_get_vdec_hw_capa" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_ipi_register" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_mapping_dm_addr" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "scp_get_rproc" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
>> ERROR: modpost: "rproc_boot" [drivers/media/platform/mtk-vcodec/mtk-vcodec-common.ko] undefined!
ERROR: modpost: "__delay" [drivers/net/phy/mdio-cavium.ko] undefined!
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH bpf-next v3 4/6] bpf: Introduce bpf_per_cpu_ptr()
by Hao Luo
On Mon, Sep 21, 2020 at 11:11 AM Andrii Nakryiko
<andrii.nakryiko(a)gmail.com> wrote:
>
> On Thu, Sep 17, 2020 at 12:14 PM Hao Luo <haoluo(a)google.com> wrote:
> >
> > I need to cast the pointer to "const void __percpu *" before passing
> > into per_cpu_ptr. I will update and resend.
>
> You can try just declaring it as __percpu in BPF_CALL_2 macro. That
> might work, or not, depending on how exactly BPF_CALL macros are
> implemented (I haven't checked).
>
ACK. IMO it's probably better cast inside, rather than depending on
BPF_CALL macros. The parameters are not true percpu pointers anyway
and potential changes on BPF_CALL may break this, I'm afraid.
> >
> > On Wed, Sep 16, 2020 at 6:14 PM kernel test robot <lkp(a)intel.com> wrote:
> > >
> > > Hi Hao,
> > >
> > > Thank you for the patch! Perhaps something to improve:
> > >
> > > [auto build test WARNING on bpf-next/master]
> > >
> > > url: https://github.com/0day-ci/linux/commits/Hao-Luo/bpf-BTF-support-for-ksym...
> > > base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
> > > config: powerpc-randconfig-s032-20200916 (attached as .config)
> > > compiler: powerpc64-linux-gcc (GCC) 9.3.0
> > > reproduce:
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # apt-get install sparse
> > > # sparse version: v0.6.2-201-g24bdaac6-dirty
> > > # save the attached .config to linux build tree
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=powerpc
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp(a)intel.com>
> > >
> > >
> > > sparse warnings: (new ones prefixed by >>)
> > >
> > > >> kernel/bpf/helpers.c:631:31: sparse: sparse: incorrect type in initializer (different address spaces) @@ expected void const [noderef] __percpu *__vpp_verify @@ got void const * @@
> > > >> kernel/bpf/helpers.c:631:31: sparse: expected void const [noderef] __percpu *__vpp_verify
> > > >> kernel/bpf/helpers.c:631:31: sparse: got void const *
> > >
> > > # https://github.com/0day-ci/linux/commit/3f6ea3c1c73efe466a96ff7499219fe3b...
> > > git remote add linux-review https://github.com/0day-ci/linux
> > > git fetch --no-tags linux-review Hao-Luo/bpf-BTF-support-for-ksyms/20200917-064052
> > > git checkout 3f6ea3c1c73efe466a96ff7499219fe3b03b8f48
> > > vim +631 kernel/bpf/helpers.c
> > >
> > > 625
> > > 626 BPF_CALL_2(bpf_per_cpu_ptr, const void *, ptr, u32, cpu)
> > > 627 {
> > > 628 if (cpu >= nr_cpu_ids)
> > > 629 return (unsigned long)NULL;
> > > 630
> > > > 631 return (unsigned long)per_cpu_ptr(ptr, cpu);
> > > 632 }
> > > 633
> > > 634 const struct bpf_func_proto bpf_per_cpu_ptr_proto = {
> > > 635 .func = bpf_per_cpu_ptr,
> > > 636 .gpl_only = false,
> > > 637 .ret_type = RET_PTR_TO_MEM_OR_BTF_ID_OR_NULL,
> > > 638 .arg1_type = ARG_PTR_TO_PERCPU_BTF_ID,
> > > 639 .arg2_type = ARG_ANYTHING,
> > > 640 };
> > > 641
> > > > 642 const struct bpf_func_proto bpf_get_current_task_proto __weak;
> > > 643 const struct bpf_func_proto bpf_probe_read_user_proto __weak;
> > > 644 const struct bpf_func_proto bpf_probe_read_user_str_proto __weak;
> > > 645 const struct bpf_func_proto bpf_probe_read_kernel_proto __weak;
> > > 646 const struct bpf_func_proto bpf_probe_read_kernel_str_proto __weak;
> > > 647
> > >
> > > ---
> > > 0-DAY CI Kernel Test Service, Intel Corporation
> > > https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [PATCH v5 2/3] remoteproc: qcom: Add capability to collect minidumps
by kernel test robot
Hi Siddharth,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v5.9-rc7 next-20200929]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Siddharth-Gupta/Introduce-mini-d...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 171d4ff79f965c1f164705ef0aaea102a6ad238b
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/cc292eb63f7fe2d3007889428362b160e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Siddharth-Gupta/Introduce-mini-dump-support-for-remoteproc/20200925-075245
git checkout cc292eb63f7fe2d3007889428362b160e8854e9e
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
drivers/remoteproc/qcom_q6v5_pas.c: In function 'adsp_add_minidump_segments':
>> drivers/remoteproc/qcom_q6v5_pas.c:151:9: error: implicit declaration of function '__raw_readq'; did you mean '__raw_readl'? [-Werror=implicit-function-declaration]
151 | da = __raw_readq(®ion_info->region_base_address);
| ^~~~~~~~~~~
| __raw_readl
cc1: some warnings being treated as errors
vim +151 drivers/remoteproc/qcom_q6v5_pas.c
123
124 static void adsp_add_minidump_segments(struct rproc *rproc, struct md_ss_toc *minidump_ss)
125 {
126 struct md_ss_region __iomem *region_info;
127 int seg_cnt = 0, i;
128 void __iomem *ptr;
129 dma_addr_t da;
130 size_t size;
131 char *name;
132
133 seg_cnt = minidump_ss->ss_region_count;
134 ptr = ioremap((unsigned long)minidump_ss->md_ss_smem_regions_baseptr,
135 seg_cnt * sizeof(struct md_ss_region));
136
137 if (!ptr)
138 return;
139
140 region_info = ptr;
141
142 if (!list_empty(&rproc->dump_segments)) {
143 dev_info(&rproc->dev, "dump segment list already populated\n");
144 goto unmap_iomem;
145 }
146
147 for (i = 0; i < seg_cnt; i++) {
148 if (__raw_readl(®ion_info->md_valid) == MD_REGION_VALID) {
149 name = kmalloc(MAX_REGION_NAME_LENGTH, GFP_KERNEL);
150 memcpy_fromio(name, region_info->name, sizeof(region_info->name));
> 151 da = __raw_readq(®ion_info->region_base_address);
152 size = __raw_readq(®ion_info->region_size);
153 rproc_coredump_add_custom_segment(rproc, da, size, NULL, name);
154 }
155 region_info++;
156 }
157
158 unmap_iomem:
159 iounmap(ptr);
160 }
161
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[linux-next:master 9021/11956] arch/arm/mach-imx/mach-mx21ads.c:325: undefined reference to `mx21_clocks_init'
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 49e7e3e905e437a02782019570f70997e2da9101
commit: 805837740d0142c38ab94b2269ca28da3890ae68 [9021/11956] clk: imx: imx21: Remove clock driver
config: arm-randconfig-r022-20200929 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project de55ebe3bbc77882901ae2b9654503b7611b28f3)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm cross compiling tool for clang build
# apt-get install binutils-arm-linux-gnueabi
# https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commi...
git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
git fetch --no-tags linux-next master
git checkout 805837740d0142c38ab94b2269ca28da3890ae68
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Note: the linux-next/master HEAD 49e7e3e905e437a02782019570f70997e2da9101 builds fine.
It may have been fixed somewhere.
All errors (new ones prefixed by >>):
arm-linux-gnueabi-ld: arch/arm/mach-imx/mach-mx21ads.o: in function `mx21ads_timer_init':
>> arch/arm/mach-imx/mach-mx21ads.c:325: undefined reference to `mx21_clocks_init'
arm-linux-gnueabi-ld: drivers/tty/tty_io.o: in function `tty_line_name':
drivers/tty/tty_io.c:1139: undefined reference to `stpcpy'
arm-linux-gnueabi-ld: drivers/tty/tty_io.c:1139: undefined reference to `stpcpy'
arm-linux-gnueabi-ld: drivers/tty/tty_io.c:1139: undefined reference to `stpcpy'
arm-linux-gnueabi-ld: drivers/scsi/scsi_transport_sas.o: in function `get_sas_device_type_names':
drivers/scsi/scsi_transport_sas.c:131: undefined reference to `stpcpy'
arm-linux-gnueabi-ld: drivers/scsi/scsi_transport_sas.o: in function `get_sas_linkspeed_names':
drivers/scsi/scsi_transport_sas.c:158: undefined reference to `stpcpy'
arm-linux-gnueabi-ld: drivers/scsi/scsi_transport_sas.o:drivers/scsi/scsi_transport_sas.c:158: more undefined references to `stpcpy' follow
vim +325 arch/arm/mach-imx/mach-mx21ads.c
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 322
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 323 static void __init mx21ads_timer_init(void)
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 324 {
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 @325 mx21_clocks_init(32768, 26000000);
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 326 }
6b91edde09fadde arch/arm/mach-mx2/mx21ads.c Ivo Clarysse 2009-04-15 327
:::::: The code at line 325 was first introduced by commit
:::::: 6b91edde09fadde2657b11b454b88ae89c5b4cae MXC: mx21ads base support
:::::: TO: Ivo Clarysse <ivo.clarysse(a)gmail.com>
:::::: CC: Sascha Hauer <s.hauer(a)pengutronix.de>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
[dhowells-fs:rxrpc-next 2/3] net/rxrpc/conn_client.c:494:1-7: preceding lock on line 471 (fwd)
by Julia Lawall
Does the spin lock taken on line 471 need to be released in the !usable
case?
The return on line 494 also looks odd for a void function.
julia
---------- Forwarded message ----------
Date: Tue, 15 Sep 2020 09:39:41 +0800
From: kernel test robot <lkp(a)intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr>
Subject: [dhowells-fs:rxrpc-next 2/3] net/rxrpc/conn_client.c:494:1-7: preceding
lock on line 471
CC: kbuild-all(a)lists.01.org
TO: David Howells <dhowells(a)redhat.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git rxrpc-next
head: 288827d53e8edcca94caf6a507105fcbd20f419d
commit: 245500d853e9f20036cec7df4f6984ece4c6bf26 [2/3] rxrpc: Rewrite the client connection manager
:::::: branch date: 6 days ago
:::::: commit date: 6 days ago
config: i386-randconfig-c001-20200914 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> net/rxrpc/conn_client.c:494:1-7: preceding lock on line 471
# https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/com...
git remote add dhowells-fs https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git
git fetch --no-tags dhowells-fs rxrpc-next
git checkout 245500d853e9f20036cec7df4f6984ece4c6bf26
vim +494 net/rxrpc/conn_client.c
45025bceef17ed David Howells 2016-08-24 459
45025bceef17ed David Howells 2016-08-24 460 /*
245500d853e9f2 David Howells 2020-07-01 461 * Add a connection to a bundle if there are no usable connections or we have
245500d853e9f2 David Howells 2020-07-01 462 * connections waiting for extra capacity.
45025bceef17ed David Howells 2016-08-24 463 */
245500d853e9f2 David Howells 2020-07-01 464 static void rxrpc_maybe_add_conn(struct rxrpc_bundle *bundle, gfp_t gfp)
45025bceef17ed David Howells 2016-08-24 465 {
245500d853e9f2 David Howells 2020-07-01 466 struct rxrpc_call *call;
245500d853e9f2 David Howells 2020-07-01 467 int i, usable;
45025bceef17ed David Howells 2016-08-24 468
245500d853e9f2 David Howells 2020-07-01 469 _enter("");
245500d853e9f2 David Howells 2020-07-01 470
245500d853e9f2 David Howells 2020-07-01 @471 spin_lock(&bundle->channel_lock);
245500d853e9f2 David Howells 2020-07-01 472
245500d853e9f2 David Howells 2020-07-01 473 /* See if there are any usable connections. */
245500d853e9f2 David Howells 2020-07-01 474 usable = 0;
245500d853e9f2 David Howells 2020-07-01 475 for (i = 0; i < ARRAY_SIZE(bundle->conns); i++)
245500d853e9f2 David Howells 2020-07-01 476 if (rxrpc_may_reuse_conn(bundle->conns[i]))
245500d853e9f2 David Howells 2020-07-01 477 usable++;
245500d853e9f2 David Howells 2020-07-01 478
245500d853e9f2 David Howells 2020-07-01 479 if (!usable && !list_empty(&bundle->waiting_calls)) {
245500d853e9f2 David Howells 2020-07-01 480 call = list_first_entry(&bundle->waiting_calls,
245500d853e9f2 David Howells 2020-07-01 481 struct rxrpc_call, chan_wait_link);
245500d853e9f2 David Howells 2020-07-01 482 if (test_bit(RXRPC_CALL_UPGRADE, &call->flags))
245500d853e9f2 David Howells 2020-07-01 483 bundle->try_upgrade = true;
245500d853e9f2 David Howells 2020-07-01 484 }
245500d853e9f2 David Howells 2020-07-01 485
245500d853e9f2 David Howells 2020-07-01 486 if (!usable)
245500d853e9f2 David Howells 2020-07-01 487 goto alloc_conn;
245500d853e9f2 David Howells 2020-07-01 488
245500d853e9f2 David Howells 2020-07-01 489 spin_unlock(&bundle->channel_lock);
245500d853e9f2 David Howells 2020-07-01 490 _leave("");
245500d853e9f2 David Howells 2020-07-01 491 return;
245500d853e9f2 David Howells 2020-07-01 492
245500d853e9f2 David Howells 2020-07-01 493 alloc_conn:
245500d853e9f2 David Howells 2020-07-01 @494 return rxrpc_add_conn_to_bundle(bundle, gfp);
45025bceef17ed David Howells 2016-08-24 495 }
45025bceef17ed David Howells 2016-08-24 496
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months
Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the cma_heap implementation (fwd)
by Julia Lawall
Some mutex_unlocks appear to be needed in the function cma_heap_vmap.
julia
---------- Forwarded message ----------
Date: Sat, 26 Sep 2020 18:11:36 +0800
From: kernel test robot <lkp(a)intel.com>
To: kbuild(a)lists.01.org
Cc: lkp(a)intel.com, Julia Lawall <julia.lawall(a)lip6.fr>
Subject: Re: [RFC][PATCH 2/6] dma-buf: heaps: Move heap-helper logic into the
cma_heap implementation
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20200926042453.67517-3-john.stultz(a)linaro.org>
References: <20200926042453.67517-3-john.stultz(a)linaro.org>
TO: John Stultz <john.stultz(a)linaro.org>
Hi John,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linux/master]
[also build test WARNING on tegra-drm/drm/tegra/for-next linus/master next-20200925]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/John-Stultz/dma-buf-Performance-...
base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git bcf876870b95592b52519ed4aafcf9d95999bc9c
:::::: branch date: 6 hours ago
:::::: commit date: 6 hours ago
config: x86_64-randconfig-c002-20200925 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Julia Lawall <julia.lawall(a)lip6.fr>
coccinelle warnings: (new ones prefixed by >>)
>> drivers/dma-buf/heaps/cma_heap.c:203:2-8: preceding lock on line 200
drivers/dma-buf/heaps/cma_heap.c:208:2-8: preceding lock on line 200
--
>> drivers/dma-buf/heaps/cma_heap.c:119:5-8: Unneeded variable: "ret". Return "0" on line 131
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 3 months