Re: [PATCH] x86/apic/flat64: Add back the early_param("apic", parse_apic)
by kbuild test robot
Hi Dexuan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/x86/core]
[also build test WARNING on tip/auto-latest v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Dexuan-Cui/x86-apic-flat64-Add-b...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 9cb1fd0efd195590b828b9b865421ad345a4a145
config: x86_64-rhel (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> WARNING: modpost: vmlinux.o(.text+0x6a947): Section mismatch in reference from the function flat_acpi_madt_oem_check() to the variable .init.data:_node_to_pnode
The function flat_acpi_madt_oem_check() references
the variable __initdata _node_to_pnode.
This is often because flat_acpi_madt_oem_check lacks a __initdata
annotation or the annotation of _node_to_pnode is wrong.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH v4 1/3] virtio: add dma-buf support for exported objects
by kbuild test robot
In-Reply-To: <20200526105811.30784-2-stevensd(a)chromium.org>
References: <20200526105811.30784-2-stevensd(a)chromium.org>
TO: David Stevens <stevensd(a)chromium.org>
TO: Gerd Hoffmann <kraxel(a)redhat.com>
TO: David Airlie <airlied(a)linux.ie>
TO: Daniel Vetter <daniel(a)ffwll.ch>
TO: Sumit Semwal <sumit.semwal(a)linaro.org>
CC: "Michael S . Tsirkin" <mst(a)redhat.com>
CC: Jason Wang <jasowang(a)redhat.com>
CC: Maarten Lankhorst <maarten.lankhorst(a)linux.intel.com>
CC: Maxime Ripard <mripard(a)kernel.org>
CC: Thomas Zimmermann <tzimmermann(a)suse.de>
CC: David Stevens <stevensd(a)chromium.org>
Hi David,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on next-20200525]
[also build test WARNING on v5.7-rc7]
[cannot apply to linus/master v5.7-rc7 v5.7-rc6 v5.7-rc5]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/David-Stevens/Support-virtio-cro...
base: 7b4cb0a48db03a67d1ce21c4f97b1508a241a2e7
config: x86_64-randconfig-a002-20200531 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> drivers/virtio/virtio_dma_buf.o: warning: objtool: __llvm_gcov_writeout()+0x0: call without frame pointer save/setup
>> drivers/virtio/virtio_dma_buf.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
>> drivers/virtio/virtio_dma_buf.o: warning: objtool: __llvm_gcov_flush()+0x0: call without frame pointer save/setup
>> drivers/virtio/virtio_dma_buf.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[frank-w-bpi-r2-4.14:5.7-rc 32/39] drivers/net/ethernet/mediatek/mtk_eth_soc.c:2819:24: warning: initialized field overwritten
by kbuild test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.7-rc
head: b020fdd1ceb1683f13d77545ad0aa5c194fed62f
commit: d5db71dcb4b0796373d5028ac0259a900864a52c [32/39] net: ethernet: mtk_eth_soc: add support ethtool link ksettings
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout d5db71dcb4b0796373d5028ac0259a900864a52c
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/mediatek/mtk_eth_soc.c:68:5: warning: no previous prototype for 'mtk_m32' [-Wmissing-prototypes]
68 | u32 mtk_m32(struct mtk_eth *eth, u32 mask, u32 set, unsigned reg)
| ^~~~~~~
>> drivers/net/ethernet/mediatek/mtk_eth_soc.c:2819:24: warning: initialized field overwritten [-Woverride-init]
2819 | .get_link_ksettings = mtk_ethtool_get_link_ksettings,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2819:24: note: (near initialization for 'mtk_ethtool_ops.get_link_ksettings')
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2820:24: warning: initialized field overwritten [-Woverride-init]
2820 | .set_link_ksettings = mtk_ethtool_set_link_ksettings,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/mediatek/mtk_eth_soc.c:2820:24: note: (near initialization for 'mtk_ethtool_ops.set_link_ksettings')
vim +2819 drivers/net/ethernet/mediatek/mtk_eth_soc.c
2803
2804 static const struct ethtool_ops mtk_ethtool_ops = {
2805 .get_link_ksettings = mtk_get_link_ksettings,
2806 .set_link_ksettings = mtk_set_link_ksettings,
2807 .get_drvinfo = mtk_get_drvinfo,
2808 .get_msglevel = mtk_get_msglevel,
2809 .set_msglevel = mtk_set_msglevel,
2810 .nway_reset = mtk_nway_reset,
2811 .get_link = ethtool_op_get_link,
2812 .get_strings = mtk_get_strings,
2813 .get_sset_count = mtk_get_sset_count,
2814 .get_ethtool_stats = mtk_get_ethtool_stats,
2815 .get_rxnfc = mtk_get_rxnfc,
2816 .set_rxnfc = mtk_set_rxnfc,
2817 .get_pauseparam = mtk_ethtool_get_pauseparam,
2818 .set_pauseparam = mtk_ethtool_set_pauseparam,
> 2819 .get_link_ksettings = mtk_ethtool_get_link_ksettings,
2820 .set_link_ksettings = mtk_ethtool_set_link_ksettings,
2821 };
2822
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[frank-w-bpi-r2-4.14:5.7-rc 6/39] drivers/net/dsa/mt7530.c:2107:6: warning: no previous prototype for function 'mt7531_sgmii_restart_an'
by kbuild test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.7-rc
head: b020fdd1ceb1683f13d77545ad0aa5c194fed62f
commit: 0493f8e427d318aecd1c2514f39da1bef1bbe933 [6/39] net: dsa: mt7530: Add the support of MT7531 switch
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
git checkout 0493f8e427d318aecd1c2514f39da1bef1bbe933
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/dsa/mt7530.c:1723:3: error: implicit declaration of function 'mt7623_pad_clk_setup' [-Werror,-Wimplicit-function-declaration]
mt7623_pad_clk_setup(ds);
^
drivers/net/dsa/mt7530.c:1723:3: note: did you mean 'mt7530_pad_clk_setup'?
drivers/net/dsa/mt7530.c:478:1: note: 'mt7530_pad_clk_setup' declared here
mt7530_pad_clk_setup(struct dsa_switch *ds, phy_interface_t mode)
^
>> drivers/net/dsa/mt7530.c:2107:6: warning: no previous prototype for function 'mt7531_sgmii_restart_an' [-Wmissing-prototypes]
void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port)
^
drivers/net/dsa/mt7530.c:2107:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port)
^
static
1 warning and 1 error generated.
vim +/mt7531_sgmii_restart_an +2107 drivers/net/dsa/mt7530.c
2106
> 2107 void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port)
2108 {
2109 struct mt7530_priv *priv = ds->priv;
2110 u32 val;
2111
2112 val = mt7530_read(priv, MT7531_PCS_CONTROL_1(port));
2113 val |= MT7531_SGMII_AN_RESTART;
2114 mt7530_write(priv, MT7531_PCS_CONTROL_1(port), val);
2115 }
2116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[jkirsher-next-queue:dev-queue 46/57] drivers/net/ethernet/intel/iecm/iecm_txrx.c:2510:28: error: 'last_offset' undeclared; did you mean 'page_offset'?
by kbuild test robot
Hi Alice,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
head: cf731225b28c18d6e612900febee69b61a395ed8
commit: 8f6cd6503e784ae8046168c2840b466b0d4be113 [46/57] iecm: Add iecm to the kernel build system
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 8f6cd6503e784ae8046168c2840b466b0d4be113
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/intel/iecm/iecm_txrx.c:84:6: warning: no previous prototype for 'iecm_tx_buf_rel_all' [-Wmissing-prototypes]
84 | void iecm_tx_buf_rel_all(struct iecm_queue *txq)
| ^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:115:6: warning: no previous prototype for 'iecm_tx_desc_rel' [-Wmissing-prototypes]
115 | void iecm_tx_desc_rel(struct iecm_queue *txq, bool bufq)
| ^~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:136:6: warning: no previous prototype for 'iecm_tx_desc_rel_all' [-Wmissing-prototypes]
136 | void iecm_tx_desc_rel_all(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:312:6: warning: no previous prototype for 'iecm_rx_buf_rel_all' [-Wmissing-prototypes]
312 | void iecm_rx_buf_rel_all(struct iecm_queue *rxq)
| ^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:341:6: warning: no previous prototype for 'iecm_rx_desc_rel' [-Wmissing-prototypes]
341 | void iecm_rx_desc_rel(struct iecm_queue *rxq, bool bufq,
| ^~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:371:6: warning: no previous prototype for 'iecm_rx_desc_rel_all' [-Wmissing-prototypes]
371 | void iecm_rx_desc_rel_all(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:486:6: warning: no previous prototype for 'iecm_rx_hdr_buf_hw_alloc' [-Wmissing-prototypes]
486 | bool iecm_rx_hdr_buf_hw_alloc(struct iecm_queue *rxq,
| ^~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c: In function 'iecm_rx_can_reuse_page':
>> drivers/net/ethernet/intel/iecm/iecm_txrx.c:2510:28: error: 'last_offset' undeclared (first use in this function); did you mean 'page_offset'?
2510 | if (rx_buf->page_offset > last_offset)
| ^~~~~~~~~~~
| page_offset
drivers/net/ethernet/intel/iecm/iecm_txrx.c:2510:28: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/ethernet/intel/iecm/iecm_txrx.c: At top level:
drivers/net/ethernet/intel/iecm/iecm_txrx.c:3565:5: warning: no previous prototype for 'iecm_vport_splitq_napi_poll' [-Wmissing-prototypes]
3565 | int iecm_vport_splitq_napi_poll(struct napi_struct *napi, int budget)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:3603:6: warning: no previous prototype for 'iecm_vport_intr_map_vector_to_qs' [-Wmissing-prototypes]
3603 | void iecm_vport_intr_map_vector_to_qs(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/iecm/iecm_txrx.c:3715:5: warning: no previous prototype for 'iecm_vport_intr_alloc' [-Wmissing-prototypes]
3715 | int iecm_vport_intr_alloc(struct iecm_vport *vport)
| ^~~~~~~~~~~~~~~~~~~~~
In file included from drivers/net/ethernet/intel/include/iecm.h:50,
from drivers/net/ethernet/intel/iecm/iecm_txrx.c:4:
drivers/net/ethernet/intel/include/iecm_txrx.h:293:30: warning: 'iecm_rx_ptype_lkup' defined but not used [-Wunused-const-variable=]
293 | struct iecm_rx_ptype_decoded iecm_rx_ptype_lkup[IECM_RX_SUPP_PTYPE] = {
| ^~~~~~~~~~~~~~~~~~
vim +2510 drivers/net/ethernet/intel/iecm/iecm_txrx.c
8e9c2406b39ca3 Alice Michael 2020-05-18 2484
8e9c2406b39ca3 Alice Michael 2020-05-18 2485 /**
8e9c2406b39ca3 Alice Michael 2020-05-18 2486 * iecm_rx_can_reuse_page - Determine if page can be reused for another rx
8e9c2406b39ca3 Alice Michael 2020-05-18 2487 * @rx_buf: buffer containing the page
8e9c2406b39ca3 Alice Michael 2020-05-18 2488 *
8e9c2406b39ca3 Alice Michael 2020-05-18 2489 * If page is reusable, we have a green light for calling iecm_reuse_rx_page,
8e9c2406b39ca3 Alice Michael 2020-05-18 2490 * which will assign the current buffer to the buffer that next_to_alloc is
8e9c2406b39ca3 Alice Michael 2020-05-18 2491 * pointing to; otherwise, the dma mapping needs to be destroyed and
8e9c2406b39ca3 Alice Michael 2020-05-18 2492 * page freed
8e9c2406b39ca3 Alice Michael 2020-05-18 2493 */
8e9c2406b39ca3 Alice Michael 2020-05-18 2494 static bool iecm_rx_can_reuse_page(struct iecm_rx_buf *rx_buf)
8e9c2406b39ca3 Alice Michael 2020-05-18 2495 {
1eca33fee90523 Alice Michael 2020-05-18 2496 #if (PAGE_SIZE >= 8192)
1eca33fee90523 Alice Michael 2020-05-18 2497 #endif
1eca33fee90523 Alice Michael 2020-05-18 2498 unsigned int pagecnt_bias = rx_buf->pagecnt_bias;
1eca33fee90523 Alice Michael 2020-05-18 2499 struct page *page = rx_buf->page;
1eca33fee90523 Alice Michael 2020-05-18 2500
1eca33fee90523 Alice Michael 2020-05-18 2501 /* avoid re-using remote pages */
1eca33fee90523 Alice Michael 2020-05-18 2502 if (unlikely(iecm_rx_page_is_reserved(page)))
1eca33fee90523 Alice Michael 2020-05-18 2503 return false;
1eca33fee90523 Alice Michael 2020-05-18 2504
1eca33fee90523 Alice Michael 2020-05-18 2505 #if (PAGE_SIZE < 8192)
1eca33fee90523 Alice Michael 2020-05-18 2506 /* if we are only owner of page we can reuse it */
1eca33fee90523 Alice Michael 2020-05-18 2507 if (unlikely((page_count(page) - pagecnt_bias) > 1))
1eca33fee90523 Alice Michael 2020-05-18 2508 return false;
1eca33fee90523 Alice Michael 2020-05-18 2509 #else
1eca33fee90523 Alice Michael 2020-05-18 @2510 if (rx_buf->page_offset > last_offset)
1eca33fee90523 Alice Michael 2020-05-18 2511 return false;
1eca33fee90523 Alice Michael 2020-05-18 2512 #endif /* PAGE_SIZE < 8192) */
1eca33fee90523 Alice Michael 2020-05-18 2513
1eca33fee90523 Alice Michael 2020-05-18 2514 /* If we have drained the page fragment pool we need to update
1eca33fee90523 Alice Michael 2020-05-18 2515 * the pagecnt_bias and page count so that we fully restock the
1eca33fee90523 Alice Michael 2020-05-18 2516 * number of references the driver holds.
1eca33fee90523 Alice Michael 2020-05-18 2517 */
1eca33fee90523 Alice Michael 2020-05-18 2518 if (unlikely(pagecnt_bias == 1)) {
1eca33fee90523 Alice Michael 2020-05-18 2519 page_ref_add(page, USHRT_MAX - 1);
1eca33fee90523 Alice Michael 2020-05-18 2520 rx_buf->pagecnt_bias = USHRT_MAX;
1eca33fee90523 Alice Michael 2020-05-18 2521 }
1eca33fee90523 Alice Michael 2020-05-18 2522
1eca33fee90523 Alice Michael 2020-05-18 2523 return true;
8e9c2406b39ca3 Alice Michael 2020-05-18 2524 }
8e9c2406b39ca3 Alice Michael 2020-05-18 2525
:::::: The code at line 2510 was first introduced by commit
:::::: 1eca33fee905239fb42612b2aa89fdeedd33b138 iecm: Add splitq TX/RX
:::::: TO: Alice Michael <alice.michael(a)intel.com>
:::::: CC: Jeff Kirsher <jeffrey.t.kirsher(a)intel.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[frank-w-bpi-r2-4.14:5.7-rc 13/50] cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory
by kbuild test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.7-rc
head: b020fdd1ceb1683f13d77545ad0aa5c194fed62f
commit: f3f726dccda55cf4cfa3d9bc23923dc5b9e48404 [13/50] mt6625l: include wifi-folder
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout f3f726dccda55cf4cfa3d9bc23923dc5b9e48404
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the frank-w-bpi-r2-4.14/5.7-rc HEAD b020fdd1ceb1683f13d77545ad0aa5c194fed62f builds fine.
It only hurts bisectibility.
All error/warnings (new ones prefixed by >>, old ones prefixed by <<):
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-/include/mach: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/btif/common/plat_inc/btif_pub.h:17,
from drivers/misc/mediatek/btif/common/mtk_btif.c:37:
drivers/misc/mediatek/btif/common/plat_inc/plat_common.h: In function 'hal_log_print':
>> drivers/misc/mediatek/btif/common/plat_inc/plat_common.h:64:2: error: function 'hal_log_print' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
64 | vsnprintf(temp_sring, DBG_LOG_STR_SIZE, str, args);
| ^~~~~~~~~
drivers/misc/mediatek/btif/common/mtk_btif.c: In function 'mtk_btif_restore_noirq':
>> drivers/misc/mediatek/btif/common/mtk_btif.c:379:6: error: variable 'i_ret' set but not used [-Werror=unused-but-set-variable]
379 | int i_ret = 0;
| ^~~~~
drivers/misc/mediatek/btif/common/mtk_btif.c: At top level:
>> drivers/misc/mediatek/btif/common/mtk_btif.c:522:6: error: no previous prototype for 'btif_rx_notify_cb' [-Werror=missing-prototypes]
522 | void btif_rx_notify_cb(void)
| ^~~~~~~~~~~~~~~~~
drivers/misc/mediatek/btif/common/mtk_btif.c: In function 'flag_store':
>> drivers/misc/mediatek/btif/common/mtk_btif.c:773:6: error: variable 'result' set but not used [-Werror=unused-but-set-variable]
773 | int result = 0;
| ^~~~~~
drivers/misc/mediatek/btif/common/mtk_btif.c: In function '_btif_pio_write':
>> drivers/misc/mediatek/btif/common/mtk_btif.c:2779:42: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]
2779 | if ((++retry > max_tx_retry) || (i_ret < 0)) {
| ^
drivers/misc/mediatek/btif/common/mtk_btif.c: In function 'btif_log_buf_dmp_out':
>> drivers/misc/mediatek/btif/common/mtk_btif.c:3034:17: error: variable 'p_buf' set but not used [-Werror=unused-but-set-variable]
3034 | unsigned char *p_buf = NULL;
| ^~~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-/include/mach: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/btif/common/plat_inc/btif_pub.h:17,
from drivers/misc/mediatek/btif/common/inc/mtk_btif.h:37,
from drivers/misc/mediatek/btif/common/mtk_btif_exp.c:20:
drivers/misc/mediatek/btif/common/plat_inc/plat_common.h: In function 'hal_log_print':
>> drivers/misc/mediatek/btif/common/plat_inc/plat_common.h:64:2: error: function 'hal_log_print' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
64 | vsnprintf(temp_sring, DBG_LOG_STR_SIZE, str, args);
| ^~~~~~~~~
drivers/misc/mediatek/btif/common/mtk_btif_exp.c: At top level:
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:24:12: error: no previous prototype for 'btif_exp_srh_id' [-Werror=missing-prototypes]
24 | p_mtk_btif btif_exp_srh_id(unsigned long u_id)
| ^~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:512:5: error: no previous prototype for 'btif_open_no_id' [-Werror=missing-prototypes]
512 | int btif_open_no_id(void)
| ^~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:527:5: error: no previous prototype for 'btif_close_no_id' [-Werror=missing-prototypes]
527 | int btif_close_no_id(void)
| ^~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:541:5: error: no previous prototype for 'btif_write_no_id' [-Werror=missing-prototypes]
541 | int btif_write_no_id(const unsigned char *p_buf, unsigned int len)
| ^~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:562:5: error: no previous prototype for 'btif_dpidle_ctrl_no_id' [-Werror=missing-prototypes]
562 | int btif_dpidle_ctrl_no_id(ENUM_BTIF_DPIDLE_CTRL en_flag)
| ^~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:586:5: error: no previous prototype for 'btif_loopback_ctrl_no_id' [-Werror=missing-prototypes]
586 | int btif_loopback_ctrl_no_id(ENUM_BTIF_LPBK_MODE enable)
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/btif/common/mtk_btif_exp.c:597:5: error: no previous prototype for 'btif_dbg_ctrl_no_id' [-Werror=missing-prototypes]
597 | int btif_dbg_ctrl_no_id(ENUM_BTIF_DBG_ID flag)
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-/include/mach: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/btif/common/plat_inc/btif_dma_pub.h:19,
from drivers/misc/mediatek/btif/common/plat_inc/btif_dma_priv.h:18,
from drivers/misc/mediatek/btif/common/btif_dma_plat.c:22:
drivers/misc/mediatek/btif/common/plat_inc/plat_common.h: In function 'hal_log_print':
>> drivers/misc/mediatek/btif/common/plat_inc/plat_common.h:64:2: error: function 'hal_log_print' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
64 | vsnprintf(temp_sring, DBG_LOG_STR_SIZE, str, args);
| ^~~~~~~~~
drivers/misc/mediatek/btif/common/btif_dma_plat.c: In function 'hal_dma_pm_ops':
>> drivers/misc/mediatek/btif/common/btif_dma_plat.c:1315:17: error: variable 'flag' set but not used [-Werror=unused-but-set-variable]
1315 | unsigned int flag = 0;
| ^~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-/include/mach: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/btif/common/plat_inc/btif_pub.h:17,
from drivers/misc/mediatek/btif/common/btif_plat.c:21:
drivers/misc/mediatek/btif/common/plat_inc/plat_common.h: In function 'hal_log_print':
>> drivers/misc/mediatek/btif/common/plat_inc/plat_common.h:64:2: error: function 'hal_log_print' might be a candidate for 'gnu_printf' format attribute [-Werror=suggest-attribute=format]
64 | vsnprintf(temp_sring, DBG_LOG_STR_SIZE, str, args);
| ^~~~~~~~~
drivers/misc/mediatek/btif/common/btif_plat.c: In function 'hal_btif_pm_ops':
>> drivers/misc/mediatek/btif/common/btif_plat.c:1348:17: error: variable 'flag' set but not used [-Werror=unused-but-set-variable]
1348 | unsigned int flag = 0;
| ^~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/wmt_gpio.c:15:
>> drivers/misc/mediatek/connectivity/common/common_detect/wmt_gpio.h:24:10: fatal error: osal.h: No such file or directory
24 | #include "osal.h"
| ^~~~~~~~
cc1: all warnings being treated as errors
compilation terminated.
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:20:
drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c: In function 'hif_sdio_is_chipid_valid':
>> drivers/misc/mediatek/connectivity/common/common_detect/wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
>> drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:108:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
108 | WMT_DETECT_ERR_FUNC("no supported chipid foundn");
| ^~~~~~~~~~~~~~~~~~~
drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c: In function 'hif_sdio_match_chipid_by_dev_id':
>> drivers/misc/mediatek/connectivity/common/common_detect/wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:135:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
135 | WMT_DETECT_ERR_FUNC("No valid chipId found, vendor id(0x%x), device id(0x%x)n", id->vendor,
| ^~~~~~~~~~~~~~~~~~~
drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c: In function 'sdio_detect_probe':
>> drivers/misc/mediatek/connectivity/common/common_detect/wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:236:4: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
236 | WMT_DETECT_ERR_FUNC("sdio_enable_func failed!n");
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:20:
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c: In function 'do_wlan_drv_init':
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:31:2: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
31 | WMT_DETECT_ERR_FUNC("Can not find wlan module for chip: %d !n", chip_id);
| ^~~~~~~~~~~~~~~~~~~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c: In function 'do_connectivity_driver_init':
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:49:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
49 | WMT_DETECT_ERR_FUNC("do common driver init failed, ret:%dn", tmp_ret);
| ^~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:50:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
50 | WMT_DETECT_ERR_FUNC("abort connectivity driver init, because common part is not readyn");
| ^~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:58:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
58 | WMT_DETECT_ERR_FUNC("do common driver init failed, ret:%dn", tmp_ret);
| ^~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/conn_drv_init.c:75:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
75 | WMT_DETECT_ERR_FUNC("do wlan module init failed, ret:%dn", tmp_ret);
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/drv_init/common_drv_init.c:20:
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/common_drv_init.c: In function 'do_combo_common_drv_init':
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/common_drv_init.c:54:2: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
54 | WMT_DETECT_ERR_FUNC("COMBO chip is not supported, please check CONFIG_MTK_COMBO_CHIP in kernel confign");
| ^~~~~~~~~~~~~~~~~~~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/common_drv_init.c: In function 'do_soc_common_drv_init':
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/common_drv_init.c:76:2: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
76 | WMT_DETECT_ERR_FUNC("SOC chip is not supported, please check CONFIG_MTK_COMBO_CHIP in kernel confign");
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
cc1: all warnings being treated as errors
--
>> cc1: error: drivers/misc/mediatek/include/mt-plat//include: No such file or directory [-Werror=missing-include-dirs]
>> cc1: error: arch/arm/mach-//dct/dct: No such file or directory [-Werror=missing-include-dirs]
In file included from drivers/misc/mediatek/connectivity/common/common_detect/drv_init/wlan_drv_init.c:20:
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/wlan_drv_init.c: In function 'do_wlan_drv_init':
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/wlan_drv_init.c:47:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
47 | WMT_DETECT_ERR_FUNC("WLAN-GEN3 driver is not supported, please check CONFIG_MTK_COMBO_CHIPn");
| ^~~~~~~~~~~~~~~~~~~
>> drivers/misc/mediatek/connectivity/common/common_detect/drv_init/../wmt_detect.h:77:23: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits]
77 | if (gWmtDetectDbgLvl >= WMT_DETECT_LOG_ERR) | ^~
drivers/misc/mediatek/connectivity/common/common_detect/drv_init/wlan_drv_init.c:62:3: note: in expansion of macro 'WMT_DETECT_ERR_FUNC'
62 | WMT_DETECT_ERR_FUNC("WLAN-GEN2 driver is not supported, please check CONFIG_MTK_COMBO_CHIPn");
| ^~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[jkirsher-next-queue:dev-queue 8/57] drivers/net/ethernet/intel/ice/ice_idc.c:432:7: error: implicit declaration of function 'ice_pf_state_is_nominal'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
head: cf731225b28c18d6e612900febee69b61a395ed8
commit: d0ed22b261179970c5551628fd3b78ea4c0652ac [8/57] ice: Support resource allocation requests
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout d0ed22b261179970c5551628fd3b78ea4c0652ac
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/ethernet/intel/ice/ice_idc.c: In function 'ice_peer_alloc_rdma_qsets':
drivers/net/ethernet/intel/ice/ice_idc.c:270:7: error: implicit declaration of function 'ice_validate_peer_dev' [-Werror=implicit-function-declaration]
270 | if (!ice_validate_peer_dev(peer_dev) || !res)
| ^~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_idc.c: In function 'ice_peer_alloc_res':
>> drivers/net/ethernet/intel/ice/ice_idc.c:432:7: error: implicit declaration of function 'ice_pf_state_is_nominal' [-Werror=implicit-function-declaration]
432 | if (!ice_pf_state_is_nominal(pf))
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_idc.c: In function 'ice_peer_unregister':
drivers/net/ethernet/intel/ice/ice_idc.c:496:17: error: implicit declaration of function 'peer_to_ice_dev_int' [-Werror=implicit-function-declaration]
496 | peer_dev_int = peer_to_ice_dev_int(peer_dev);
| ^~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/intel/ice/ice_idc.c:496:15: warning: assignment to 'struct ice_peer_dev_int *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
496 | peer_dev_int = peer_to_ice_dev_int(peer_dev);
| ^
drivers/net/ethernet/intel/ice/ice_idc.c:498:8: error: implicit declaration of function 'ice_peer_close'; did you mean 'ice_vsi_close'? [-Werror=implicit-function-declaration]
498 | ret = ice_peer_close(peer_dev_int, &reason);
| ^~~~~~~~~~~~~~
| ice_vsi_close
drivers/net/ethernet/intel/ice/ice_idc.c: In function 'ice_peer_register':
drivers/net/ethernet/intel/ice/ice_idc.c:543:15: warning: assignment to 'struct ice_peer_dev_int *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
543 | peer_dev_int = peer_to_ice_dev_int(peer_dev);
| ^
drivers/net/ethernet/intel/ice/ice_idc.c: In function 'ice_peer_update_vsi_filter':
>> drivers/net/ethernet/intel/ice/ice_idc.c:581:8: error: implicit declaration of function 'ice_cfg_iwarp_fltr' [-Werror=implicit-function-declaration]
581 | ret = ice_cfg_iwarp_fltr(&pf->hw, vsi->idx, enable);
| ^~~~~~~~~~~~~~~~~~
At top level:
drivers/net/ethernet/intel/ice/ice_idc.c:597:30: warning: 'ops' defined but not used [-Wunused-const-variable=]
597 | static const struct iidc_ops ops = {
| ^~~
cc1: some warnings being treated as errors
vim +/ice_pf_state_is_nominal +432 drivers/net/ethernet/intel/ice/ice_idc.c
247
248 /**
249 * ice_peer_alloc_rdma_qsets - Allocate Leaf Nodes for RDMA Qset
250 * @peer_dev: peer that is requesting the Leaf Nodes
251 * @res: Resources to be allocated
252 * @partial_acceptable: If partial allocation is acceptable to the peer
253 *
254 * This function allocates Leaf Nodes for given RDMA Qset resources
255 * for the peer device.
256 */
257 static int
258 ice_peer_alloc_rdma_qsets(struct iidc_peer_dev *peer_dev, struct iidc_res *res,
259 int __always_unused partial_acceptable)
260 {
261 u16 max_rdmaqs[ICE_MAX_TRAFFIC_CLASS];
262 enum ice_status status;
263 struct ice_vsi *vsi;
264 struct device *dev;
265 struct ice_pf *pf;
266 int i, ret = 0;
267 u32 *qset_teid;
268 u16 *qs_handle;
269
> 270 if (!ice_validate_peer_dev(peer_dev) || !res)
271 return -EINVAL;
272
273 pf = pci_get_drvdata(peer_dev->pdev);
274 dev = ice_pf_to_dev(pf);
275
276 if (res->cnt_req > ICE_MAX_TXQ_PER_TXQG)
277 return -EINVAL;
278
279 qset_teid = kcalloc(res->cnt_req, sizeof(*qset_teid), GFP_KERNEL);
280 if (!qset_teid)
281 return -ENOMEM;
282
283 qs_handle = kcalloc(res->cnt_req, sizeof(*qs_handle), GFP_KERNEL);
284 if (!qs_handle) {
285 kfree(qset_teid);
286 return -ENOMEM;
287 }
288
289 ice_for_each_traffic_class(i)
290 max_rdmaqs[i] = 0;
291
292 for (i = 0; i < res->cnt_req; i++) {
293 struct iidc_rdma_qset_params *qset;
294
295 qset = &res->res[i].res.qsets;
296 if (qset->vsi_id != peer_dev->pf_vsi_num) {
297 dev_err(dev, "RDMA QSet invalid VSI requested\n");
298 ret = -EINVAL;
299 goto out;
300 }
301 max_rdmaqs[qset->tc]++;
302 qs_handle[i] = qset->qs_handle;
303 }
304
305 vsi = ice_find_vsi(pf, peer_dev->pf_vsi_num);
306 if (!vsi) {
307 dev_err(dev, "RDMA QSet invalid VSI\n");
308 ret = -EINVAL;
309 goto out;
310 }
311
312 status = ice_cfg_vsi_rdma(vsi->port_info, vsi->idx, vsi->tc_cfg.ena_tc,
313 max_rdmaqs);
314 if (status) {
315 dev_err(dev, "Failed VSI RDMA qset config\n");
316 ret = -EINVAL;
317 goto out;
318 }
319
320 for (i = 0; i < res->cnt_req; i++) {
321 struct iidc_rdma_qset_params *qset;
322
323 qset = &res->res[i].res.qsets;
324 status = ice_ena_vsi_rdma_qset(vsi->port_info, vsi->idx,
325 qset->tc, &qs_handle[i], 1,
326 &qset_teid[i]);
327 if (status) {
328 dev_err(dev, "Failed VSI RDMA qset enable\n");
329 ret = -EINVAL;
330 goto out;
331 }
332 vsi->qset_handle[qset->tc] = qset->qs_handle;
333 qset->teid = qset_teid[i];
334 }
335
336 out:
337 kfree(qset_teid);
338 kfree(qs_handle);
339 return ret;
340 }
341
342 /**
343 * ice_peer_free_rdma_qsets - Free leaf nodes for RDMA Qset
344 * @peer_dev: peer that requested qsets to be freed
345 * @res: Resource to be freed
346 */
347 static int
348 ice_peer_free_rdma_qsets(struct iidc_peer_dev *peer_dev, struct iidc_res *res)
349 {
350 enum ice_status status;
351 int count, i, ret = 0;
352 struct ice_vsi *vsi;
353 struct device *dev;
354 struct ice_pf *pf;
355 u16 vsi_id;
356 u32 *teid;
357 u16 *q_id;
358
359 if (!ice_validate_peer_dev(peer_dev) || !res)
360 return -EINVAL;
361
362 pf = pci_get_drvdata(peer_dev->pdev);
363 dev = ice_pf_to_dev(pf);
364
365 count = res->res_allocated;
366 if (count > ICE_MAX_TXQ_PER_TXQG)
367 return -EINVAL;
368
369 teid = kcalloc(count, sizeof(*teid), GFP_KERNEL);
370 if (!teid)
371 return -ENOMEM;
372
373 q_id = kcalloc(count, sizeof(*q_id), GFP_KERNEL);
374 if (!q_id) {
375 kfree(teid);
376 return -ENOMEM;
377 }
378
379 vsi_id = res->res[0].res.qsets.vsi_id;
380 vsi = ice_find_vsi(pf, vsi_id);
381 if (!vsi) {
382 dev_err(dev, "RDMA Invalid VSI\n");
383 ret = -EINVAL;
384 goto rdma_free_out;
385 }
386
387 for (i = 0; i < count; i++) {
388 struct iidc_rdma_qset_params *qset;
389
390 qset = &res->res[i].res.qsets;
391 if (qset->vsi_id != vsi_id) {
392 dev_err(dev, "RDMA Invalid VSI ID\n");
393 ret = -EINVAL;
394 goto rdma_free_out;
395 }
396 q_id[i] = qset->qs_handle;
397 teid[i] = qset->teid;
398
399 vsi->qset_handle[qset->tc] = 0;
400 }
401
402 status = ice_dis_vsi_rdma_qset(vsi->port_info, count, teid, q_id);
403 if (status)
404 ret = -EINVAL;
405
406 rdma_free_out:
407 kfree(teid);
408 kfree(q_id);
409
410 return ret;
411 }
412
413 /**
414 * ice_peer_alloc_res - Allocate requested resources for peer device
415 * @peer_dev: peer that is requesting resources
416 * @res: Resources to be allocated
417 * @partial_acceptable: If partial allocation is acceptable to the peer
418 *
419 * This function allocates requested resources for the peer device.
420 */
421 static int
422 ice_peer_alloc_res(struct iidc_peer_dev *peer_dev, struct iidc_res *res,
423 int partial_acceptable)
424 {
425 struct ice_pf *pf;
426 int ret;
427
428 if (!ice_validate_peer_dev(peer_dev) || !res)
429 return -EINVAL;
430
431 pf = pci_get_drvdata(peer_dev->pdev);
> 432 if (!ice_pf_state_is_nominal(pf))
433 return -EBUSY;
434
435 switch (res->res_type) {
436 case IIDC_RDMA_QSETS_TXSCHED:
437 ret = ice_peer_alloc_rdma_qsets(peer_dev, res,
438 partial_acceptable);
439 break;
440 default:
441 ret = -EINVAL;
442 break;
443 }
444
445 return ret;
446 }
447
448 /**
449 * ice_peer_free_res - Free given resources
450 * @peer_dev: peer that is requesting freeing of resources
451 * @res: Resources to be freed
452 *
453 * Free/Release resources allocated to given peer device.
454 */
455 static int
456 ice_peer_free_res(struct iidc_peer_dev *peer_dev, struct iidc_res *res)
457 {
458 int ret;
459
460 if (!ice_validate_peer_dev(peer_dev) || !res)
461 return -EINVAL;
462
463 switch (res->res_type) {
464 case IIDC_RDMA_QSETS_TXSCHED:
465 ret = ice_peer_free_rdma_qsets(peer_dev, res);
466 break;
467 default:
468 ret = -EINVAL;
469 break;
470 }
471
472 return ret;
473 }
474
475 /**
476 * ice_peer_unregister - request to unregister peer
477 * @peer_dev: peer device
478 *
479 * This function triggers close/remove on peer_dev allowing peer
480 * to unregister.
481 */
482 static int ice_peer_unregister(struct iidc_peer_dev *peer_dev)
483 {
484 enum iidc_close_reason reason = IIDC_REASON_PEER_DEV_UNINIT;
485 struct ice_peer_dev_int *peer_dev_int;
486 struct ice_pf *pf;
487 int ret;
488
489 if (!ice_validate_peer_dev(peer_dev))
490 return -EINVAL;
491
492 pf = pci_get_drvdata(peer_dev->pdev);
493 if (ice_is_reset_in_progress(pf->state))
494 return -EBUSY;
495
496 peer_dev_int = peer_to_ice_dev_int(peer_dev);
497
> 498 ret = ice_peer_close(peer_dev_int, &reason);
499 if (ret)
500 return ret;
501
502 peer_dev->peer_ops = NULL;
503
504 ice_peer_state_change(peer_dev_int, ICE_PEER_DEV_STATE_REMOVED, false);
505
506 return 0;
507 }
508
509 /**
510 * ice_peer_register - Called by peer to open communication with LAN
511 * @peer_dev: ptr to peer device
512 *
513 * registering peer is expected to populate the ice_peerdrv->name field
514 * before calling this function.
515 */
516 static int ice_peer_register(struct iidc_peer_dev *peer_dev)
517 {
518 struct ice_peer_drv_int *peer_drv_int;
519 struct ice_peer_dev_int *peer_dev_int;
520 struct iidc_peer_drv *peer_drv;
521
522 if (!peer_dev) {
523 pr_err("Failed to reg peer dev: peer_dev ptr NULL\n");
524 return -EINVAL;
525 }
526
527 if (!peer_dev->pdev) {
528 pr_err("Failed to reg peer dev: peer dev pdev NULL\n");
529 return -EINVAL;
530 }
531
532 if (!peer_dev->peer_ops || !peer_dev->ops) {
533 pr_err("Failed to reg peer dev: peer dev peer_ops/ops NULL\n");
534 return -EINVAL;
535 }
536
537 peer_drv = peer_dev->peer_drv;
538 if (!peer_drv) {
539 pr_err("Failed to reg peer dev: peer drv NULL\n");
540 return -EINVAL;
541 }
542
543 peer_dev_int = peer_to_ice_dev_int(peer_dev);
544 peer_drv_int = peer_dev_int->peer_drv_int;
545 if (!peer_drv_int) {
546 pr_err("Failed to match peer_drv_int to peer_dev\n");
547 return -EINVAL;
548 }
549
550 peer_drv_int->peer_drv = peer_drv;
551
552 ice_peer_state_change(peer_dev_int, ICE_PEER_DEV_STATE_PROBED, false);
553
554 return 0;
555 }
556
557 /**
558 * ice_peer_update_vsi_filter - update main VSI filters for RDMA
559 * @peer_dev: pointer to RDMA peer device
560 * @filter: selection of filters to enable or disable
561 * @enable: bool whether to enable or disable filters
562 */
563 static int
564 ice_peer_update_vsi_filter(struct iidc_peer_dev *peer_dev,
565 enum iidc_rdma_filter __always_unused filter,
566 bool enable)
567 {
568 struct ice_vsi *vsi;
569 struct ice_pf *pf;
570 int ret;
571
572 if (!ice_validate_peer_dev(peer_dev))
573 return -EINVAL;
574
575 pf = pci_get_drvdata(peer_dev->pdev);
576
577 vsi = ice_get_main_vsi(pf);
578 if (!vsi)
579 return -EINVAL;
580
> 581 ret = ice_cfg_iwarp_fltr(&pf->hw, vsi->idx, enable);
582
583 if (ret) {
584 dev_err(ice_pf_to_dev(pf), "Failed to %sable iWARP filtering\n",
585 enable ? "en" : "dis");
586 } else {
587 if (enable)
588 vsi->info.q_opt_flags |= ICE_AQ_VSI_Q_OPT_PE_FLTR_EN;
589 else
590 vsi->info.q_opt_flags &= ~ICE_AQ_VSI_Q_OPT_PE_FLTR_EN;
591 }
592
593 return ret;
594 }
595
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
[frank-w-bpi-r2-4.14:5.7-rc 6/39] drivers/net/dsa/mt7530.c:2107:6: warning: no previous prototype for 'mt7531_sgmii_restart_an'
by kbuild test robot
tree: https://github.com/frank-w/BPI-R2-4.14 5.7-rc
head: b020fdd1ceb1683f13d77545ad0aa5c194fed62f
commit: 0493f8e427d318aecd1c2514f39da1bef1bbe933 [6/39] net: dsa: mt7530: Add the support of MT7531 switch
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 0493f8e427d318aecd1c2514f39da1bef1bbe933
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
drivers/net/dsa/mt7530.c: In function 'mt7530_pad_setup':
drivers/net/dsa/mt7530.c:1723:3: error: implicit declaration of function 'mt7623_pad_clk_setup'; did you mean 'mt7530_pad_clk_setup'? [-Werror=implicit-function-declaration]
1723 | mt7623_pad_clk_setup(ds);
| ^~~~~~~~~~~~~~~~~~~~
| mt7530_pad_clk_setup
drivers/net/dsa/mt7530.c: At top level:
>> drivers/net/dsa/mt7530.c:2107:6: warning: no previous prototype for 'mt7531_sgmii_restart_an' [-Wmissing-prototypes]
2107 | void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port)
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/mt7531_sgmii_restart_an +2107 drivers/net/dsa/mt7530.c
2106
> 2107 void mt7531_sgmii_restart_an(struct dsa_switch *ds, int port)
2108 {
2109 struct mt7530_priv *priv = ds->priv;
2110 u32 val;
2111
2112 val = mt7530_read(priv, MT7531_PCS_CONTROL_1(port));
2113 val |= MT7531_SGMII_AN_RESTART;
2114 mt7530_write(priv, MT7531_PCS_CONTROL_1(port), val);
2115 }
2116
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months
Re: [PATCH 1/2] tracing: Move synthetic events to a separate file
by kbuild test robot
In-Reply-To: <9fc01420bdbf756ef3f8267b33aff6de2e6f2b60.1590608239.git.zanussi(a)kernel.org>
References: <9fc01420bdbf756ef3f8267b33aff6de2e6f2b60.1590608239.git.zanussi(a)kernel.org>
TO: Tom Zanussi <zanussi(a)kernel.org>
Hi Tom,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/perf/core]
[also build test WARNING on trace/for-next linus/master v5.7-rc7 next-20200529]
[cannot apply to linux/master]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Tom-Zanussi/tracing-Make-synthet...
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git c50c75e9b87946499a62bffc021e95c87a1d57cd
config: x86_64-randconfig-a002-20200531 (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>, old ones prefixed by <<):
>> kernel/trace/trace_events_synth.o: warning: objtool: __llvm_gcov_writeout()+0x7: call without frame pointer save/setup
>> kernel/trace/trace_events_synth.o: warning: objtool: __llvm_gcov_reset()+0x0: call without frame pointer save/setup
>> kernel/trace/trace_events_synth.o: warning: objtool: __llvm_gcov_flush()+0x0: call without frame pointer save/setup
>> kernel/trace/trace_events_synth.o: warning: objtool: __llvm_gcov_init()+0x0: call without frame pointer save/setup
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
9 months