Re: [RFC V2 2/3] arm64/mm: Define arch_get_mappable_range()
by kernel test robot
Hi Anshuman,
[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on v5.10-rc6]
[cannot apply to mmotm/master s390/features arm64/for-next/core hnaz-linux-mm/master next-20201130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Anshuman-Khandual/mm-hotplug-Pre...
base: b65054597872ce3aefbc6a666385eabdf9e288da
config: arm64-randconfig-r002-20201130 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project dfcf1acf13226be0f599a7ab6b395b66dc9545d6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/7d8145ca97fc2f90d8378399cf1823cfd...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Anshuman-Khandual/mm-hotplug-Pre-validate-the-address-range-with-platform/20201130-113145
git checkout 7d8145ca97fc2f90d8378399cf1823cfd90049be
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
>> arch/arm64/mm/mmu.c:1447:14: warning: no previous prototype for function 'arch_get_mappable_range' [-Wmissing-prototypes]
struct range arch_get_mappable_range(void)
^
arch/arm64/mm/mmu.c:1447:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct range arch_get_mappable_range(void)
^
static
1 warning generated.
vim +/arch_get_mappable_range +1447 arch/arm64/mm/mmu.c
1446
> 1447 struct range arch_get_mappable_range(void)
1448 {
1449 struct range memhp_range;
1450
1451 /*
1452 * Linear mapping region is the range [PAGE_OFFSET..(PAGE_END - 1)]
1453 * accommodating both its ends but excluding PAGE_END. Max physical
1454 * range which can be mapped inside this linear mapping range, must
1455 * also be derived from its end points.
1456 */
1457 memhp_range.start = __pa(_PAGE_OFFSET(vabits_actual));
1458 memhp_range.end = __pa(PAGE_END - 1);
1459 return memhp_range;
1460 }
1461
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
Re: [PATCH 17/18] gpio: gpiolib-acpi: Export acpi_get_gpiod()
by kernel test robot
Hi Daniel,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on driver-core/driver-core-testing pm/linux-next v5.10-rc6 next-20201130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Add-functionality-...
base: git://linuxtv.org/media_tree.git master
config: s390-randconfig-p001-20201130 (attached as .config)
compiler: s390-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/eb1854ac694a8e59c0ea703e46fe2ee7e...
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Daniel-Scally/Add-functionality-to-ipu3-cio2-driver-allowing-software_node-connections-to-sensors-on-platforms-designed-for-Windows/20201130-214014
git checkout eb1854ac694a8e59c0ea703e46fe2ee7e3118b42
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
s390-linux-ld: kernel/sysctl.o: in function `acpi_get_gpiod':
>> sysctl.c:(.text+0x2bb8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: kernel/irq/irqdomain.o: in function `acpi_get_gpiod':
irqdomain.c:(.text+0x378): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: kernel/dma/mapping.o: in function `acpi_get_gpiod':
mapping.c:(.text+0xb0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/gpio/gpiolib.o: in function `acpi_get_gpiod':
gpiolib.c:(.text+0x1c00): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/gpio/gpio-pca953x.o: in function `acpi_get_gpiod':
gpio-pca953x.c:(.text+0x29e0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/gpio/gpio-pca9570.o: in function `acpi_get_gpiod':
gpio-pca9570.c:(.text+0x338): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/gpio/gpio-pcf857x.o: in function `acpi_get_gpiod':
gpio-pcf857x.c:(.text+0xcb0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/gpio/gpio-tpic2810.o: in function `acpi_get_gpiod':
gpio-tpic2810.c:(.text+0x418): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/pwm/core.o: in function `acpi_get_gpiod':
core.c:(.text+0x660): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/pwm/pwm-pca9685.o: in function `acpi_get_gpiod':
pwm-pca9685.c:(.text+0x10d8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/dma/dmaengine.o: in function `acpi_get_gpiod':
dmaengine.c:(.text+0x1f30): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/dma/dw/platform.o: in function `acpi_get_gpiod':
platform.c:(.text+0x420): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/dma/qcom/hidma.o: in function `acpi_get_gpiod':
hidma.c:(.text+0x28e8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/88pg86x.o: in function `acpi_get_gpiod':
88pg86x.c:(.text+0x198): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/ad5398.o: in function `acpi_get_gpiod':
ad5398.c:(.text+0x780): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/da9210-regulator.o: in function `acpi_get_gpiod':
da9210-regulator.c:(.text+0x628): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/isl6271a-regulator.o: in function `acpi_get_gpiod':
isl6271a-regulator.c:(.text+0x3b8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/isl9305.o: in function `acpi_get_gpiod':
isl9305.c:(.text+0x1a0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/lp872x.o: in function `acpi_get_gpiod':
lp872x.c:(.text+0x11c0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/lp8755.o: in function `acpi_get_gpiod':
lp8755.c:(.text+0x1148): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/ltc3589.o: in function `acpi_get_gpiod':
ltc3589.c:(.text+0x8c8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/max8649.o: in function `acpi_get_gpiod':
max8649.c:(.text+0x7a0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/max8660.o: in function `acpi_get_gpiod':
max8660.c:(.text+0xe28): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/max77826-regulator.o: in function `acpi_get_gpiod':
max77826-regulator.c:(.text+0x230): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/mp8859.o: in function `acpi_get_gpiod':
mp8859.c:(.text+0x2e0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/mt6311-regulator.o: in function `acpi_get_gpiod':
mt6311-regulator.c:(.text+0x248): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/pca9450-regulator.o: in function `acpi_get_gpiod':
pca9450-regulator.c:(.text+0x790): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/pfuze100-regulator.o: in function `acpi_get_gpiod':
pfuze100-regulator.c:(.text+0xaa8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/pv88060-regulator.o: in function `acpi_get_gpiod':
pv88060-regulator.c:(.text+0x870): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/pv88080-regulator.o: in function `acpi_get_gpiod':
pv88080-regulator.c:(.text+0xb38): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/pv88090-regulator.o: in function `acpi_get_gpiod':
pv88090-regulator.c:(.text+0x960): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/rt4801-regulator.o: in function `acpi_get_gpiod':
rt4801-regulator.c:(.text+0x6a0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/rtmv20-regulator.o: in function `acpi_get_gpiod':
rtmv20-regulator.c:(.text+0xb20): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/slg51000-regulator.o: in function `acpi_get_gpiod':
slg51000-regulator.c:(.text+0xb28): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/tps62360-regulator.o: in function `acpi_get_gpiod':
tps62360-regulator.c:(.text+0xe68): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/regulator/tps65132-regulator.o: in function `acpi_get_gpiod':
tps65132-regulator.c:(.text+0x728): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/core.o: in function `acpi_get_gpiod':
core.c:(.text+0x27f8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/platform.o: in function `acpi_get_gpiod':
platform.c:(.text+0x798): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/cpu.o: in function `acpi_get_gpiod':
cpu.c:(.text+0x8c8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/property.o: in function `acpi_get_gpiod':
property.c:(.text+0x2f8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/cacheinfo.o: in function `acpi_get_gpiod':
cacheinfo.c:(.text+0xca8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/base/regmap/regmap-i2c.o: in function `acpi_get_gpiod':
regmap-i2c.c:(.text+0xcb0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/ad525x_dpot-i2c.o: in function `acpi_get_gpiod':
ad525x_dpot-i2c.c:(.text+0x278): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/bh1770glc.o: in function `acpi_get_gpiod':
bh1770glc.c:(.text+0x28a8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/apds990x.o: in function `acpi_get_gpiod':
apds990x.c:(.text+0x23a8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/isl29003.o: in function `acpi_get_gpiod':
isl29003.c:(.text+0xad8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/isl29020.o: in function `acpi_get_gpiod':
isl29020.c:(.text+0x5e8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/tsl2550.o: in function `acpi_get_gpiod':
tsl2550.c:(.text+0x9d8): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/ds1682.o: in function `acpi_get_gpiod':
ds1682.c:(.text+0x578): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/hmc6352.o: in function `acpi_get_gpiod':
hmc6352.c:(.text+0x568): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
s390-linux-ld: drivers/misc/eeprom/eeprom.o: in function `acpi_get_gpiod':
eeprom.c:(.text+0x7a0): multiple definition of `acpi_get_gpiod'; init/main.o:main.c:(.text+0x0): first defined here
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
ld.lld: error: debug_core.c:(.text+0x19C6): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
by kernel test robot
CC: linux-kernel(a)vger.kernel.org
TO: Daniel Thompson <daniel.thompson(a)linaro.org>
CC: Douglas Anderson <dianders(a)chromium.org>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: b65054597872ce3aefbc6a666385eabdf9e288da
commit: 771910f719651789adee8260e1a2c4c0ba161007 kernel: debug: Centralize dbg_[de]activate_sw_breakpoints
date: 9 weeks ago
config: riscv-randconfig-r004-20201130 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project dfcf1acf13226be0f599a7ab6b395b66dc9545d6)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install riscv cross compiling tool for clang build
# apt-get install binutils-riscv64-linux-gnu
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit...
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 771910f719651789adee8260e1a2c4c0ba161007
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=riscv
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
ld.lld: error: arch/riscv/kernel/head.o:(.head.text+0x8): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
ld.lld: error: debug_core.c:(.text+0x19AC): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x19C6): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1A60): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1CA6): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1DE0): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1E56): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1EA2): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1EDC): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1F66): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1F94): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
>> ld.lld: error: debug_core.c:(.text+0x1FB2): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
ld.lld: error: debug_core.c:(.text+0x2036): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
ld.lld: error: debug_core.c:(.init.text+0xD8): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
ld.lld: error: debug_core.c:(.init.text+0x176): relocation R_RISCV_ALIGN requires unimplemented linker relaxation; recompile with -mno-relax
ld.lld: error: undefined symbol: stpcpy
>>> referenced by tty_io.c
>>> tty/tty_io.o:(alloc_tty_struct) in archive drivers/built-in.a
>>> referenced by tty_io.c
>>> tty/tty_io.o:(tty_register_device_attr) in archive drivers/built-in.a
>>> referenced by tty_io.c
>>> tty/tty_io.o:(show_cons_active) in archive drivers/built-in.a
>>> referenced 1 more times
>>> did you mean: strcpy
>>> defined in: lib/lib.a(string.o)
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[djwong-xfs:realtime-rmap 174/202] fs/xfs/xfs_extfree_item.c:377:16: warning: variable 'rt_len' set but not used
by kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git realtime-rmap
head: 8f3f8360bb6fe95f3ecd3b1024f21eb094c72a53
commit: ddba8c1aacc55b7d88537b18b369021263cd4a9f [174/202] xfs: support logging EFIs for realtime extents
config: c6x-randconfig-r036-20201130 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/comm...
git remote add djwong-xfs https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git
git fetch --no-tags djwong-xfs realtime-rmap
git checkout ddba8c1aacc55b7d88537b18b369021263cd4a9f
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
fs/xfs/xfs_extfree_item.c: In function 'xfs_trans_free_extent':
>> fs/xfs/xfs_extfree_item.c:377:16: warning: variable 'rt_len' set but not used [-Wunused-but-set-variable]
377 | xfs_extlen_t rt_len;
| ^~~~~~
>> fs/xfs/xfs_extfree_item.c:376:17: warning: variable 'rt_ext' set but not used [-Wunused-but-set-variable]
376 | xfs_rtblock_t rt_ext;
| ^~~~~~
vim +/rt_len +377 fs/xfs/xfs_extfree_item.c
349
350 /*
351 * Free an extent and log it to the EFD. Note that the transaction is marked
352 * dirty regardless of whether the extent free succeeds or fails to support the
353 * EFI/EFD lifecycle rules.
354 */
355 static int
356 xfs_trans_free_extent(
357 struct xfs_trans *tp,
358 struct xfs_efd_log_item *efdp,
359 xfs_fsblock_t start_block,
360 xfs_extlen_t ext_len,
361 bool realtime,
362 const struct xfs_owner_info *oinfo,
363 bool skip_discard)
364 {
365 struct xfs_mount *mp = tp->t_mountp;
366 struct xfs_extent *extp;
367 uint next_extent;
368 xfs_agnumber_t agno = XFS_FSB_TO_AGNO(mp, start_block);
369 xfs_agblock_t agbno = XFS_FSB_TO_AGBNO(mp,
370 start_block);
371 int error;
372
373 trace_xfs_bmap_free_deferred(tp->t_mountp, agno, 0, agbno, ext_len);
374
375 if (realtime) {
> 376 xfs_rtblock_t rt_ext;
> 377 xfs_extlen_t rt_len;
378 xfs_extlen_t mod;
379
380 rt_len = ext_len / mp->m_sb.sb_rextsize;
381
382 rt_ext = div_u64_rem(start_block, mp->m_sb.sb_rextsize, &mod);
383 ASSERT(mod == 0);
384
385 error = xfs_rtfree_extent(tp, rt_ext, rt_len);
386 } else
387 error = __xfs_free_extent(tp, start_block, ext_len, oinfo,
388 XFS_AG_RESV_NONE, skip_discard);
389 /*
390 * Mark the transaction dirty, even on error. This ensures the
391 * transaction is aborted, which:
392 *
393 * 1.) releases the EFI and frees the EFD
394 * 2.) shuts down the filesystem
395 */
396 tp->t_flags |= XFS_TRANS_DIRTY;
397 set_bit(XFS_LI_DIRTY, &efdp->efd_item.li_flags);
398
399 next_extent = efdp->efd_next_extent;
400 ASSERT(next_extent < efdp->efd_format.efd_nextents);
401 extp = &(efdp->efd_format.efd_extents[next_extent]);
402 extp->ext_start = start_block;
403 extp->ext_len = ext_len;
404 efdp->efd_next_extent++;
405
406 return error;
407 }
408
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months
[PATCH linux-next] include/getcpu.h: Fixed kernel test robot warning
by Souptick Joarder
Kernel test robot generates below warning ->
>> arch/s390/kernel/vdso64/getcpu.c:8:5: warning: no previous prototype
>> for function '__s390_vdso_getcpu' [-Wmissing-prototypes]
int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
getcpu_cache *unused)
^
arch/s390/kernel/vdso64/getcpu.c:8:1: note: declare 'static' if the
function is not intended to be used outside of this translation unit
int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
getcpu_cache *unused)
^
static
1 warning generated.
vim +/__s390_vdso_getcpu +8 arch/s390/kernel/vdso64/getcpu.c
7
> 8 int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct
> getcpu_cache *unused)
It is fixed by adding a prototype.
Reported-by: kernel test robot <lkp(a)intel.com>
Signed-off-by: Souptick Joarder <jrdr.linux(a)gmail.com>
---
include/linux/getcpu.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/getcpu.h b/include/linux/getcpu.h
index c304dcd..43c9208 100644
--- a/include/linux/getcpu.h
+++ b/include/linux/getcpu.h
@@ -16,4 +16,5 @@ struct getcpu_cache {
unsigned long blob[128 / sizeof(long)];
};
+int __s390_vdso_getcpu(unsigned *cpu, unsigned *node, struct getcpu_cache *unused);
#endif
--
1.9.1
1 year, 10 months
[jpirko-mlxsw:petrm_resilient 5/5] net/ipv4/nexthop.c:2638 nexthop_dfs_bucket_activity_write() error: uninitialized symbol 'err'.
by Dan Carpenter
tree: https://github.com/jpirko/linux_mlxsw petrm_resilient
head: f89604f4fb4130335e42ccf65a969ad0a0f58166
commit: f89604f4fb4130335e42ccf65a969ad0a0f58166 [5/5] debugfs for nexthop [xxx]
config: i386-randconfig-m021-20201120 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp(a)intel.com>
Reported-by: Dan Carpenter <dan.carpenter(a)oracle.com>
smatch warnings:
net/ipv4/nexthop.c:2638 nexthop_dfs_bucket_activity_write() error: uninitialized symbol 'err'.
vim +/err +2638 net/ipv4/nexthop.c
f89604f4fb41303 Petr Machata 2020-11-19 2589 static ssize_t nexthop_dfs_bucket_activity_write(struct file *file,
f89604f4fb41303 Petr Machata 2020-11-19 2590 const char __user *user_buf,
f89604f4fb41303 Petr Machata 2020-11-19 2591 size_t size, loff_t *ppos)
f89604f4fb41303 Petr Machata 2020-11-19 2592 {
f89604f4fb41303 Petr Machata 2020-11-19 2593 const char *tok_bucketid;
f89604f4fb41303 Petr Machata 2020-11-19 2594 const char *tok_nhid;
f89604f4fb41303 Petr Machata 2020-11-19 2595 struct nexthop *nh;
f89604f4fb41303 Petr Machata 2020-11-19 2596 loff_t pos = *ppos;
f89604f4fb41303 Petr Machata 2020-11-19 2597 char buf[128];
f89604f4fb41303 Petr Machata 2020-11-19 2598 u16 bucketid; // xxx or u32 if we choose so
f89604f4fb41303 Petr Machata 2020-11-19 2599 char *ptr;
f89604f4fb41303 Petr Machata 2020-11-19 2600 u32 nhid;
f89604f4fb41303 Petr Machata 2020-11-19 2601 int err;
f89604f4fb41303 Petr Machata 2020-11-19 2602
f89604f4fb41303 Petr Machata 2020-11-19 2603 if (pos < 0)
f89604f4fb41303 Petr Machata 2020-11-19 2604 return -EINVAL;
f89604f4fb41303 Petr Machata 2020-11-19 2605 if (pos == size)
f89604f4fb41303 Petr Machata 2020-11-19 2606 goto skip;
"err" not set on this path.
f89604f4fb41303 Petr Machata 2020-11-19 2607 if (pos)
f89604f4fb41303 Petr Machata 2020-11-19 2608 return -EINVAL;
f89604f4fb41303 Petr Machata 2020-11-19 2609 if (size > sizeof(buf))
f89604f4fb41303 Petr Machata 2020-11-19 2610 return -ENOMEM;
f89604f4fb41303 Petr Machata 2020-11-19 2611 if (copy_from_user(buf, user_buf, size))
f89604f4fb41303 Petr Machata 2020-11-19 2612 return -EFAULT;
f89604f4fb41303 Petr Machata 2020-11-19 2613
f89604f4fb41303 Petr Machata 2020-11-19 2614 buf[sizeof(buf) - 1] = '\0';
f89604f4fb41303 Petr Machata 2020-11-19 2615 ptr = buf;
f89604f4fb41303 Petr Machata 2020-11-19 2616 tok_nhid = strsep(&ptr, " \t");
f89604f4fb41303 Petr Machata 2020-11-19 2617 tok_bucketid = strsep(&ptr, " \t");
f89604f4fb41303 Petr Machata 2020-11-19 2618
f89604f4fb41303 Petr Machata 2020-11-19 2619 if (!tok_nhid || !tok_bucketid || ptr)
f89604f4fb41303 Petr Machata 2020-11-19 2620 return -EINVAL;
f89604f4fb41303 Petr Machata 2020-11-19 2621
f89604f4fb41303 Petr Machata 2020-11-19 2622 err = kstrtou32(tok_nhid, 0, &nhid);
f89604f4fb41303 Petr Machata 2020-11-19 2623 if (err)
f89604f4fb41303 Petr Machata 2020-11-19 2624 return err;
f89604f4fb41303 Petr Machata 2020-11-19 2625
f89604f4fb41303 Petr Machata 2020-11-19 2626 err = kstrtou16(tok_bucketid, 0, &bucketid);
f89604f4fb41303 Petr Machata 2020-11-19 2627 if (err)
f89604f4fb41303 Petr Machata 2020-11-19 2628 return err;
f89604f4fb41303 Petr Machata 2020-11-19 2629
f89604f4fb41303 Petr Machata 2020-11-19 2630 rcu_read_lock();
f89604f4fb41303 Petr Machata 2020-11-19 2631 nh = nexthop_find_by_id(&init_net, nhid);
f89604f4fb41303 Petr Machata 2020-11-19 2632 if (!nh || !nexthop_select_path(nh, bucketid))
f89604f4fb41303 Petr Machata 2020-11-19 2633 err = -ENOENT;
f89604f4fb41303 Petr Machata 2020-11-19 2634 rcu_read_unlock();
f89604f4fb41303 Petr Machata 2020-11-19 2635
f89604f4fb41303 Petr Machata 2020-11-19 2636 skip:
f89604f4fb41303 Petr Machata 2020-11-19 2637 *ppos = size;
f89604f4fb41303 Petr Machata 2020-11-19 @2638 return err ?: size;
^^^
Uninitialized.
f89604f4fb41303 Petr Machata 2020-11-19 2639 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
1 year, 10 months