[mani-mhi:mhi-rebase 4/16] drivers/bus/mhi/core/main.c:79:13: error: 'struct mhi_device' has no member named 'ul_chan_id'; did you mean 'ul_chan'?
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi.git mhi-rebase
head: ae69a80178c4a0e1f2c6b71327fe5a9b13c7a86b
commit: b465752ade2337ae5d8350ce382cc381d7104d01 [4/16] bus: mhi: core: Add support for creating and destroying MHI devices
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
git checkout b465752ade2337ae5d8350ce382cc381d7104d01
# save the attached .config to linux build tree
make ARCH=i386
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
Note: the mani-mhi/mhi-rebase HEAD ae69a80178c4a0e1f2c6b71327fe5a9b13c7a86b builds fine.
It only hurts bisectibility.
All errors (new ones prefixed by >>):
drivers/bus/mhi/core/main.c: In function 'mhi_create_devices':
>> drivers/bus/mhi/core/main.c:79:13: error: 'struct mhi_device' has no member named 'ul_chan_id'; did you mean 'ul_chan'?
mhi_dev->ul_chan_id = mhi_chan->chan;
^~~~~~~~~~
ul_chan
>> drivers/bus/mhi/core/main.c:84:13: error: 'struct mhi_device' has no member named 'dl_chan_id'; did you mean 'dl_chan'?
mhi_dev->dl_chan_id = mhi_chan->chan;
^~~~~~~~~~
dl_chan
drivers/bus/mhi/core/main.c:101:15: error: 'struct mhi_device' has no member named 'ul_chan_id'; did you mean 'ul_chan'?
mhi_dev->ul_chan_id = mhi_chan->chan;
^~~~~~~~~~
ul_chan
drivers/bus/mhi/core/main.c:104:15: error: 'struct mhi_device' has no member named 'dl_chan_id'; did you mean 'dl_chan'?
mhi_dev->dl_chan_id = mhi_chan->chan;
^~~~~~~~~~
dl_chan
At top level:
drivers/bus/mhi/core/main.c:45:13: warning: 'mhi_notify' defined but not used [-Wunused-function]
static void mhi_notify(struct mhi_device *mhi_dev, enum mhi_callback cb_reason)
^~~~~~~~~~
vim +79 drivers/bus/mhi/core/main.c
57
58 /* Bind MHI channels to MHI devices */
59 void mhi_create_devices(struct mhi_controller *mhi_cntrl)
60 {
61 int i;
62 struct mhi_chan *mhi_chan;
63 struct mhi_device *mhi_dev;
64 int ret;
65
66 mhi_chan = mhi_cntrl->mhi_chan;
67 for (i = 0; i < mhi_cntrl->max_chan; i++, mhi_chan++) {
68 if (!mhi_chan->configured || mhi_chan->mhi_dev ||
69 !(mhi_chan->ee_mask & BIT(mhi_cntrl->ee)))
70 continue;
71 mhi_dev = mhi_alloc_device(mhi_cntrl);
72 if (!mhi_dev)
73 return;
74
75 mhi_dev->dev_type = MHI_DEVICE_XFER;
76 switch (mhi_chan->dir) {
77 case DMA_TO_DEVICE:
78 mhi_dev->ul_chan = mhi_chan;
> 79 mhi_dev->ul_chan_id = mhi_chan->chan;
80 break;
81 case DMA_FROM_DEVICE:
82 /* We use dl_chan as offload channels */
83 mhi_dev->dl_chan = mhi_chan;
> 84 mhi_dev->dl_chan_id = mhi_chan->chan;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[otc-clk-server-linux:ira/lck-4071-b8-v6 20/26] fs/stat.c:82:20: error: 'sb_dax_rwsem' undeclared; did you mean '__init_rwsem'?
by kbuild test robot
tree: otc-clk-server-linux/ira/lck-4071-b8-v6
head: f65f189ef9573bb3a5c9b3ca0498302be1e7b95f
commit: 7c166e2717e311bdfcdef940760d1675e22d26db [20/26] WIP: BUG_ON hits... vfs_getattr_nosec: expand lock scope
config: x86_64-defconfig (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
git checkout 7c166e2717e311bdfcdef940760d1675e22d26db
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All error/warnings (new ones prefixed by >>):
fs/stat.c: In function 'vfs_getattr_nosec':
>> fs/stat.c:82:20: error: 'sb_dax_rwsem' undeclared (first use in this function); did you mean '__init_rwsem'?
percpu_down_read(&sb_dax_rwsem);
^~~~~~~~~~~~
__init_rwsem
fs/stat.c:82:20: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/linux/export.h:43:0,
from fs/stat.c:8:
>> include/linux/percpu-rwsem.h:113:35: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
#define percpu_rwsem_is_held(sem) lockdep_is_held(&(sem)->rw_sem)
^
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
# define unlikely(x) __builtin_expect(!!(x), 0)
^
>> fs/stat.c:83:2: note: in expansion of macro 'BUG_ON'
BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
^~~~~~
>> fs/stat.c:83:10: note: in expansion of macro 'percpu_rwsem_is_held'
BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +82 fs/stat.c
52
53 /**
54 * vfs_getattr_nosec - getattr without security checks
55 * @path: file to get attributes from
56 * @stat: structure to return attributes in
57 * @request_mask: STATX_xxx flags indicating what the caller wants
58 * @query_flags: Query mode (KSTAT_QUERY_FLAGS)
59 *
60 * Get attributes without calling security_inode_getattr.
61 *
62 * Currently the only caller other than vfs_getattr is internal to the
63 * filehandle lookup code, which uses only the inode number and returns no
64 * attributes to any user. Any other code probably wants vfs_getattr.
65 */
66 int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
67 u32 request_mask, unsigned int query_flags)
68 {
69 struct inode *inode = d_backing_inode(path->dentry);
70
71 memset(stat, 0, sizeof(*stat));
72 stat->result_mask |= STATX_BASIC_STATS;
73 request_mask &= STATX_ALL;
74 query_flags &= KSTAT_QUERY_FLAGS;
75
76 /* allow the fs to override these if it really wants to */
77 if (IS_NOATIME(inode))
78 stat->result_mask &= ~STATX_ATIME;
79 if (IS_AUTOMOUNT(inode))
80 stat->attributes |= STATX_ATTR_AUTOMOUNT;
81
> 82 percpu_down_read(&sb_dax_rwsem);
> 83 BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
84 if (IS_DAX(inode))
85 stat->attributes |= STATX_ATTR_DAX;
86 percpu_up_read(&sb_dax_rwsem);
87
88 if (inode->i_op->getattr)
89 return inode->i_op->getattr(path, stat, request_mask,
90 query_flags);
91 generic_fillattr(inode, stat);
92 return 0;
93 }
94 EXPORT_SYMBOL(vfs_getattr_nosec);
95
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[otc-clk-server-linux:ira/lck-4071-b8-v6 8/26] include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE'
by kbuild test robot
tree: otc-clk-server-linux/ira/lck-4071-b8-v6
head: f65f189ef9573bb3a5c9b3ca0498302be1e7b95f
commit: 430ea75e09461390b90c387a846ab9cf026a2783 [8/26] fs: Add locking for a dynamic DAX state
config: nios2-randconfig-a001-20200130 (attached as .config)
compiler: nios2-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 430ea75e09461390b90c387a846ab9cf026a2783
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=nios2
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from include/linux/poll.h:10:0,
from net//sctp/associola.c:33:
include/linux/fs.h:1918:1: warning: data definition has no type or storage class
DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
include/linux/fs.h: In function 'inode_dax_state_down_read':
>> include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
include/linux/fs.h: In function 'inode_dax_state_up_read':
include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'inode_dax_state_down_write':
include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'inode_dax_state_up_write':
include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'enable_dax_state_static_branch':
>> include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'local_bh_enable'? [-Werror=implicit-function-declaration]
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~
local_bh_enable
>> include/linux/fs.h:1945:24: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'enable_dax_state_static_branch'?
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~~
enable_dax_state_static_branch
cc1: some warnings being treated as errors
--
In file included from include/linux/compat.h:17:0,
from include/linux/ethtool.h:17,
from include/linux/netdevice.h:37,
from net//xfrm/xfrm_policy.c:24:
include/linux/fs.h:1918:1: warning: data definition has no type or storage class
DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~
>> include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
include/linux/fs.h: In function 'inode_dax_state_down_read':
>> include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~
>> include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
include/linux/fs.h: In function 'inode_dax_state_up_read':
include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_down_write':
include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_up_write':
include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'enable_dax_state_static_branch':
>> include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'local_bh_enable'? [-Werror=implicit-function-declaration]
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~
local_bh_enable
include/linux/fs.h:1945:24: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
cc1: some warnings being treated as errors
vim +1918 include/linux/fs.h
1904
1905 #if defined(CONFIG_FS_DAX)
1906 /*
1907 * Filesystems wishing to support dynamic DAX states must do the following.
1908 *
1909 * 1) the direct_IO address_space_operation must be supported in all
1910 * potential a_ops vectors for any state suported by the inode.
1911 * 2) FS's should enable the static branch lock_dax_state_static_key when a DAX
1912 * capable device is detected.
1913 * 3) DAX state changes shall not be allowed while the file is mmap'ed
1914 * 4) For non-mmaped operations the VFS layer must take the read lock for any
1915 * use of IS_DAX()
1916 * 5) Filesystems take the write lock when changing DAX states.
1917 */
> 1918 DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
1919 static inline void inode_dax_state_down_read(struct inode *inode)
1920 {
> 1921 if (!static_branch_unlikely(&lock_dax_state_static_key))
1922 return;
1923 percpu_down_read(&inode->i_sb->s_dax_sem);
1924 }
1925 static inline void inode_dax_state_up_read(struct inode *inode)
1926 {
1927 if (!static_branch_unlikely(&lock_dax_state_static_key))
1928 return;
1929 percpu_up_read(&inode->i_sb->s_dax_sem);
1930 }
1931 static inline void inode_dax_state_down_write(struct inode *inode)
1932 {
> 1933 if (!static_branch_unlikely(&lock_dax_state_static_key))
1934 return;
1935 percpu_down_write(&inode->i_sb->s_dax_sem);
1936 }
1937 static inline void inode_dax_state_up_write(struct inode *inode)
1938 {
> 1939 if (!static_branch_unlikely(&lock_dax_state_static_key))
1940 return;
1941 percpu_up_write(&inode->i_sb->s_dax_sem);
1942 }
1943 static inline void enable_dax_state_static_branch(void)
1944 {
> 1945 static_branch_enable(&lock_dax_state_static_key);
1946 }
1947 #else /* !CONFIG_FS_DAX */
1948 #define inode_dax_state_down_read(inode) do { (void)(inode); } while (0)
1949 #define inode_dax_state_up_read(inode) do { (void)(inode); } while (0)
1950 #define inode_dax_state_down_write(inode) do { (void)(inode); } while (0)
1951 #define inode_dax_state_up_write(inode) do { (void)(inode); } while (0)
1952 #define enable_dax_state_static_branch()
1953 #endif /* CONFIG_FS_DAX */
1954
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[shenki:dev-5.5 95/117] drivers/soc/aspeed/aspeed-lpc-ctrl.c:247:17: warning: format '%zu' expects argument of type 'size_t', but argument 3 has type 'resource_size_t {aka long long unsigned int}'
by kbuild test robot
tree: https://github.com/shenki/linux dev-5.5
head: f547d16b9b97b8e9661b61ad0bc83f9729be3d73
commit: b77722515453e048e356d2b606bb16b144bc3e57 [95/117] soc: aspeed: Fail probe of lpc-ctrl if reserved memory is not aligned
config: x86_64-randconfig-a003-20200129 (attached as .config)
compiler: gcc-6 (Debian 6.3.0-18+deb9u1) 6.3.0 20170516
reproduce:
git checkout b77722515453e048e356d2b606bb16b144bc3e57
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
In file included from include/linux/miscdevice.h:7:0,
from drivers/soc/aspeed/aspeed-lpc-ctrl.c:9:
drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe':
>> drivers/soc/aspeed/aspeed-lpc-ctrl.c:247:17: warning: format '%zu' expects argument of type 'size_t', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
dev_err(dev, "Reserved memory size must be a power of 2, got %zu\n",
^
include/linux/device.h:1691:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
>> drivers/soc/aspeed/aspeed-lpc-ctrl.c:247:4: note: in expansion of macro 'dev_err'
dev_err(dev, "Reserved memory size must be a power of 2, got %zu\n",
^~~~~~~
drivers/soc/aspeed/aspeed-lpc-ctrl.c:253:17: warning: format '%zu' expects argument of type 'size_t', but argument 3 has type 'resource_size_t {aka long long unsigned int}' [-Wformat=]
dev_err(dev, "Reserved memory must be naturally aligned for size %zu\n",
^
include/linux/device.h:1691:22: note: in definition of macro 'dev_fmt'
#define dev_fmt(fmt) fmt
^~~
drivers/soc/aspeed/aspeed-lpc-ctrl.c:253:4: note: in expansion of macro 'dev_err'
dev_err(dev, "Reserved memory must be naturally aligned for size %zu\n",
^~~~~~~
vim +247 drivers/soc/aspeed/aspeed-lpc-ctrl.c
197
198 static int aspeed_lpc_ctrl_probe(struct platform_device *pdev)
199 {
200 struct aspeed_lpc_ctrl *lpc_ctrl;
201 struct device_node *node;
202 struct resource resm;
203 struct device *dev;
204 int rc;
205
206 dev = &pdev->dev;
207
208 lpc_ctrl = devm_kzalloc(dev, sizeof(*lpc_ctrl), GFP_KERNEL);
209 if (!lpc_ctrl)
210 return -ENOMEM;
211
212 /* If flash is described in device tree then store */
213 node = of_parse_phandle(dev->of_node, "flash", 0);
214 if (!node) {
215 dev_dbg(dev, "Didn't find host pnor flash node\n");
216 } else {
217 rc = of_address_to_resource(node, 1, &resm);
218 of_node_put(node);
219 if (rc) {
220 dev_err(dev, "Couldn't address to resource for flash\n");
221 return rc;
222 }
223
224 lpc_ctrl->pnor_size = resource_size(&resm);
225 lpc_ctrl->pnor_base = resm.start;
226 }
227
228
229 dev_set_drvdata(&pdev->dev, lpc_ctrl);
230
231 /* If memory-region is described in device tree then store */
232 node = of_parse_phandle(dev->of_node, "memory-region", 0);
233 if (!node) {
234 dev_dbg(dev, "Didn't find reserved memory\n");
235 } else {
236 rc = of_address_to_resource(node, 0, &resm);
237 of_node_put(node);
238 if (rc) {
239 dev_err(dev, "Couldn't address to resource for reserved memory\n");
240 return -ENXIO;
241 }
242
243 lpc_ctrl->mem_size = resource_size(&resm);
244 lpc_ctrl->mem_base = resm.start;
245
246 if (!is_power_of_2(lpc_ctrl->mem_size)) {
> 247 dev_err(dev, "Reserved memory size must be a power of 2, got %zu\n",
248 lpc_ctrl->mem_size);
249 return -EINVAL;
250 }
251
252 if (!IS_ALIGNED(lpc_ctrl->mem_base, lpc_ctrl->mem_size)) {
253 dev_err(dev, "Reserved memory must be naturally aligned for size %zu\n",
254 lpc_ctrl->mem_size);
255 return -EINVAL;
256 }
257 }
258
259 lpc_ctrl->regmap = syscon_node_to_regmap(
260 pdev->dev.parent->of_node);
261 if (IS_ERR(lpc_ctrl->regmap)) {
262 dev_err(dev, "Couldn't get regmap\n");
263 return -ENODEV;
264 }
265
266 lpc_ctrl->clk = devm_clk_get(dev, NULL);
267 if (IS_ERR(lpc_ctrl->clk)) {
268 dev_err(dev, "couldn't get clock\n");
269 return PTR_ERR(lpc_ctrl->clk);
270 }
271 rc = clk_prepare_enable(lpc_ctrl->clk);
272 if (rc) {
273 dev_err(dev, "couldn't enable clock\n");
274 return rc;
275 }
276
277 lpc_ctrl->miscdev.minor = MISC_DYNAMIC_MINOR;
278 lpc_ctrl->miscdev.name = DEVICE_NAME;
279 lpc_ctrl->miscdev.fops = &aspeed_lpc_ctrl_fops;
280 lpc_ctrl->miscdev.parent = dev;
281 rc = misc_register(&lpc_ctrl->miscdev);
282 if (rc) {
283 dev_err(dev, "Unable to register device\n");
284 goto err;
285 }
286
287 return 0;
288
289 err:
290 clk_disable_unprepare(lpc_ctrl->clk);
291 return rc;
292 }
293
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[otc-clk-server-linux:ira/lck-4071-b8-v6 8/26] include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'fpga_bridge_enable'?
by kbuild test robot
tree: otc-clk-server-linux/ira/lck-4071-b8-v6
head: f65f189ef9573bb3a5c9b3ca0498302be1e7b95f
commit: 430ea75e09461390b90c387a846ab9cf026a2783 [8/26] fs: Add locking for a dynamic DAX state
config: s390-randconfig-a001-20200130 (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 430ea75e09461390b90c387a846ab9cf026a2783
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
In file included from drivers//fpga/dfl.h:20:0,
from drivers//fpga/dfl-fme-pr.c:28:
include/linux/fs.h:1918:1: warning: data definition has no type or storage class
DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
include/linux/fs.h: In function 'inode_dax_state_down_read':
include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
include/linux/fs.h: In function 'inode_dax_state_up_read':
include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'inode_dax_state_down_write':
include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'inode_dax_state_up_write':
include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function)
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h: In function 'enable_dax_state_static_branch':
>> include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'fpga_bridge_enable'? [-Werror=implicit-function-declaration]
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~
fpga_bridge_enable
include/linux/fs.h:1945:24: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'enable_dax_state_static_branch'?
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~~
enable_dax_state_static_branch
cc1: some warnings being treated as errors
--
In file included from include/linux/compat.h:17:0,
from arch/s390/include/asm/elf.h:132,
from include/linux/elf.h:5,
from include/linux/module.h:18,
from drivers//fpga/fpga-bridge.c:11:
include/linux/fs.h:1918:1: warning: data definition has no type or storage class
DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
include/linux/fs.h: In function 'inode_dax_state_down_read':
include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
include/linux/fs.h: In function 'inode_dax_state_up_read':
include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_down_write':
include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_up_write':
include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'enable_dax_state_static_branch':
>> include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'fpga_bridge_enable'? [-Werror=implicit-function-declaration]
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~
fpga_bridge_enable
include/linux/fs.h:1945:24: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
cc1: some warnings being treated as errors
--
In file included from include/linux/security.h:28:0,
from kernel//trace/trace_stack.c:8:
include/linux/fs.h:1918:1: warning: data definition has no type or storage class
DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1918:1: error: type defaults to 'int' in declaration of 'DECLARE_STATIC_KEY_FALSE' [-Werror=implicit-int]
include/linux/fs.h:1918:1: warning: parameter names (without types) in function declaration
include/linux/fs.h: In function 'inode_dax_state_down_read':
include/linux/fs.h:1921:7: error: implicit declaration of function 'static_branch_unlikely' [-Werror=implicit-function-declaration]
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~
include/linux/fs.h:1921:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h:1921:31: note: each undeclared identifier is reported only once for each function it appears in
include/linux/fs.h: In function 'inode_dax_state_up_read':
include/linux/fs.h:1927:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_down_write':
include/linux/fs.h:1933:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'inode_dax_state_up_write':
include/linux/fs.h:1939:31: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
if (!static_branch_unlikely(&lock_dax_state_static_key))
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
include/linux/fs.h: In function 'enable_dax_state_static_branch':
>> include/linux/fs.h:1945:2: error: implicit declaration of function 'static_branch_enable'; did you mean 'stack_trace_save'? [-Werror=implicit-function-declaration]
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~
stack_trace_save
include/linux/fs.h:1945:24: error: 'lock_dax_state_static_key' undeclared (first use in this function); did you mean 'proc_do_static_key'?
static_branch_enable(&lock_dax_state_static_key);
^~~~~~~~~~~~~~~~~~~~~~~~~
proc_do_static_key
cc1: some warnings being treated as errors
vim +1945 include/linux/fs.h
1904
1905 #if defined(CONFIG_FS_DAX)
1906 /*
1907 * Filesystems wishing to support dynamic DAX states must do the following.
1908 *
1909 * 1) the direct_IO address_space_operation must be supported in all
1910 * potential a_ops vectors for any state suported by the inode.
1911 * 2) FS's should enable the static branch lock_dax_state_static_key when a DAX
1912 * capable device is detected.
1913 * 3) DAX state changes shall not be allowed while the file is mmap'ed
1914 * 4) For non-mmaped operations the VFS layer must take the read lock for any
1915 * use of IS_DAX()
1916 * 5) Filesystems take the write lock when changing DAX states.
1917 */
1918 DECLARE_STATIC_KEY_FALSE(lock_dax_state_static_key);
1919 static inline void inode_dax_state_down_read(struct inode *inode)
1920 {
1921 if (!static_branch_unlikely(&lock_dax_state_static_key))
1922 return;
1923 percpu_down_read(&inode->i_sb->s_dax_sem);
1924 }
1925 static inline void inode_dax_state_up_read(struct inode *inode)
1926 {
1927 if (!static_branch_unlikely(&lock_dax_state_static_key))
1928 return;
1929 percpu_up_read(&inode->i_sb->s_dax_sem);
1930 }
1931 static inline void inode_dax_state_down_write(struct inode *inode)
1932 {
1933 if (!static_branch_unlikely(&lock_dax_state_static_key))
1934 return;
1935 percpu_down_write(&inode->i_sb->s_dax_sem);
1936 }
1937 static inline void inode_dax_state_up_write(struct inode *inode)
1938 {
1939 if (!static_branch_unlikely(&lock_dax_state_static_key))
1940 return;
1941 percpu_up_write(&inode->i_sb->s_dax_sem);
1942 }
1943 static inline void enable_dax_state_static_branch(void)
1944 {
> 1945 static_branch_enable(&lock_dax_state_static_key);
1946 }
1947 #else /* !CONFIG_FS_DAX */
1948 #define inode_dax_state_down_read(inode) do { (void)(inode); } while (0)
1949 #define inode_dax_state_up_read(inode) do { (void)(inode); } while (0)
1950 #define inode_dax_state_down_write(inode) do { (void)(inode); } while (0)
1951 #define inode_dax_state_up_write(inode) do { (void)(inode); } while (0)
1952 #define enable_dax_state_static_branch()
1953 #endif /* CONFIG_FS_DAX */
1954
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[otc-clk-server-linux:ira/lck-4071-b8-v6 20/26] fs/stat.c:82:20: error: 'sb_dax_rwsem' undeclared
by kbuild test robot
tree: otc-clk-server-linux/ira/lck-4071-b8-v6
head: f65f189ef9573bb3a5c9b3ca0498302be1e7b95f
commit: 7c166e2717e311bdfcdef940760d1675e22d26db [20/26] WIP: BUG_ON hits... vfs_getattr_nosec: expand lock scope
config: nds32-defconfig (attached as .config)
compiler: nds32le-linux-gcc (GCC) 9.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 7c166e2717e311bdfcdef940760d1675e22d26db
# save the attached .config to linux build tree
GCC_VERSION=9.2.0 make.cross ARCH=nds32
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
fs/stat.c: In function 'vfs_getattr_nosec':
>> fs/stat.c:82:20: error: 'sb_dax_rwsem' undeclared (first use in this function)
82 | percpu_down_read(&sb_dax_rwsem);
| ^~~~~~~~~~~~
fs/stat.c:82:20: note: each undeclared identifier is reported only once for each function it appears in
In file included from include/asm-generic/bug.h:5,
from ./arch/nds32/include/generated/asm/bug.h:1,
from include/linux/bug.h:5,
from include/linux/mmdebug.h:5,
from include/linux/mm.h:9,
from fs/stat.c:9:
include/linux/percpu-rwsem.h:113:35: error: implicit declaration of function 'lockdep_is_held'; did you mean 'lockdep_is_held_type'? [-Werror=implicit-function-declaration]
113 | #define percpu_rwsem_is_held(sem) lockdep_is_held(&(sem)->rw_sem)
| ^~~~~~~~~~~~~~~
include/linux/compiler.h:78:42: note: in definition of macro 'unlikely'
78 | # define unlikely(x) __builtin_expect(!!(x), 0)
| ^
fs/stat.c:83:2: note: in expansion of macro 'BUG_ON'
83 | BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
| ^~~~~~
fs/stat.c:83:10: note: in expansion of macro 'percpu_rwsem_is_held'
83 | BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
| ^~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/sb_dax_rwsem +82 fs/stat.c
52
53 /**
54 * vfs_getattr_nosec - getattr without security checks
55 * @path: file to get attributes from
56 * @stat: structure to return attributes in
57 * @request_mask: STATX_xxx flags indicating what the caller wants
58 * @query_flags: Query mode (KSTAT_QUERY_FLAGS)
59 *
60 * Get attributes without calling security_inode_getattr.
61 *
62 * Currently the only caller other than vfs_getattr is internal to the
63 * filehandle lookup code, which uses only the inode number and returns no
64 * attributes to any user. Any other code probably wants vfs_getattr.
65 */
66 int vfs_getattr_nosec(const struct path *path, struct kstat *stat,
67 u32 request_mask, unsigned int query_flags)
68 {
69 struct inode *inode = d_backing_inode(path->dentry);
70
71 memset(stat, 0, sizeof(*stat));
72 stat->result_mask |= STATX_BASIC_STATS;
73 request_mask &= STATX_ALL;
74 query_flags &= KSTAT_QUERY_FLAGS;
75
76 /* allow the fs to override these if it really wants to */
77 if (IS_NOATIME(inode))
78 stat->result_mask &= ~STATX_ATIME;
79 if (IS_AUTOMOUNT(inode))
80 stat->attributes |= STATX_ATTR_AUTOMOUNT;
81
> 82 percpu_down_read(&sb_dax_rwsem);
83 BUG_ON(!percpu_rwsem_is_held(&sb_dax_rwsem));
84 if (IS_DAX(inode))
85 stat->attributes |= STATX_ATTR_DAX;
86 percpu_up_read(&sb_dax_rwsem);
87
88 if (inode->i_op->getattr)
89 return inode->i_op->getattr(path, stat, request_mask,
90 query_flags);
91 generic_fillattr(inode, stat);
92 return 0;
93 }
94 EXPORT_SYMBOL(vfs_getattr_nosec);
95
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[peterz-queue:x86/rwx 6/11] arch/x86/kernel/alternative.c:976:30: error: inlining failed in call to always_inline 'text_poke_addr': function attribute mismatch
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/rwx
head: 644b33c47c6a58a5ea22b376f9b73cabcd926734
commit: a045ecb2dc8eba388aec52c0bf26bf607c079753 [6/11] x86/int3: Ensure that poke_int3_handler() is not sanitized
config: x86_64-randconfig-f002-20200129 (attached as .config)
compiler: gcc-7 (Debian 7.5.0-3) 7.5.0
reproduce:
git checkout a045ecb2dc8eba388aec52c0bf26bf607c079753
# save the attached .config to linux build tree
make ARCH=x86_64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/x86/kernel/alternative.c: In function 'patch_cmp':
>> arch/x86/kernel/alternative.c:976:30: error: inlining failed in call to always_inline 'text_poke_addr': function attribute mismatch
static __always_inline void *text_poke_addr(struct text_poke_loc *tp)
^~~~~~~~~~~~~~
arch/x86/kernel/alternative.c:985:12: note: called from here
if (key < text_poke_addr(tp))
^~~~~~~~~~~~~~~~~~
>> arch/x86/kernel/alternative.c:976:30: error: inlining failed in call to always_inline 'text_poke_addr': function attribute mismatch
static __always_inline void *text_poke_addr(struct text_poke_loc *tp)
^~~~~~~~~~~~~~
arch/x86/kernel/alternative.c:987:12: note: called from here
if (key > text_poke_addr(tp))
^~~~~~~~~~~~~~~~~~
vim +/text_poke_addr +976 arch/x86/kernel/alternative.c
c0213b0ac03cf6 Daniel Bristot de Oliveira 2019-06-12 975
38708e003996f7 Thomas Gleixner 2020-01-21 @976 static __always_inline void *text_poke_addr(struct text_poke_loc *tp)
4531ef6a8aaf13 Peter Zijlstra 2019-10-09 977 {
4531ef6a8aaf13 Peter Zijlstra 2019-10-09 978 return _stext + tp->rel_addr;
4531ef6a8aaf13 Peter Zijlstra 2019-10-09 979 }
4531ef6a8aaf13 Peter Zijlstra 2019-10-09 980
:::::: The code at line 976 was first introduced by commit
:::::: 38708e003996f75a949e81ae7f1bd8ce47eab06e x86/int3: Ensure that poke_int3_handler() is not traced
:::::: TO: Thomas Gleixner <tglx(a)linutronix.de>
:::::: CC: Peter Zijlstra <peterz(a)infradead.org>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[plbossart-sound:sdw/master_framework 1/1] drivers//soundwire/master.c:119:1: warning: control reaches end of non-void function
by kbuild test robot
tree: https://github.com/plbossart/sound sdw/master_framework
head: 9fd32a3b5f5cef8953999dc060d4193d96fce64a
commit: 9fd32a3b5f5cef8953999dc060d4193d96fce64a [1/1] [HACK] add framework for master
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 9fd32a3b5f5cef8953999dc060d4193d96fce64a
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All warnings (new ones prefixed by >>):
drivers//soundwire/master.c: In function 'sdw_master_device_process_wake_event':
>> drivers//soundwire/master.c:119:1: warning: control reaches end of non-void function [-Wreturn-type]
}
^
vim +119 drivers//soundwire/master.c
96
97 int sdw_master_device_process_wake_event(struct sdw_master_device *md)
98 {
99 struct sdw_master_driver *mdrv;
100 struct device *dev;
101
102 pr_err("%s: start\n", __func__);
103 if (!md)
104 return -EINVAL;
105
106 pr_err("%s: 1\n", __func__);
107
108 dev = &md->dev;
109 mdrv = drv_to_sdw_master_driver(dev->driver);
110
111 pr_err("%s: 2\n", __func__);
112
113 if (mdrv && mdrv->process_wake_event) {
114 pr_err("%s: 3\n", __func__);
115 mdrv->startup(md);
116 }
117
118 pr_err("%s: end\n", __func__);
> 119 }
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months
[peterz-queue:x86/rwx 9/11] arch/s390/kernel/module.c:438:8: error: too few arguments to function 'apply_rela'
by kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git x86/rwx
head: 644b33c47c6a58a5ea22b376f9b73cabcd926734
commit: 99fc8ed105370f313fe166aa2e0670064ac4ddf4 [9/11] livepatch: Use text_poke() for relocations
config: s390-allyesconfig (attached as .config)
compiler: s390-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
git checkout 99fc8ed105370f313fe166aa2e0670064ac4ddf4
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=s390
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp(a)intel.com>
All errors (new ones prefixed by >>):
arch/s390/kernel/module.c: In function 'apply_rela_bits':
arch/s390/kernel/module.c:199:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &val, 1);
^~~
arch/s390/kernel/module.c:199:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c:203:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &tmp, 2);
^~~
arch/s390/kernel/module.c:203:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c:205:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &val, 2);
^~~
arch/s390/kernel/module.c:205:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c:209:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &tmp, 4);
^~~
arch/s390/kernel/module.c:209:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c:211:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &val, 4);
^~~
arch/s390/kernel/module.c:211:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c:213:9: warning: passing argument 1 of 'write' makes pointer from integer without a cast [-Wint-conversion]
write(loc, &val, 8);
^~~
arch/s390/kernel/module.c:213:9: note: expected 'void *' but argument is of type 'Elf64_Addr {aka long long unsigned int}'
arch/s390/kernel/module.c: In function '__apply_relocate_add':
>> arch/s390/kernel/module.c:438:8: error: too few arguments to function 'apply_rela'
rc = apply_rela(rela, base, symtab, strtab, me);
^~~~~~~~~~
arch/s390/kernel/module.c:218:12: note: declared here
static int apply_rela(Elf_Rela *rela, Elf_Addr base, Elf_Sym *symtab,
^~~~~~~~~~
vim +/apply_rela +438 arch/s390/kernel/module.c
^1da177e4c3f41 Linus Torvalds 2005-04-16 418
99fc8ed105370f Peter Zijlstra 2019-10-21 419 static int __apply_relocate_add(Elf_Shdr *sechdrs, const char *strtab,
^1da177e4c3f41 Linus Torvalds 2005-04-16 420 unsigned int symindex, unsigned int relsec,
99fc8ed105370f Peter Zijlstra 2019-10-21 421 struct module *me,
99fc8ed105370f Peter Zijlstra 2019-10-21 422 void (*write)(void *addr, const void *data, size_t len))
^1da177e4c3f41 Linus Torvalds 2005-04-16 423 {
^1da177e4c3f41 Linus Torvalds 2005-04-16 424 Elf_Addr base;
^1da177e4c3f41 Linus Torvalds 2005-04-16 425 Elf_Sym *symtab;
^1da177e4c3f41 Linus Torvalds 2005-04-16 426 Elf_Rela *rela;
^1da177e4c3f41 Linus Torvalds 2005-04-16 427 unsigned long i, n;
^1da177e4c3f41 Linus Torvalds 2005-04-16 428 int rc;
^1da177e4c3f41 Linus Torvalds 2005-04-16 429
^1da177e4c3f41 Linus Torvalds 2005-04-16 430 DEBUGP("Applying relocate section %u to %u\n",
^1da177e4c3f41 Linus Torvalds 2005-04-16 431 relsec, sechdrs[relsec].sh_info);
^1da177e4c3f41 Linus Torvalds 2005-04-16 432 base = sechdrs[sechdrs[relsec].sh_info].sh_addr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 433 symtab = (Elf_Sym *) sechdrs[symindex].sh_addr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 434 rela = (Elf_Rela *) sechdrs[relsec].sh_addr;
^1da177e4c3f41 Linus Torvalds 2005-04-16 435 n = sechdrs[relsec].sh_size / sizeof(Elf_Rela);
^1da177e4c3f41 Linus Torvalds 2005-04-16 436
^1da177e4c3f41 Linus Torvalds 2005-04-16 437 for (i = 0; i < n; i++, rela++) {
083e14c09b7ae0 Martin Schwidefsky 2013-01-11 @438 rc = apply_rela(rela, base, symtab, strtab, me);
^1da177e4c3f41 Linus Torvalds 2005-04-16 439 if (rc)
^1da177e4c3f41 Linus Torvalds 2005-04-16 440 return rc;
^1da177e4c3f41 Linus Torvalds 2005-04-16 441 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 442 return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16 443 }
^1da177e4c3f41 Linus Torvalds 2005-04-16 444
:::::: The code at line 438 was first introduced by commit
:::::: 083e14c09b7ae0247b9944a386fdc32cd0719da1 s390/modules: add relocation overflow checking
:::::: TO: Martin Schwidefsky <schwidefsky(a)de.ibm.com>
:::::: CC: Martin Schwidefsky <schwidefsky(a)de.ibm.com>
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
2 years, 4 months