Problem to build Lustre client 2.7.0 with OFED on CentOS
by David Roman
Hello,
I want compiled Lustre Client 2.7.0 with OFED-3.18-rc3 under Centos 6.6 (2.6.32-504.8.1.el6.x86_64 x86_64)
# rpm -qa | grep kernel
kernel-debug-devel-2.6.32-504.8.1.el6.x86_64
kernel-2.6.32-504.8.1.el6.x86_64
kernel-headers-2.6.32-504.8.1.el6.x86_64
kernel-devel-2.6.32-504.8.1.el6.x86_64
kernel-firmware-2.6.32-504.8.1.el6.noarch
kernel-debug-2.6.32-504.8.1.el6.x86_64
dracut-kernel-004-356.el6_6.2.noarch
I install OFED-3.18-rc3
tar OFED-3.18-rc3.tgz
cd OFED-3.18-rc3/
./install.pl
I install Lustre Client 2.7.0 rpm
rpm -ivh https://downloads.hpdd.intel.com/public/lustre/lustre-2.7.0/el6.6/client/...
And I try to build rpms
cd /root/rpmbuild/SOURCES/
tar xzf lustre-2.7.0.tgz
cd lustre-2.7.0
./configure --with-linux=/usr/src/kernels/$(uname -r) --with-o2ib=/usr/src/compat-rdma
make (but it doesn't work)
make all-recursive
make[1]: entrant dans le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0 »
Making all in .
make[2]: entrant dans le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0 »
make sources -C lustre || exit $?
make[3]: entrant dans le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0/lustre »
perl ../lustre/scripts/version_tag.pl .. .. > tmpver
echo "#define LUSTRE_RELEASE 2.6.32_504.8.1.el6.x86_64_" >> tmpver
cmp -s ../lustre/include/lustre/lustre_build_version.h tmpver > tmpdiff 2> /dev/null && \
rm -f tmpver tmpdiff || \
mv -f tmpver ../lustre/include/lustre/lustre_build_version.h
make[3]: quittant le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0/lustre »
make CC="gcc" -C /usr/src/kernels/2.6.32-504.8.1.el6.x86_64 \
-f /root/rpmbuild/SOURCES/lustre-2.7.0/build/Makefile LUSTRE_LINUX_CONFIG=/usr/src/kernels/2.6.32-504.8.1.el6.x86_64/.config \
LINUXINCLUDE='-I$(srctree)/arch/$(SRCARCH)/include -Iarch/$(SRCARCH)/include/generated -Iinclude $(if $(KBUILD_SRC),-Iinclude2 -I$(srctree)/include) -I$(srctree)/arch/$(SRCARCH)/include/uapi -Iarch/$(SRCARCH)/include/generated/uapi -I$(srctree)/include/uapi -Iinclude/generated/uapi -include /usr/src/kernels/2.6.32-504.8.1.el6.x86_64/include/linux/kconfig.h' \
M=/root/rpmbuild/SOURCES/lustre-2.7.0 -o tmp_include_depends -o scripts -o \
include/config/MARKER modules
make[3]: entrant dans le répertoire « /usr/src/kernels/2.6.32-504.8.1.el6.x86_64 »
LD /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/built-in.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-tracefile.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-debug.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-prim.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-mem.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-cpu.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-fs.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-tcpip.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-proc.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-curproc.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-utils.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-module.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-crypto.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-crypto-adler.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-crypto-crc32.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/linux-crypto-crc32pclmul.o
AS [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/linux/crc32-pclmul_asm.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/debug.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/fail.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/nidstrings.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/module.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/tracefile.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/watchdog.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/libcfs_string.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/hash.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/kernel_user_comm.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/prng.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/workitem.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/upcall_cache.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/libcfs_cpu.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/libcfs_mem.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/libcfs_lock.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/heap.o
LD [M] /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/libcfs/libcfs.o
LD /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/built-in.o
CC [M] /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.o
Dans le fichier inclus à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:7,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/usr/src/compat-rdma/include/linux/../../compat/config.h:395:1: erreur: « PACKAGE_BUGREPORT » redéfini
Dans le fichier inclus à partir de <command-line>:0:
/root/rpmbuild/SOURCES/lustre-2.7.0/config.h:558:1: erreur: ceci est la localisation d'une précédente définition
Dans le fichier inclus à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:7,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/usr/src/compat-rdma/include/linux/../../compat/config.h:398:1: erreur: « PACKAGE_NAME » redéfini
Dans le fichier inclus à partir de <command-line>:0:
/root/rpmbuild/SOURCES/lustre-2.7.0/config.h:561:1: erreur: ceci est la localisation d'une précédente définition
Dans le fichier inclus à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:7,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/usr/src/compat-rdma/include/linux/../../compat/config.h:401:1: erreur: « PACKAGE_STRING » redéfini
Dans le fichier inclus à partir de <command-line>:0:
/root/rpmbuild/SOURCES/lustre-2.7.0/config.h:564:1: erreur: ceci est la localisation d'une précédente définition
Dans le fichier inclus à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:7,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/usr/src/compat-rdma/include/linux/../../compat/config.h:404:1: erreur: « PACKAGE_TARNAME » redéfini
Dans le fichier inclus à partir de <command-line>:0:
/root/rpmbuild/SOURCES/lustre-2.7.0/config.h:567:1: erreur: ceci est la localisation d'une précédente définition
Dans le fichier inclus à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:7,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/usr/src/compat-rdma/include/linux/../../compat/config.h:407:1: erreur: « PACKAGE_VERSION » redéfini
Dans le fichier inclus à partir de <command-line>:0:
/root/rpmbuild/SOURCES/lustre-2.7.0/config.h:570:1: erreur: ceci est la localisation d'une précédente définition
Dans le fichier inclus à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/include/libcfs/libcfs.h:278,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:80,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
/root/rpmbuild/SOURCES/lustre-2.7.0/libcfs/include/libcfs/libcfs_string.h:136:1: erreur: « strtoul » redéfini
Dans le fichier inclus à partir de include/acpi/platform/acenv.h:141,
à partir de include/acpi/acpi.h:56,
à partir de include/linux/pci_hotplug.h:232,
à partir de /usr/src/compat-rdma/include/linux/compat-3.12.h:8,
à partir de /usr/src/compat-rdma/include/linux/compat-2.6.h:71,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.h:67,
à partir de /root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.c:42:
include/acpi/platform/aclinux.h:73:1: erreur: ceci est la localisation d'une précédente définition
make[7]: *** [/root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd/o2iblnd.o] Erreur 1
make[6]: *** [/root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds/o2iblnd] Erreur 2
make[5]: *** [/root/rpmbuild/SOURCES/lustre-2.7.0/lnet/klnds] Erreur 2
make[4]: *** [/root/rpmbuild/SOURCES/lustre-2.7.0/lnet] Erreur 2
make[3]: *** [_module_/root/rpmbuild/SOURCES/lustre-2.7.0] Erreur 2
make[3]: quittant le répertoire « /usr/src/kernels/2.6.32-504.8.1.el6.x86_64 »
make[2]: *** [modules] Erreur 2
make[2]: quittant le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0 »
make[1]: *** [all-recursive] Erreur 1
make[1]: quittant le répertoire « /root/rpmbuild/SOURCES/lustre-2.7.0 »
make: *** [all] Erreur 2
Where is my mistake ??
Regards
David Roman
6 years, 5 months
Re: [HPDD-discuss] Lustre 1.8.9 wc1 for Kernel 2.6.32-504 - again
by Chris Hunter
We apply patch for LU2800 & LU5237 (b2d09eb6,diff?) to git b1_8 branch.
A couple optional patches for LU3067 & LU3596 are available. It has
become difficult to build 1.8 clients with recent redhat kernels (they
tend backport fixes from the 3.10 kernels).
We have not moved to newer client version because of support for legacy
OS and (perceived) client performance issues with 2.1/2.4/2.5 versions.
IMO the b2_5 client issues appear to be resolved so that's likely our
upgrade path.
Note it appears the b1_8 branch was closed last month and all open pull
requests were abandonded.
regards,
chris hunter
yale hpc group
> Hi,
>
> hmm... there are different versions of the patch and different git
> repositories around. This one:
> works for the github branch you mentioned:
>
> patch -p1 < ~/Downloads/2661328b.diff
> patching file lustre/llite/dir.c
> Hunk #1 succeeded at 1051 with fuzz 1 (offset -126 lines).
> Hunk #2 succeeded at 1197 (offset -112 lines).
> Hunk #3 succeeded at 1264 (offset -117 lines).
6 years, 5 months
[PATCH] staging: lustre: Deletion of unnecessary checks before three function calls
by SF Markus Elfring
From: Markus Elfring <elfring(a)users.sourceforge.net>
Date: Fri, 26 Jun 2015 23:10:42 +0200
The following functions test whether their argument is NULL and then
return immediately.
* kfree
* ll_file_data_put
* ptlrpc_connection_put
Thus the test around such calls is not needed.
This issue was detected by using the Coccinelle software.
See also a previous update suggestion:
"remove unneeded null test before free" by Julia Lawall
https://lkml.org/lkml/2015/5/1/498
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg878600.html
Signed-off-by: Markus Elfring <elfring(a)users.sourceforge.net>
---
drivers/staging/lustre/lustre/llite/file.c | 3 +--
drivers/staging/lustre/lustre/llite/llite_lib.c | 2 +-
drivers/staging/lustre/lustre/ptlrpc/import.c | 6 ++----
drivers/staging/lustre/lustre/ptlrpc/service.c | 4 +---
4 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
index 3075db2..1a85c41 100644
--- a/drivers/staging/lustre/lustre/llite/file.c
+++ b/drivers/staging/lustre/lustre/llite/file.c
@@ -702,8 +702,7 @@ out_och_free:
out_openerr:
if (opendir_set != 0)
ll_stop_statahead(inode, lli->lli_opendir_key);
- if (fd != NULL)
- ll_file_data_put(fd);
+ ll_file_data_put(fd);
} else {
ll_stats_ops_tally(ll_i2sbi(inode), LPROC_LL_OPEN, 1);
}
diff --git a/drivers/staging/lustre/lustre/llite/llite_lib.c b/drivers/staging/lustre/lustre/llite/llite_lib.c
index 2513988..ab4839c 100644
--- a/drivers/staging/lustre/lustre/llite/llite_lib.c
+++ b/drivers/staging/lustre/lustre/llite/llite_lib.c
@@ -1114,7 +1114,7 @@ void ll_clear_inode(struct inode *inode)
if (lli->lli_mds_read_och)
ll_md_real_close(inode, FMODE_READ);
- if (S_ISLNK(inode->i_mode) && lli->lli_symlink_name) {
+ if (S_ISLNK(inode->i_mode)) {
kfree(lli->lli_symlink_name);
lli->lli_symlink_name = NULL;
}
diff --git a/drivers/staging/lustre/lustre/ptlrpc/import.c b/drivers/staging/lustre/lustre/ptlrpc/import.c
index c9b8481..1eae389 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/import.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/import.c
@@ -555,14 +555,12 @@ static int import_select_connection(struct obd_import *imp)
imp_conn->oic_last_attempt = cfs_time_current_64();
/* switch connection, don't mind if it's same as the current one */
- if (imp->imp_connection)
- ptlrpc_connection_put(imp->imp_connection);
+ ptlrpc_connection_put(imp->imp_connection);
imp->imp_connection = ptlrpc_connection_addref(imp_conn->oic_conn);
dlmexp = class_conn2export(&imp->imp_dlm_handle);
LASSERT(dlmexp != NULL);
- if (dlmexp->exp_connection)
- ptlrpc_connection_put(dlmexp->exp_connection);
+ ptlrpc_connection_put(dlmexp->exp_connection);
dlmexp->exp_connection = ptlrpc_connection_addref(imp_conn->oic_conn);
class_export_put(dlmexp);
diff --git a/drivers/staging/lustre/lustre/ptlrpc/service.c b/drivers/staging/lustre/lustre/ptlrpc/service.c
index 9117f1c..b9ae0b7 100644
--- a/drivers/staging/lustre/lustre/ptlrpc/service.c
+++ b/drivers/staging/lustre/lustre/ptlrpc/service.c
@@ -2826,9 +2826,7 @@ void ptlrpc_hr_fini(void)
ptlrpc_stop_hr_threads();
cfs_percpt_for_each(hrp, i, ptlrpc_hr.hr_partitions) {
- if (hrp->hrp_thrs != NULL) {
- kfree(hrp->hrp_thrs);
- }
+ kfree(hrp->hrp_thrs);
}
cfs_percpt_free(ptlrpc_hr.hr_partitions);
--
2.4.4
6 years, 6 months
[PATCH] staging: lustre: mgc: no need to compare bool value
by Luis de Bethencourt
Inverting the value of eof is a more direct way of passing to the debugging
function if eof is false or not.
Signed-off-by: Luis de Bethencourt <luis(a)debethencourt.com>
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mgc/mgc_request.c b/drivers/staging/lustre/lustre/mgc/mgc_request.c
index 7947aec..cd3ce40 100644
--- a/drivers/staging/lustre/lustre/mgc/mgc_request.c
+++ b/drivers/staging/lustre/lustre/mgc/mgc_request.c
@@ -1406,7 +1406,7 @@ again:
eof = res->mcr_offset == res->mcr_size;
CDEBUG(D_INFO, "Latest version %lld, more %d.\n",
- res->mcr_offset, eof == false);
+ res->mcr_offset, !eof);
ealen = sptlrpc_cli_unwrap_bulk_read(req, req->rq_bulk, 0);
if (ealen < 0) {
--
2.1.4
6 years, 6 months
Mounting OSTs fails after format with error -110?
by Sean Caron
Hi all,
Me again :O Still working my way through server build on what's basically
Lustre-devel from Git.
I'm in Section 10 of the documentation trying to get the filesystem proper
built and it's not quite going according to plan.
Brief background: One MGS/MDT and three OSS machines. MGS/MDT at
192.168.1.100 and the three OSS machines are at 192.168.1.101,
192.168.1.102 and 192.168.1.103.
So I go and build the combined MGS and MGT datastore on my MGS using the
directions in Section 10.1 of the administration guide:
mkfs.lustre --fsname=lustre --mgs --mdt --index=0 --reformat /dev/md0
I then go and mount it up, no problem:
mkdir -p /mdt
mount -t lustre /dev/md0 /mdt
I see stuff in dmesg on the MGS/MDT machine and it looks good:
[ 296.734221] LDISKFS-fs (md0): mounted filesystem with ordered data mode.
Opts: user_xattr,errors=remount-ro
[ 304.545375] LDISKFS-fs (md0): mounted filesystem with ordered data mode.
Opts: user_xattr,errors=remount-ro
[ 304.729341] Lustre: Lustre: Build Version:
v2_7_55_0-g7cb2e4b-CHANGED-3.10.0-229.4.2.el7.centos_lustre.x86_64
[ 305.516113] LDISKFS-fs (md0): mounted filesystem with ordered data mode.
Opts: user_xattr,errors=remount-ro,no_mbcache
[ 305.964081] Lustre: ctl-lustre-MDT0000: No data found on store.
Initialize space
[ 305.992657] Lustre: lustre-MDT0000: new disk, initializing
[ 306.110046] Lustre: ctl-lustre-MDT0000: super-sequence allocation rc = 0
[0x0000000200000400-0x0000000240000400):0:mdt
So that all seems okay, but then I go over to my first OSS node ... I first
try to run mkfs.lustre, that seems to complete okay:
mkfs.lustre --fsname=lustre --mgsnode=192.168.1.100@tcp0 --ost --index=1
--reformat /dev/md2
But then if I try to actually mount that, it pauses for a moment, then
gives me a timeout error:
mkdir -p /ost1
mount -t lustre /dev/md2 /ost1
I see the following in dmesg ... Does an error -110 make any sense to
anyone?
[ 1010.230310] Lustre: Lustre: Build Version:
v2_7_55_0-g7cb2e4b-CHANGED-3.10.0-229.4.2.el7.centos_lustre.x86_64
[ 1011.468508] LDISKFS-fs (md2): mounted filesystem with ordered data mode.
Opts: errors=remount-ro,no_mbcache
[ 1016.665780] Lustre: 4595:0:(client.c:2003:ptlrpc_expire_one_request())
@@@ Request sent has timed out for slow reply: [sent 1435697020/real
1435697020] req@ffff881f958f8000 x1505437437394948/t0(0)
o250->MGC192.168.1.100@tcp@192.168.1.100@tcp:26/25 lens 520/544 e 0 to 1 dl
1435697025 ref 1 fl Rpc:XN/0/ffffffff rc 0/-1
[ 1022.955966] LustreError: 15f-b: lustre-OST0001: cannot register this
server with the MGS: rc = -110. Is the MGS running?
[ 1022.956230] LustreError:
4561:0:(obd_mount_server.c:1789:server_fill_super()) Unable to start
targets: -110
[ 1022.956388] LustreError:
4561:0:(obd_mount_server.c:1504:server_put_super()) no obd lustre-OST0001
[ 1022.956469] LustreError:
4561:0:(obd_mount_server.c:137:server_deregister_mount()) lustre-OST0001
not registered
[ 1023.216433] Lustre: server umount lustre-OST0001 complete
[ 1023.216439] LustreError: 4561:0:(obd_mount.c:1342:lustre_fill_super())
Unable to mount (-110)
I've ensured that LNET is running ... I was sure to disable SELinux ...
these are all running on an RFC1918 subnet; common broadcast domain; there
shouldn't be any firewalling or anything in the way ... connectivity
basically seems okay between the MGS/MDT and the OSS machines. Any thoughts?
Thanks!
Sean
6 years, 6 months
[PATCH] Drivers: staging: lustre: Fix function name typo in comment
by Nik Nyby
This fixes typo in a comment that's referencing an invalid
function name.
Signed-off-by: Nik Nyby <nikolas(a)gnu.org>
---
drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/include/lustre_net.h b/drivers/staging/lustre/lustre/include/lustre_net.h
index 77a7de9..0ebe4a8 100644
--- a/drivers/staging/lustre/lustre/include/lustre_net.h
+++ b/drivers/staging/lustre/lustre/include/lustre_net.h
@@ -2012,7 +2012,7 @@ struct ptlrpc_service {
int srv_ncpts;
/** CPTs array this service bound on */
__u32 *srv_cpts;
- /** 2^srv_cptab_bits >= cfs_cpt_numbert(srv_cptable) */
+ /** 2^srv_cptab_bits >= cfs_cpt_number(srv_cptable) */
int srv_cpt_bits;
/** CPT table this service is running over */
struct cfs_cpt_table *srv_cptable;
--
2.1.4
6 years, 6 months
OST not clearing/updating space after lfs_migrate.
by Kumar, Amit
Dear All,
I have been attempting to rebalance full OST's using lfs_migrate in RSYNC_MODE=true, mainly because the internal lfs_migrate fails with the version I have(v2.4.3). Anyways even after migrating the files off of OST's with a restriping flag set to restripe on all OST's, I am finding that the OST's remaining space does not get updated. I am performing rebalancing while the OST of interest is deactivated from MDS.
Am I missing anything here?
Please advise.
Thank you,
Amit
6 years, 6 months
URGENT: Potential Data lost
by Kumar, Amit
Dear All,
I was working on and OSS and upon rebooting the OSS, I noticed poor performance on the OST's and hence went on to run ost_survey and an accidental edit of benchmark script had obdfilter_survey that began running on one of the OST but I terminated before it completed. At this point I have deactivated all OST's on this OSS server. I am not sure on how to recover or clean this up to get the OST back to production use. Any insight or help will be greatly appreciated.
Thank you,
Amit
6 years, 6 months
[PATCH] staging: lustre: obdclass: fix macro coding style issue in uuid.c
by Vasiliy Korchagin
This patch fixes the checkpatch.pl error:
ERROR: Macros with complex values should be enclosed in parentheses
+#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
Signed-off-by: Vasiliy Korchagin <vasiliy.korchagin(a)gmail.com>
---
drivers/staging/lustre/lustre/obdclass/uuid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/uuid.c b/drivers/staging/lustre/lustre/obdclass/uuid.c
index ff0a01b..8d00882 100644
--- a/drivers/staging/lustre/lustre/obdclass/uuid.c
+++ b/drivers/staging/lustre/lustre/obdclass/uuid.c
@@ -55,7 +55,7 @@ static inline __u32 consume(int nob, __u8 **ptr)
return value;
}
-#define CONSUME(val, ptr) (val) = consume(sizeof(val), (ptr))
+#define CONSUME(val, ptr) ((val) = consume(sizeof(val), (ptr)))
static void uuid_unpack(class_uuid_t in, __u16 *uu, int nr)
{
--
2.4.4
6 years, 7 months
