December 2012 - Devel

by Andriy Gapon

It looks like the reference count manipulations performed in AcpiUtUpdateRefCount/AcpiUtUpdateObjectReference are not protected by any lock. Although, it is possible that I am missing some implied locking in the higher levels. In particular, I am concerned about access to the ASL elements like Name(_HID, 2) via AcpiNsEvaluate -> AcpiExResolveNodeToValue. In this case multiple threads can concurrently get or drop references to the value object. The reason to inquire about this is that over the time several FreeBSD users has reported some seldom occurring, non-reproducible, ACPI-related heisen-panics. Their common element is a trap upon memory access in AcpiOsAcquireObject(AcpiGbl_OperandCache). Which, in my opinion, strongly hints at corruption of AcpiGbl_OperandCache via double-deallocation of an object. Which I then connect to the reference counting. Some links: http://lists.freebsd.org/pipermail/freebsd-current/2012-March/032637.html http://lists.freebsd.org/pipermail/freebsd-acpi/2012-January/007406.html http://thread.gmane.org/gmane.os.freebsd.stable/83262/focus=83445 https://bugs.dragonflybsd.org/issues/568 -- Andriy Gapon

9 years, 3 months

3
17
0 / 0

[PATCH] tools/power/acpi: Introduce acpi_validate with manpage for easy validation of ACPI BIOS tables

by Thomas Renninger

The used iasl compiler shares the same code base as the kernel. Warnings or errors mostly point to bad BIOSes. These errors should get reported to the BIOS vendors and may indicated that acpica (kernel ACPI parts) need compatibility adjustings. Why is an extra tool needed for this? The dynamic ACPI Source Language (ASL) parts are located in DSDT and often multiple SSDT tables. Those often have dependencies to each other and the iasl compiler often cannot resolve external symbols correctly if they are not passed as external tables (iasl -e option) when tables get disassembled. This quickly leads to false positive errors. This tool makes sure disassembling and recompilation is done correctly. This tool is also made for ACPI BIOS table verification for BIOS vendors and hardware certification tools for distributions. Hardware which supports Linux must/should not show any warnings or errors. Remarks and optimization hints in the logs can be used to further enhance the ACPI BIOS code. Warnings and errors mostly describe the issues in a way, so that they can get passed to and used by BIOS developers to fix the problems easily. Signed-off-by: Thomas Renninger <trenn(a)suse.de> --- tools/power/acpi/acpi_validate | 193 ++++++++++++++++++++++++++++++++++++++ tools/power/acpi/acpi_validate.8 | 72 ++++++++++++++ 2 files changed, 265 insertions(+), 0 deletions(-) create mode 100755 tools/power/acpi/acpi_validate create mode 100644 tools/power/acpi/acpi_validate.8 diff --git a/tools/power/acpi/acpi_validate b/tools/power/acpi/acpi_validate new file mode 100755 index 0000000..12d105b --- /dev/null +++ b/tools/power/acpi/acpi_validate @@ -0,0 +1,193 @@ +#!/bin/bash +# +# Copyright (c) 2012 SUSE Linux Products GmbH +# Thomas Renninger <trenn(a)suse.de> +# +# This program is free software; you can redistribute it and/or modify it +# under the terms and conditions of the GNU General Public License, +# version 2, as published by the Free Software Foundation. +# +# This program is distributed in the hope it will be useful, but WITHOUT +# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or +# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for +# more details. +# +# You should have received a copy of the GNU General Public License along with +# this program; if not, write to the Free Software Foundation, Inc., +# 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. +# + +OUTPUT_DIR="$PWD" +VERBOSE=0 +# Disable remarks and resource checks. The latter often/mostly generates +# false positive warnings. Can be overridden via -c option +COMPILE_OPTIONS="-sa -cr -vr" +DISASSEMBLE_OPTIONS="" +OUTPUT="/dev/null" +ACPIDUMP="" + +function usage() +{ + echo "acpi_validate [ -o output_dir ] [ -v ] [ -a acpidump ]" + echo " [ -c compile_options ] [ -d disassemble_options ]" + echo + echo "This tool extracts, disassembles and recompiles ACPI BIOS tables." + echo "The disassembled files will be copied into the local or specified" + echo "output directory (-o option)." + echo + echo "The underlying iasl compiler verifies and may complain about" + echo "correctness of some of the BIOS tables." + echo "These can give a pointer to possible malfunction of the system." + echo + echo "If you think you found a bug in the iasl compiler or related tools," + echo "you can ask here for help: devel(a)acpica.org" + echo "You may also want to ask there if you are not sure whether it really" + echo "is a BIOS bug." + echo + echo "If you are sure you found a BIOS issue, complain to your hardware vendor." + echo "The iasl compiler typically provides a description of the warning/error in a way," + echo "so that BIOS authors can easily fix it." + echo + echo "Options" + echo " -o output_dir: Copy tables to this directory instead of local one" + echo " -v: : be more verbose" + echo " -a acpidump : Use this acpidump file" + echo " instead of the tables from the local machine" + echo " -d options : Pass iasl disassemble options" + echo " -c options : Pass iasl compile options" + echo " will override -sa -cr -vr (default options)" + echo " -h : Show help" + exit 1 +} + +if [ "$(id -u)" != "0" ]; then + echo "This script must be run as root" + exit 1 +fi + +while getopts hva:o:c:d: name ; do + case $name in + o) + OUTPUT_DIR="$OPTARG" + if [ ! -d "$OUTPUT_DIR" ];then + mkdir "$OUTPUT_DIR" + if [[ $? != 0 ]];then + echo "Cannot create directory $OUTPUT_DIR" + exit 1 + fi + elif [ ! -w "$OUTPUT_DIR" ];then + echo "Cannot write into directory $OUTPUT_DIR" + exit 1 + fi + + [[ $VERBOSE == 1 ]] && echo "Installing for architecture: $OUTPUT_DIR" + ;; + a) + ACPIDUMP="$OPTARG" + if [ ! -r "$ACPIDUMP" ];then + echo "$ACPIDUMP does not exist" + exit 1 + fi + [[ $VERBOSE == 1 ]] && echo "acpidump file: $ACPIDUMP" + ;; + c) + COMPILE_OPTIONS="$OPTARG" + [[ $VERBOSE == 1 ]] && echo "Compile options: $COMPILE_OPTIONS" + ;; + c) + DISASSEMBLE_OPTIONS="$OPTARG" + [[ $VERBOSE == 1 ]] && echo "Disassemble options: $DISASSEMBLE_OPTIONS" + ;; + v) + VERBOSE=1 + OUTPUT="1" + ;; + ?) + usage + ;; + esac +done +shift $(($OPTIND -1)) + +shopt -s nocasematch +TEMP_DIR=$(mktemp -d) +[[ $VERBOSE == 1 ]] && echo "Using temporary directory: $TEMP_DIR" + +if [ -r "$ACPIDUMP" ];then + cp "$ACPIDUMP" "$TEMP_DIR"/acpidump +fi + +pushd "$TEMP_DIR" >/dev/null + +mkdir log +mkdir err +if [ ! -r acpidump ];then + acpidump >acpidump +fi +acpixtract -a acpidump >&$OUTPUT 2>&1 + + +# ACPICA changed from uppercase to lowercase, try to find both: +SDTs=$(ls [SD]DST*.dat 2>/dev/null) +SDTs="${SDTs}$(ls [sd]sdt*.dat 2>/dev/null)" + +for file in *.dat;do + table=${file/.dat/} + # Enable case insensitive pattern matching + + case $file in + [DS]SDT*.dat | [sd]sdt*.dat) + # Use other [sd]sdt*.dat tables to reference possible + # external symbols. Pass the table itself for disassembling + # comma separted. + # For example you we have: + # dsdt.dat ssdt1 ssdt2.dat + # and the current table to disassemble is ssdt1.dat the + # command has to be: + # iasl -e dsdt.dat,ssdt2.dat -d ssdt1.dat + + # Get rid of the table which gets disassembled + # could have leading or trailing whitespace depending whether + # it is at the end or the beginning of the list + REF_TABLE_LIST=${SDTs/[[:space:]]$file/} + REF_TABLE_LIST=${SDTs/$file[[:space:]]/} + # Convert the whitespace list into a comma separated one: + REF_TABLE_LIST=${REF_TABLE_LIST//[[:space:]]/,} + echo "stdout and stderr of $file disassembling:" >log/${table}.log + iasl $DISASSEMBLE_OPTIONS -e ${REF_TABLE_LIST} -d $file 1>>log/${table}.log 2>&1 + [[ $VERBOSE == 1 ]] && echo "iasl $DISASSEMBLE_OPTIONS -e ${REF_TABLE_LIST} -d $file 1>>log/${table}.log 2>&1" + iasl $COMPILE_OPTIONS ${table}.dsl 1>>log/${table}.log 2>>err/${table}.err + [[ $VERBOSE == 1 ]] && echo "iasl $COMPILE_OPTIONS ${table}.dsl 1>>log/${table}.log 2>>err/${table}.err" + ;; + *.dat) + iasl -d $file 1>log/${table}.log 2>&1 + iasl -sa ${table}.dsl 1>log/${table}.log 2>err/${table}.err + ;; + esac +done + +# remove empty error files +rm $(find err -size 0) +ERR_TABLES=$(ls err) +ERR_TABLES=${ERR_TABLES//.err/} + +popd >/dev/null +cp -r "$TEMP_DIR"/* "$OUTPUT_DIR" + +if [[ $VERBOSE == 1 ]];then + echo "Temporary directory (undeleted): $TEMP_DIR" +else + rm -rf "$TEMP_DIR" +fi + +if [ "$ERR_TABLES" = "" ];then + echo "No errors or warnings detected" + exit 0 +else + echo "These tables have warnings or errors (details in "$OUTPUT_DIR"/err directory):" + for err in $ERR_TABLES;do + echo -n $err $'\t' + sed -n -e 's/Compilation complete. $.* Errors, .* Warnings$.*/\1/p' "$OUTPUT_DIR"/log/$err.log + done + exit 1 +fi diff --git a/tools/power/acpi/acpi_validate.8 b/tools/power/acpi/acpi_validate.8 new file mode 100644 index 0000000..cd10694 --- /dev/null +++ b/tools/power/acpi/acpi_validate.8 @@ -0,0 +1,72 @@ +.TH ACPI_VALIDATE 8 +.SH NAME +acpi_validate \- Extracts, disassembles and recompiles ACPI BIOS tables. +.SH SYNOPSIS +.ft B +.B acpica_validate [ \-o output_dir ] [ \-a acpidump ] [ \-v ] [ \-c compile_options ] [ \-d disassemble_options ] +.SH DESCRIPTION +\fBacpi_validate \fP extracts, disassembles and recompiles ACPI BIOS +tables. The disassembled files will be copied into the local or specified +output directory (-o option). + +The underlying iasl compiler verifies and may complain about correctness of +some of the BIOS tables. Warnings or errors can give a pointer to possible +malfunction of the system. The Linux kernel uses the same code base as the +iasl interpreter which is used to validate tables. + +The ASL (ACPI Source Language) files (*.dsl) can get recompiled manually via +\fBiasl -sa\fP and the resulting compilation (*.aml) can get passed to the +kernel via the "Overriding ACPI tables via initrd" mechanism. Only use this +feature if you know what you are doing. Read +Documentation/acpi/initrd_table_override.txt (part of the kernel sources) for +further information. + +If you think you found a bug in the iasl compiler or related +tools, you can ask here for help: \fBdevel(a)acpica.org\fP + +You may also want to ask there if you are not sure whether it really +is a BIOS bug. + +If you are sure you found a BIOS issue, complain to your hardware vendor. The +iasl compiler typically provides a description of the warning/error in a way, +so that BIOS authors can easily fix it. + +.SH OPTIONS +\fB-o output_dir\fP + +The output directory where extracted, disassembled and +recompiled tables are copied to. Compiler output is located in a log +subdirectory, warnings and errors found by the compiler are located in the err +directory. +.PP +\fB-a acpidump\fP + +Take this acpidump file instead of dumping and extracting +ACPI tables from the local machine +.PP +\fB-v\fP + +Be more verbose +.PP +\fB-c options\fP + +Override default iasl compile options (default -sa -cr -vr) +.PP +\fB-d options\fP + +Override default iasl disassemble options + +.SH NOTES + +.B "acpi_validate" +must be run as root. + +.SH REFERENCES +ACPICA: https://acpica.org/ + +.SH "SEE ALSO" +.BR acpidump (8) + +.SH AUTHOR +.nf +Written by Thomas Renninger <trenn(a)suse.de> -- 1.7.6.1

9 years, 4 months

3
3
0 / 0

AcpiGetEventStatus: interface with behavior

by Andriy Gapon

AcpiGetEventStatus has an out parameter of type ACPI_EVENT_STATUS. My impression that values of that type should conform to bit definitions provided near the type declaration (ACPI_EVENT_FLAG_ENABLED, ACPI_EVENT_FLAG_SET, etc). But it seems that currently AcpiGetEventStatus returns only values zero and one corresponding to inactive and active status. The linux (adaption of the) code here http://lxr.linux.no/#linux+v3.7.1/drivers/acpi/acpica/evxfevnt.c#L313 seems to be a bit more elaborate. It actually tries to produce a value that conforms to the definitions by examining not only the status register but also enable register. It looks like AcpiHwGetGpeStatus is the model for how ACPI_EVENT_STATUS should be populated. I am not sure if AcpiGetEventStatus should be made compatible with ACPI_EVENT_STATUS or if its out type should be changed to something else. Also, it looks that the comment near ACPI_EVENT_STATUS definitions is a little bit out of sync. -- Andriy Gapon

9 years, 5 months

1
1
0 / 0

ACPI RASF table

by Guo, Shuangshuan (Suney＠CFE-CTS)

Hi, I am working on the ACPI 5.0 table RASF (RAS Feature), in ACPI-CA src code there is a struct ACPI_RASF_SHARED_MEMORY to descript the RASF communication channel in actbl3.h. /* RASF Platform Communication Channel Shared Memory Region */ typedef struct acpi_rasf_shared_memory { UINT32 Signature; UINT16 Command; UINT16 Status; UINT64 RequestedAddress; UINT64 RequestedLength; UINT64 ActualAddress; UINT64 ActualLength; UINT16 Flags; UINT8 Speed; } ACPI_RASF_SHARED_MEMORY; But it seems it does not follow the ACPI spec definition in 5.2.20.3 RASF Communication Channel. Actually I can't understand what the mean of "RequestedAddress" here is. In my opinion, PATROL SCRUB block needs the RequestedAddress and ActualAddress. I am using the ACPICA version 20121018 Is there any ACPICA developer can take a look? Regards, shuang-shuan,guo Center for Firmware Expertise Business Critical Systems

9 years, 5 months

2
1
0 / 0

[PATCH 0/3] ACPICA: Reduce source code differences between Linux and ACPICA.

by Lv Zheng

This patch set is based on the ACPICA 20121220 release. This patch set has passed basic build and boot tests. The source code differences between Linux and ACPICA can be summarized as follows: 1. 1976 Lines (70.5 Kbytes) before applying the patch set; 2. 1796 Lines (64.8 Kbytes) after applying the patch set. Please review. Lv Zheng (3): ACPICA: Cleanup PM_TIMER_FREQUENCY definition. ACPICA: Cleanup table handler naming conflicts. ACPICA: Add new statistics interface. drivers/acpi/acpica/acglobal.h | 4 +++- drivers/acpi/acpica/dsmethod.c | 1 + drivers/acpi/acpica/evsci.c | 1 + drivers/acpi/acpica/tbxface.c | 4 ++-- drivers/acpi/acpica/utglobal.c | 11 +++++++++++ drivers/acpi/acpica/utxface.c | 38 ++++++++++++++++++++++++++++++++++++++ drivers/acpi/numa.c | 2 +- drivers/acpi/processor_idle.c | 5 +++-- drivers/acpi/tables.c | 6 +++--- include/acpi/acpixf.h | 6 ++++-- include/acpi/actypes.h | 16 +++++++++++----- include/linux/acpi.h | 15 ++++++++++----- 12 files changed, 88 insertions(+), 21 deletions(-) --- Background of "ACPICA <-> Linux Divergences Fixes" The divergences fixes are meant to make the ACPICA release engineering work easier. More jobs can be done by the scripts running on the machines without the human intervention if the divergences can be controlled down to an acceptable level. The fixes will use the following two steps to reduce the divergences: 1. Fix the "cosmetic" stuff: The ACPICA release engineers will focus on the divergences that relate to the "commentary", "indentation", "coding styles", "debug messages", "code block offsetting", etc. in this step. Such divergences are fixed so that the "useful" stuff can rise to the surface. Most of the fixes do not affect the generation of the Linux binary, some of them do not affect the functionality of the generated Linux binary. Since introducing such fixes to Linux is low risk and some release patches depend on the divergences fixes, the work might be done by the ACPICA release engineers using a reduced community process. Such fixes will be attached on top of the release patch set directly during the release work. Such "cosmetic" fixes are expected to be done in 2-4 merge cycles. 2. Fix the "useful" stuff: Either by porting the Linux bug fixes to the ACPICA. Or by merging the lost ACPICA features to the Linux. These patches will be sent to community one by one, awaiting comments, then get merged. They will not appear in the release patch set. Every "cosmetic" divergences fix patch lists the line number of the divergences reduced by the patch. The divergences result is generated by the following steps: --------------------------------------------------------------------------- 1. pop the patch from the kernel 2. divergence.sh -s <kernel source tree> 3. push the patch to the kernel 4. divergence.sh -s <kernel source tree> --------------------------------------------------------------------------- Where the divergence.sh can be found in the generate/linux folder of the acpica project source tree. If a "cosmetic" divergences fix patch does not affect the generation of the Linux binary, you can find a binary comparision result in the patch description. The comparision result is generated by the following steps: --------------------------------------------------------------------------- 1. pop the patch and build the kernel 2. objcopy -R .notes binary1 > binary2 3. objdump -d binary2 > before.dump 4. push the patch and build the kernel 5. objcopy -R .notes binary1 > binary2 6. objdump -d binary2 > after.dump 7. diff -u before.dump after.dump --------------------------------------------------------------------------- Where: 1. Basically, binary1 will be "drivers/acpi/acpica/acpi.o". The same process will be executed on "vmlinux" for confirmation if there are header file changes that will seriously affect the generation of the vmlinux. 2. The build step is done by an i386 toolchain so we need to delete .note section which belongs to the .text section to avoid confusions. If you have concerns about such fixes, please do not send your blame to the code authors or the subsystem maintainers as they have done the right things to help improve the Linux or the ACPICA. Please send your blame to the following mail address whose owner is the culprit doing the bad things (ex. introducing the mistakes) during the release engineering work. --------------------------------------------------------------------------- Lv "ZETALOG" Zheng <lv.zheng(a)intel.com> --------------------------------------------------------------------------- -- 1.7.10

9 years, 5 months

1
3
0 / 0

I'll be waiting for you!

by albertwong

I wish to find my soul mate! I am a attractive and confident lady. I do believe in love based on a deep passion and even deeper understanding And I know how to love and cherish a truly fine man. I appreciate in men their ability to communicate with girl. I am a straightforward girl and I have nothing to hide from you. My dream is to create a family with a decent man. Here are my photos and my profile, perhaps http://jejaqoju.webclot.org/ I am yours fate.

9 years, 5 months

1
0
0 / 0

ACPICA version 20121220 released

by Moore, Robert

20 December 2012. Summary of changes for version 20121220: This release is available at https://www.acpica.org/downloads The ACPI 5.0 specification is available at www.acpi.info 1) ACPICA Kernel-resident Subsystem: Implemented a new interface, AcpiWalkResourceBuffer. This interface is an alternate entry point for AcpiWalkResources and improves the usability of the resource manager by accepting as input a buffer containing the output of either a _CRS, _PRS, or _AEI method. The key functionality is that the input buffer is not deleted by this interface so that it can be used by the host later. See the ACPICA reference for details. Interpreter: Add a warning if a 64-bit constant appears in a 32-bit table (DSDT version < 2). The constant will be truncated and this warning reflects that behavior. Resource Manager: Add support for the new ACPI 5.0 wake bit in the IRQ, ExtendedInterrupt, and GpioInt descriptors. This change adds support to both get and set the new wake bit in these descriptors, separately from the existing share bit. Reported by Aaron Lu. Interpreter: Fix Store() when an implicit conversion is not possible. For example, in the cases such as a store of a string to an existing package object, implement the store as a CopyObject(). This is a small departure from the ACPI specification which states that the control method should be aborted in this case. However, the ASLTS suite depends on this behavior. Performance improvement for the various FUNCTION_TRACE and DEBUG_PRINT macros: check if debug output is currently enabled as soon as possible to minimize performance impact if debug is in fact not enabled. Source code restructuring: Cleanup to improve modularity. The following new files have been added: dbconvert.c, evhandler.c, nsprepkg.c, psopinfo.c, psobject.c, rsdumpinfo.c, utstring.c, and utownerid.c. Associated makefiles and project files have been updated. Changed an exception code for LoadTable operator. For the case where one of the input strings is too long, change the returned exception code from AE_BAD_PARAMETER to AE_AML_STRING_LIMIT. Fixed a possible memory leak in dispatcher error path. On error, delete the mutex object created during method mutex creation. Reported by tim.gardner(a)canonical.com. Example Code and Data Size: These are the sizes for the OS-independent acpica.lib produced by the Microsoft Visual C++ 9.0 32-bit compiler. The debug version of the code includes the debug output trace mechanism and has a much larger code and data size. Previous Release: Non-Debug Version: 94.3K Code, 25.3K Data, 119.6K Total Debug Version: 175.5K Code, 74.5K Data, 250.0K Total Current Release: Non-Debug Version: 94.5K Code, 25.5K Data, 120.0K Total Debug Version: 182.2K Code, 74.9K Data, 257.1K Total 2) iASL Compiler/Disassembler and Tools: iASL: Disallow a method call as argument to the ObjectType ASL operator. This change tracks an errata to the ACPI 5.0 document. The AML grammar will not allow the interpreter to differentiate between a method and a method invocation when these are used as an argument to the ObjectType operator. The ACPI specification change is to disallow a method invocation (UserTerm) for the ObjectType operator. Finish support for the TPM2 and CSRT tables in the headers, table compiler, and disassembler. Unix user-space OSL: Fix a problem with WaitSemaphore where the timeout always expires immediately if the semaphore is not available. The original code was using a relative-time timeout, but sem_timedwait requires the use of an absolute time. iASL: Added a remark if the Timer() operator is used within a 32-bit table. This operator returns a 64-bit time value that will be truncated within a 32-bit table. iASL Source code restructuring: Cleanup to improve modularity. The following new files have been added: aslhex.c, aslxref.c, aslnamesp.c, aslmethod.c, and aslfileio.c. Associated makefiles and project files have been updated.

9 years, 6 months

1
0
0 / 0

Comments cleanup patch

by Zheng, Lv

Hi, Bob Please find and check the comments cleanup patch generated during the 20121114 release rework in the attachments. Thanks -Lv

9 years, 6 months

2
1
0 / 0

sleep state parsing in acpica

by Laszlo Ersek

Hello Robert, Jordan, the S3 and S4 packages prepared by OVMF / edk2 commit [1] (svn rev 14003) look like Name (\_S3, Package (0x01) { 0x00000001 }) Name (\_S4, Package (0x01) { 0x00000002 }) They are refused by the following ACPICA code section (please excuse the wide listing): repo: git://github.com/otcshare/acpica.git file: source/components/hardware/hwxface.c 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 635) /* 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 636) * The package must have at least two elements. NOTE (March 2005): This 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 637) * goes against the current ACPI spec which defines this object as a 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 638) * package with one encoded DWORD element. However, existing practice 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 639) * by BIOS vendors seems to be to have 2 or more elements, at least 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 640) * one per sleep type (A/B). 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 641) */ 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 642) else if (Info->ReturnObject->Package.Count < 2) 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 643) { 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 644) ACPI_ERROR ((AE_INFO, 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 645) "Sleep State return package does not have at least two elements")); 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 646) Status = AE_AML_NO_OPERAND; 4fa895bc (Robert Moore 2008-11-19 13:15:10 -0800 647) } I ran into the problem with the 20121217.16 Fedora 18 nightly build: [ 0.000000] Linux version 3.6.10-4.fc18.x86_64 (mockbuild@) (gcc version 4.7.2 20121109 (Red Hat 4.7.2-8) (GCC) ) #1 SMP Tue Dec 11 18:01:27 UTC 2012 [ 0.064483] ACPI: Interpreter enabled [ 0.064483] ACPI: (supports S0ACPI Error: Sleep State return package does not have at least two elements (20120711/hwxface-511) [ 0.064483] ACPI Exception: AE_AML_NO_OPERAND, While evaluating SleepState [\_S3_], bad Sleep object ffff880119a33c18 type Package (20120711/hwxface-543) [ 0.064483] ACPI Error: Sleep State return package does not have at least two elements (20120711/hwxface-511) [ 0.064483] ACPI Exception: AE_AML_NO_OPERAND, While evaluating SleepState [\_S4_], bad Sleep object ffff880119a33cf0 type Package (20120711/hwxface-543) [ 0.064483] S5) Should I attempt a patch for ACPICA (see the attachment), or is it not worth the hassle and I should just fixup the AML generation in OVMF (split the DWord into Bytes)? (Please keep me CC'd, I'm not subscribed to <devel(a)acpica.org>.) Thanks Laszlo [1] http://tianocore.git.sourceforge.net/git/gitweb.cgi?p=tianocore/edk2;a=co...

9 years, 6 months

1
0
0 / 0

ACPI 5.0 implementation for armv7 and armv8 architecture

by Ayan Halder

Hi, I am planning to implement ACPI5.0 on an SOC having Cortex A5 and Atlas cpu( based on armv8 architecture) running linux on top of them. As per the ACPI 5.0 hardware specification(Fixed Hardware/ Generic Hardware model) of ACPI5.0, the processor needs to support various low power modes(C0, C1, C2, C3) and sleep states(S1, S2, S3, S4, S5) via register interfaces as well as OEM provided AML(ACPI Machine Language). Therefore, which instructions in armv7 and armv8 put the processor into the afore-mentioned low power modes and sleep states? ( The arm instruction manual specifies "wfe" and "wfi" to put the processor in a sleep state, but I am not sure if this confirms to the ACPI 5.0 requirements ) Besides, does arm provide any AML(ACPI Machine Language) code to put the processor to low power modes? If not, then how do we create an ACPI machine language code for armv7 and armv8 architecture and do we have an AML interpreter for armv7 and armv8 architecture? Regards, Ayan Kumar Halder

9 years, 6 months

4
4
0 / 0

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

Devel December 2012